- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 5ca9fd: [Misc] Fix a SonarQube issue: an overflow-prone co...
by XWiki Notifications 29 Aug '26

29 Aug '26

Branch: refs/heads/claude/clever-feynman-bvqqrl-s9354-resource Home: https://github.com/xwiki/xwiki-platform Commit: 5ca9fdae78e57d8c4477bd39a888b69cb1a04d21 https://github.com/xwiki/xwiki-platform/commit/5ca9fdae78e57d8c4477bd39a888… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-resource/xwiki-platform-resource-api/src/main/java/org/xwiki/resource/AbstractResourceReferenceHandler.java M xwiki-platform-core/xwiki-platform-resource/xwiki-platform-resource-api/src/test/java/org/xwiki/resource/ResourceReferenceHandlerTest.java Log Message: ----------- [Misc] Fix a SonarQube issue: an overflow-prone compareTo whose test asserts its magnitude * java:S9354: AbstractResourceReferenceHandler#compareTo used getPriority() - other.getPriority(); int subtraction wraps on overflow and can then return the wrong sign. Replaced with Integer.compare(). * ResourceReferenceHandlerTest#priority asserted the exact difference (300) rather than its sign, which is not part of the Comparable contract; adapted to assert the sign. Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] f6e732: [Misc] Fix various SonarQube issues
by XWiki Notifications 29 Aug '26

29 Aug '26

Branch: refs/heads/claude/clever-feynman-bvqqrl Home: https://github.com/xwiki/xwiki-platform Commit: f6e7321657febd7db2dec4012a5f76f367159161 https://github.com/xwiki/xwiki-platform/commit/f6e7321657febd7db2dec4012a5f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-api/src/test/java/org/xwiki/display/internal/DocumentContentDisplayerTest.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/test/java/org/xwiki/export/pdf/internal/job/DefaultDocumentRendererTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-messagestream/xwiki-platform-legacy-messagestream-api/src/test/java/org/xwiki/messagestream/MessageStreamTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-api/src/main/java/org/xwiki/localization/internal/AbstractTranslationBundle.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-macro/src/test/java/org/xwiki/localization/macro/IntegrationTests.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/thread/PrepareMailRunnableTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/NotificationFilter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/DefaultNotificationPreferenceManager.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/main/java/org/xwiki/observation/remote/internal/converter/EventConverters.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Class.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/sheet/scripting/SheetScriptServiceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/web/DownloadActionTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacro.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/test/java/org/xwiki/rendering/internal/wiki/XWikiWikiModelTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/Right.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheTest.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-creationjob/src/main/java/org/xwiki/platform/wiki/creationjob/internal/WikiCreationJob.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S9354: use Integer.compare() rather than subtraction in compare()/compareTo() * java:S9357: replace anonymous inner classes on functional interfaces with lambdas * java:S9358: move the conditional expression inside the duplicated operation Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-commons] dcb422: [Misc] Fix various SonarQube issues
by XWiki Notifications 29 Aug '26

29 Aug '26

Branch: refs/heads/claude/nifty-bell-bvqqrl Home: https://github.com/xwiki/xwiki-commons Commit: dcb422039808e009664097b069b0287548ac6f0c https://github.com/xwiki/xwiki-commons/commit/dcb422039808e009664097b069b02… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-component/xwiki-commons-component-default/src/main/java/org/xwiki/component/embed/EmbeddableComponentManager.java M xwiki-commons-core/xwiki-commons-context/src/test/java/org/xwiki/context/internal/DefaultExecutionContextManagerTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/repository/internal/DefaultExtensionRepositoryManager.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/test/FileExtensionRepository.java M xwiki-commons-core/xwiki-commons-legacy/xwiki-commons-legacy-velocity/src/main/java/org/xwiki/velocity/introspection/MethodOverrideUberspector.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-api/src/test/java/org/xwiki/observation/WrappedThreadEventListenerTest.java M xwiki-commons-core/xwiki-commons-observation/xwiki-commons-observation-local/src/main/java/org/xwiki/observation/internal/DefaultObservationManager.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S9354: use Integer.compare() rather than subtraction in compare()/compareTo() * java:S9357: replace anonymous inner classes on functional interfaces with lambdas * java:S9358: move the conditional expression inside the duplicated operation Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform] dd09e8: [Misc] Fix various SonarQube issues
by XWiki Notifications 29 Aug '26

29 Aug '26

Branch: refs/heads/claude/clever-feynman-bvqqrl Home: https://github.com/xwiki/xwiki-platform Commit: dd09e84df9e2f5df9fdd88fa3c1736768d1c246c https://github.com/xwiki/xwiki-platform/commit/dd09e84df9e2f5df9fdd88fa3c17… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-api/src/test/java/org/xwiki/display/internal/DocumentContentDisplayerTest.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/test/java/org/xwiki/export/pdf/internal/job/DefaultDocumentRendererTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-messagestream/xwiki-platform-legacy-messagestream-api/src/test/java/org/xwiki/messagestream/MessageStreamTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-api/src/main/java/org/xwiki/localization/internal/AbstractTranslationBundle.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-macro/src/test/java/org/xwiki/localization/macro/IntegrationTests.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/thread/PrepareMailRunnableTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-api/src/main/java/org/xwiki/notifications/filters/NotificationFilter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-preferences/xwiki-platform-notifications-preferences-api/src/main/java/org/xwiki/notifications/preferences/internal/DefaultNotificationPreferenceManager.java M xwiki-platform-core/xwiki-platform-observation/xwiki-platform-observation-remote/src/main/java/org/xwiki/observation/remote/internal/converter/EventConverters.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Class.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/internal/sheet/scripting/SheetScriptServiceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/web/DownloadActionTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacro.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-xwiki/src/test/java/org/xwiki/rendering/internal/wiki/XWikiWikiModelTest.java M xwiki-platform-core/xwiki-platform-resource/xwiki-platform-resource-api/src/main/java/org/xwiki/resource/AbstractResourceReferenceHandler.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/Right.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheTest.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-creationjob/src/main/java/org/xwiki/platform/wiki/creationjob/internal/WikiCreationJob.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S9354: use Integer.compare() rather than subtraction in compare()/compareTo() * java:S9357: replace anonymous inner classes on functional interfaces with lambdas * java:S9358: move the conditional expression inside the duplicated operation Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-rendering] ee1d99: [Misc] Fix various SonarQube issues
by XWiki Notifications 29 Aug '26

29 Aug '26

Branch: refs/heads/claude/peaceful-archimedes-bvqqrl Home: https://github.com/xwiki/xwiki-rendering Commit: ee1d99bf053128d6f64950b88fafb1a4b825c89a https://github.com/xwiki/xwiki-rendering/commit/ee1d99bf053128d6f64950b88fa… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M xwiki-rendering-api/src/main/java/org/xwiki/rendering/transformation/AbstractTransformation.java M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xdomxml10/src/main/java/org/xwiki/rendering/xdomxml10/internal/renderer/parameter/FormatConverter.java M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xdomxml10/src/main/java/org/xwiki/rendering/xdomxml10/internal/renderer/parameter/HeaderLevelConverter.java M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xdomxml10/src/main/java/org/xwiki/rendering/xdomxml10/internal/renderer/parameter/ListTypeConverter.java M xwiki-rendering-transformations/xwiki-rendering-transformation-macro/src/main/java/org/xwiki/rendering/macro/AbstractMacro.java Log Message: ----------- [Misc] Fix various SonarQube issues * java:S9354: use Integer.compare() rather than subtraction in compare()/compareTo() * java:S9357: replace anonymous inner classes on functional interfaces with lambdas * java:S9358: move the conditional expression inside the duplicated operation Co-Authored-By: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[jira@xwiki.org][Issue] Updates for RN-11: Allow unchecking "with screenshots" and "without screenshots" radio buttons
by XWiki Notifications 28 Aug '26

28 Aug '26

1 0

[xwiki-contrib/application-releasenotes] 2c74d0: RN-72: getChanges ignores the equals in the greate...
by XWiki Notifications 28 Aug '26

28 Aug '26

Branch: refs/heads/RN-72-pagetest Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 2c74d011c7c5c33f446fe81d34eb36a761350bde https://github.com/xwiki-contrib/application-releasenotes/commit/2c74d011c7… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M application-releasenotes-test/application-releasenotes-test-docker/src/test/it/org/xwiki/releasenotes/test/ui/ReleaseNotesIT.java M application-releasenotes-ui/pom.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/GetChangesMacroPageTest.java A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/WikiMacroComponentList.java A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/WikiMacroLoader.java Log Message: ----------- RN-72: getChanges ignores the equals in the greater or equal and lower and equal filters * Replace the functional test of this fix by a page test on the getChanges wiki macro, which is much cheaper to run and asserts the fix more directly: it captures the XWQL statement the macro builds and the values it binds, instead of inferring the operator from the changes the report ends up listing. It also covers the "like" case and multi-item filters, which the functional test did not. * Add WikiMacroComponentList and WikiMacroLoader, the equivalent of the WikiMacroFactoryComponentClass annotation and of the WikiMacroSetup helper that XWiki only provides since 15.2, while this application supports 14.10. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notifica…

1 0

[xwiki-contrib/application-releasenotes]
by XWiki Notifications 28 Aug '26

28 Aug '26

Branch: refs/heads/RN-11 Home: https://github.com/xwiki-contrib/application-releasenotes To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notifica…

1 0

[xwiki-contrib/application-releasenotes] 3a1d25: RN-11: Allow unchecking "with screenshots" and "wi...
by XWiki Notifications 28 Aug '26

28 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 3a1d25ea0cec9e97a2ffcb875796de6da19bcf7d https://github.com/xwiki-contrib/application-releasenotes/commit/3a1d25ea0c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M application-releasenotes-ui/pom.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/HomeCustomReportPageTest.java Log Message: ----------- RN-11: Allow unchecking "with screenshots" and "without screenshots" radio buttons * Add a third "With and Without Screenshots" radio button to the custom report form, selected by default. It sends an empty containsScreenshots value, which ReleaseNotes.Code.Report skips like any other empty request parameter, so no screenshot filter reaches the getChanges macro. A radio button cannot be unchecked once one of its group has been selected, so this third option is the only way back to reporting on both kinds of changes. * Wrap each of the three radio buttons in a label so that clicking the text selects the option, and close the input tags that were left open. * Move the three screenshot filter labels to the translation bundle instead of hardcoding them in English. * Add a page test on ReleaseNotes.Code.HomeCustomReport checking the three options, their values and which one is selected. This is the first test of the UI module, hence the new xwiki-platform-test-page dependency. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> Commit: 95d746056e1aad4b77cabe7fccae4baf0fa8e344 https://github.com/xwiki-contrib/application-releasenotes/commit/95d746056e… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M application-releasenotes-ui/pom.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/HomeCustomReportPageTest.java Log Message: ----------- RN-11: Allow unchecking "with screenshots" and "without screenshots" radio buttons Compare: https://github.com/xwiki-contrib/application-releasenotes/compare/c90f5307a… To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notifica…

1 0

[xwiki-contrib/application-releasenotes] 3a1d25: RN-11: Allow unchecking "with screenshots" and "wi...
by XWiki Notifications 28 Aug '26

28 Aug '26

Branch: refs/heads/RN-11 Home: https://github.com/xwiki-contrib/application-releasenotes Commit: 3a1d25ea0cec9e97a2ffcb875796de6da19bcf7d https://github.com/xwiki-contrib/application-releasenotes/commit/3a1d25ea0c… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-29 (Sat, 29 Aug 2026) Changed paths: M application-releasenotes-ui/pom.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Translations.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/HomeCustomReportPageTest.java Log Message: ----------- RN-11: Allow unchecking "with screenshots" and "without screenshots" radio buttons * Add a third "With and Without Screenshots" radio button to the custom report form, selected by default. It sends an empty containsScreenshots value, which ReleaseNotes.Code.Report skips like any other empty request parameter, so no screenshot filter reaches the getChanges macro. A radio button cannot be unchecked once one of its group has been selected, so this third option is the only way back to reporting on both kinds of changes. * Wrap each of the three radio buttons in a label so that clicking the text selects the option, and close the input tags that were left open. * Move the three screenshot filter labels to the translation bundle instead of hardcoding them in English. * Add a page test on ReleaseNotes.Code.HomeCustomReport checking the three options, their values and which one is selected. This is the first test of the UI module, hence the new xwiki-platform-test-page dependency. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notifica…

1 0