- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 6cf8b0: [Misc] Explain why these code blocks are empty and...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 6cf8b0db2c6516390e152391105553b5b3e32270 https://github.com/xwiki/xwiki-platform/commit/6cf8b0db2c6516390e1523911055… Author: claude[bot] <209825114+claude[bot](a)users.noreply.github.com> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-api/src/main/java/org/xwiki/mail/MailStatus.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/internal/livedata/custom/NotificationCustomFiltersQueryHelper.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/Document.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/render/groovy/ParseGroovyFromString.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorTimer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/XWikiPluginManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/GroovyAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/ObjectRemoveAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java Log Message: ----------- [Misc] Explain why these code blocks are empty and fix comment syntax (SonarQube) (#6221) * [Misc] Explain why these code blocks are empty and fix comment syntax (SonarQube) * java:S108: document the 80 empty blocks reported in 19 files with a comment saying why they are empty, and remove two blocks that are empty and useless (an empty finally and an empty else in XWiki). * java:S9355: turn the block comments that carry Javadoc tags into real Javadoc comments (MailStatus fields and XWiki#getUserTimeZone). Co-Authored-By: Vincent Massol <vincent(a)massol.net> * [Misc] Turn the empty-block comments into TODOs (SonarQube) * Following review: a catch that neither rethrows nor logs is a bug to fix later, so each comment now starts with a "// TODO:" asking either to log a warning, or (where an exception is the expected outcome) to change the logic so the case isn't signalled by an exception. * The two blocks that are not exception handling (dropping XML control characters, an empty switch default) keep their plain comment. Co-Authored-By: Vincent Massol <vincent(a)massol.net> * [Misc] Replace the try/catch of MonitorTimer#toString() with a null check * Following review: the catch was only there to swallow the NPE thrown when the duration of a timer that has not ended yet is printed, so a null check on the two dates says it directly and removes the empty block. * Behaviour is unchanged: the "Duration: " label was already appended before the throwing expression, so a running timer printed the label with no value before and still does. Co-Authored-By: Vincent Massol <vincent(a)massol.net> * [Misc] Drop the TODOs where catching the exception is the valid design * Following review: XWikiRightNotFoundException is a domain signal meaning "no right defined at this level", so catching it to continue with the next check is valid and the 12 TODOs asking to change that logic are removed; the comment saying what the catch means stays. * FeedPlugin's TODO is reworded: falling back when the Map constructor is missing is fine, but catching Throwable there also hides a failure of the constructor that was found, so the ask is to log a warning. Co-Authored-By: Vincent Massol <vincent(a)massol.net> --------- Co-authored-by: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 3b4f8c: [Misc] Replace the try/catch of MonitorTimer#toStr...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/clever-feynman-6a1n0j Home: https://github.com/xwiki/xwiki-platform Commit: 3b4f8c859d134cf3543d68aa424d5af0b82ebe4d https://github.com/xwiki/xwiki-platform/commit/3b4f8c859d134cf3543d68aa424d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/monitor/api/MonitorTimer.java Log Message: ----------- [Misc] Replace the try/catch of MonitorTimer#toString() with a null check * Following review: the catch was only there to swallow the NPE thrown when the duration of a timer that has not ended yet is printed, so a null check on the two dates says it directly and removes the empty block. * Behaviour is unchanged: the "Duration: " label was already appended before the throwing expression, so a running timer printed the label with no value before and still does. Co-Authored-By: Vincent Massol <vincent(a)massol.net> Commit: 1cef9b6735dec9245fb7af16685d12c169cb9d3e https://github.com/xwiki/xwiki-platform/commit/1cef9b6735dec9245fb7af16685d… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java Log Message: ----------- [Misc] Drop the TODOs where catching the exception is the valid design * Following review: XWikiRightNotFoundException is a domain signal meaning "no right defined at this level", so catching it to continue with the next check is valid and the 12 TODOs asking to change that logic are removed; the comment saying what the catch means stays. * FeedPlugin's TODO is reworded: falling back when the Map constructor is missing is fine, but catching Throwable there also hides a failure of the constructor that was found, so the ask is to log a warning. Co-Authored-By: Vincent Massol <vincent(a)massol.net> Compare: https://github.com/xwiki/xwiki-platform/compare/9e3be4c2f387...1cef9b6735de To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[jira@xwiki.org][Issue] Updates for XRENDERING-812: PrintTextListener duplicates the no-op listener callbacks of EmptyWemListener
by XWiki Notifications 25 Aug '26

25 Aug '26

1 0

[xwiki/xwiki-rendering]
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/peaceful-archimedes-6a1n0j Home: https://github.com/xwiki/xwiki-rendering To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-rendering] b316b3: [Misc] Compile a regex outside a loop and use Java...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-rendering Commit: b316b3438936319d0bea887b1084ec7eedc9a363 https://github.com/xwiki/xwiki-rendering/commit/b316b3438936319d0bea887b108… Author: claude[bot] <209825114+claude[bot](a)users.noreply.github.com> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-rendering-syntaxes/xwiki-rendering-syntax-xwiki20/src/main/java/org/xwiki/rendering/internal/renderer/xwiki20/XWikiSyntaxChainingRenderer.java M xwiki-rendering-wikimodel/src/test/java/org/xwiki/rendering/wikimodel/ReferenceHandlerTest.java Log Message: ----------- [Misc] Compile a regex outside a loop and use Javadoc syntax (SonarQube) (#412) * java:S9142: hoist the parameter-value escaping regex of XWikiSyntaxChainingRenderer into a compiled Pattern constant instead of calling String#replaceAll() inside the parameter loop. * java:S9355: remove the two "(non-Javadoc)" block comments of ReferenceHandlerTest, which hold Javadoc tags without being Javadoc; the @Override annotations already say the methods are inherited. Co-authored-by: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0

[xwiki/xwiki-commons]
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/nifty-bell-6a1n0j Home: https://github.com/xwiki/xwiki-commons To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-commons] 2e157b: [Misc] Rename the variables named "record" in the ...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-commons Commit: 2e157b0acc0fcae79a864473e02a01fe611fbe7b https://github.com/xwiki/xwiki-commons/commit/2e157b0acc0fcae79a864473e02a0… Author: claude[bot] <209825114+claude[bot](a)users.noreply.github.com> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/ExtensionJobHistory.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/ExtensionJobHistorySerializer.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/internal/DefaultExtensionJobHistory.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/internal/DefaultExtensionJobHistorySerializer.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/main/java/org/xwiki/extension/job/history/internal/ReplayJob.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/job/history/internal/DefaultExtensionJobHistoryTest.java M xwiki-commons-core/xwiki-commons-extension/xwiki-commons-extension-api/src/test/java/org/xwiki/extension/job/history/internal/ExtensionJobHistoryRecorderTest.java Log Message: ----------- [Misc] Rename the variables named "record" in the extension job history (SonarQube) (#1924) * "record" is a restricted identifier in Java, so java:S6213 asks for a different name; renamed the 16 variables and parameters holding an ExtensionJobHistoryRecord to "historyRecord". * The two flagged *methods* named "record()" are left untouched: renaming QuestionRecorder#record(T) would break the public API. Co-authored-by: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-commons/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/claude/clever-feynman-6a1n0j-s9142 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 6f166a: [Misc] Compile regular expressions outside of loop...
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 6f166aef5f6b55fc3f98ca6e7e2f0411994b43ae https://github.com/xwiki/xwiki-platform/commit/6f166aef5f6b55fc3f98ca6e7e2f… Author: claude[bot] <209825114+claude[bot](a)users.noreply.github.com> Date: 2026-08-25 (Tue, 25 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/main/java/org/xwiki/notifications/filters/migration/R160500000XWIKI22271DataMigration.java M xwiki-platform-core/xwiki-platform-query/xwiki-platform-query-manager/src/main/java/org/xwiki/query/internal/EscapeLikeParametersQuery.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-ui/src/test/java/org/xwiki/search/ui/SearchSuggestSourceSheetPageTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-transaction/src/main/java/org/xwiki/store/TransactionException.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-integration/src/main/java/org/xwiki/test/integration/XWikiExecutorSuite.java M xwiki-platform-tools/xwiki-platform-tool-standards-validator/src/main/java/org/xwiki/validator/HTML5DutchWebGuidelinesValidator.java Log Message: ----------- [Misc] Compile regular expressions outside of loops (SonarQube) (#6222) * [Misc] Compile regular expressions outside of loops (SonarQube) * java:S9142: extract the regular expressions that were compiled on every iteration of a loop (through String#matches() or String#replaceAll()) into static Pattern constants. Co-Authored-By: Vincent Massol <vincent(a)massol.net> * [Misc] Use the multi-line Javadoc format in DefaultCSRFTokenTest * Following review: the single-line /** xxx */ form is not the house style, so the comment added by the previous commit and the three the file already had are converted to the multi-line form. Co-Authored-By: Vincent Massol <vincent(a)massol.net> --------- Co-authored-by: Vincent Massol <vincent(a)massol.net> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-rendering]
by XWiki Notifications 25 Aug '26

25 Aug '26

Branch: refs/heads/XRENDERING-812 Home: https://github.com/xwiki/xwiki-rendering To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-rendering/settings/notifications

1 0