- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 534501: [Misc] Apply the logging best practices to oldcore...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/misc-logging-batch8 Home: https://github.com/xwiki/xwiki-platform Commit: 534501bf1aedb36a71aa2dc9499bb3690b69f3e9 https://github.com/xwiki/xwiki-platform/commit/534501bf1aedb36a71aa2dc9499b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/DefaultWikiComponentInvocationHandler.java M xwiki-platform-core/xwiki-platform-export/xwiki-platform-export-pdf/xwiki-platform-export-pdf-default/src/main/java/org/xwiki/export/pdf/internal/chrome/ChromeManager.java M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/FeedPlugin.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePlugin.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePluginAPI.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-rest/src/main/java/org/xwiki/livedata/rest/model/jaxb/StringMap.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/AbstractMailListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/hibernate/legacy/LegacySessionImplementor.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/user/UserAuthenticatedEventNotifier.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/VisitStatsStoreItem.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/hibernate/HibernateAttachmentVersioningStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R35102XWIKI7771DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R40000XWIKI6990DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R4359XWIKI1459DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R6079XWIKI1878DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/api/XWikiUser.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/MyFormAuthenticator.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/AdminAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/CommentAddAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/DownloadRevAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/EditAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/LogoutAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/RegisterAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SaveAndContinueAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/UploadAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiURLFactoryServiceImpl.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/main/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCache.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/JsxAction.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/SsxAction.java M xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-ui/src/main/java/org/xwiki/test/ui/WCAGContext.java M xwiki-platform-core/xwiki-platform-zipexplorer/src/main/java/com/xpn/xwiki/plugin/zipexplorer/ZipExplorerPlugin.java Log Message: ----------- [Misc] Apply the logging best practices to oldcore and 10 more platform modules Fourth pass of the logging audit. The first three passes all keyed off the log call itself; none of them looked at the Logger field: how it is acquired, which class it names, or its modifiers -- which is the first rule on the code style page. This pass covers that, plus a wider re-run of the redundant-guard and printStackTrace detectors. * Point four loggers at their own class. XWikiGroupServiceImpl logged as XWikiDocument, LegacySessionImplementor as XWiki, WCAGContext as BasePage and XWikiURLFactoryServiceImpl as its own interface, so their lines were filed under another class and per-class log configuration did not reach them. * Use @Inject Logger in 12 components instead of a static LoggerFactory logger. * Replace 4 remaining printStackTrace() calls in main code with error(), all in catch blocks that otherwise swallowed the failure. ZipExplorerPlugin needed three and already had a logger; FeedPlugin.getFeedOutput needed one. * Make 4 Logger fields static final (XWikiUser and DefaultWikiComponentInvocationHandler were building one per instance) and rename 3 LOG fields to LOGGER. * Remove 23 redundant isXxxEnabled() guards. Two of them tested the wrong level and so silently suppressed their message: XWiki hid a warn() behind isDebugEnabled() and VisitStatsStoreItem hid an error() behind isWarnEnabled(). Guards whose arguments do real work are kept. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/misc-logging-batch7 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 169061: [Misc] Apply the logging best practices to oldcore...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 16906187c4ab5d3ccf93cd4818ad577579a7e7eb https://github.com/xwiki/xwiki-platform/commit/16906187c4ab5d3ccf93cd4818ad… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-api/src/main/java/org/xwiki/container/internal/DefaultApplicationContextListenerManager.java M xwiki-platform-core/xwiki-platform-feed/xwiki-platform-feed-api/src/main/java/com/xpn/xwiki/plugin/feed/UpdateThread.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/doc/DocumentErrorHandler.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/internal/web/XWikiConfigurationService.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/main/java/org/xwiki/officeimporter/internal/server/OfficeServerLifecycleListener.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/main/java/org/xwiki/officeimporter/script/OfficeImporterScriptService.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/main/java/org/xwiki/officeimporter/server/script/OfficeServerScriptService.java M xwiki-platform-core/xwiki-platform-office/xwiki-platform-office-importer/src/test/java/org/xwiki/officeimporter/server/script/OfficeServerScriptServiceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/hibernate/HibernateStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/BooleanClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/classes/EmailClass.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/plugin/packaging/Package.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/RefererStats.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/XWikiStatsServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/RefererStatsStoreItem.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/stats/impl/xwiki/XWikiStatsReader.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateBaseStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/AbstractXWikiAuthService.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/GroovyAuthServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiRightServiceImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/DownloadRevAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/SkinAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/Utils.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/includeservletasstring/IncludeServletAsString.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/store/hibernate/AbstractHibernateAdapter.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-wikimacro/xwiki-platform-rendering-wikimacro-store/src/main/java/org/xwiki/rendering/wikimacro/internal/DefaultWikiMacroInitializer.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/RepositoryManager.java M xwiki-platform-core/xwiki-platform-resource/xwiki-platform-resource-servlet/src/main/java/org/xwiki/resource/servlet/AbstractServletResourceReferenceHandler.java M xwiki-platform-core/xwiki-platform-resource/xwiki-platform-resource-servlet/src/test/java/org/xwiki/resource/servlet/AbstractServletResourceReferenceHandlerTest.java Log Message: ----------- [Misc] Apply the logging best practices to oldcore and 7 more platform modules (#6068) * Give a message to log calls that had none: error(e.getMessage(), e) logs no indication of what failed, and renders "null" whenever the exception carries no message. * Route Throwable.printStackTrace() and System.out calls in main code through SLF4J, so the trace reaches the log file with its level, timestamp and logger. * Pass the caught exception to the debug()/info() calls that were dropping the only explanation they had. * Unwrap isXxxEnabled() guards around a single parameterized call with cheap arguments, which SLF4J already defers. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/misc-logging-batch6 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 51f34b: [Misc] Apply the logging best practices to oldcore...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 51f34b728e8a0b418f5df9f3efaae9c7bde4ffd9 https://github.com/xwiki/xwiki-platform/commit/51f34b728e8a0b418f5df9f3efaa… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-versioncheck/src/main/java/org/xwiki/extension/versioncheck/internal/VersionCheckInitializer.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/thread/MailSenderInitializerListener.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/XWiki.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/api/User.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/context/RequestInitializer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/model/reference/DocumentReferenceConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/pdf/FOPXSLFORenderer.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/AbstractSheetBinder.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/sheet/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/skin/AbstractSkin.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/store/PropertyConverter.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/internal/template/InternalTemplateManager.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/objects/BaseElement.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/pdf/impl/PdfExportImpl.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/XWikiHibernateAttachmentStore.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/store/migration/hibernate/R35102XWIKI7771DataMigration.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/util/Util.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiAction.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/web/XWikiServletURLFactory.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/org/xwiki/internal/document/DocumentRequiredRightsReader.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/org/xwiki/internal/document/DocumentRequiredRightsReaderTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/XWikiResource.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/AbstractSxAction.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/main/java/org/xwiki/wiki/internal/provisioning/DefaultWikiCopier.java Log Message: ----------- [Misc] Apply the logging best practices to oldcore and 5 more platform modules (#6066) Closes out the SLF4J logging audit: the xwiki-platform-oldcore sites left over from the exceptions-discarded-in-a-catch pass, plus the last stragglers a re-run of both parsers surfaced elsewhere. * warn() in a catch now appends the root cause instead of dropping the exception; error() in a catch receives the caught exception itself. * XWiki.evaluateVelocity passed xe.getCause(), which is null when the exception has no cause, so no stack trace was ever logged. * VersionCheckInitializer passed the exception where a value was expected: the placeholder rendered literally and a warning printed a stack trace. * MailSenderInitializerListener announced the Prepare thread after stopping the Sender thread and vice versa. * User.isUserInGroup built its message with MessageFormat, XWikiResource used quotes and a trailing newline instead of brackets, DefaultWikiCopier logged the message-less form, AbstractSxAction used getMessage(). Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/misc-logging-batch5 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] b3c2a6: [Misc] Apply the logging best practices to 26 more...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: b3c2a609e4d341955fb5318aec10596bff1eb323 https://github.com/xwiki/xwiki-platform/commit/b3c2a609e4d341955fb5318aec10… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-activeinstalls2/xwiki-platform-activeinstalls2-api/src/main/java/org/xwiki/activeinstalls2/internal/ActiveInstallsPingRunnable.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java M xwiki-platform-core/xwiki-platform-attachment/xwiki-platform-attachment-validation/xwiki-platform-attachment-validation-api/src/main/java/org/xwiki/attachment/validation/AttachmentValidationScriptService.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-api/src/main/java/org/xwiki/captcha/script/CaptchaScriptService.java M xwiki-platform-core/xwiki-platform-component/xwiki-platform-component-wiki/src/main/java/org/xwiki/component/wiki/internal/bridge/DefaultWikiComponentBridge.java M xwiki-platform-core/xwiki-platform-csrf/src/main/java/org/xwiki/csrf/internal/DefaultCSRFToken.java M xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/main/java/org/xwiki/rendering/internal/macro/dashboard/EditableGadgetRenderer.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/job/AbstractDistributionJob.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-distribution/src/main/java/org/xwiki/extension/distribution/internal/job/step/CleanExtensionsDistributionStep.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/doc/InstalledExtensionDocumentListener.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/handler/XarExtensionHandler.java M xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-handlers/xwiki-platform-extension-handler-xar/src/main/java/org/xwiki/extension/xar/internal/repository/InstalledExtensionSynchronizer.java M xwiki-platform-core/xwiki-platform-filter/xwiki-platform-filter-streams/xwiki-platform-filter-stream-xar/src/main/java/org/xwiki/filter/xar/internal/input/WikiReader.java M xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-default/src/main/java/org/xwiki/icon/internal/context/IconContextStore.java M xwiki-platform-core/xwiki-platform-image/xwiki-platform-image-processing/xwiki-platform-image-processing-plugin/src/main/java/com/xpn/xwiki/plugin/image/ImagePlugin.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-annotation/src/main/java/org/xwiki/annotation/internal/AnnotationVelocityContextInitializer.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-events-hibernate/xwiki-platform-legacy-events-hibernate-api/src/main/java/org/xwiki/eventstream/store/internal/RecordableEventMigrator.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-oldcore/src/main/java/com/xpn/xwiki/notify/XWikiPageNotification.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-wiki/src/main/java/org/xwiki/localization/wiki/internal/ComponentDocumentTranslationBundle.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-wiki/src/test/java/org/xwiki/localization/wiki/internal/ComponentDocumentTranslationBundleTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/main/java/org/xwiki/mail/internal/factory/usersandgroups/AddressUserDataExtractor.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/main/java/org/xwiki/model/internal/reference/converter/EntityReferenceConverter.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-notifiers/xwiki-platform-notifications-notifiers-default/src/main/java/org/xwiki/notifications/notifiers/internal/email/AbstractMimeMessageIterator.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-sources/src/main/java/org/xwiki/notifications/sources/internal/DefaultGroupingEventManager.java M xwiki-platform-core/xwiki-platform-panels/xwiki-platform-panels-api/src/main/java/org/xwiki/panels/internal/AbstractPanelsUIExtensionManager.java M xwiki-platform-core/xwiki-platform-panels/xwiki-platform-panels-api/src/test/java/org/xwiki/panels/internal/AbstractPanelsUIExtensionManagerTest.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/RatingDeletedEntityListener.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/internal/RatingMovedEntityListener.java M xwiki-platform-core/xwiki-platform-ratings/xwiki-platform-ratings-api/src/main/java/org/xwiki/ratings/script/AbstractScriptRatingsManager.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/main/java/org/xwiki/refactoring/internal/job/AbstractReplaceUserJob.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceRenamer.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/job/ReplaceUserJob.java M xwiki-platform-core/xwiki-platform-repository/xwiki-platform-repository-server-api/src/main/java/org/xwiki/repository/internal/ExtensionStore.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-script/src/main/java/org/xwiki/security/authentication/script/AuthenticationScriptService.java M xwiki-platform-core/xwiki-platform-skin/xwiki-platform-skin-skinx/src/main/java/com/xpn/xwiki/web/sx/SxDocumentSource.java M xwiki-platform-core/xwiki-platform-tag/xwiki-platform-tag-api/src/main/java/com/xpn/xwiki/plugin/tag/TagPlugin.java M xwiki-platform-core/xwiki-platform-tag/xwiki-platform-tag-api/src/main/java/org/xwiki/tag/internal/selector/DefaultTagsSelector.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-api/src/main/java/org/xwiki/uiextension/script/UIExtensionScriptService.java M xwiki-platform-core/xwiki-platform-velocity/xwiki-platform-velocity-webapp/src/main/java/org/xwiki/velocity/XWikiWebappResourceLoader.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/main/java/org/xwiki/xar/internal/property/DateXarObjectPropertySerializer.java M xwiki-platform-core/xwiki-platform-xar/xwiki-platform-xar-model/src/test/java/org/xwiki/xar/internal/property/DateXarObjectPropertySerializerTest.java Log Message: ----------- [Misc] Apply the logging best practices to 26 more platform modules (#6065) Second pass of the SLF4J logging audit, covering a class the first pass excluded wholesale: log calls inside a catch block that throw away the exception they are holding. The blanket "error() without a Throwable is fine when no exception is in scope" exclusion does not apply inside a catch -- there the exception *is* in scope. 54 such sites are fixed across 26 modules: error() now receives the caught exception in the SLF4J Throwable slot, and warn() (which must not print a stack trace) now appends ExceptionUtils.getRootCauseMessage(e). Several were more than a style issue. Since SLF4J 1.7.26 a trailing Throwable is always trimmed off the argument array, so: * logger.error("... [{}]", e) logged the trace but left the {} unsubstituted, printing it literally. In IconContextStore that placeholder was meant for the icon set name, which was therefore never logged. * logger.error("... [{}]", ref, ExceptionUtils.getRootCause(e)) logged no trace at all whenever the exception had no cause, because getRootCause returns null then. All of xwiki-platform-ratings used this idiom. * XWikiPageNotification built a throwaway XWikiException in both of its catch blocks purely to format a string via getFullMessage(), logged that string and dropped the exception, so no stack trace was ever produced. Also picked up along the way: two WARNSTACK sites the first parser missed (WikiReader uses the Marker overload, which shifts the argument positions; DocumentContentAnnotationUpdateListener used the message-less warn(e.getMessage(), e) form), and the "Unexcepted" misspelling in IconContextStore. Deliberately left alone: InterruptedException catches (the root cause message renders as "InterruptedException: null"), expected-control-flow fallbacks, and the 26 remaining sites in xwiki-platform-oldcore, which are left for a follow-up. Tests and checkstyle (-Plegacy,quality) were run from each of the 31 affected module directories; all pass. Three tests asserting on a changed message were updated (AbstractPanelsUIExtensionManagerTest, ComponentDocumentTranslationBundleTest, DateXarObjectPropertySerializerTest). Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/misc-logging-batch4 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] c6fd2f: [Misc] Apply the logging best practices to 15 more...
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: c6fd2f4bf5d47cfb8e82251625cf73658793d79c https://github.com/xwiki/xwiki-platform/commit/c6fd2f4bf5d47cfb8e82251625cf… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-08-02 (Sun, 02 Aug 2026) Changed paths: M xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-servlet/src/main/java/org/xwiki/container/servlet/HttpServletUtils.java M xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-servlet/src/main/java/org/xwiki/container/servlet/filters/internal/SafeRedirectFilter.java M xwiki-platform-core/xwiki-platform-dashboard/xwiki-platform-dashboard-macro/src/main/java/org/xwiki/rendering/internal/macro/dashboard/DashboardMacro.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-default/src/main/java/org/xwiki/index/internal/DefaultTasksManager.java M xwiki-platform-core/xwiki-platform-javascript/xwiki-platform-javascript-importmap/src/main/java/org/xwiki/javascript/importmap/internal/JavascriptImportmapResolver.java M xwiki-platform-core/xwiki-platform-javascript/xwiki-platform-javascript-importmap/src/test/java/org/xwiki/javascript/importmap/internal/JavascriptImportmapResolverTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-script/src/main/java/org/xwiki/localization/script/LocalizationScriptService.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultModelBridge.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/main/java/org/xwiki/refactoring/internal/DefaultReferenceUpdater.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/DefaultSheetManager.java M xwiki-platform-core/xwiki-platform-sheet/xwiki-platform-sheet-api/src/main/java/org/xwiki/sheet/internal/SheetDocumentDisplayer.java M xwiki-platform-core/xwiki-platform-tika/xwiki-platform-tika-detect/src/main/java/org/xwiki/tika/internal/TikaUtils.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/main/java/org/xwiki/uiextension/internal/WikiUIExtensionParameters.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionParametersTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-script/src/main/java/org/xwiki/user/script/GroupScriptService.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-script/src/test/java/org/xwiki/user/script/GroupScriptServiceTest.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/internal/converter/AbstractRequestParameterConverter.java M xwiki-platform-core/xwiki-platform-wysiwyg/xwiki-platform-wysiwyg-api/src/main/java/org/xwiki/wysiwyg/script/WysiwygEditorScriptService.java M xwiki-platform-core/xwiki-platform-xml/xwiki-platform-xml-script/src/main/java/org/xwiki/xml/script/XMLScriptService.java M xwiki-platform-core/xwiki-platform-zipexplorer/src/main/java/com/xpn/xwiki/plugin/zipexplorer/ZipExplorerPlugin.java M xwiki-platform-distribution/xwiki-platform-distribution-flavor/xwiki-platform-distribution-flavor-test/xwiki-platform-distribution-flavor-test-webstandards/src/test/it/org/xwiki/test/webstandards/framework/AbstractValidationTest.java Log Message: ----------- [Misc] Apply the logging best practices to 15 more platform modules (#6064) Last batch of the logging best-practices audit: the 15 modules that had only one or two offending call sites each. * `warn()` no longer passes a Throwable: the stack trace leaves the SLF4J slot and the cause is surfaced through `ExceptionUtils.getRootCauseMessage()`. * `String.format()` and string concatenation replaced with `{}` placeholders and arguments. * `warn()` calls using `e.getMessage()` switched to `ExceptionUtils.getRootCauseMessage()`, which surfaces the underlying cause. * Values wrapped in `[]`, and trailing whitespace trimmed from messages. `DashboardMacro` also stopped discarding its `ComponentLookupException` entirely: the log line now names its root cause. The two `LogCaptureExtension`-based tests that assert the rendered message were updated. Their exception fixtures had no message, which would have rendered an uninformative `[GroupException: ]`, so they now carry a distinct message each. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 02 Aug '26

02 Aug '26

Branch: refs/heads/misc-logging-batch3 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0