- notifications - lists.xwiki.org

[xwiki/xwiki-platform] b945a1: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/stable-18.6.x Home: https://github.com/xwiki/xwiki-platform Commit: b945a1fa66130bd0869090dceeeaae46eb6ee9b9 https://github.com/xwiki/xwiki-platform/commit/b945a1fa66130bd0869090dceeea… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests (#6020) (#6022) Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, so the converted assertions were one java:S3415 argument swap away from silently no longer matching anything. On this branch the class-level @SuppressWarnings("java:S3415") that master had added to hold that off was never applied, so the file goes straight from the converted form back to the boolean one. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. (cherry picked from commit d114bf0615cdf7c1f058ac4547721f48302c43d9) Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 1321f6: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/backport/stable-18.6.x/pr-6020 Home: https://github.com/xwiki/xwiki-platform Commit: 1321f6a848ab6b51842a1a56c07b0191f5c20911 https://github.com/xwiki/xwiki-platform/commit/1321f6a848ab6b51842a1a56c07b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests (#6020) Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, so the converted assertions were one java:S3415 argument swap away from silently no longer matching anything. On this branch the class-level @SuppressWarnings("java:S3415") that master had added to hold that off was never applied, so the file goes straight from the converted form back to the boolean one. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> (cherry picked from commit d114bf0615cdf7c1f058ac4547721f48302c43d9) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/misc-s5785-equals-contract-tests Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] d114bf: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: d114bf0615cdf7c1f058ac4547721f48302c43d9 https://github.com/xwiki/xwiki-platform/commit/d114bf0615cdf7c1f058ac454772… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests (#6020) Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, which is why it already needed a class-level @SuppressWarnings("java:S3415") to stay correct. That suppression is dropped since the assertions call equals() explicitly again. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. Co-authored-by: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 87a7c0: [Misc] Revert the java:S5785 changes on the equals...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/misc-s5785-equals-contract-tests Home: https://github.com/xwiki/xwiki-platform Commit: 87a7c019edbde0068e1834b59d9f1bfe552f4f30 https://github.com/xwiki/xwiki-platform/commit/87a7c019edbde0068e1834b59d9f… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/EntityReferenceTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-api/src/test/java/org/xwiki/model/reference/RegexEntityReferenceTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java Log Message: ----------- [Misc] Revert the java:S5785 changes on the equals()/hashCode() contract tests Converting assertTrue/assertFalse(a.equals(b)) into assertEquals/assertNotEquals in tests whose purpose is to verify the equals()/hashCode() contract changes what is being tested. JUnit compares through AssertionUtils.objectsAreEqual(a, b), i.e. a == null ? b == null : a.equals(b), so the call site no longer shows which object is the receiver and which one is the argument, and it invites a later java:S3415 "swap these arguments" change that would call the other object's equals() instead. The 88 assertions concerned are restored to their boolean form in 14 test files, and the reason now lives in the code as @SuppressWarnings("java:S5785") plus an explanatory comment on each contract-test method. Assertions that merely happen to compare two values with equals() in ordinary tests are left converted, as are the hashCode() comparisons outside contract tests. RegexEntityReferenceTest is the clearest case: RegexEntityReference#equals() only runs the regex when the regex reference is the receiver, which is why it already needed a class-level @SuppressWarnings("java:S3415") to stay correct. That suppression is dropped since the assertions call equals() explicitly again. This reverts the equals()/hashCode() contract-test parts of 1eafd658a13, a94435cb30c, ce509be1144 and d5ac2bd37e0. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-dev-llm] 20bbe2: [Misc] Release v1.0.0
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: 20bbe28ef8fd9634d3d7080801acaef30239886c https://github.com/xwiki/xwiki-dev-llm/commit/20bbe28ef8fd9634d3d7080801aca… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M .claude-plugin/marketplace.json M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json Log Message: ----------- [Misc] Release v1.0.0 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] cf0671: [Misc] Add S2143, S2160 and S1141 to the SonarQube...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: cf0671c9777d039fa59f8b6029b1bc60d69f7d05 https://github.com/xwiki/xwiki-dev-llm/commit/cf0671c9777d039fa59f8b6029b1b… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M xwiki/okf/sonarqube/index.md Log Message: ----------- [Misc] Add S2143, S2160 and S1141 to the SonarQube denylist Missed from the previous commit. Like S3776 these are real design changes rather than mechanical cleanups, so a Sonar sweep is the wrong vehicle. Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[xwiki/xwiki-dev-llm] 8603a9: [Misc] Move the SonarQube rule-fix knowledge into ...
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-dev-llm Commit: 8603a9d0d1e4ba86805c96b9cede76b84508922a https://github.com/xwiki/xwiki-dev-llm/commit/8603a9d0d1e4ba86805c96b9cede7… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-29 (Wed, 29 Jul 2026) Changed paths: M .claude-plugin/marketplace.json M README.md M kimi.plugin.json M opencode.jsonc M xwiki/.claude-plugin/plugin.json M xwiki/instructions/xwiki-org.md M xwiki/okf/conventions/code-style.md M xwiki/okf/index.md A xwiki/okf/sonarqube/constant-and-resource-rules.md A xwiki/okf/sonarqube/dead-code-rules.md A xwiki/okf/sonarqube/index.md A xwiki/okf/sonarqube/modernization-rules.md A xwiki/okf/sonarqube/simplification-rules.md A xwiki/okf/sonarqube/syntax-rules.md A xwiki/okf/sonarqube/test-code-rules.md A xwiki/okf/sonarqube/verification.md M xwiki/skills/xwiki-build/SKILL.md M xwiki/skills/xwiki-fix-sonarqube-issue/SKILL.md Log Message: ----------- [Misc] Move the SonarQube rule-fix knowledge into a per-rule-family OKF topic Distils the durable half of the sonarqube routine-memory repo into the OKF so that fixing a Sonar issue is driven by knowing which sites to DROP, not just what the transform is. * Add okf/sonarqube/ — index (rule map, denylist, universal drop conditions) plus six family files loaded lazily, one per rule group, and verification.md. Pool sizes are excluded as volatile; the index gives a facet query instead. * Record the @SuppressWarnings("java:SXXXX") + rationale-comment convention in okf/conventions/code-style.md — retire a won't-fix in the code, not in SonarCloud, so the next developer reads the reason next to the code. * Add reactor-result semantics to the xwiki-build skill: a mid-reactor failure skips every later module, and how to tell a pre-existing failure from yours. * Rewrite the xwiki-fix-sonarqube-issue skill around the OKF: drop its inline allow/denylist, add the load protocol and the safe-batch-application procedure (assert-guarded script, match-count location, subagent verification). Co-Authored-By: Claude Opus 5 (1M context) <noreply(a)anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-dev-llm/settings/notifications

1 0

[jira@xwiki.org][Issue] Updates for XDOCKER-426: Harden the Dockerfile build steps (LibreOffice symlink, shell error mode, checksum format)
by XWiki Notifications 29 Jul '26

29 Jul '26

1 0

[xwiki/xwiki-docker]
by XWiki Notifications 29 Jul '26

29 Jul '26

Branch: refs/heads/XDOCKER-426 Home: https://github.com/xwiki/xwiki-docker To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-docker/settings/notifications

1 0