- notifications - lists.xwiki.org

[xwiki/xwiki-platform] 1eafd6: [Misc] Use dedicated assertions instead of boolean...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 1eafd658a1364446d82b7b9e613a91e44341a7f0 https://github.com/xwiki/xwiki-platform/commit/1eafd658a1364446d82b7b9e613a… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-container/xwiki-platform-container-servlet/src/test/java/org/xwiki/container/servlet/filters/SavedRequestManagerTest.java M xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-default/src/test/java/org/xwiki/icon/internal/DefaultIconSetManagerTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-observation/src/test/java/org/xwiki/observation/ActionExecutionEventTest.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-default/src/test/java/org/xwiki/mail/internal/thread/SendMailRunnableTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-api/src/test/java/org/xwiki/refactoring/job/question/EntitySelectionTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightMapTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/RightSetTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/test/java/org/xwiki/store/serialization/xml/internal/AttachmentListMetadataSerializerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-api/src/test/java/org/xwiki/url/ExtendedURLTest.java M xwiki-platform-core/xwiki-platform-webjars/xwiki-platform-webjars-api/src/test/java/org/xwiki/webjars/WebJarResourceReferenceTest.java M xwiki-platform-core/xwiki-platform-wiki/xwiki-platform-wiki-default/src/test/java/org/xwiki/wiki/internal/manager/DefaultWikiCreatorTest.java Log Message: ----------- [Misc] Use dedicated assertions instead of boolean assertions in tests (SonarCloud java:S5785) * Replace assertTrue/assertFalse on equals(), ==, != and null checks with assertEquals/assertNotEquals/assertSame/assertNotNull across 11 test classes. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-papb8a Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] a94435: [Misc] Use dedicated assertions instead of boolean...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: a94435cb30c8807bc767adb30726396e8f72e074 https://github.com/xwiki/xwiki-platform/commit/a94435cb30c8807bc767adb30726… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiLinkTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/objects/NumberPropertyTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/store/DatabaseProductTest.java Log Message: ----------- [Misc] Use dedicated assertions instead of boolean assertions in oldcore tests (SonarCloud java:S5785) * Replace assertTrue/assertFalse wrapping equals(), ==, != and size() comparisons with assertEquals/assertNotEquals/assertSame/assertNotSame so failures report the actual and expected values. * The receiver is kept as the first argument to preserve each assertion's equals()/identity direction. Test-only change, behaviour-preserving. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-0y3zww Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 5fe8e1: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 5fe8e1bab60ae77ad2d1f65572b9184a5219dbec https://github.com/xwiki/xwiki-platform/commit/5fe8e1bab60ae77ad2d1f65572b9… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-core/src/test/java/org/xwiki/annotation/content/SpaceNormalizerContentAltererTest.java M xwiki-platform-core/xwiki-platform-annotation/xwiki-platform-annotation-core/src/test/java/org/xwiki/annotation/content/WhiteSpaceContentAltererTest.java M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/CSRFTokenInvalidatorTest.java M xwiki-platform-core/xwiki-platform-csrf/src/test/java/org/xwiki/csrf/DefaultCSRFTokenConfigurationTest.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-html/src/test/java/org/xwiki/rendering/display/html/internal/DefaultTemplateHTMLDisplayerTest.java M xwiki-platform-core/xwiki-platform-display/xwiki-platform-display-html/src/test/java/org/xwiki/rendering/display/html/script/HTMLDisplayerScriptServiceTest.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-livetable/src/test/java/org/xwiki/livedata/internal/livetable/LiveTableLiveDataSourceTest.java M xwiki-platform-core/xwiki-platform-livedata/xwiki-platform-livedata-livetable/src/test/java/org/xwiki/livedata/internal/livetable/PropertyTypeSupplierTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-jar/src/test/java/org/xwiki/localization/jar/internal/JARTranslationBundleFactoryTest.java M xwiki-platform-core/xwiki-platform-localization/xwiki-platform-localization-sources/xwiki-platform-localization-source-jar/src/test/java/org/xwiki/localization/jar/internal/RootClassLoaderTranslationBundleTest.java M xwiki-platform-core/xwiki-platform-mentions/xwiki-platform-mentions-notifications/src/test/java/org/xwiki/mentions/internal/MentionsNotificationDisplayerTest.java M xwiki-platform-core/xwiki-platform-mentions/xwiki-platform-mentions-notifications/src/test/java/org/xwiki/mentions/internal/MentionsRecordableEventConverterTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-api/src/test/java/org/xwiki/notifications/internal/DefaultCompositeEventStatusManagerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-api/src/test/java/org/xwiki/notifications/internal/SimilarityCalculatorTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/test/java/org/xwiki/notifications/filters/internal/DocumentMovedListenerTest.java M xwiki-platform-core/xwiki-platform-notifications/xwiki-platform-notifications-filters/xwiki-platform-notifications-filters-default/src/test/java/org/xwiki/notifications/filters/internal/UserAddedEventListenerTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/job/ReplaceUserJobTest.java M xwiki-platform-core/xwiki-platform-refactoring/xwiki-platform-refactoring-default/src/test/java/org/xwiki/refactoring/internal/listener/UpdateObjectsOnClassRenameListenerTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/test/java/org/xwiki/search/solr/internal/DefaultSolrTest.java M xwiki-platform-core/xwiki-platform-search/xwiki-platform-search-solr/xwiki-platform-search-solr-embedded/src/test/java/org/xwiki/search/solr/internal/EmbeddedSolrInitializationTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DefaultAuthenticationFailureManagerTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authentication/xwiki-platform-security-authentication-default/src/test/java/org/xwiki/security/authentication/internal/DisableAccountFailureStrategyTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/SecurityReferenceTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/cache/internal/DefaultSecurityCacheTest.java M xwiki-platform-core/xwiki-platform-security/xwiki-platform-security-authorization/xwiki-platform-security-authorization-api/src/test/java/org/xwiki/security/authorization/internal/DefaultAuthorizationSettlerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-resource/src/test/java/org/xwiki/user/resource/internal/document/DocumentUserResourceReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-user/xwiki-platform-user-resource/src/test/java/org/xwiki/user/resource/internal/document/UserResourceReferenceTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Mechanical, behaviour-preserving cleanup of SonarCloud rule java:S5786 across 13 modules: JUnit5 no longer requires test classes or test methods to be public, package-private is the recommended visibility. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-vcdatr Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] 9ef628: [Misc] Make JUnit5 test classes and methods packag...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 9ef6288923f9c34315f0410731d5ca5d359499e3 https://github.com/xwiki/xwiki-platform/commit/9ef6288923f9c34315f0410731d5… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/test/java/org/xwiki/captcha/internal/JCaptchaResourceReferenceHandlerTest.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/test/java/org/xwiki/captcha/internal/JCaptchaResourceReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-captcha/xwiki-platform-captcha-jcaptcha/xwiki-platform-captcha-jcaptcha-api/src/test/java/org/xwiki/captcha/internal/script/JCaptchaInternalScriptServiceTest.java M xwiki-platform-core/xwiki-platform-diff/xwiki-platform-diff-xml/src/test/java/org/xwiki/diff/xml/internal/DefaultDataURIConverterTest.java M xwiki-platform-core/xwiki-platform-diff/xwiki-platform-diff-xml/src/test/java/org/xwiki/diff/xml/internal/ImageDownloaderTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/ChildDocumentsTreeNodeGroupTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/DocumentTreeNodeTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/query/ExcludedDocumentFilterTest.java M xwiki-platform-core/xwiki-platform-index/xwiki-platform-index-tree/xwiki-platform-index-tree-api/src/test/java/org/xwiki/index/tree/internal/nestedpages/query/ExcludedSpaceFilterTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/DeprecatedLocalReferenceEntityReferenceSerializerTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/ReferencesTest.java M xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-model-api/src/test/java/org/xwiki/model/internal/reference/StringsTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/test/java/org/xwiki/model/validation/AbstractEntityNameValidationTest.java M xwiki-platform-core/xwiki-platform-model/xwiki-platform-model-validation/xwiki-platform-model-validation-api/src/test/java/org/xwiki/model/validation/script/ModelValidationScriptServiceTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/test/java/org/xwiki/rendering/async/internal/AsyncRendererCacheTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/test/java/org/xwiki/rendering/async/internal/service/AsyncRendererResourceReferenceResolverTest.java M xwiki-platform-core/xwiki-platform-rendering/xwiki-platform-rendering-async/xwiki-platform-rendering-async-default/src/test/java/org/xwiki/rendering/async/internal/service/AsyncRendererResourceReferenceTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-api/src/test/java/org/xwiki/store/merge/MergeDocumentResultTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-api/src/test/java/org/xwiki/store/merge/MergeManagerResultTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-default/src/test/java/org/xwiki/store/merge/MergeDocumentResultScriptTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-default/src/test/java/org/xwiki/store/merge/internal/DefaultMergeConflictDecisionManagerTest.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-merge/xwiki-platform-store-merge-default/src/test/java/org/xwiki/store/merge/internal/DefaultMergeManagerTest.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionParametersTest.java M xwiki-platform-core/xwiki-platform-uiextension/xwiki-platform-uiextension-default/src/test/java/org/xwiki/uiextension/WikiUIExtensionTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-schemes/xwiki-platform-url-scheme-standard/src/test/java/org/xwiki/url/internal/standard/ContextAndActionURLNormalizerTest.java M xwiki-platform-core/xwiki-platform-url/xwiki-platform-url-schemes/xwiki-platform-url-scheme-standard/src/test/java/org/xwiki/url/internal/standard/StandardURLStringEntityReferenceResolverTest.java Log Message: ----------- [Misc] Make JUnit5 test classes and methods package-private (SonarCloud java:S5786) Mechanical, behaviour-preserving cleanup of SonarCloud rule java:S5786 across 10 modules: JUnit5 test classes and their test/lifecycle methods do not need to be public and should be package-private. Only test class declarations and JUnit-annotated methods were changed; no production code touched. To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-d5hd3s Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform] ce509b: [Misc] Use assertEquals/assertNotEquals instead of...
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: ce509be1144324d46501d813bdffee986c785d92 https://github.com/xwiki/xwiki-platform/commit/ce509be1144324d46501d813bdff… Author: Vincent Massol <vincent(a)massol.net> Date: 2026-07-15 (Wed, 15 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-bridge/src/test/java/org/xwiki/bridge/ActionExecutingEventTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/AbstractRecordableEventDescriptorTest.java M xwiki-platform-core/xwiki-platform-eventstream/xwiki-platform-eventstream-api/src/test/java/org/xwiki/eventstream/SimpleEventQueryTest.java Log Message: ----------- [Misc] Use assertEquals/assertNotEquals instead of boolean assertions in bridge and eventstream-api tests (SonarCloud java:S5785) Replace assertTrue(a.equals(b))/assertFalse(a.equals(b)) and assertTrue(x == 0)/assertTrue(x != 0) with assertEquals/assertNotEquals so that a failure reports the actual and expected values. The receiver is kept as the first argument to preserve the exact equals() direction (matters for the cross-type comparison against ActionExecutedEvent). To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0

[xwiki/xwiki-platform]
by XWiki Notifications 15 Jul '26

15 Jul '26

Branch: refs/heads/claude/vigilant-dirac-d9tl91 Home: https://github.com/xwiki/xwiki-platform To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications

1 0