There are 2 comments.
 
 
XWiki Rendering / cid:jira-generated-image-avatar-3dd97f01-b357-4dba-ac13-458bbcacd958 XRENDERING-805 Reopened

Improve indentation in TocTreeBuilder.java (lambda arguments) to fix Checkstyle ci

 
View issue   ยท   Add comment
 

2 comments

 
cid:jira-generated-image-avatar-09d21662-8f55-441e-85f2-b3bf82c8e7ca Vincent Massol on 20/Mar/26 09:19
 

For example on StrictDuplicateCode, PackageHtml, ClassDataAbstractionCoupling

From our checkstyle.xml file:

  <!-- We cannot use this rule as it fails on our license headers, considering them as copy-pastes!
  <module name="StrictDuplicateCode"/>
  -->
  <!-- We'd like to use this one but there's no option to exclude our internal packages
  <module name="PackageHtml"/>
  -->
    <!-- This is a good metric but checkstyle doesn't allow to remove JDK's base classes
         from the new count thus making this check unusable IMO
    <module name="ClassDataAbstractionCoupling"/>
    -->

This was done a long time ago, maybe there are now ways to cope with this.

 
cid:jira-generated-image-avatar-09d21662-8f55-441e-85f2-b3bf82c8e7ca Vincent Massol on 20/Mar/26 09:20
 
bq. For example on StrictDuplicateCode, PackageHtml, ClassDataAbstractionCoupling

From our checkstyle.xml file:

{code}
  <!-- We cannot use this rule as it fails on our license headers, considering them as copy-pastes!
  <module name="StrictDuplicateCode"/>
  -->
{code}

{code}
  <!-- We'd like to use this one but there's no option to exclude our internal packages
  <module name="PackageHtml"/>
  -->
{code}

{code}
    <!-- This is a good metric but checkstyle doesn't allow to remove JDK's base classes
         from the new count thus making this check unusable IMO
    <module name="ClassDataAbstractionCoupling"/>
    -->
{code}

This was done a long time ago, maybe there are now ways to cope with this
, and it would be good to do a new pass on the checkstyle config .