There is 1 comment.
 
 
XWiki Platform / cid:jira-generated-image-avatar-04aaf7e4-0bc3-46ce-ba8f-24e03f507ec0 XWIKI-23182 Open

Modifying an image style should not require updating all past images inserted

 
View issue   ยท   Add comment
 

1 comment

 
cid:jira-generated-image-avatar-5bf5c909-a0b3-44f2-9d91-918e54b59b80 Michael Hamann on 23/Mar/26 11:31
 

It would be even better this could be achieved without modifying the style attribute as this creates a lot of mess with WYSIWYG editing. Ideally, as much as possible, this should be achieved with a style sheet that is generated based on the configured image style and that applies the configured styles based on the data-attribute that denotes the image style. At least to me, that would seem a lot cleaner as it would avoid inline styles where possible. Now the question is of course what should happen if both inline styles and an image style are used and if it should be possible to override the defaults of the image style. I guess the WYSIWYG editor should prevent overriding the image style where desirable (by being aware of it) but the user could of course still manually set them.

That said, I remember that I helped creating some rendering code that already updates style attributes during some rendering/parsing steps. So we should first understand again what they're already doing and if they could be extended to deal with this.