There are 4 comments.
 
 
XWiki Rendering / cid:jira-generated-image-avatar-140840f4-f353-4ca6-8764-3e7bdebf6682 XRENDERING-805 Reopened

Improve indentation in TocTreeBuilder.java (lambda arguments) to fix Checkstyle ci

 
View issue   ยท   Add comment
 

4 comments

 
cid:jira-generated-image-avatar-3727265e-bc02-42ba-80be-6c4d235153a1 Kairav on 19/Mar/26 15:40
 

Michael Hamann I'm sorry for the late reply I hate to see you having to fetch the PR, I should have linked it, that's my bad. I'll reply properly on the weekend in regards to what the update is about, can you link the checkstyle config that xwiki is using? Is this the correct one I see from xwiki/xwiki-commons checkstyle.xml 

 
cid:jira-generated-image-avatar-3727265e-bc02-42ba-80be-6c4d235153a1 Kairav on 19/Mar/26 15:43
 

On a site note, I'm seeing a lot of exclusions in the xml file on checks that seem important for your team. For example on StrictDuplicateCode, PackageHtml, ClassDataAbstractionCoupling etc. Which ones does the team deem important but isn't using them because of limited capibility? 

 
cid:jira-generated-image-avatar-3727265e-bc02-42ba-80be-6c4d235153a1 Kairav on 19/Mar/26 15:44
 
On a site note, I'm seeing a lot of exclusions in the xml file on checks that seem important for your team. For example on StrictDuplicateCode, PackageHtml, ClassDataAbstractionCoupling etc. Which ones does the team deem important but isn't using them because of limited capibility?   If this comment should be moved to a separate ticket / issue, then please let me know
 
cid:jira-generated-image-avatar-3b963828-0d78-4d10-aadf-c1ba69dbf8b9 Michael Hamann on 19/Mar/26 15:44
 

Kairav Yes, that's our Checkstyle configuration.