[xwiki/xwiki-platform] 6f2a60: XWIKI-24201: MailStatusStore should validate filte...
Branch: refs/heads/master Home: https://github.com/xwiki/xwiki-platform Commit: 6f2a608c5ca6c367b23203833a763e1f6d5f4bf8 https://github.com/xwiki/xwiki-platform/commit/6f2a608c5ca6c367b23203833a763... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-04-13 (Mon, 13 Apr 2026) Changed paths: M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-storage/src/main/java/org/xwiki/mail/internal/DatabaseMailStatusStore.java M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-storage/src/test/java/org/xwiki/mail/internal/DatabaseMailStatusStoreTest.java Log Message: ----------- XWIKI-24201: MailStatusStore should validate filter and sorting fields * Validate filter and sorting fields, ignoring invalid sort fields and throwing on invalid filter fields. * Use MailStatus property names qualified with an alias (to avoid reserved keywords) instead of the actual column names. * Map the documented but wrong "status" key to the "state" property. * Map the "id" field, which was previously mapped to the "mail_id" column, to the "messageId" property that is stored in the "mail_id" column. * Adapt tests to not use the non-existing status key except for an actual test for the alias. * Add tests for the validation. Commit: a36fe0f6225a31744f12731098d41e6de612e0cb https://github.com/xwiki/xwiki-platform/commit/a36fe0f6225a31744f12731098d41... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-04-13 (Mon, 13 Apr 2026) Changed paths: M xwiki-platform-core/xwiki-platform-mail/xwiki-platform-mail-send/xwiki-platform-mail-send-storage/src/main/java/org/xwiki/mail/internal/DatabaseMailStatusStore.java Log Message: ----------- [Misc] Use HQL property name in mail status delete() query for consistency Use the HQL property name 'messageId' instead of the SQL column name 'mail_id' in the delete query of DatabaseMailStatusStore, consistent with all other query methods in the class. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Compare: https://github.com/xwiki/xwiki-platform/compare/bf0a780dcaf9...a36fe0f6225a To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications