[xwiki-contrib/confluence] bee26e: Misc: coding style: simplify a bit the inline comm...
Branch: refs/heads/betterinlinecomments Home: https://github.com/xwiki-contrib/confluence Commit: bee26ed6301663c4337541aa14938946747e0cbf https://github.com/xwiki-contrib/confluence/commit/bee26ed6301663c4337541aa1... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceConverterListener.java Log Message: ----------- Misc: coding style: simplify a bit the inline comment handling Commit: 04993868635d575e0ef2ab2a61bdc33530d9e2f9 https://github.com/xwiki-contrib/confluence/commit/04993868635d575e0ef2ab2a6... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceConverterListener.java Log Message: ----------- Misc: add a FIXME for the setWrappedListener / getWrappedListener asymetry in ConfluenceConverterListener Commit: 055dbac0312d6c206dc66b4dd111478e994a24e5 https://github.com/xwiki-contrib/confluence/commit/055dbac0312d6c206dc66b4dd... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-xml/checkstyle-suppressions.xml M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceConverterListener.java A confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceWrappingListener.java A confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/NormalizedPlainFilter.java Log Message: ----------- Misc: move ConfluenceConverterListener's inner classes to dedicated java files Commit: da70730d5bdd31e8d43df092daf1b9c0774eb859 https://github.com/xwiki-contrib/confluence/commit/da70730d5bdd31e8d43df092d... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/wikimodel/AbstractRichContentTagHandler.java M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceConverterListener.java Log Message: ----------- Misc: fix the getWrappedListener / setWrappedListener asymetry Commit: 9be58c7fd20af7845f241ee4db45c0314f6b20bc https://github.com/xwiki-contrib/confluence/commit/9be58c7fd20af7845f241ee4d... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceWrappingListener.java Log Message: ----------- Misc: code style: simplify queueEvents Commit: 0a116dc856749844bfbca573740e005b3b39434a https://github.com/xwiki-contrib/confluence/commit/0a116dc856749844bfbca5737... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/wikimodel/ElementMacroTagHandler.java M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/wikimodel/LinkBodyTagHandler.java M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceConverterListener.java Log Message: ----------- Misc: code style Commit: eb6c65dbc7954a1532b3a8074a5bcdd3fbf4dae9 https://github.com/xwiki-contrib/confluence/commit/eb6c65dbc7954a1532b3a8074... Author: Raphaël Jakse <raphael.jakse@xwiki.com> Date: 2026-03-03 (Tue, 03 Mar 2026) Changed paths: M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/ConfluenceXHTMLInputFilterStream.java M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/ConfluenceXHTMLParser.java M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/InternalConfluenceXHTMLInputProperties.java M confluence-syntax-xhtml/src/main/java/org/xwiki/contrib/confluence/parser/xhtml/internal/wikimodel/AbstractRichContentTagHandler.java M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceConverterListener.java M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceInputFilterStream.java M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/ConfluenceWrappingListener.java M confluence-xml/src/main/java/org/xwiki/contrib/confluence/filter/internal/input/NormalizedPlainFilter.java Log Message: ----------- Misc: Stop changing the wrapped listener in ConfluenceConverterListener * This makes the code easier to follow and more robust, especially since listeners can be queued in ConfluenceWrappingListener to allow complex handling and cleaning. * Whenever a handler needs to save events to replay or render them in a custom way, it must use its own instance of ConfluenceConverterListener. * To allow this, ConfluenceXHTMLParser now has a converter provider, with a setter and getter. * ConfluenceXHTMLParser doesn't have a setConverter and a getConverter method anymore: the converter provider is supposed to be used instead. * Annotation handling now uses the queueing mechanism of ConfluenceWrappingListener instead of changing the wrapped listener. * Any attempt of changing the wrapped listener will now result in an UnsupportedOperationException. Compare: https://github.com/xwiki-contrib/confluence/compare/bee26ed63016%5E...eb6c65... To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/confluence/settings/notifications
participants (1)
-
XWiki Notifications