[xwiki/xwiki-platform] 90be98: XWIKI-18545 Align Like button visuals with known c...
Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 90be9879c792c2fdcde9a4b22a5fe3a7d9644652 https://github.com/xwiki/xwiki-platform/commit/90be9879c792c2fdcde9a4b22a5fe... Author: Anca Luca <lucaa@xwiki.com> Date: 2025-11-27 (Thu, 27 Nov 2025) Changed paths: M xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-fontawesome/src/main/resources/IconThemes/FontAwesome.xml M xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-ui/src/main/resources/IconThemes/Silk.xml A xwiki-platform-core/xwiki-platform-legacy/xwiki-platform-legacy-web/src/main/webapp/resources/icons/silk/heart_empty.gif M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-test/xwiki-platform-like-test-docker/src/test/it/org/xwiki/like/test/ui/LikeIT.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-test/xwiki-platform-like-test-pageobjects/src/main/java/org/xwiki/like/test/po/LikeButton.java M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.fr.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeUIX.xml M xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/icons/default.iconset A xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-war/src/main/webapp/resources/icons/silk/heart_empty.png Log Message: ----------- XWIKI-18545 Align Like button visuals with known conventions (#2645) * Updated the LikeUIX page to the latest platform XML format, prior to making the actual changes fixing the issue * Moved all translations from the LikeUIX to usage of the l10n service instead of velocity evaluation of the javascript source (finishing the refactoring started in XWIKI-19139) * Formatted the Silk icon theme page XML to current xar format * Added a heart_empty icon, in the default icon set, in FontAwesome Theme and in Silk * The Silk icon images were produced based on the heart icon of silk, by clearing the inside the heart (transparency) * Updated formatting of the translation pages that will be updated for this feature * Split the likes UI in 2 elements: a button for the action, heart shaped, and a link that displays the number of current likes and allows to get to the list of likes * Styled the like button to align with current conventions: 'primary' when the element was liked already and default when it's not, so that it lights up when liked by current user * Updated translations to correspond to the new UI * Moved the gif version of the icon in the legacy web module, next to all other gif icons * Fixed code according to @michitux's comments: using let instead of var and escaping link label * Added a slightly colored background box to the heart icon on hover, to enhance visually it's reactivity on hover and better separate the 2 controls: the heart and the likers link * Removed the outline of the heart button as the outline border is too crammed up against the content and makes the button undistinguishable * Fixed some formatting --------- Co-authored-by: LucasC <lucas.charpentier@xwiki.com> Co-authored-by: Marius Dumitru Florea <marius@xwiki.com> Co-authored-by: Simon Urli <simon.urli@xwiki.com> (cherry picked from commit 957d3d3cb556037d98058d2f25098941ea3a992b) Commit: e93de9700486e80ef54eeb05e8e5833fe0f1c3fb https://github.com/xwiki/xwiki-platform/commit/e93de9700486e80ef54eeb05e8e58... Author: Simon Urli <simon.urli@xwiki.com> Date: 2025-11-27 (Thu, 27 Nov 2025) Changed paths: M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.xml Log Message: ----------- XWIKI-18545: Align Like button visuals with known conventions * Only mark the translations as deprecated for now (cherry picked from commit d904c96c4b33007b2d8e4649fb145e06ca27d227) Commit: dad2023870b4e243a12dfd233e00020572fa1d98 https://github.com/xwiki/xwiki-platform/commit/dad2023870b4e243a12dfd233e000... Author: Simon Urli <simon.urli@xwiki.com> Date: 2025-11-27 (Thu, 27 Nov 2025) Changed paths: M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.fr.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeUIX.xml Log Message: ----------- XWIKI-18545: Align Like button visuals with known conventions * Fix translations (cherry picked from commit 289f77893bb81f6f5797cf22ef60238ebc47a990) Commit: 5f1f14ca33490c3f0358fb3fc6f49f5080430cab https://github.com/xwiki/xwiki-platform/commit/5f1f14ca33490c3f0358fb3fc6f49... Author: Simon Urli <simon.urli@xwiki.com> Date: 2025-11-27 (Thu, 27 Nov 2025) Changed paths: M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.de.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.es.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.fr.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.ja.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.ko.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.no.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.ru.xml M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-ui/src/main/resources/XWiki/Like/LikeTranslations.uk.xml Log Message: ----------- XWIKI-18545: Align Like button visuals with known conventions * Fix translations to properly put them in deprecated section (cherry picked from commit 1935cbc65b42958dc5b6ae9566affb2560ba123a) Commit: 275c909734684bc1610145b27e1a304b506c29b6 https://github.com/xwiki/xwiki-platform/commit/275c909734684bc1610145b27e1a3... Author: Thomas Mortagne <thomas.mortagne@gmail.com> Date: 2025-11-27 (Thu, 27 Nov 2025) Changed paths: M xwiki-platform-core/xwiki-platform-like/xwiki-platform-like-test/xwiki-platform-like-test-docker/src/test/it/org/xwiki/like/test/ui/LikeIT.java Log Message: ----------- XWIKI-18545 Align Like button visuals with known conventions * remove unused imports (cherry picked from commit df2bc498140c46d2d8fd1078a119f620526d8f52) Compare: https://github.com/xwiki/xwiki-platform/compare/72f8bf4d4921...275c90973468 To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications