Branch: refs/heads/backport/stable-17.10.x/pr-3943 Home: https://github.com/xwiki/xwiki-platform Commit: b524e4b54553e054bb28f2f1b7c60aa8627d2b75 https://github.com/xwiki/xwiki-platform/commit/b524e4b54553e054bb28f2f1b7c60... Author: Simon Urli <simon.urli@xwiki.com> Date: 2026-01-06 (Tue, 06 Jan 2026) Changed paths: M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachment.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiAttachmentContent.java M xwiki-platform-core/xwiki-platform-oldcore/src/main/java/com/xpn/xwiki/doc/XWikiDocument.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/doc/XWikiDocumentMockitoTest.java M xwiki-platform-core/xwiki-platform-oldcore/src/test/java/com/xpn/xwiki/test/MockitoOldcore.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/main/java/org/xwiki/store/legacy/doc/internal/FilesystemAttachmentContent.java M xwiki-platform-core/xwiki-platform-store/xwiki-platform-store-filesystem-oldcore/src/test/java/org/xwiki/store/legacy/store/internal/FilesystemAttachmentVersioningStoreTest.java Log Message: ----------- XWIKI-22931: The edit action modify the cached document when creating a page from template (#3943) * Fix XWikiDocument#copyAttachment to actually perform a real clone including the copy of the content * Introduce a XWikiAttachment#cloneWithActualContent to clone and copy the content * Introduce a XWikiAttachmentContent#clone(boolean) that allows to decide to skip or not copying the content * Get rid of ownerDocument in XWikiAttachmentContent * Properly override new clone method in extended classes * Set the attachment document in XWikiDocument#setAttachment * Small improvments but still having bad stack trace when trying to create page from template related to Solr * Properly load the file content before cloning it * Fix override * Fix since * Ensure that the test is covered (cherry picked from commit bd810557f84f3b056884335f1c64210c81a3e641) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications