[xwiki/xwiki-platform] 7317a6: XWIKI-21894: JSC_PARSE_ERROR in Tour.WebHome (#2895)
Branch: refs/heads/stable-16.1.x Home: https://github.com/xwiki/xwiki-platform Commit: 7317a6295b3e2045d8786026c2cadae359a52aaa https://github.com/xwiki/xwiki-platform/commit/7317a6295b3e2045d8786026c2cad... Author: Antoine Mottier <antoine.mottier83+github@gmail.com> Date: 2024-02-20 (Tue, 20 Feb 2024) Changed paths: M xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-fontawesome/src/main/resources/IconThemes/FontAwesome.xml Log Message: ----------- XWIKI-21894: JSC_PARSE_ERROR in Tour.WebHome (#2895) Use double quotes for icon aria-hidden value The single quotes leads to error for example with tour extension: ``` xwiki:Tour.WebHome:17:78: ERROR - [JSC_PARSE_ERROR] Parse error. ',' expected 17| $('<a class="action actionLaunch"><span class="fa fa-play" aria-hidden='true'></span> Launch</a>') ^ 1 error(s), 0 warning(s) ``` (cherry picked from commit 3fe9ffeab1715358f07b94709da48d91c494b8c1) To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications