[xwiki-contrib/application-releasenotes] f235fc: RN-90: Twelve pages hardcode the ReleaseNotes spac...
Branch: refs/heads/RN-90 Home: https://github.com/xwiki-contrib/application-releasenotes Commit: f235fcd873c87102f7dd607987fa09abc2807a01 https://github.com/xwiki-contrib/application-releasenotes/commit/f235fcd873c... Author: Vincent Massol <vincent@massol.net> Date: 2026-08-31 (Mon, 31 Aug 2026) Changed paths: M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerFlow.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerGrid.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerList.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeDisplayerSimple.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ChangeSheet.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/DisplayChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/GetChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/Change/ReleaseNotesChangesMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeCustomReport.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseChanges.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/HomeReleaseNotes.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Code/ReleaseNotesContributorsMacro.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/Data/WebHome.xml M application-releasenotes-ui/src/main/resources/ReleaseNotes/WebHome.xml A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/CopiedApplicationPageTest.java A application-releasenotes-ui/src/test/java/org/xwiki/releasenotes/HardcodedTopSpaceTest.java Log Message: ----------- RN-90: Twelve pages hardcode the ReleaseNotes space prefix instead of resolving the top-level space at runtime * Resolve the include target from $topSpace in the twelve places that wrote the literal prefix: ReleaseNotes.WebHome, ReleaseNotes.Data.WebHome (three includes), Code/HomeReleaseNotes, Code/HomeReleaseChanges, Code/Change/ReleaseNotesChangesMacro, the four Code/Change/ChangeDisplayer* pages and Code/Change/ChangeSheet. Each of these includes now sits inside a {{velocity}} block, which is what lets its reference be interpolated, the way Code/Change/DisplayChangesMacro already did. * Resolve the classname of the seven Live Data suggest URLs from $topSpace, in the parse=1 JavaScriptExtension objects of Code/HomeReleaseNotes and Code/HomeCustomReport. They silently suggested nothing in a copy of the application, because the suggest endpoint answers an unknown class with an empty list rather than an error. * State which document resolves $topSpace, which was left unstated: the macro's own document for getChanges and displayChanges, which are callable from any page of the wiki; $doc for releasenotechanges and releasenotecontributors, which only work on a release note page; and the value inherited from displayChanges for the four displayer pages, which now list $topSpace among their documented inputs instead of re-deriving it from the calling page. * Add HardcodedTopSpaceTest, which guards every page content and every parse=1 script extension against the literal prefix, and CopiedApplicationPageTest, which renders displayChanges from a copy of the application under another top-level space with nothing left under the shipped one. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> To unsubscribe from these emails, change your notification settings at https://github.com/xwiki-contrib/application-releasenotes/settings/notificat...
participants (1)
-
XWiki Notifications