[xwiki/xwiki-platform] 7b6d55: XWIKI-24642: REST pages in a space resource empty ...
Branch: refs/heads/stable-17.10.x Home: https://github.com/xwiki/xwiki-platform Commit: 7b6d55b375a5f149511a138ffda1b28402d9a29e https://github.com/xwiki/xwiki-platform/commit/7b6d55b375a5f149511a138ffda1b... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/pages/PagesResourceImpl.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/PagesResourceIT.java Log Message: ----------- XWIKI-24642: REST pages in a space resource empty when ordered by date on Oracle * Accept null in the locale condition of the query as Oracle stores the empty string as null, so "language = ''" matched no document at all there and the resource returned an empty result. * Add an integration test asserting that the resource returns the pages of the space when they are ordered by date. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit f9e1a8fa58d9c09eaf19d1e31e73d937c5273ef9) Commit: 54cc6c430b6f568eeeeb204a9a72bb5cd9456ba4 https://github.com/xwiki/xwiki-platform/commit/54cc6c430b6f568eeeeb204a9a72b... Author: Michael Hamann <michael.hamann@xwiki.com> Date: 2026-07-30 (Thu, 30 Jul 2026) Changed paths: M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/BaseAttachmentsResource.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/pages/PagesResourceImpl.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/main/java/org/xwiki/rest/internal/resources/wikis/WikiPagesResourceImpl.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/attachments/AttachmentsResourceImplTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/spaces/SpaceAttachmentsResourceImplTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/wikis/WikiAttachmentsResourceImplTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-server/src/test/java/org/xwiki/rest/internal/resources/wikis/WikiPagesResourceImplTest.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/PagesResourceIT.java M xwiki-platform-core/xwiki-platform-rest/xwiki-platform-rest-test/xwiki-platform-rest-test-tests/src/test/it/org/xwiki/rest/test/WikisResourceIT.java Log Message: ----------- XWIKI-24643: Several REST resources return results in arbitrary, unstable order * Order the pages of a wiki by full name and locale, the attachments by document, locale and file name, and add the page name to the date ordering of the pages in a space, so that paginating with start/number returns a stable, deterministic order. Without ordering by a unique key the database is free to return rows in an arbitrary order that can differ between queries, which made a REST functional test fail occasionally on Oracle. * Add integration tests asserting the order of the pages of a wiki and of the attachments, using names that are ordered differently in a non-binary collation, and asserting that paginating the date-ordered pages of a space returns each page exactly once. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> (cherry picked from commit bebabc42d6eee94e7340d4496c942331ecdd9a53) Compare: https://github.com/xwiki/xwiki-platform/compare/1c315a5b68a0...54cc6c430b6f To unsubscribe from these emails, change your notification settings at https://github.com/xwiki/xwiki-platform/settings/notifications
participants (1)
-
XWiki Notifications