June 2005 - xwiki-devs@xwiki.org

xwiki build.50 Build Successful
by ludovic＠xwiki.org 08 Jun '05

08 Jun '05

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20050608225627Lbuild…

1 0

A small patch for XWiki.getAuthService and XWiki.getRightService (easier debugging mostly)
by Lilianne E. Blaze 08 Jun '05

08 Jun '05

Hello, I'd like to propose a small "improvement" to XWiki.getAuthService and XWiki.getRightService, with these it would be easier to find out problems with custom implementations of these services. Also, it's a good example of what I had in mind earlier in my "Comments and log statements?" post. Greetings, Lilianne E. Blaze Index: com/xpn/xwiki/XWiki.java =================================================================== --- com/xpn/xwiki/XWiki.java (revision 580) +++ com/xpn/xwiki/XWiki.java (working copy) @@ -68,6 +68,7 @@ import com.xpn.xwiki.user.api.XWikiGroupService; import com.xpn.xwiki.user.api.XWikiRightService; import com.xpn.xwiki.user.api.XWikiUser; +import com.xpn.xwiki.user.impl.LDAP.LDAPAuthServiceImpl; import com.xpn.xwiki.user.impl.exo.ExoAuthServiceImpl; import com.xpn.xwiki.user.impl.exo.ExoGroupServiceImpl; import com.xpn.xwiki.user.impl.xwiki.XWikiAuthServiceImpl; @@ -2474,22 +2499,51 @@ public XWikiAuthService getAuthService() { if (authService==null) { - String authClass; - if (isExo()) - authClass = Param("xwiki.authentication.authclass","com.xpn.xwiki.user.impl.exo.ExoAuthServiceImpl"); - else if (isLDAP()) - authClass = Param("xwiki.authentication.authclass","com.xpn.xwiki.user.impl.LDAP.LDAPAuthServiceImpl"); + + log.info("Initializing AuthService..."); + + String authClass = Param("xwiki.authentication.authclass"); + if( authClass != null ) + { + if( log.isDebugEnabled() ) log.debug("Using custom AuthClass "+authClass+"."); + } else - authClass = Param("xwiki.authentication.authclass","com.xpn.xwiki.user.impl.xwiki.XWikiAuthServiceImpl"); + { + + if (isExo()) + authClass = "com.xpn.xwiki.user.impl.exo.ExoAuthServiceImpl"; + else if (isLDAP()) + authClass = "com.xpn.xwiki.user.impl.LDAP.LDAPAuthServiceImpl"; + else + authClass = "com.xpn.xwiki.user.impl.xwiki.XWikiAuthServiceImpl"; + + if( log.isDebugEnabled() ) log.debug("Using default AuthClass "+authClass+"."); + + } try { + authService = (XWikiAuthService) Class.forName(authClass).newInstance(); + + log.debug("Initialized AuthService using Relfection."); + } catch (Exception e) { - e.printStackTrace(); + + log.warn("Failed to initialize AuthService "+authClass+" using Reflection, trying default implementations using 'new'."); + + // e.printStackTrace(); - not needed? -LBlaze + + // LDAP support wasn't here before, I assume it should be? -LBlaze + if (isExo()) authService = new ExoAuthServiceImpl(); + else if(isLDAP()) + authService = new LDAPAuthServiceImpl(); else authService = new XWikiAuthServiceImpl(); + + if( log.isDebugEnabled() ) log.debug("Initialized AuthService "+authService.getClass().getName()+" using 'new'."); + } } return authService; @@ -2497,12 +2551,36 @@ public XWikiRightService getRightService() { if (rightService==null) { - String rightsClass = Param("xwiki.authentication.rightsclass","com.xpn.xwiki.user.impl.xwiki.XWikiRightServiceImpl"); + + log.info("Initializing RightService..."); + + String rightsClass = Param("xwiki.authentication.rightsclass"); + if( rightsClass != null ) + { + if( log.isDebugEnabled() ) log.debug("Using custom RightsClass "+rightsClass+"."); + } + else + { + rightsClass = "com.xpn.xwiki.user.impl.xwiki.XWikiRightServiceImpl"; + if( log.isDebugEnabled() ) log.debug("Using default RightsClass "+rightsClass+"."); + } + + try { + rightService = (XWikiRightService) Class.forName(rightsClass).newInstance(); + log.debug("Initialized RightService using Reflection."); + } catch (Exception e) { - e.printStackTrace(); + + log.warn("Failed to initialize RightService "+rightsClass+" using Reflection, trying default implementation using 'new'."); + + //e.printStackTrace(); - not needed? -LBlaze + rightService = new XWikiRightServiceImpl(); + + if( log.isDebugEnabled() ) log.debug("Initialized RightService "+authService.getClass().getName()+" using 'new'."); + } } return rightService;

2 1

RFC: Google project XWikipedia
by Jim Stuttard 08 Jun '05

08 Jun '05

Hi, Wide search on the mail archives doesn't return the 2 folks who suggested an XWikipedia. Having 360K words of wiki markup articles and notes to go in such an app I'm happy to start immediate work on the use cases and uml for this. I guess at least 3 possible overlaps with other suggested projects: * Local Names for connecting to external sources. * P2P for interwiki sharing * freemind for topic map organisation. WDYT Cheers Jim PS Have now had a go at learning javascript, velocity and groovy so I should be up to speed soon (20 years C, C++, java and strict jsp-j2ee). -- Using Opera's revolutionary e-mail client: http://www.opera.com/m2/

2 12

FI: Re: AJAX
by Jim Stuttard 08 Jun '05

08 Jun '05

Hi, You might enjoy: 1. Original [http://indicthreads.com/blogs/189/adopting_ajax.html] 1. +1 Suggests using Commons Validator instead of javascript on forms. WDYT Craig, Ludovic...? [http://blogs.apress.com/archives/000501.html] 1. Another view [http://blogs.sun.com/roller/page/robogeek/20050601#re_the_java_performance_…] Jim ~'XML is the bastard offspring of Lisp without the semantics' Phil Wadler (author of XSLT formal specification)

1 0

RE: [xwiki-commits] r596 - in xwiki/trunk/src: main/java/com/xpn/xwiki/plugin/packaging test/com/xpn/xwiki/test
by Vincent Massol 07 Jun '05

07 Jun '05

> -----Original Message----- > From: Vincent Massol [mailto:vincent@massol.net] > Sent: mardi 7 juin 2005 13:57 > To: 'xwiki-dev(a)objectweb.org' > Subject: RE: [xwiki-commits] r596 - in xwiki/trunk/src: > main/java/com/xpn/xwiki/plugin/packaging test/com/xpn/xwiki/test > > > > > -----Original Message----- > > From: Jeremi Joslin [mailto:jeremi@users.forge.objectweb.org] > > Sent: mardi 7 juin 2005 13:53 > > To: xwiki-commits(a)objectweb.org > > Subject: [xwiki-commits] r596 - in xwiki/trunk/src: > > main/java/com/xpn/xwiki/plugin/packaging test/com/xpn/xwiki/test > > [snip] > > > +/** > > + * =================================================================== > > + * > > + * Copyright (c) 2005 Jrmi Joslin, XpertNet, All rights reserved. > > Jeremi, you're going to find me a pain in the ... but there are 2 issues > here: > > 1/ I think the copyright should go to Ludovic Dubost. At least that's the > current policy AFAIK Actually forget that (sorry about it) because I guess that's the current discussion in progress. I personally always try to have a single person/organization that gets the copyright attribution for the reasons mentioned here: http://clirr.sourceforge.net/contributing.html Ludovic, before we do this license change what is the current licensing policy WRT the copyright? By looking at the existing source code I had assumed it was to give it to you but maybe that's not the case. [snip] Thanks -Vincent

2 1

get the output stream
by jeremi joslin 07 Jun '05

07 Jun '05

For testing the package, I need to get the Output Stream from HttpServletResponse to put it in a byte[]. Does anyone now how to do this? Jérémi -- http://www.sport42.net - http://stage.xwiki.com Tel : 06.84.50.33.49 skype: jeremi23

1 0

RFI: javascript ban problem
by Jim Stuttard 07 Jun '05

07 Jun '05

Hi, 1. I mentioned this problem to someone on the list the other week. Would like to know what you folks think. On the Sonera-Zed, British Gas and Philips projects javascript was unneeded (WAP-WML), minimised or banned for security reasons. This might be another barrier to acceptance. I've had to turn javascript on to access XWiki. A standard set of security problems is referenced at: http://www.panix.com/~aahz/javascript.html Do folks reckon the security problems have now been tied up then and these corps should change their policy? Cheers Jim 2. PS Ajax is not the only way of doing asynch before this project adopts yet another technology. FI: List members might enjoy Phil Wadler's 'The next 700 computer languages' http://homepages.inf.ed.ac.uk/wadler/topics/xml.html I regard it as pretty mandatory reading.

2 4

xwiki build.49 Build Successful
by ludovic＠xwiki.org 07 Jun '05

07 Jun '05

View results here -> http://build.xpertnet.biz/cc/buildresults/xwiki?log=log20050607135638Lbuild…

1 0

RE: [xwiki-commits] r596 - in xwiki/trunk/src: main/java/com/xpn/xwiki/plugin/packaging test/com/xpn/xwiki/test
by Vincent Massol 07 Jun '05

07 Jun '05

> -----Original Message----- > From: Jeremi Joslin [mailto:jeremi@users.forge.objectweb.org] > Sent: mardi 7 juin 2005 13:53 > To: xwiki-commits(a)objectweb.org > Subject: [xwiki-commits] r596 - in xwiki/trunk/src: > main/java/com/xpn/xwiki/plugin/packaging test/com/xpn/xwiki/test [snip] > +/** > + * =================================================================== > + * > + * Copyright (c) 2005 Jrmi Joslin, XpertNet, All rights reserved. Jeremi, you're going to find me a pain in the ... but there are 2 issues here: 1/ I think the copyright should go to Ludovic Dubost. At least that's the current policy AFAIK 2/ Your name is Jeremi, right? ;-) [snip] -Vincent

2 1

RE: [xwiki-commits] r594 - xwiki/trunk/src/test/com/xpn/xwiki/test
by Vincent Massol 07 Jun '05

07 Jun '05

Hi Jeremi, > -----Original Message----- > From: Jeremi Joslin [mailto:jeremi@users.forge.objectweb.org] > Sent: mardi 7 juin 2005 13:08 > To: xwiki-commits(a)objectweb.org > Subject: [xwiki-commits] r594 - xwiki/trunk/src/test/com/xpn/xwiki/test [snip] > +/** > + * =================================================================== > + * <p/> > + * Copyright (c) 2005 Jrmi Joslin, All rights reserved. > + * <p/> This looks like a strange header. Why are there "<p/>" tags? > + * User: jeremi > + * Date: May 13, 2005 > + * Time: 2:30:12 PM > + */ I though we had agreed that we didn't want these anymore? :-) > +public class DocumentInfoTest extends HibernateTestCase{ Minor space issues > + public void testActionTo() > + { We really need the checkstyle stuff. I'll work on it. Thanks -Vincent

2 1