May 2008 - xwiki-devs@xwiki.org

[xwiki-devs] WatchList working
by Kamna Jain 31 May '08

31 May '08

Hello Jean, Devs, I got the Watchlist notifications to work. Thanks a lot for guidance. I did not do anything new today. But, I guess I was expecting it to fire at any simple changes I made to the page..like just adding a simple line and commenting it out... Do you think it should have fired even for those changes...9it did not..or maybe it just takes one day to start ..) today, I added some logic using velocity on that page and then it fired..and has been doing so since then. So I changed the chron to hourly again from every minute( 0 * * * * to 0 0 * * *) Also, I tried using the RSS feeds that are provided but my RSS reader complains that the link is not valid (it does not have a .rss or .xml extension to it) Is there a way I can set my preferences to get the updated RSS feed links. I see in the Watchlist object, only email settings are included. Nothing for the RSS. Can anyone advice on how to use that. The emails I am receiving have a Comment section! How can we program the system so that a comment is automatically added to the email based on the page that was modified? Thanks and looking forward to your responses Kamna

2 1

[xwiki-devs] [VOTE] XE 1.5 roadmap and dates
by Vincent Massol 30 May '08

30 May '08

Here's a date proposal for XE 1.5: 1.5 M1 - 30 May 2008 1.5 M2 - 20 June 2008 1.5 RC1 - 4 Juillet 2008 1.5 RC2 / Final - 11 Juillet 2008 Roadmap: * More bug fixes * Better performance o Run XE with a profiler and find bottlenecks o Reduce number of database calls o Improved page loading * More automated tests o More selenium tests * Overhaul of the Administration Optional (good to have): New rendering mechanism. Here's my +1 Thanks -Vincent

6 8

[xwiki-devs] Exception when excuting checkstyle with maven
by Julien Lancelot 30 May '08

30 May '08

I'm trying to generate checkstyle report with maven (mvn checkstyle:checkstyle) and it fails... I'm executing it at the root folder of xwiki source. I use maven 2.0.8, and tried without success with version 2.0.9, and 2.1-SNAPSHOT. Here the trace (see trace.txt attached for full trace) : [ERROR] FATAL ERROR [INFO] ------------------------------------------------------------------------ [INFO] An invalid artifact was detected. This artifact might be in your project's POM, or it might have been included transitively during the resolution process. Here is the information we do have for this artifact: o GroupID: com.xpn.xwiki.platform.tools o ArtifactID: xwiki-verification-resources o Version: <<< MISSING >>> o Type: jar [INFO] ------------------------------------------------------------------------ [INFO] Trace org.apache.maven.artifact.InvalidArtifactRTException: For artifact {com.xpn.xwiki.platform.tools:xwiki-verification-resources:null:jar}: The version cannot be empty. at org.apache.maven.artifact.DefaultArtifact.validateIdentity(DefaultArtifact.java:147) at org.apache.maven.artifact.DefaultArtifact.<init>(DefaultArtifact.java:122) at org.apache.maven.artifact.factory.DefaultArtifactFactory.createArtifact(DefaultArtifactFactory.java:158) at org.apache.maven.artifact.factory.DefaultArtifactFactory.createDependencyArtifact(DefaultArtifactFactory.java:70) at org.apache.maven.project.artifact.MavenMetadataSource.createArtifacts(MavenMetadataSource.java:334) at org.apache.maven.plugin.DefaultPluginManager.addPlugin(DefaultPluginManager.java:343) at org.apache.maven.plugin.DefaultPluginManager.verifyVersionedPlugin(DefaultPluginManager.java:208) at org.apache.maven.plugin.DefaultPluginManager.verifyPlugin(DefaultPluginManager.java:172) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.verifyPlugin(DefaultLifecycleExecutor.java:1257) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.getMojoDescriptor(DefaultLifecycleExecutor.java:1522) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.segmentTaskListByAggregationNeeds(DefaultLifecycleExecutor.java:386) at org.apache.maven.lifecycle.DefaultLifecycleExecutor.execute(DefaultLifecycleExecutor.java:138) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:333) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:126) at org.apache.maven.cli.MavenCli.main(MavenCli.java:282) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25) at java.lang.reflect.Method.invoke(Method.java:585) at org.codehaus.classworlds.Launcher.launchEnhanced(Launcher.java:315) at org.codehaus.classworlds.Launcher.launch(Launcher.java:255) at org.codehaus.classworlds.Launcher.mainWithExitCode(Launcher.java:430) at org.codehaus.classworlds.Launcher.main(Launcher.java:375) -- Julien Lancelot Hortis, Consulting & Innovation team Sonar , Open Source Quality Dashboard for Java projects Try Sonar at http://sonar.hortis.ch

1 2

Re: [xwiki-devs] [xwiki-notifications] r9982 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki
by Vincent Massol 30 May '08

30 May '08

On May 29, 2008, at 11:41 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-05-29 23:41:59 +0200 (Thu, 29 May 2008) > New Revision: 9982 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java > Log: > XWIKI-2415: Sending notifications fails when restoring documents > from the recycle bin > Fixed. > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-05-29 21:10:01 UTC (rev 9981) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-05-29 21:41:59 UTC (rev 9982) > @@ -1113,6 +1113,12 @@ > // We need to save the original document since > saveXWikiDoc() will reset it and we > // need that original document for the notification below. > XWikiDocument originalDocument = > doc.getOriginalDocument(); > + // Always use an originalDocument, to provide a > consistent behavior. The cases where > + // originalDocument is null are rare (specifically when > the XWikiDocument object is > + // manually constructed, and not obtained using the API). > + if (originalDocument == null) { > + originalDocument = new > XWikiDocument(doc.getSpace(), doc.getName()); > + } > > // Notify listeners about the document change > if (originalDocument == null || > originalDocument.isNew()) { hmmm... this doesn't look correct. You're forcing the originalDocument to be not null but then next says: if originalDocument is null... Thanks -Vincent

2 2

Re: [xwiki-devs] Admin XAR package
by Ludovic Dubost 30 May '08

30 May '08

I'll work on making a working version. Sorry about that. Ludovic Evelina Slatineanu wrote: > Hi, > > Why does the AdminApplication xar has 0 bytes when I download it? :P > > Thx, > Evelina > > -----Original Message----- > From: devs-bounces(a)xwiki.org [mailto:devs-bounces@xwiki.org] On Behalf Of > Ludovic Dubost > Sent: Wednesday, May 28, 2008 6:11 PM > To: devs(a)xwiki.org; XWiki Users > Subject: [xwiki-devs] Admin XAR package > > > I've published an admin XAR package which helps monitoring an XWiki > instance. It includes a Requests Status, Memory Status as well as a > selective Import/Export. > > http://code.xwiki.org/xwiki/bin/view/Applications/AdminApplication > > Ludovic > > -- > Ludovic Dubost > Blog: http://blog.ludovic.org/ > XWiki: http://www.xwiki.com > Skype: ldubost GTalk: ldubost > > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > > -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

1 0

[xwiki-devs] Admin XAR package
by Ludovic Dubost 30 May '08

30 May '08

I've published an admin XAR package which helps monitoring an XWiki instance. It includes a Requests Status, Memory Status as well as a selective Import/Export. http://code.xwiki.org/xwiki/bin/view/Applications/AdminApplication Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

3 2

[xwiki-devs] About the top menu item in Presentation tag in Space Prefs in Administration
by Saraswatee Kashyap 30 May '08

30 May '08

Hi, What should be done to get the top menu items in a single line? We are using menuitem to create the menu items which we get in multiple lines. Can you provide us the way in which the menu should be created in a single line. Thanks, Sara

1 0

Re: [xwiki-devs] [xwiki-notifications] r9953 - xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0
by Vincent Massol 29 May '08

29 May '08

Hi Ludovic, Some questions for you: * Why are you re-releasing the SM 1.0 version? (was this an error?). Did you rollback (I didn't see a rollback message)? Has your change overriden the existing 1.0 tag? * Why are you creating a 1.0 branch? Why your change cannot go in 1.1 instead? * Did you create a jira version for 1.0.1? Thanks -Vincent On May 27, 2008, at 9:16 PM, ludovic (SVN) wrote: > Author: ludovic > Date: 2008-05-27 21:16:09 +0200 (Tue, 27 May 2008) > New Revision: 9953 > > Modified: > xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0/ > pom.xml > Log: > [maven-release-plugin] prepare release xwiki-plugin-spacemanager-1.0 > > Modified: xwiki-platform/xwiki-plugins/tags/xwiki-plugin- > spacemanager-1.0/pom.xml > =================================================================== > --- xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0/ > pom.xml 2008-05-27 19:16:06 UTC (rev 9952) > +++ xwiki-platform/xwiki-plugins/tags/xwiki-plugin-spacemanager-1.0/ > pom.xml 2008-05-27 19:16:09 UTC (rev 9953) > @@ -62,8 +62,8 @@ > </dependencies> > > <scm> > - <connection>scm:svn:http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/bra… > </connection> > - <developerConnection>scm:svn:https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/br… > </developerConnection> > - <url>http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/branches/xw… > </url> > + <connection>scm:svn:http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/tag… > </connection> > + <developerConnection>scm:svn:https://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/ta… > </developerConnection> > + <url>http://svn.xwiki.org/svnroot/xwiki/xwiki-platform/xwiki-plugins/tags/xwiki-… > </url> > </scm> > </project>

3 3

Re: [xwiki-devs] [xwiki-notifications] r9964 - xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki
by Vincent Massol 29 May '08

29 May '08

Maybe this code could be put in some releaseLocks() method(s) for now? Thanks -Vincent On May 29, 2008, at 1:24 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-05-29 01:24:11 +0200 (Thu, 29 May 2008) > New Revision: 9964 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > user/impl/xwiki/XWikiAuthServiceImpl.java > Log: > XWIKI-2191: When user logout, his pages locks should be removed > Fixed. > - When a local user logs out, his locks are removed. > - When a global user logs out, his locks in the current and main > wiki are removed. > > Patch submitted by Asiri Rathnayake, applied with a few changes > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/user/impl/xwiki/XWikiAuthServiceImpl.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > user/impl/xwiki/XWikiAuthServiceImpl.java 2008-05-28 20:18:19 UTC > (rev 9963) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > user/impl/xwiki/XWikiAuthServiceImpl.java 2008-05-28 23:24:11 UTC > (rev 9964) > @@ -31,6 +31,8 @@ > import org.apache.commons.lang.StringUtils; > import org.apache.commons.logging.Log; > import org.apache.commons.logging.LogFactory; > +import org.hibernate.Query; > +import org.hibernate.Session; > import org.securityfilter.config.SecurityConfig; > import org.securityfilter.filter.SecurityRequestWrapper; > import org.securityfilter.realm.SimplePrincipal; > @@ -200,8 +202,66 @@ > wrappedRequest.setUserPrincipal(null); > > try { > + if (auth.processLogin(wrappedRequest, response, > context)) { > + return null; > + } > > - // Process login out (this only works with FORMS > + // TODO : This code need to be moved elsewhere > (appropriately). > + Principal user = wrappedRequest.getUserPrincipal(); > + if (context.getAction().equals("logout") && user != > null) { > + // Release all active locks on current wiki. > + try { > + > xwiki.getHibernateStore().beginTransaction(context); > + Session session = > xwiki.getHibernateStore().getSession(context); > + String sql = "delete from XWikiLock as lock > where lock.userName=:userName"; > + Query query = session.createQuery(sql); > + query.setString("userName", user.getName()); > + query.executeUpdate(); > + } catch (Exception e) { > + throw new > XWikiException(XWikiException.MODULE_XWIKI_STORE, > + > XWikiException.ERROR_XWIKI_STORE_HIBERNATE_DELETING_LOCK, > + "Error while deleting active locks held by > logging out user."); > + } finally { > + try { > + > xwiki.getHibernateStore().endTransaction(context, true); > + } catch (Exception e) { > + > + } > + } > + // If we're in a non-main wiki & the user is global, > + // switch to the global wiki and delete locks held > there. > + if (xwiki.isVirtualMode() > + && ! > context.getMainXWiki().equals(context.getDatabase()) > + && > user.getName().startsWith(context.getMainXWiki() + ":")) { > + String cdb = context.getDatabase(); > + // switch to main wiki. > + context.setDatabase(context.getMainXWiki()); > + try { > + > xwiki.getHibernateStore().beginTransaction(context); > + Session session = > xwiki.getHibernateStore().getSession(context); > + String sql = > + "delete from XWikiLock as lock where > lock.userName=:userName"; > + Query query = session.createQuery(sql); > + String localName = > user.getName().substring(user.getName().indexOf(":") + 1); > + query.setString("userName", localName); > + query.executeUpdate(); > + } catch (Exception e) { > + throw new > XWikiException(XWikiException.MODULE_XWIKI_STORE, > + > XWikiException.ERROR_XWIKI_STORE_HIBERNATE_DELETING_LOCK, > + "Error while deleting active locks held > by logging out user."); > + } finally { > + try { > + > xwiki.getHibernateStore().endTransaction(context, true); > + } catch (Exception e) { > + > + } > + // switch back to original wiki. > + context.setDatabase(cdb); > + } > + } > + } > + > + // Process logout (this only works with Forms) > if (auth.processLogout(wrappedRequest, response, > xwiki.getUrlPatternMatcher())) { > if (log.isInfoEnabled()) { > log.info("User " + context.getUser() + " has > been logged-out"); > @@ -210,11 +270,6 @@ > return null; > } > > - if (auth.processLogin(wrappedRequest, response, > context)) { > - return null; > - } > - > - Principal user = wrappedRequest.getUserPrincipal(); > if (log.isInfoEnabled()) { > if (user != null) { > log.info("User " + user.getName() + " is > authentified");

1 0

[xwiki-devs] [Proposal] QueryManager in store
by Artem Melentyev 28 May '08

28 May '08

Hi, devs. I would like to propose new QueryManager which will deprecate our store.search(* methods This proposal is based on Vincent ideas at http://markmail.org/message/mjgg52coupsmfomg and QueryManager from JCR v2 QueryManager is designed for low-level querying in Java code. (QueryPlugin for high-level and velocity) The main idea is support of multiple languages and easy to add new languages. This is needed for JCRStore. Here is interfaces: public interface QueryManager { Query createQuery(String statement, String language); Query getNamedQuery(String qname); String[] getLanguages(); boolean hasLanguage(String language); } public interface Query { enum Language { HQL, XPATH, JCRSQL } <T> List<T> execute(); Query bindValue(String var, Object val); Query setLimit(int limit); Query setOffset(int offset); } Here is abstract usecase: QueryManager qm = xwiki.getStore().getQueryManager(); Query q = qm.getNamedQuery("SomeNameOfQuery"); if (q==null && qm.hasLanguage(Query.Language.HQL.name())) { q = qm.createQuery("from XWikiDocument where author=:var", Language.HQL.name()); } else if (q==null && qm.hasLanguage(Language.XPATH.name())) { q = qm.createQuery("/*/*[@author=:var]", Language.XPATH.name()); } else throw new RuntimeException(); List<XWikiDocument> res = q.setLimit(10).setOffset(10) .bindValue("var", "Some.Author").execute(); notes: I'm not sure we need getNamedQuery right now. But it can be useful for move some complicated queries to store level (to some QueryHolders) or overriding queries. Queries are detached from store session. So session isn't opened until Query#execute(). WDYT? -- Artem Melentyev

2 6