June 2008 - xwiki-devs@xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r10535 - in xwiki-platform/core/trunk/xwiki-core/src: main/resources/META-INF/services test/java/com/xpn/xwiki/render/markup
by Vincent Massol 21 Jun '08

21 Jun '08

On Jun 21, 2008, at 2:04 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-06-21 02:04:51 +0200 (Sat, 21 Jun 2008) > New Revision: 10535 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/resources/META-INF/ > services/com.xpn.xwiki.render.filter.XWikiFilter > xwiki-platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/ > render/markup/AbstractSyntaxTest.java > xwiki-platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/ > render/markup/UnderlineTest.java > Log: > XWIKI-2489: _blank Links in table > Fixed. > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/ > META-INF/services/com.xpn.xwiki.render.filter.XWikiFilter > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/resources/META-INF/ > services/com.xpn.xwiki.render.filter.XWikiFilter 2008-06-20 23:59:12 > UTC (rev 10534) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/resources/META-INF/ > services/com.xpn.xwiki.render.filter.XWikiFilter 2008-06-21 00:04:51 > UTC (rev 10535) > @@ -7,13 +7,13 @@ > com.xpn.xwiki.render.filter.StyleFilter > com.xpn.xwiki.render.filter.MacroFilter > com.xpn.xwiki.render.filter.XWikiHeadingFilter > +com.xpn.xwiki.render.filter.UnderlineFilter > com.xpn.xwiki.render.filter.XWikiLinkFilter > org.radeox.filter.NewlineFilter > com.xpn.xwiki.render.filter.XWikiListFilter > org.radeox.filter.LineFilter > org.radeox.filter.StrikeThroughFilter > org.radeox.filter.ParagraphFilter > -com.xpn.xwiki.render.filter.UnderlineFilter > com.xpn.xwiki.render.filter.StrongFilter > org.radeox.filter.ItalicFilter > com.xpn.xwiki.render.filter.UrlFilter This worries me slightly. I hope there's no side effects of this. [snip] > + > + public void testLinkTargetHasPriority() Priority over what? It's not clear from the test itself. testLinkTargetHasPriorityOverXXX > > + { > + String testString = "[link>Main.WebHome>_blank] and > [another link>Main.WebHome>_blank]"; > + String result = this.renderer.render(testString, > this.document, this.document, this.context); > + assertTrue(result.indexOf("em") == -1); > + } > } Thanks -Vincent

1 0

Re: [xwiki-devs] [VOTE] Overhaul of the administration, layout
by Thomas Mortagne 20 Jun '08

20 Jun '08

I'm +1 for view mode and left panel take too many place so : Layout2 On Tue, Jun 17, 2008 at 3:50 PM, Evelina Slatineanu <evelina.slatineanu(a)xwiki.com> wrote: > I am +1 for layout 2 + Jv's proposal to have a hidden div for the big icons > (which is even faster than ajax and it is exactly like Control Panel in > Windows - no need to have the menu anymore). > > Although layout 3 looks good at first view, I have some comments about it: > > 1. the integration of admin pages like Panels (which need view mode) can be > very difficult (example: for Panel Wizard > I had to change layoutvars.vm so that it display the panels for the > requested space instead of the ones in "Panels" space). > > 2. why not letting the user to customize the administration layout as he > wants, meaning to choose what panels he wants to have on the left or on the > right in the admin page? I mean if the users sees that he needs more room > to edit application pages inside admin, he can change the layout...I really > don't see the issue > > So I'm really +1 to keep admin in view mode. > > Thanks, > Evelina > > > -----Original Message----- > From: devs-bounces(a)xwiki.org [mailto:devs-bounces@xwiki.org] On Behalf Of > Jean-Vincent Drean > Sent: Tuesday, June 17, 2008 4:32 PM > To: XWiki Developers > Subject: Re: [xwiki-devs] [VOTE] Overhaul of the administration, layout > > BTW I'm +1 for Layout2. > > On Mon, Jun 16, 2008 at 6:17 PM, Jean-Vincent Drean <jv(a)xwiki.com> wrote: >> Hi XWikiers, >> >> Evelina has finished the ground work on the new administration and >> it's now time to vote for its layout. >> http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministration >> >> Proposals : >> >> Admin in view mode, with a left menu : >> > http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout1 >> Admin in view mode, without a left menu : >> > http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout2 >> Admin in edit mode, with a navigation panel : >> > http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout3 >> Admin in edit mode, without a navigation panel : >> > http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationLayout4 >> >> Other question, how do we display the space selector : >> >> > http://dev.xwiki.org/xwiki/bin/view/Design/ImproveWikiAdministrationSpaceSel > ection >> >> -- >> Jean-Vincent Drean >> > > > > -- > Jean-Vincent Drean > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

4 3

[xwiki-devs] IncludeForm Macro
by Archana Mettu 20 Jun '08

20 Jun '08

Hello developers, Thank you for responding to my previous query. Can you please explain the differences between the following two macros, what advantages does includeInContext provide over the other? 1. includeForm() 2. includeInContext() Having retrieved an object on a page, how can I update some fields of that object and save? Doc.save() saves the document changing its version.... but, doesn't update the object-parameters. What am I missing? Regards, Archana Mettu.

4 3

[xwiki-devs] xwiki-patchservice under core1.4 build fails
by Panduga, Satya 20 Jun '08

20 Jun '08

I am trying to build the xwiki-core jar file from sources, But I am getting the following error when i run the maven install. other projects under core compile without any issue. Any one has the same experience building xwiki core jar from source. Please help. Thanks Satya [INFO] [resources:resources] [INFO] Using default encoding to copy filtered resources. [INFO] [compiler:compile] [INFO] Compiling 38 source files to C:\xwiki new\xwiki platform\core\xwiki-patc service\target\classes [INFO] ------------------------------------------------------------------------ [ERROR] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Compilation failure C:\xwiki new\xwiki platform\core\xwiki-patchservice\src\main\java\org\xwiki\pla form\patchservice\web\PatchServiceAction.java:[14,46] package org.xwiki.platfor .patchservice.plugin does not exist C:\xwiki new\xwiki platform\core\xwiki-patchservice\src\main\java\org\xwiki\pla form\patchservice\hook\PatchCreator.java:[25,46] package org.xwiki.platform.pat hservice.plugin does not exist C:\xwiki new\xwiki platform\core\xwiki-patchservice\src\main\java\org\xwiki\pla form\patchservice\hook\PatchCreator.java:[39,4] cannot find symbol symbol : class PatchservicePlugin location: class org.xwiki.platform.patchservice.hook.PatchCreator C:\xwiki new\xwiki platform\core\xwiki-patchservice\src\main\java\org\xwiki\pla form\patchservice\hook\PatchCreator.java:[45,24] cannot find symbol symbol : class PatchservicePlugin location: class org.xwiki.platform.patchservice.hook.PatchCreator C:\xwiki new\xwiki platform\core\xwiki-patchservice\src\main\java\org\xwiki\pla form\patchservice\web\PatchServiceAction.java:[33,8] cannot find symbol symbol : class PatchservicePlugin location: class org.xwiki.platform.patchservice.web.PatchServiceAction C:\xwiki new\xwiki platform\core\xwiki-patchservice\src\main\java\org\xwiki\pla form\patchservice\web\PatchServiceAction.java:[34,13] cannot find symbol symbol : class PatchservicePlugin location: class org.xwiki.platform.patchservice.web.PatchServiceAction The contents of this e-mail are intended for the named addressee only. It contains information that may be confidential. Unless you are the named addressee or an authorized designee, you may not copy or use it, or disclose it to anyone else. If you received it in error please notify us immediately and then destroy it.

2 1

[xwiki-devs] DocHour Day Results for 19 June 2008
by Thomas Mortagne 20 Jun '08

20 Jun '08

Hi everyone, Yesterday was our second DocHour day day. The following bugs were fixed: http://jira.xwiki.org/jira/secure/IssueNavigator.jspa?reset=true&&customfie… - Jerome Velociter XWIKI-1351 Write a tutorial for newcomers on how to create Java selenium tests. - Artem Melentev XWIKI-1211 Document the comment on page save feature - Thomas Mortagne XAWM-80 Improve wiki descriptor editor documentation - Vincent Massol XWIKI-2488 Improve Macro display in the Code Zone by removing the Bundled With Skin attribute XWIKI-1483 Document the {pre} macro So that's a total of 5 distinct tasks around documentation improvement. This is not much but not everyone had time with the 1.5M2 release very soon and bugfixing day to finish. You can still do your doc hour and add it to this conversation. Thanks everyone -- Thomas Mortagne

1 0

[xwiki-devs] [ANN] XWiki Workspaces 1.1 Milestone 2 Released
by Jerome Velociter 19 Jun '08

19 Jun '08

The XWiki development team is pleased to announce the release of XWiki Workspaces 1.1 Milestone 2. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download New features have been implemented in this release, amongst them : * Global roles: the administrator can now delegate responsibilities to groups of administrators and power users * Public registration: It is now possible to enable public registration for visitors that do not own an account * Invitation management: You can invite via email people who are not registered yet on the XWiki Workspaces instance to come and work in existing workspaces. You can read the full release notes, including screenshots of the aforementioned features, here : http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesWorkspaces11Milestone2 To get started with XWiki Workspaces, point your browser at http://workspaces.xwiki.org Thanks -The XWiki dev team

1 0

Re: [xwiki-devs] [xwiki-notifications] r10467 - xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/XWiki
by Vincent Massol 19 Jun '08

19 Jun '08

On Jun 19, 2008, at 5:40 PM, jvdrean (SVN) wrote: > Author: jvdrean > Date: 2008-06-19 17:40:19 +0200 (Thu, 19 Jun 2008) > New Revision: 10467 > > Modified: > xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/XWikiUserSheet > Log: > XWIKI-1730 : Allow Admin to reset users' passwords is there a test for this one? Thanks -Vincent > > > Fixed typo. > > Modified: xwiki-products/xwiki-enterprise/trunk/wiki/src/main/ > resources/XWiki/XWikiUserSheet > =================================================================== > --- xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/XWikiUserSheet 2008-06-19 15:36:44 UTC (rev 10466) > +++ xwiki-products/xwiki-enterprise/trunk/wiki/src/main/resources/ > XWiki/XWikiUserSheet 2008-06-19 15:40:19 UTC (rev 10467) > @@ -78,7 +78,7 @@ > ##------------------------------------------------------------------ > #set($i = $context.user.indexOf(":")+1) > #set($isMyProfile = ($doc.fullName == $context.user.substring($i)) > && ($context.action == "view")) > - #if($isMyprofile || $xwiki.hasAdminRights()) > + #if($isMyProfile || $xwiki.hasAdminRights()) > #if($isMyProfile) > #set($msgKeyEditSuffix = ".mine") > #end

1 0

[xwiki-devs] Bug Fixing Day Results for 18 June 2008
by Vincent Massol 19 Jun '08

19 Jun '08

Hi everyone, Yesterday was our second bug fixing day (which we intend to have every wednesday). The following bugs were fixed: http://tinyurl.com/6xup69 - Vincent XWIKI-2485 Calling the Flush Cache API prevents Users and Groups from being deleted properly - Sergiu XWIKI-2386 Non-threadsafe manipulation of the document in SaveAction XWIKI-2385 displayPrettyName does not show the mandatory mark in certain situations - Thomas XWIKI-2468 sql exception during delete virtual wiki in Oracle XWIKI-2483 Lots of code don't take care of "xwiki.temp.dir" when a temporary directory is needed - Artem XWIKI-2317 Documents created from APIs starts at version 2.1 - Fabio XECLIPSE-91 Keybinding conflicts may interfere with normal accelerator operation XECLIPSE-93 Open page menu item not visible when using XEclipse in the Eclipse IDE XECLIPSE-97 Indexer must start indexing all spaces automatically + be persistent XECLIPSE-90 Compatibility with Confluence Fabio Mancinelli Eugene Kuleshov So that's a total of 10 bugs fixed. Well done everybody and thanks to all who participated. Special kudos to Fabio, Sergiu and Thomas. Thanks -Vincent

1 0

Re: [xwiki-devs] [xwiki-notifications] r10459 - xwiki-platform/web/trunk/standard/src/main/webapp/templates
by Vincent Massol 19 Jun '08

19 Jun '08

Hi Artem, On Jun 19, 2008, at 2:44 PM, amelentev (SVN) wrote: > Author: amelentev > Date: 2008-06-19 14:44:27 +0200 (Thu, 19 Jun 2008) > New Revision: 10459 > > Modified: > xwiki-platform/web/trunk/standard/src/main/webapp/templates/ > editactions.vm > Log: > XWIKI-114: Adding comment for edit changes > > fix old typo You cannot do this since: * the issue is already closed and has already been released * this won't appear in the release notes The best is to create a new jira issue for this explaining what the problem is from the user's point of view. Thanks -Vincent > Modified: xwiki-platform/web/trunk/standard/src/main/webapp/ > templates/editactions.vm > =================================================================== > --- xwiki-platform/web/trunk/standard/src/main/webapp/templates/ > editactions.vm 2008-06-19 12:06:15 UTC (rev 10458) > +++ xwiki-platform/web/trunk/standard/src/main/webapp/templates/ > editactions.vm 2008-06-19 12:44:27 UTC (rev 10459) > @@ -75,7 +75,7 @@ > > #if((!$commentFieldAdded)&&($xwiki.hasEditComment())) > #set($commentFieldAdded = 1) > -#if($xwiki.isEditCommentHidden()) > +#if($xwiki.isEditCommentFieldHidden()) > <input type="hidden" name="comment" value="" size="80" /> > #else > $msg.get("core.comment"): <input type="text" name="comment" value="" > size="80" />

2 1

[xwiki-devs] Markmail
by Markus Lanthaler 19 Jun '08

19 Jun '08

Hello everyone, maybe http://markmail.org/ would be interesting for XWiki to. Seems very useful for me. Btw. has someone some feedback on my last mail regarding the SSO project?

2 1