November 2009 - xwiki-devs@xwiki.org

[xwiki-devs] Removing of 1.8 and 1.9 branches
by Vincent Massol 30 Nov '09

30 Nov '09

Hi devs, As we've already agreed we only keep the trunk + 1 one stable branch. I've noticed we still have 1.8 and 1.9 branches in our SVN repo. I'm going to remove them later today. Please shout if you have a good reason not to remove them. Note: We still have the tags of course... Thanks -Vincent

1 1

Re: [xwiki-devs] [xwiki-notifications] r25362 - in contrib/people: . fmancinelli fmancinelli/xwiki-command fmancinelli/xwiki-command/src fmancinelli/xwiki-command/src/main fmancinelli/xwiki-command/src/main/java fmancinelli/xwiki-command/src/main/jav
by Vincent Massol 30 Nov '09

30 Nov '09

On Mon, Nov 30, 2009 at 10:00 AM, Fabio Mancinelli <fabio.mancinelli(a)xwiki.com> wrote: > On Nov 30, 2009, at 3:08 AM, Sergiu Dumitriu wrote: >> >> Why do you pass the component manager around? Each component >> implementation can declare a dependency on ComponentManager if it needs it. >> >>> + String execute(ComponentManager componentManager, String... arguments) throws Exception; >>> +} >> > Right. > It's a leftover because before I wasn't implementing commands as components. Even if you're not using Components, passing the CM is still an implementation details that should not be shown in a user-API signature. If you're not using Components you'd pass it in the constructor of your command. Thanks -Vincent

2 1

30 Nov '09

On 11/29/2009 11:56 PM, fmancinelli (SVN) wrote: > Author: fmancinelli > Date: 2009-11-29 23:56:23 +0100 (Sun, 29 Nov 2009) > New Revision: 25362 > > Added: > contrib/people/fmancinelli/ > contrib/people/fmancinelli/xwiki-command/ > contrib/people/fmancinelli/xwiki-command/README.txt > contrib/people/fmancinelli/xwiki-command/pom.xml > contrib/people/fmancinelli/xwiki-command/src/ > contrib/people/fmancinelli/xwiki-command/src/main/ > contrib/people/fmancinelli/xwiki-command/src/main/java/ > contrib/people/fmancinelli/xwiki-command/src/main/java/META-INF/ > contrib/people/fmancinelli/xwiki-command/src/main/java/META-INF/MANIFEST.MF > contrib/people/fmancinelli/xwiki-command/src/main/java/org/ > contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/ > contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/ > contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/Command.java > contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/CommandResource.java > contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/commands/ > contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/commands/LS.java > contrib/people/fmancinelli/xwiki-command/src/main/resources/ > contrib/people/fmancinelli/xwiki-command/src/main/resources/META-INF/ > contrib/people/fmancinelli/xwiki-command/src/main/resources/META-INF/components.txt > Log: > [Initial import] A proof of concept for a "command line" XWiki interface based on HTTP. > > > Added: contrib/people/fmancinelli/xwiki-command/README.txt > =================================================================== > --- contrib/people/fmancinelli/xwiki-command/README.txt (rev 0) > +++ contrib/people/fmancinelli/xwiki-command/README.txt 2009-11-29 22:56:23 UTC (rev 25362) > @@ -0,0 +1,9 @@ > +This module adds a resource to the XWiki REST subsystem for executing commands. > +This resource accepts text/plain POSTs containing a command line and sends back > +responses in text/plain containing the result of the execution of the command. > + > +A simple "ls" command which lists the spaces in a wiki is provided. > + > +Clients can send commands using cURL in this way: > + > +curl -d "ls" -H "Content-type: text/plain" http://localhost:8080/xwiki/rest/command > > Added: contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/Command.java > =================================================================== > --- contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/Command.java (rev 0) > +++ contrib/people/fmancinelli/xwiki-command/src/main/java/org/xwiki/command/Command.java 2009-11-29 22:56:23 UTC (rev 25362) > @@ -0,0 +1,28 @@ > +package org.xwiki.command; > + > +import org.xwiki.component.annotation.ComponentRole; > +import org.xwiki.component.manager.ComponentManager; > + > +/** > + *<p> > + * This is the command interface. Each command should implement this interface and be annotated with a @Component > + * annotation for declaring its name. Don't forget to add the FQN of the command in the META-INF/components.txt > + * otherwise it will not be visible. > + *</p> > + */ > +@ComponentRole > +public interface Command > +{ > + /** > + *<p> > + * Execute the command > + *</p> > + * > + * @param componentManager The XWiki component manager for looking up the XWiki components needed for executing the > + * command. > + * @param arguments The arguments extracted from the command line. > + * @return A String containing the result of the execution of the command. > + * @throws Exception > + */ Why do you pass the component manager around? Each component implementation can declare a dependency on ComponentManager if it needs it. > + String execute(ComponentManager componentManager, String... arguments) throws Exception; > +} -- Sergiu Dumitriu http://purl.org/net/sergiu/

3 2

[xwiki-devs] HELP : a large database of users
by farouk korteby 30 Nov '09

30 Nov '09

Hi every body, I want to develop a platform based in XWiki Enterprise with a large database of users, can you give me some tips ? Thank you -- Farouk

4 11

Re: [xwiki-devs] [xwiki-notifications] r25288 - enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc platform/core/trunk/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc platform/core/trunk/xwiki-xmlrpc/xwiki-xmlrpc-model/src/main/java/org/xwiki/xmlrpc
by Sergiu Dumitriu 30 Nov '09

30 Nov '09

On 11/26/2009 04:28 PM, tmortagne (SVN) wrote: > Author: tmortagne > Date: 2009-11-26 16:28:25 +0100 (Thu, 26 Nov 2009) > New Revision: 25288 > > Added: > enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java > Modified: > enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java > platform/core/trunk/xwiki-xmlrpc/xwiki-xmlrpc-client/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcClient.java > platform/core/trunk/xwiki-xmlrpc/xwiki-xmlrpc-model/src/main/java/org/xwiki/xmlrpc/XWikiXmlRpcApi.java > Log: > XWIKI-4464: Extend the XmlRpc API with new rendering features > * Apply patch from Florin Ciubotaru: > ** New getRenderedContendMethods added to the api(We still need a few votes on devs for these to get commited). Completed the client with the new additions. > ** Added integration tests. > > Modified: enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java > =================================================================== > --- enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java 2009-11-26 11:14:42 UTC (rev 25287) > +++ enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/com/xpn/xwiki/it/xmlrpc/AllTests.java 2009-11-26 15:28:25 UTC (rev 25288) > @@ -62,6 +62,7 @@ > addTestCase(suite, org.xwiki.xmlrpc.XWikiClassesTest.class); > addTestCase(suite, org.xwiki.xmlrpc.XWikiObjectsTest.class); > addTestCase(suite, org.xwiki.xmlrpc.SearchTest.class); > + addTestCase(suite, org.xwiki.xmlrpc.RenderingTest.class); > > return new XWikiTestSetup(suite); > } > > Added: enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java > =================================================================== > --- enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java (rev 0) > +++ enterprise/trunk/distribution-test/xmlrpc-tests/src/test/it/org/xwiki/xmlrpc/RenderingTest.java 2009-11-26 15:28:25 UTC (rev 25288) > @@ -0,0 +1,145 @@ > +/* > + * See the NOTICE file distributed with this work for additional > + * information regarding copyright ownership. > + * > + * This is free software; you can redistribute it and/or modify it > + * under the terms of the GNU Lesser General Public License as > + * published by the Free Software Foundation; either version 2.1 of > + * the License, or (at your option) any later version. > + * > + * This software is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + * Lesser General Public License for more details. > + * > + * You should have received a copy of the GNU Lesser General Public > + * License along with this software; if not, write to the Free > + * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA > + * 02110-1301 USA, or see the FSF site: http://www.fsf.org. > + * > + */ > +package org.xwiki.xmlrpc; > + > +import java.util.List; > + > +import junit.framework.Assert; > + > +import org.apache.xmlrpc.XmlRpcException; > +import org.xwiki.xmlrpc.model.XWikiPage; > + > +public class RenderingTest extends AbstractXWikiXmlRpcTest > +{ > + public void testGetInputSyntaxes() throws XmlRpcException > + { > + List<String> syntaxes = rpc.getInputSyntaxes(); > + > + TestUtils.banner("TEST: getInputSyntaxes()"); I'd swap the banner setting and the retrieval method, since if the method fails, then the banner won't be set. Also, System.out should not be used. > + System.out.format("%d conversion input syntaxes found:\n", syntaxes.size()); > + for (String syntaxId : syntaxes) { > + System.out.format("%s\n", syntaxId); > + } > + Assert.assertTrue(syntaxes.size() != 0); > + } > + > + public void testGetOutputSyntaxes() throws XmlRpcException > + { > + List<String> syntaxes = rpc.getOutputSyntaxes(); > + > + TestUtils.banner("TEST: getOutputSyntaxes()"); > + System.out.format("%d conversion output syntaxes found:\n", syntaxes.size()); > + for (String syntaxId : syntaxes) { > + System.out.format("%s\n", syntaxId); > + } > + Assert.assertTrue(syntaxes.size() != 0); > + } > + > + public void testConvert() throws XmlRpcException > + { > + String inputXWiki = > + "**BoldText**//ItalicText//" + String.format("%n") + "==h2Text==" + String.format("%n") + "normalText"; Why String.format("%n")? Doesn't a simple \n suffice? Or, if the reak system endline must be used, for a reason I can't see now, how about org.apache.commons.lang.SystemUtils.LINE_SEPARATOR or the raw System.getProperty("line.separator")? > + String inputXhtml = > + "<div><p><strong>boldText</strong><br/><em>ItalicText</em></p>" + String.format("%n") > + + "<h2 id=\"h2Text\"><span>h2Text</span></h2><p>normalText</p></div>"; > + > + TestUtils.banner("TEST: convert()"); > + System.out.format("\nTesting xwiki/2.0 -> xhtml/1.0 conversion\n"); > + System.out.format("Input text:\n%s", inputXWiki); > + > + String outputXhtml = rpc.convert(inputXhtml, "xwiki/2.0", "xhtml/1.0"); > + > + System.out.format("\nOutput text:\n%s", outputXhtml); > + > + Assert.assertNotNull(outputXhtml); > + Assert.assertFalse(outputXhtml.equals("")); You could also test some generated markup here. > + Assert.assertTrue(outputXhtml.contains("strong")); > + Assert.assertTrue(outputXhtml.contains("normalText")); > + Assert.assertTrue(outputXhtml.contains("ItalicText")); > + > + System.out.format("\nTesting xhtml/1.0 -> xwiki/2.0 conversion\n"); > + System.out.format("Input text:\n%s", inputXhtml); > + > + String outputXWiki = rpc.convert(inputXhtml, "xhtml/1.0", "xwiki/2.0"); > + > + System.out.format("\nOutput text:\n%s\n", outputXWiki); > + > + Assert.assertNotNull(outputXWiki); > + Assert.assertFalse(outputXhtml.equals("")); > + Assert.assertTrue(outputXhtml.contains("normalText")); > + Assert.assertTrue(outputXhtml.contains("ItalicText")); > + } > + > + public void testGetRenderedContent() throws XmlRpcException > + { > + String pageContent = "**Text in Bold**{{velocity}}VelocityCode{{/velocity}}"; > + > + XWikiPage page = new XWikiPage(); > + page.setId(TestConstants.TEST_PAGE); > + page.setContent(pageContent); > + page.setSyntaxId("xwiki/2.0"); > + > + TestUtils.banner("TEST: getRenderedContent()"); > + System.out.format("\nCalling getRenderedContent for page %s\n", page.getId()); > + System.out.format("\nWiki content is:\n%s\n", pageContent); > + > + rpc.storePage(page); > + > + try { > + String renderedContent = rpc.getRenderedContent(page.getId(), "annotatedxhtml/1.0"); > + > + System.out.format("\nObtained rendered content:\n%s\n\n", renderedContent); > + > + Assert.assertTrue(renderedContent.contains("Text in Bold")); > + Assert.assertTrue(renderedContent.contains("startmacro")); > + } finally { > + rpc.removePage(page.getId()); > + } > + } > + > + public void testRenderPageContent() throws XmlRpcException > + { > + String pageContent = "**Text in Bold**{{velocity}}VelocityCode{{/velocity}}"; > + > + XWikiPage page = new XWikiPage(); > + page.setId(TestConstants.TEST_PAGE); > + page.setContent(pageContent); > + page.setSyntaxId("xwiki/2.0"); > + > + TestUtils.banner("TEST: renderPageContent"); > + System.out.format("\nCalling renderPageContent with context as page %s\n", TestConstants.TEST_PAGE); > + System.out.format("\nWiki content is:\n%s\n", pageContent); > + > + rpc.storePage(page); > + > + try { > + String renderedContent = > + rpc.renderPageContent(page.getId(), page.getContent(), page.getSyntaxId(), "annotatedxhtml/1.0"); > + > + System.out.format("\nObtained rendered content:\n%s\n\n", renderedContent); > + > + Assert.assertTrue(renderedContent.contains("Text in Bold")); > + Assert.assertTrue(renderedContent.contains("startmacro")); > + } finally { > + rpc.removePage(page.getId()); > + } > + } > +} > > > Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java > =================================================================== > --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java 2009-11-26 11:14:42 UTC (rev 25287) > +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/xmlrpc/XWikiXmlRpcApiImpl.java 2009-11-26 15:28:25 UTC (rev 25288) > @@ -1455,4 +1455,47 @@ > } > return syntaxes; > } > + > + /** > + * Renders a text in the context of a wiki page. > + * > + * @param token The authentication token. > + * @param pageId The id of the page. > + * @param content The context to be rendered. > + * @param sourceSyntaxId The syntax of the content. > + * @param targetSyntaxId The target syntax of the rendered content > + * @return The rendered content. > + * @throws Exception If a invalid token is provided, an unsupported syntax id is given or the rendering fails. > + */ Make sure a user can't use the programming rights of a page to interpret his own text. > + public String renderPageContent(String token, String pageId, String content, String sourceSyntaxId, > + String targetSyntaxId) throws Exception > + { > + XWikiXmlRpcUser user = XWikiUtils.checkToken(token, this.xwikiContext); > + LOG.debug(String.format("User %s has called renderPageContent()", user.getName())); > + > + Document doc = XWikiUtils.getDocument(this.xwikiApi, pageId, true); > + > + return doc.getRenderedContent(content, sourceSyntaxId, targetSyntaxId); > + } > + > + /** > + * Gets the rendered content of an existing document. > + * > + * @param token The authentication token. > + * @param pageId The id of the page. > + * @param syntaxId The target syntax of the rendered content > + * @return The rendered content > + * @throws Exception If a invalid token is provided, an unsupported syntax id is given or the rendering fails. > + */ > + public String getRenderedContent(String token, String pageId, String syntaxId) throws Exception > + { > + XWikiXmlRpcUser user = XWikiUtils.checkToken(token, this.xwikiContext); > + LOG.debug(String.format("User %s has called getRenderedContent()", user.getName())); > + > + Document doc = XWikiUtils.getDocument(this.xwikiApi, pageId, true); > + SyntaxFactory syntaxFactory = Utils.getComponent(SyntaxFactory.class); > + Syntax syntax = syntaxFactory.createSyntaxFromIdString(syntaxId); > + > + return doc.getRenderedContent(syntax); > + } > } > -- Sergiu Dumitriu http://purl.org/net/sergiu/

1 0

[xwiki-devs] Generate URL Link and Save it in WYSIWYG editor
by Leon Wang 29 Nov '09

29 Nov '09

Hi Devs, Hi Marius, Could you give me some clues how to generate and save a page url that could locate to the position of a certain title/section of the article within the WYSIWYG editor, for example like this url, http://platform.xwiki.org/xwiki/bin/view/DevGuide/APIGuide#HAccessobjectsin…, click this link it will bring me to "Access objects in a page" subtitle. What I want to achieve is that in the WYSIWYG editor after I highlighted a sentence and clicked the Requirement tree node, it will highlight the background of the text and generate a link to the highlighted text, so this generated link could bring designer/system maintainer to the context of the document. Could you point me to the place of your WYSIWYG editor source code that I need to add/change? Do you know how can I get the value of the selected text, should I directly right javascript or should I modify your WYSIWYG source code? Thank you so much! Have a nice new week! Jue Wang (Leon)

1 0

[xwiki-devs] XOO
by Cristina Scheau 29 Nov '09

29 Nov '09

Hi all! How are you? I apologize that I wasn't so active recently. I spent all my time with tasks from my job and my Master. Now I have a little bit more free time (in the evenings and weekends) and I would like to continue the XOO project. I'm not clear what should I exactly do next and maybe you can help me with your feedback and ideas. I'd really like to contribute again to the XWiki software . Although I was not so happy with the API from OpenOffice , last summer was a really interesting experience for me. Thank you, Cristina S.

1 0

[xwiki-devs] [VOTE] New tool, xwiki-tool-standards-validator
by Jean-Vincent Drean 29 Nov '09

29 Nov '09

Hi, I'd like to commit a new standalone tool, xwiki-tool-standards-validator, it allows to run XHTML and Dutch Web Guidelines validation tests (only a few rules for the moment) on an InputStream. This tool will be used by a new enterprise module that I'll commit right after, xwiki-enterprise-test-webstandards which runs the validators on every pages present in the XE distrib. Here's my +1, JV.

7 12

Re: [xwiki-devs] [xwiki-users] Page Loading Optimization
by Jerome Velociter 29 Nov '09

29 Nov '09

Hi Thibaul, all Something easy to do that would contribute to reduce the number of CSS files is to concatenate all the WYSIWYG CSS files from the various plugins at build time (there are more than 10 AFAIK). Marius, have you looked into this? Do you know if this could be done in the 2.1 timeframe ? Note that the target of 1 CSS and 1 JS is pretty challenging for XWiki as we are also making it a modular software where CSS and JS extensions can be conditionally loaded on some (not all) of the pages. Something to investigate for JavaScript extensions could be a dynamic JS loading mecanism, a la dojo (http://dojocampus.org/content/2008/10/09/dojo-module-packaging-and-loading/) Jerome. PS: I put devs in copy as this is more a developer topic. On 11/5/09 5:28 PM, Thibaut Camberlin wrote: > Hi all, > > Page Loading time is a very important criteria when developing a web site. > According to a recent > survey<http://www.webdesignerwall.com/general/users-place-more-weight-on-design/>more > than half people would drive away from a site with slow loading pages. > > There are several interesting issues that could be implemented to > substantially improve page loading time in XWiki. > > Number one is aggreation of CSS and JS files in order to reduce HTTP > requests. (For info, we have a total of 25 external CSS and JS files on a > basic XWiki install when in the best world we would have just 2 - 1 CSS and > 1 JS) > > Someone interrested in working on this with me ? >

6 16

[xwiki-devs] Open Office server on myxwiki.org
by stephane barbey 28 Nov '09

28 Nov '09

Hi Team, Anybody knows if it's possible to make office document import on the myxwiki.org farm ? Thanks in advance. Stéphane Barbey.

2 1