June 2009 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] Add String getCurrentSpace() to DocumentAccessBridge
by Vincent Massol 29 Jun '09

29 Jun '09

Hi, In order to implement SpacePreferencesConfigurationSource I need access to the current space. Hence I'm proposing to add String DocumentAccessBridge.getCurrentSpace() Here's my +1 Thanks -Vincent

5 12

[xwiki-devs] VOTE for moving the collection and ratings plugins out of sandbox
by Ludovic Dubost 29 Jun '09

29 Jun '09

Hi, I would like to start a vote to move the ratings and collections plugins out of the sandbox, as a first step to make them available in the default XE bundle. We now have some clients that are using these plugins in production, so it is time to make them real plugins. Some history about the ratings and collections plugins. RATINGS: This plugin allows to record ratings about any item, an particular documents. It stores ratings in separate spaces and records the calculated average rating in the document itself. It includes java and groovy hooks to write custom rating calculation. This can be usefull to not calculate a single average but to include the "rating" of the users in the calculation. A skin extension allows to include the ratings selection mecanism in the UI (it's a separate module). As a second step the Ratings plugin and application can be bundled in standard XWiki. COLLECTION: The collection plugin allows to manipulate collections of XWiki documents. The plugin is the basis for the MultiPage Export feature allowing to make a PDF or a XAR of multiple pages. The collection plugin also includes a special activity stream allowing to record changes of a document and all it's childs. The changes are recorded only for documents that match a specific class set in xwiki.cfg. As a second step an application can be published for MultiPage Export on code.xwiki.org . Some changes are still necessary for that to not depend on skin modifications for this to work so it will be done later. Here is my +1 for both. -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

7 9

Re: [xwiki-devs] [xwiki-notifications] r21683 - platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart
by Vincent Massol 29 Jun '09

29 Jun '09

On Jun 29, 2009, at 11:21 AM, asiri (SVN) wrote: > Author: asiri > Date: 2009-06-29 11:21:59 +0200 (Mon, 29 Jun 2009) > New Revision: 21683 > > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/ > TestChartMacro.java > Log: > [misc] Moving the temporary chart image file generated during tests > inside the target directory. > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/ > xwiki-rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/ > chart/TestChartMacro.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/ > TestChartMacro.java 2009-06-29 09:01:23 UTC (rev 21682) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/ > TestChartMacro.java 2009-06-29 09:21:59 UTC (rev 21683) > @@ -38,6 +38,6 @@ > */ > protected File getChartImageFile(ChartMacroParameters > parameters, String content) > { > - return new File("./chart.png"); > + return new File("./target/chart.png"); This is very bad. You should never hardcode maven directories location. Thanks -Vincent

2 7

Re: [xwiki-devs] [xwiki-notifications] r21686 - platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart
by Vincent Massol 29 Jun '09

29 Jun '09

On Jun 29, 2009, at 12:04 PM, asiri (SVN) wrote: > Author: asiri > Date: 2009-06-29 12:04:41 +0200 (Mon, 29 Jun 2009) > New Revision: 21686 > > Modified: > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/ > TestChartMacro.java > Log: > [misc] Removing the hard-coded directory. > > Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/ > xwiki-rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/ > chart/TestChartMacro.java > =================================================================== > --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/ > TestChartMacro.java 2009-06-29 09:29:03 UTC (rev 21685) > +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki- > rendering-macro-chart/src/test/java/org/xwiki/rendering/macro/chart/ > TestChartMacro.java 2009-06-29 10:04:41 UTC (rev 21686) > @@ -38,6 +38,6 @@ > */ > protected File getChartImageFile(ChartMacroParameters > parameters, String content) > { > - return new File("./target/chart.png"); > + return new File(System.getProperty("java.io.tmpdir") + "/ > chart.png"); This is still bad. Thanks -Vincent

2 1

[xwiki-devs] XWikiSyntax generates exception
by Pascal Voitot 29 Jun '09

29 Jun '09

http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax gives : Error number 4001 in 4: Error while parsing velocity page Main.XWikiSyntax Wrapped Exception: Failed to evaluate content with id XWiki Syntax <http://platform.xwiki.org/xwiki/bin/view/Main/XWikiSyntax> ... org.apache.velocity.exception.MethodInvocationException: Invocation of method 'fromXML' in class com.xpn.xwiki.doc.XWikiDocument threw exception com.xpn.xwiki.XWikiException: Error number 2002 in 2: Error parsing xml Wrapped Exception: Error on line -1 of document : Premature end of file. Nested exception: Premature end of file. @ Main.XWikiSyntax6,16? <http://platform.xwiki.org/xwiki/bin/edit/Main/6%2C16?parent=Main.XWikiSyntax> at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:286) at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:203) at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:294) at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:318) at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:178) at org.xwiki.velocity.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:143) at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:108) at com.xpn.xwiki.render.XWikiVelocityRenderer.render(XWikiVelocityRenderer.java:85) at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.renderText(DefaultXWikiRenderingEngine.java:272) at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.renderText(DefaultXWikiRenderingEngine.java:202) at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.renderText(DefaultXWikiRenderingEngine.java:170) at com.xpn.xwiki.render.DefaultXWikiRenderingEngine.renderDocument(DefaultXWikiRenderingEngine.java:159) at com.xpn.xwiki.doc.XWikiDocument.getRenderedContent(XWikiDocument.java:490) at com.xpn.xwiki.api.Document.getRenderedContent(Document.java:454) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) regards Pascal

2 1

[xwiki-devs] [Proposal] Extend the XML-RPC API
by Florin Ciubotaru 28 Jun '09

28 Jun '09

Hi, XWiki has evolved a lot in the past year and new client apps were created. Our current Xml-Rpc API is aligned to the Confluence 1.0 API specification and hasn't been really enriched in a long time. Since we have some distinct features like 'polyglot wiki' I propose to create a new "xwiki2" method set to handle XWiki 2.0 method calls. The new handler will be added to the Apache Xml-Rpc servlet properties file. Proposed new xml-rpc methods(mostly needed for XEclipse, XOffice and XOO): - parseFromHtml(String html, String syntax) : String - render(String source, String syntaxId) : String - cleanHtml(String dirtyHtml) : String - add class ( http://jira.xwiki.org/jira/browse/XWIKI-3499 ) - getConfiguredSyntaxes - getVirtualWikisNames - getMacros, etc. Proposed Xml-Rpc model extensions: - Page - syntaxId; - ServerInfo/Wiki: - isMultiWiki - defaultSyntax - encoding WDYT? Thanks, Florin Ciubotaru

7 7

[xwiki-devs] [Proposal] Split xwiki-configuration module in 2
by Vincent Massol 27 Jun '09

27 Jun '09

* one for the API: xwiki-configuration-api * one for the default implementation: xwiki-configuration-default The reason is that I'd like to implement - XWikiPreferencesConfigurationSource - SpacePreferencesConfigurationSource - UserPreferencesConfigurationSource And they'll need access to the DocumentAccessBridge And I don't think it's a good idea to have that dep in the API. WDYT? Thanks -Vincent

3 2

[xwiki-devs] Error 500
by Arvind Gupta 27 Jun '09

27 Jun '09

Hi Guys I am able not able to instaal xwiki. I am using tomcat 6 on ubuntu intrepid. Error I am gettting is *exception* javax.servlet.ServletException: com.xpn.xwiki.XWikiException: Error number 3 in 0: Could not initialize main XWiki context Wrapped Exception: Error number 3001 in 3: Cannot load class com.xpn.xwiki.store.migration.hibernate.XWikiHibernateMigrationManager from param xwiki.store.migration.manager.class Wrapped Exception: Error number 0 in 3: Exception while hibernate execute Wrapped Exception: Hibernate Dialect must be explicitly set org.apache.struts.action.RequestProcessor.processException(RequestProcessor.java:535) org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:433) org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) javax.servlet.http.HttpServlet.service(HttpServlet.java:617) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:155) com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:111) com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:295) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) *root cause* com.xpn.xwiki.XWikiException: Error number 3 in 0: Could not initialize main XWiki context Wrapped Exception: Error number 3001 in 3: Cannot load class com.xpn.xwiki.store.migration.hibernate.XWikiHibernateMigrationManager from param xwiki.store.migration.manager.class Wrapped Exception: Error number 0 in 3: Exception while hibernate execute Wrapped Exception: Hibernate Dialect must be explicitly set com.xpn.xwiki.XWiki.getMainXWiki(XWiki.java:327) com.xpn.xwiki.XWiki.getXWiki(XWiki.java:388) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:135) com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:115) org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:431) org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:236) org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) javax.servlet.http.HttpServlet.service(HttpServlet.java:617) javax.servlet.http.HttpServlet.service(HttpServlet.java:717) com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:155) com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:111) com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68) com.xpn.xwiki.web.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:295) com.xpn.xwiki.web.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:112) Please help me to getover from this error. -arvind

2 2

Re: [xwiki-devs] [xwiki-notifications] r21405 - in platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src: main/java/org/xwiki/rendering/internal/macro/velocity/filter test/java/org/xwiki/rendering/internal/macr
by Thomas Mortagne 27 Jun '09

27 Jun '09

On Fri, Jun 26, 2009 at 21:41, Sergiu Dumitriu<sergiu(a)xwiki.com> wrote: > tmortagne (SVN) wrote: >> Author: tmortagne >> Date: 2009-06-22 15:07:18 +0200 (Mon, 22 Jun 2009) >> New Revision: 21405 >> >> Added: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/filter/IndentVelocityMacroFilter.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/test/java/org/xwiki/rendering/internal/macro/velocity/filter/IndentVelocityMacroFilterTest.java >> Log: >> XWIKI-4018: Create an indentation velocity macro filter >> >> Added: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/filter/IndentVelocityMacroFilter.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/filter/IndentVelocityMacroFilter.java (rev 0) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-velocity/src/main/java/org/xwiki/rendering/internal/macro/velocity/filter/IndentVelocityMacroFilter.java 2009-06-22 13:07:18 UTC (rev 21405) > >> + /** >> + * Match indentation spaces. >> + */ >> + private static final Pattern INDENT_PATTERN = Pattern.compile("^[ \t]*", Pattern.MULTILINE); > > Replace with "^[ \t]++": > - * means that it matches all line starts, doing a useless replace for > the empty string. Thus the first +. > - The second + is not that useful, since there's no backtracking to > perform, but just to be explicit, it might save some ifs and elses. Yes it's better, i did this regexp too quickly. > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r21375 - in platform/core/trunk/xwiki-rendering: xwiki-rendering-api/src/main/java/org/xwiki/rendering/block xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/internal/macro/toc
by Thomas Mortagne 27 Jun '09

27 Jun '09

On Fri, Jun 26, 2009 at 20:52, Sergiu Dumitriu<sergiu(a)xwiki.com> wrote: > tmortagne (SVN) wrote: >> Author: tmortagne >> Date: 2009-06-21 12:34:49 +0200 (Sun, 21 Jun 2009) >> New Revision: 21375 >> >> Added: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/resources/macrotoc10.test >> Modified: >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/AbstractBlock.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/Block.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/SectionBlock.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/internal/macro/toc/TocMacro.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java >> platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/test/java/org/xwiki/rendering/RenderingTests.java >> Log: >> XWIKI-4001: ToC macro with scope=local indents the ToC items to match the level of the current section >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/AbstractBlock.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/AbstractBlock.java 2009-06-21 10:10:02 UTC (rev 21374) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/AbstractBlock.java 2009-06-21 10:34:49 UTC (rev 21375) >> @@ -308,6 +308,23 @@ >> /** >> * {@inheritDoc} >> * >> + * @see org.xwiki.rendering.block.Block#getParentBlockByType(java.lang.Class) >> + */ >> + @SuppressWarnings("unchecked") >> + public <T extends Block> T getParentBlockByType(Class<T> blockClass) >> + { >> + Block parent = getParent(); >> + >> + if (parent == null || blockClass.isAssignableFrom(parent.getClass())) { > > To get rid of the "unchecked" warning, do: > > return blockClass.cast(parent); Thanks, i did not know that. > >> + return (T) parent; >> + } >> + >> + return parent.getParentBlockByType(blockClass); >> + } >> + >> + /** >> + * {@inheritDoc} >> + * >> * @see EqualsBuilder#reflectionEquals(Object, Object) >> */ >> @Override >> >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/Block.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/Block.java 2009-06-21 10:10:02 UTC (rev 21374) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-api/src/main/java/org/xwiki/rendering/block/Block.java 2009-06-21 10:34:49 UTC (rev 21375) >> @@ -148,6 +148,16 @@ > > Forward? Maybe upward... > >> + * Look forward to find a block which inherit or is provided type. >> + <T extends Block> T getParentBlockByType(Class<T> blockClass); > > >> Modified: platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java >> =================================================================== >> --- platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java 2009-06-21 10:10:02 UTC (rev 21374) >> +++ platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-toc/src/main/java/org/xwiki/rendering/macro/toc/TocMacroParameters.java 2009-06-21 10:34:49 UTC (rev 21375) >> @@ -52,6 +52,11 @@ > > I'd rather call these customStart and hasCustomStart > >> + private boolean startSet; >> + public boolean isStartSet() > > -- > Sergiu Dumitriu > http://purl.org/net/sergiu/ > > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs > -- Thomas Mortagne

1 0