December 2010 - xwiki-devs@xwiki.org

[xwiki-devs] Theme for the XWiki Enterprise 3.x cycle
by Vincent Massol 13 Dec '10

13 Dec '10

Hi guys, Just wanted to let everyone know that at XWiki SAS (http://xwiki.com) we've had a big brainstorm about what everyone thinks that XWiki Enterprise 3.x should have as the main tagline/direction. It wasn't an easy exercise but in the end we rallied around the following theme: Main Theme: "Building Apps and Distributing them" This means for example that the Extension Manager in progress is a key element of XE 3.x. It also means making it easier to create applications in XE. Secondary theme: "Polishing" This means finishing what was started in 2.x by making it even more polished, stable, speed improvement, etc. These are the 2 general themes that XWiki committers who are belonging to the XWiki SAS company will work on. Note that these are just themes and should be viewed as general directions and helpers when someone wonders what to tackle next. Feedback welcome, as always. Thanks -Vincent, on behalf of XWiki SAS Links to understand the relationship of XWiki SAS and the open source project: * http://www.xwiki.com/xwiki/bin/view/About/Values * http://www.xwiki.com/xwiki/bin/view/About/Manifesto

1 0

[xwiki-devs] issue when creating a new action
by Ibrahim hammani 13 Dec '10

13 Dec '10

Hi, I've create a new action that I called 'PDFForm' , when I try to display a document using this action everything goes right except that XWiki displays an error and warn in the console (see below). For the warn, it happens cuz I used this code : try { fopFactory.setFontBaseURL(((Container) Utils.getComponent(Container.class)).getApplicationContext() .getResource("/WEB-INF/fonts/").getPath()); } catch (Throwable ex) { log.warn("Starting with 1.5, XWiki uses the WEB-INF/fonts/ directory as the font directory, " + "and it should contain the FreeFont (http://savannah.gnu.org/projects/freefont/) fonts. " + "FOP cannot access this directory. If this is an upgrade from a previous version, " + "make sure you also copy the WEB-INF/fonts directory from the new distribution package."); } This code doesn't display warn with 'pdf' action but with my new action. Can you tell me what i've missed please. Thank you. ______________________________ - Error creating form bean of class com.nearbeePDFForm java.lang.NullPointerException at org.apache.struts.config.FormBeanConfig.createActionForm(FormBeanConfig.java :212) at org.apache.struts.util.RequestUtils.createActionForm(RequestUtils.java:292) at org.apache.struts.util.RequestUtils.createActionForm(RequestUtils.java:191) at org.apache.struts.action.RequestProcessor.processActionForm(RequestProcessor .java:331) at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:202) at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1196) at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:414) at javax.servlet.http.HttpServlet.service(HttpServlet.java:707) at javax.servlet.http.HttpServlet.service(HttpServlet.java:820) at org.mortbay.jetty.servlet.ServletHolder.handle(ServletHolder.java:511) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler .java:1166) at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:129) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler .java:1157) at com.xpn.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilt er.java:152) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler .java:1157) at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:68) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler .java:1157) at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFi lter(SavedRequestRestorerFilter.java:218) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler .java:1157) at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFi lter(SetCharacterEncodingFilter.java:112) at org.mortbay.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler .java:1157) at org.mortbay.jetty.servlet.ServletHandler.handle(ServletHandler.java:388) at org.mortbay.jetty.security.SecurityHandler.handle(SecurityHandler.java:216) at org.mortbay.jetty.servlet.SessionHandler.handle(SessionHandler.java:182) at org.mortbay.jetty.handler.ContextHandler.handle(ContextHandler.java:765) at org.mortbay.jetty.webapp.WebAppContext.handle(WebAppContext.java:418) at org.mortbay.jetty.handler.ContextHandlerCollection.handle(ContextHandlerColl ection.java:230) at org.mortbay.jetty.handler.HandlerCollection.handle(HandlerCollection.java:11 4) at org.mortbay.jetty.handler.HandlerWrapper.handle(HandlerWrapper.java:152) at org.mortbay.jetty.Server.handle(Server.java:326) at org.mortbay.jetty.HttpConnection.handleRequest(HttpConnection.java:536) at org.mortbay.jetty.HttpConnection$RequestHandler.headerComplete(HttpConnectio n.java:915) at org.mortbay.jetty.HttpParser.parseNext(HttpParser.java:539) at org.mortbay.jetty.HttpParser.parseAvailable(HttpParser.java:212) at org.mortbay.jetty.HttpConnection.handle(HttpConnection.java:405) at org.mortbay.io.nio.SelectChannelEndPoint.run(SelectChannelEndPoint.java:409) at org.mortbay.thread.QueuedThreadPool$PoolThread.run(QueuedThreadPool.java:582 ) 2010-12-13 10:35:28,153 [http://localhost:8080/xwiki/bin/PDFForm/Sandbox/TestPage1] WARN impl.PdfExportImpl - Starting with 1.5, XWiki uses the WEB-INF/fonts/ directory as the font directory, and it should contain the FreeFont (http://savannah.gnu.org/projects/freefont/) fonts. FOP cannot access this directory. If this is an upgrade from a previous version, make sure you also copy the WEB-INF/fonts directory from the new distribution package.

2 1

Re: [xwiki-devs] [xwiki-notifications] r33349 - in platform/core/trunk: . xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal xwiki-bridge xwiki-bridge/src/main/java/org/xwiki/bridge xwiki-bridge/src/m
by Jerome Velociter 13 Dec '10

13 Dec '10

On Mon, Dec 13, 2010 at 9:17 AM, Vincent Massol <vincent(a)massol.net> wrote: > > On Dec 11, 2010, at 11:37 AM, jvelociter (SVN) wrote: > > > Author: jvelociter > > Date: 2010-12-11 11:37:21 +0100 (Sat, 11 Dec 2010) > > New Revision: 33349 > > > > Added: > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/ > > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatedEvent.java > > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatingEvent.java > > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletedEvent.java > > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletingEvent.java > > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatedEvent.java > > > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatingEvent.java > > platform/core/trunk/xwiki-legacy/ > > platform/core/trunk/xwiki-legacy/pom.xml > > platform/core/trunk/xwiki-legacy/src/ > > platform/core/trunk/xwiki-legacy/src/main/ > > platform/core/trunk/xwiki-legacy/src/main/java/ > > platform/core/trunk/xwiki-legacy/src/main/java/org/ > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/ > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/ > > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/LegacyEventDispatcher.java > > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/ > > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java > > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java > > > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java > > platform/core/trunk/xwiki-legacy/src/main/resources/ > > platform/core/trunk/xwiki-legacy/src/main/resources/META-INF/ > > > platform/core/trunk/xwiki-legacy/src/main/resources/META-INF/components.txt > > platform/core/trunk/xwiki-legacy/src/test/ > > platform/core/trunk/xwiki-legacy/src/test/java/ > > platform/core/trunk/xwiki-legacy/src/test/java/org/ > > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/ > > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/ > > > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java > > > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/LegacyEventDispatcherTest.java > > > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/event/ > > Removed: > > > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java > > > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java > > > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java > > > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/test/java/org/xwiki/observation/DocumentEventTest.java > > Modified: > > > platform/core/trunk/xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java > > platform/core/trunk/xwiki-bridge/pom.xml > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal/cache/DefaultDocumentCache.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/PatternPlugin.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/XWikiMacrosMappingRenderer.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiCacheStore.java > > > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java > > > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/XWikiTest.java > > > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/WikiMacrosTest.java > > > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/DefaultDocumentCacheTest.java > > > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCacheTest.java > > > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverterTest.java > > platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml > > > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java > > > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge/src/main/java/org/xwiki/rendering/internal/macro/wikibridge/WikiMacroEventListener.java > > Log: > > XWIKI-5786 Deprecate Document(Save|Update|Delete)Event and add new > Document(Created|Updated|Deleted)Event in xwiki-bridge instead > > XWIKI-5787 Add new Document(Creating|Updating|Deleting)Event events being > notified before the actual actions are performed on the document > > XWIKI-5788 New xwiki-legacy module to host backward compatibility code > > > Jerome, my bad i haven't followed the discussion too closely but could you > explain why you have used the xwiki-bridge module? > > The goal is to remove that module, not to add to it I think :) > > I'd have put the event bridge in xwiki-legacy. Why not put it there? > Hi Vincent, The goal is to have xwiki-legacy as backward-compatibility only. It means none of our modules should depend on it. We've decided to put the new events in xwiki-bridge since they get XWikiDocument passed as source and XWikiContext as data. When we can have new events that do not depend on xwiki-core (at runtime that is), we will create them in xwiki-model and move the ones in bridge in xwiki-legacy. Jerome. > > Thanks > -Vincent > _______________________________________________ > devs mailing list > devs(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/devs >

3 8

Re: [xwiki-devs] [xwiki-notifications] Build failed in Hudson: xwiki-platform-core #6666
by Jerome Velociter 13 Dec '10

13 Dec '10

Seems my last commit introduced a cyclic dependency by making the observation API module depend on xwiki-model. Need to investigate how to solve that. The solution is maybe to move the AbstractDocumentEvent (the one that needed the DocumentReference thus xwiki-model) to xwiki-model directly. WDYT? Jerome. On Sat, Dec 11, 2010 at 4:59 PM, Hudson <build.noreply(a)xwiki.org> wrote: > See <http://hudson.xwiki.org/job/xwiki-platform-core/6666/changes> > > Changes: > > [Marius Dumitru Florea] XWIKI-5784: TempResource action fails in multiwiki > mode > Patch from Ludovic Dubost applied without changes. > > [Jerome Velociter] XWIKI-5786 Deprecate Document(Save|Update|Delete)Event > and add new Document(Created|Updated|Deleted)Event in xwiki-bridge instead > XWIKI-5787 Add new Document(Creating|Updating|Deleting)Event events being > notified before the actual actions are performed on the document > XWIKI-5788 New xwiki-legacy module to host backward compatibility code > > [Vincent Massol] Revert code committed by error in rev 32011 (XWIKI-5603) > > ------------------------------------------ > Started by an SCM change > Started by an SCM change > Started by an SCM change > Building remotely on agent-2 > Updating http://svn.xwiki.org/svnroot/xwiki/platform/core/trunk > A xwiki-bridge/src/main/java/org/xwiki/bridge/event > AU > xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletedEvent.java > AU > xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatedEvent.java > AU > xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatedEvent.java > AU > xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletingEvent.java > AU > xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatingEvent.java > AU > xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatingEvent.java > U xwiki-bridge/pom.xml > U > xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java > A xwiki-legacy > A xwiki-legacy/src > A xwiki-legacy/src/test > A xwiki-legacy/src/test/java > A xwiki-legacy/src/test/java/org > A xwiki-legacy/src/test/java/org/xwiki > A xwiki-legacy/src/test/java/org/xwiki/observation > A > xwiki-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java > A xwiki-legacy/src/test/java/org/xwiki/observation/event > AU > xwiki-legacy/src/test/java/org/xwiki/observation/LegacyEventDispatcherTest.java > A xwiki-legacy/src/main > A xwiki-legacy/src/main/java > A xwiki-legacy/src/main/java/org > A xwiki-legacy/src/main/java/org/xwiki > A xwiki-legacy/src/main/java/org/xwiki/observation > A xwiki-legacy/src/main/java/org/xwiki/observation/event > A > xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java > A > xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java > A > xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java > A > xwiki-legacy/src/main/java/org/xwiki/observation/LegacyEventDispatcher.java > A xwiki-legacy/src/main/resources > A xwiki-legacy/src/main/resources/META-INF > A xwiki-legacy/src/main/resources/META-INF/components.txt > A xwiki-legacy/pom.xml > U > xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge/src/main/java/org/xwiki/rendering/internal/macro/wikibridge/WikiMacroEventListener.java > U > xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-box/src/test/java/org/xwiki/rendering/RenderingTests.java > U xwiki-core/src/test/java/com/xpn/xwiki/XWikiTest.java > U > xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/DefaultDocumentCacheTest.java > U > xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCacheTest.java > U > xwiki-core/src/test/java/com/xpn/xwiki/internal/WikiMacrosTest.java > U > xwiki-core/src/test/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverterTest.java > U > xwiki-core/src/main/java/com/xpn/xwiki/render/XWikiMacrosMappingRenderer.java > U xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiCacheStore.java > U > xwiki-core/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java > U xwiki-core/src/main/java/com/xpn/xwiki/plugin/PatternPlugin.java > U xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > U > xwiki-core/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java > U > xwiki-core/src/main/java/com/xpn/xwiki/internal/cache/DefaultDocumentCache.java > U > xwiki-core/src/main/java/com/xpn/xwiki/web/TempResourceAction.java > U > xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java > D > xwiki-observation/xwiki-observation-api/src/test/java/org/xwiki/observation/DocumentEventTest.java > D > xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java > D > xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java > D > xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java > U > xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java > U xwiki-observation/xwiki-observation-api/pom.xml > At revision 33351 > Parsing POMs > [INFO ] snapshot > org.xwiki.platform:xwiki-core-rendering-parent:2.5-SNAPSHOT: checking for > updates from xwiki-externals > [INFO ] snapshot > org.xwiki.platform:xwiki-core-rendering-parent:2.5-SNAPSHOT: checking for > updates from xwiki-snapshots > [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = > '98149989ac8abf2f6e9fd52097531d2b3b1176a3'; remote = > '438d9fb1e32bf9e8242d17a5423f2023f311738f' - RETRYING > [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = > '98149989ac8abf2f6e9fd52097531d2b3b1176a3'; remote = > '438d9fb1e32bf9e8242d17a5423f2023f311738f' - IGNORING > [INFO ] snapshot org.xwiki.platform:xwiki-core-parent:2.5-SNAPSHOT: > checking for updates from xwiki-externals > [INFO ] snapshot org.xwiki.platform:xwiki-core-parent:2.5-SNAPSHOT: > checking for updates from xwiki-snapshots > [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = > 'a973942b53b3000c3ecad5925737e8c934defb8a'; remote = > 'f55c89977fc9cb996640a9945debda27c54f51f2' - RETRYING > [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = > 'a973942b53b3000c3ecad5925737e8c934defb8a'; remote = > 'f55c89977fc9cb996640a9945debda27c54f51f2' - IGNORING > [INFO ] snapshot org.xwiki.platform:xwiki-core-parent:2.5-SNAPSHOT: > checking for updates from reflections-repo > [INFO ] snapshot org.xwiki.platform:xwiki:37-SNAPSHOT: checking for updates > from xwiki-externals > [INFO ] snapshot org.xwiki.platform:xwiki:37-SNAPSHOT: checking for updates > from xwiki-snapshots > [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = > '63972618b17ed2541ac00bbf719b6f9affb79dca'; remote = > '165d5e99af55d7ce9def3572216cce4c2cf3d20b' - RETRYING > [WARN ] *** CHECKSUM FAILED - Checksum failed on download: local = > '63972618b17ed2541ac00bbf719b6f9affb79dca'; remote = > '165d5e99af55d7ce9def3572216cce4c2cf3d20b' - IGNORING > [INFO ] snapshot org.xwiki.platform:xwiki:37-SNAPSHOT: checking for updates > from reflections-repo > [trunk] $ /home/hudsonagent/jdk1.5.0_15/bin/java -Xmx1024m -cp > /home/hudsonagent/hudson_root/maven-agent.jar:/home/hudsonagent/maven/boot/classworlds-1.1.jar > hudson.maven.agent.Main /home/hudsonagent/maven > /home/hudsonagent/bin/slave.jar > /home/hudsonagent/hudson_root/maven-interceptor.jar 57975 > /home/hudsonagent/hudson_root/maven2.1-interceptor.jar > <===[HUDSON REMOTING CAPACITY]===> channel started > Executing Maven: -B -f < > http://hudson.xwiki.org/job/xwiki-platform-core/ws/trunk/pom.xml> clean > deploy -Pci -Pintegration-tests > [INFO] Scanning for projects... > [INFO] > ------------------------------------------------------------------------ > [ERROR] BUILD FAILURE > [INFO] > ------------------------------------------------------------------------ > [INFO] The projects in the reactor contain a cyclic reference: Edge between > 'Vertex{label='org.xwiki.platform:xwiki-core-script'}' and > 'Vertex{label='org.xwiki.platform:xwiki-core-observation-api'}' introduces > to cycle in the graph org.xwiki.platform:xwiki-core-observation-api --> > org.xwiki.platform:xwiki-core-model --> org.xwiki.platform:xwiki-core-script > --> org.xwiki.platform:xwiki-core-observation-api > [INFO] > ------------------------------------------------------------------------ > [INFO] For more information, run Maven with the -e switch > [INFO] > ------------------------------------------------------------------------ > [INFO] Total time: 5 seconds > [INFO] Finished at: Sat Dec 11 16:59:29 GMT+01:00 2010 > [INFO] Final Memory: 9M/55M > [INFO] > ------------------------------------------------------------------------ > channel stopped > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications >

3 8

Re: [xwiki-devs] [xwiki-notifications] r33355 - in platform/core/trunk: xwiki-bridge xwiki-bridge/src/main/java/org/xwiki/bridge xwiki-core/src/main/java/com/xpn/xwiki/doc
by Vincent Massol 13 Dec '10

13 Dec '10

Hi Jerome, On Dec 11, 2010, at 10:51 PM, jvelociter (SVN) wrote: > Author: jvelociter > Date: 2010-12-11 22:51:45 +0100 (Sat, 11 Dec 2010) > New Revision: 33355 > > Modified: > platform/core/trunk/xwiki-bridge/pom.xml > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/DocumentAccessBridge.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/doc/DefaultDocumentAccessBridge.java > Log: > XWIKI-5789 New setProperty document access bridge method that takes document references instead of Strings > > > Modified: platform/core/trunk/xwiki-bridge/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-bridge/pom.xml 2010-12-11 17:10:59 UTC (rev 33354) > +++ platform/core/trunk/xwiki-bridge/pom.xml 2010-12-11 21:51:45 UTC (rev 33355) > @@ -64,6 +64,19 @@ > </dependency> > </dependencies> > </plugin> > + <plugin> > + <groupId>org.codehaus.mojo</groupId> > + <artifactId>clirr-maven-plugin</artifactId> > + <configuration> > + <skip>${xwiki.clirr.skip}</skip> > + <comparisonVersion>${clirr.previous.version}</comparisonVersion> > + <excludes> > +  > + <exclude>org/xwiki/bridge/DocumentAccessBridge</exclude> > + </excludes> > + </configuration> > + </plugin> This shouldn't be placed here. All clirr exclusions must go in core/pom.xml Thanks -Vincent

2 1

Re: [xwiki-devs] [xwiki-notifications] r33349 - in platform/core/trunk: . xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal xwiki-bridge xwiki-bridge/src/main/java/org/xwiki/bridge xwiki-bridge/src/main/java/org/xwiki/bridge/event xwiki-core/src/main/java/com/xpn/xwiki xwiki-core/src/main/java/com/xpn/xwiki/internal/cache xwiki-core/src/main/java/com/xpn/xwiki/internal/observation/remote/converter xwiki-core/src/main/java/com/xpn/xwiki/plugin xwiki-core/src
by Vincent Massol 13 Dec '10

13 Dec '10

On Dec 11, 2010, at 11:37 AM, jvelociter (SVN) wrote: > Author: jvelociter > Date: 2010-12-11 11:37:21 +0100 (Sat, 11 Dec 2010) > New Revision: 33349 > > Added: > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/ > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatedEvent.java > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentCreatingEvent.java > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletedEvent.java > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentDeletingEvent.java > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatedEvent.java > platform/core/trunk/xwiki-bridge/src/main/java/org/xwiki/bridge/event/DocumentUpdatingEvent.java > platform/core/trunk/xwiki-legacy/ > platform/core/trunk/xwiki-legacy/pom.xml > platform/core/trunk/xwiki-legacy/src/ > platform/core/trunk/xwiki-legacy/src/main/ > platform/core/trunk/xwiki-legacy/src/main/java/ > platform/core/trunk/xwiki-legacy/src/main/java/org/ > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/ > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/ > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/LegacyEventDispatcher.java > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/ > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java > platform/core/trunk/xwiki-legacy/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java > platform/core/trunk/xwiki-legacy/src/main/resources/ > platform/core/trunk/xwiki-legacy/src/main/resources/META-INF/ > platform/core/trunk/xwiki-legacy/src/main/resources/META-INF/components.txt > platform/core/trunk/xwiki-legacy/src/test/ > platform/core/trunk/xwiki-legacy/src/test/java/ > platform/core/trunk/xwiki-legacy/src/test/java/org/ > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/ > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/ > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/DocumentEventTest.java > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/LegacyEventDispatcherTest.java > platform/core/trunk/xwiki-legacy/src/test/java/org/xwiki/observation/event/ > Removed: > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentDeleteEvent.java > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentSaveEvent.java > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/DocumentUpdateEvent.java > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/test/java/org/xwiki/observation/DocumentEventTest.java > Modified: > platform/core/trunk/xwiki-annotations/xwiki-annotation-maintainer/src/main/java/org/xwiki/annotation/maintainer/internal/DocumentContentAnnotationUpdateListener.java > platform/core/trunk/xwiki-bridge/pom.xml > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/XWiki.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal/cache/DefaultDocumentCache.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverter.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/PatternPlugin.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/plugin/rightsmanager/RightsManagerListener.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/render/XWikiMacrosMappingRenderer.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/store/XWikiCacheStore.java > platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/user/impl/xwiki/XWikiGroupServiceImpl.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/XWikiTest.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/WikiMacrosTest.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/DefaultDocumentCacheTest.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/cache/rendering/DefaultRenderingCacheTest.java > platform/core/trunk/xwiki-core/src/test/java/com/xpn/xwiki/internal/observation/remote/converter/DocumentEventConverterTest.java > platform/core/trunk/xwiki-observation/xwiki-observation-api/pom.xml > platform/core/trunk/xwiki-observation/xwiki-observation-api/src/main/java/org/xwiki/observation/event/AbstractDocumentEvent.java > platform/core/trunk/xwiki-rendering/xwiki-rendering-macros/xwiki-rendering-macro-wikibridge/src/main/java/org/xwiki/rendering/internal/macro/wikibridge/WikiMacroEventListener.java > Log: > XWIKI-5786 Deprecate Document(Save|Update|Delete)Event and add new Document(Created|Updated|Deleted)Event in xwiki-bridge instead > XWIKI-5787 Add new Document(Creating|Updating|Deleting)Event events being notified before the actual actions are performed on the document > XWIKI-5788 New xwiki-legacy module to host backward compatibility code Jerome, my bad i haven't followed the discussion too closely but could you explain why you have used the xwiki-bridge module? The goal is to remove that module, not to add to it I think :) I'd have put the event bridge in xwiki-legacy. Why not put it there? Thanks -Vincent

1 0

[xwiki-devs] Autosuggest widget javascript
by Menso Heus 11 Dec '10

11 Dec '10

Hello everyone, I've created a form which needs to use autosuggest for fields. The form structure is basically a list of 10 things each of which has a supplier and a product. The supplier and product field are text input, and need to use autosuggest for pagenames from a specific space. I've been able to make the code from the Autosuggest widget work, which can be found here: http://platform.xwiki.org/xwiki/bin/view/DevGuide/AutoSuggestWidget I'm trying to translate the javascript offered there in the second codeblock on the page to a more generic function so I can say if the input is X, call suggestSupplier and if it is y call suggestProduct. All the supplier fields end in _Supplier in their name and all the product fields end in _SoftProd So far, I've been unsuccessful and I don't quite understand the structure of this javascript offered. Has someone already done this before and can they give me a pointer? Much appreciated, Menso

3 3

[xwiki-devs] [discussion] Replace the box macro with the container macro
by Anca Luca 10 Dec '10

10 Dec '10

Hi devs, There is obviously some overlapping between the purposes of the box macro (http://extensions.xwiki.org/xwiki/bin/view/Extension/Box+Macro) and the container macro (http://extensions.xwiki.org/xwiki/bin/view/Extension/Container+Macro) namely that the box macro is just a very specific type of container. How do you feel about moving all or some of the box macros functionalities to the container macro and either implement the box macro as a particular type of container, or deprecate it completely? The way I see it is that the container macro would have parameters to allow to: * fix its size * render a border around * use a background color * title (to be discussed, I am not 100% convinced that it's generic enough) * image (to be discussed, same) * layout it inside text (float it to the left or right) * other decorations we could find useful for the users (note that devs could still write css if they want more). I know that all these functions can be accomplished by CSS, but so is the columned layout, for example, and the idea is to provide to the users an easy way to do it (in this case, WYSIWYG). I'm +1, regardless of the solution (deprecate or not), but I am very convinced of the overlapping, they should not be 2 different implementations. Thanks, Anca

6 8

[xwiki-devs] [VOTE] Introduce xwiki-legacy for backward compatibility code
by Jerome Velociter 10 Dec '10

10 Dec '10

Hi, As suggested by Thomas in the thread relative to renaming document events (see http://xwiki.markmail.org/thread/62a3yaxiuosx4f6o ), I would like to introduce a new module, xwiki-legacy, to host backward compatibility code for modules. Rule would be that of course nothing should ever depend on xwiki-legacy. It will also help developers that relies on XWiki modules to upgrade to new code when we deprecate things, since as soon as they upgrade their dependency, they will not be able to build unless they fix the deprecated calls (It would not be the case if each module would host its backward-compatibility code). First use case would be for renamed events. A listener in xwiki-legacy would listen to the new document events, and notify the old corresponding ones. WDYT ? I'm +1 Jerome.

4 4

[xwiki-devs] Which database engine should be the default for 3.0?
by Sergiu Dumitriu 10 Dec '10

10 Dec '10

Hi devs, The default standalone distribution currently uses HSQLDB 1.8 as the database engine, wrapped by Hibernate 3.2.6 as the ORM engine. Both are a bit deprecated. One option is to use the 2.0 version of HSQLDB, which brings lots of improvements. Unfortunately, a direct replacement of the old jar with the new one doesn't work. It complains when trying to open an existing database, and even with a new database it complains when using boolean fields in queries, which means all searchDocuments calls will fail because of the "doc.hidden <> true" condition. Another option is to use H2, which is a reimplementation of HSQLDB, originally intended to be version 2 of HSQLDB. On their http://www.h2database.com/html/features.html#comparison feature comparison, H2 seems to have more meta-features than HSQLDB2. A third option which was already partially implemented is to use Derby. Personally I prefer H2, which seems to be more maintained than the others, with new releases every 2-3 weeks, and also has better performance and more features. -- Sergiu Dumitriu http://purl.org/net/sergiu/

2 4