July 2010 - xwiki-devs@xwiki.org

Re: [xwiki-devs] [xwiki-notifications] r29965 - contrib/sandbox/xwiki-officepreview
by Vincent Massol 04 Jul '10

04 Jul '10

Actually the solution is to simply add: ... </build> <properties>  <xwiki.clirr.skip>true</xwiki.clirr.skip> </properties> </project> Thanks -Vincent On Jul 4, 2010, at 2:51 PM, asiri (SVN) wrote: > Author: asiri > Date: 2010-07-04 14:51:21 +0200 (Sun, 04 Jul 2010) > New Revision: 29965 > > Modified: > contrib/sandbox/xwiki-officepreview/pom.xml > Log: > * Removed clirr plugin checks because we don't have a previous version of xwiki-core-officepreview artifact. > > Modified: contrib/sandbox/xwiki-officepreview/pom.xml > =================================================================== > --- contrib/sandbox/xwiki-officepreview/pom.xml 2010-07-04 01:50:57 UTC (rev 29964) > +++ contrib/sandbox/xwiki-officepreview/pom.xml 2010-07-04 12:51:21 UTC (rev 29965) > @@ -97,6 +97,13 @@ > </excludes> > </configuration> > </plugin> > + <plugin> > + <groupId>org.codehaus.mojo</groupId> > + <artifactId>clirr-maven-plugin</artifactId> > + <configuration> > + <skip>true</skip> > + </configuration> > + </plugin> > </plugins> > </build> > -</project> > \ No newline at end of file > +</project>

2 1

Re: [xwiki-devs] [xwiki-notifications] r29958 - in platform/core/trunk: . xwiki-chart/xwiki-chart-renderer xwiki-core
by Thomas Mortagne 04 Jul '10

04 Jul '10

On Sat, Jul 3, 2010 at 20:08, vmassol <platform-notifications(a)xwiki.org> wrote: > Author: vmassol > Date: 2010-07-03 20:08:56 +0200 (Sat, 03 Jul 2010) > New Revision: 29958 > > Modified: > platform/core/trunk/pom.xml > platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml > platform/core/trunk/xwiki-core/pom.xml > Log: > XWIKI-867: Move to the latest JFreeChart library version > > * Fixed missing dependency in POM > > Modified: platform/core/trunk/pom.xml > =================================================================== > --- platform/core/trunk/pom.xml 2010-07-03 16:38:29 UTC (rev 29957) > +++ platform/core/trunk/pom.xml 2010-07-03 18:08:56 UTC (rev 29958) > @@ -70,6 +70,13 @@ > <artifactId>jfreechart</artifactId> > <version>1.0.13</version> > </dependency> > +  > + <dependency> > + <groupId>jfree</groupId> > + <artifactId>jcommon</artifactId> > + <version>1.0.15</version> > + </dependency> > </dependencies> > </dependencyManagement> > <build> Thanks, I was wondering why it did not worked when looking at hudson but did not had time to look yet. > > Modified: platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml 2010-07-03 16:38:29 UTC (rev 29957) > +++ platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml 2010-07-03 18:08:56 UTC (rev 29958) > @@ -41,6 +41,12 @@ > <groupId>jfree</groupId> > <artifactId>jfreechart</artifactId> > </dependency> > +  > + <dependency> > + <groupId>jfree</groupId> > + <artifactId>jcommon</artifactId> > + </dependency> >  > <dependency> > <groupId>org.xwiki.platform</groupId> > > Modified: platform/core/trunk/xwiki-core/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-core/pom.xml 2010-07-03 16:38:29 UTC (rev 29957) > +++ platform/core/trunk/xwiki-core/pom.xml 2010-07-03 18:08:56 UTC (rev 29958) > @@ -134,6 +134,12 @@ > <groupId>jfree</groupId> > <artifactId>jfreechart</artifactId> > </dependency> > +  > + <dependency> > + <groupId>jfree</groupId> > + <artifactId>jcommon</artifactId> > + </dependency> > >  > <dependency> > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r29955 - platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx
by Vincent Massol 03 Jul '10

03 Jul '10

On Jul 3, 2010, at 4:21 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2010-07-03 16:21:17 +0200 (Sat, 03 Jul 2010) > New Revision: 29955 > > Modified: > platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java > Log: > [misc] Improved URL escaping method > > Modified: platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java > =================================================================== > --- platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java 2010-07-03 12:50:27 UTC (rev 29954) > +++ platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java 2010-07-03 14:21:17 UTC (rev 29955) > @@ -20,6 +20,8 @@ > > package com.xpn.xwiki.plugin.skinx; > > +import java.io.UnsupportedEncodingException; > +import java.net.URLEncoder; > import java.util.Collections; > import java.util.HashMap; > import java.util.LinkedHashSet; > @@ -27,7 +29,6 @@ > import java.util.Set; > import java.util.Map.Entry; > > -import org.apache.commons.lang.StringUtils; > import org.apache.commons.logging.Log; > import org.apache.commons.logging.LogFactory; > > @@ -307,10 +308,11 @@ > protected String sanitize(String value) > { > String result = value; > - result = StringUtils.replace(result, "\"", "%22"); > - result = StringUtils.replace(result, "'", "%27"); > - result = StringUtils.replace(result, "<", "%3C"); > - result = StringUtils.replace(result, ">", "%3E"); > + try { > + result = URLEncoder.encode(value, "UTF-8"); > + } catch (UnsupportedEncodingException ex) { > + // Should never happen. > + } What if it happens (if the exception is there it means it can happen)? Shouldn't you at least log an error or warning that says the result is left as is without being encoded? Thanks -Vincent

2 4

[xwiki-devs] [VOTE] Remote org.jfree.chart.plot.Plot#setDataAreaRatio call and upgrade to jfreechart 1.0.13
by Thomas Mortagne 03 Jul '10

03 Jul '10

Hi devs, Currently we are using some custom 1.0.0RC1 version of jfreechart and keep using it for only one reason: we are using org.jfree.chart.plot.Plot#setDataAreaRatio API in the old chart plugin and we can't find a proper equivalent (i don't even see what this is doing since it does not change anything in the chart i tried like in statistics). My proposal is to simply remove it so that we can move on. In any case there is a new charting component that should be the one use and which is already built with recent jfreechart API (we are pretty lucky that it simply work in such conditions since we distribute XE with 1.0.0RC1) and if setDataAreaRatio is really related to en important feature it should be supported by the new component if not already done. WDYT ? Here is my +1 -- Thomas Mortagne

5 5

Re: [xwiki-devs] [xwiki-notifications] r29950 - enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui
by Vincent Massol 03 Jul '10

03 Jul '10

Hi Sergiu, On Jul 3, 2010, at 12:56 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2010-07-03 00:56:27 +0200 (Sat, 03 Jul 2010) > New Revision: 29950 > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/EditObjectsTest.java > Log: > [misc] New test: adding an object by clicking the inline "New <class> object" [snip] > + > + @Test > + public void testInlineObjectAddButton() > + { > + ObjectEditPage oep = new ObjectEditPage(); > + oep.switchToEdit("Test", "EditObjectsTestObject"); > + oep.addObject("XWiki.XWikiUsers"); > + > + getDriver().findElement(By.cssSelector("[id='add_xobject_XWiki.XWikiUsers'] .xobject-add-control")).click(); > + Wait<WebDriver> wait = new WebDriverWait(getDriver(), getUtil().getTimeout()); > + wait.until(new ExpectedCondition<Boolean>() > + { > + public Boolean apply(WebDriver driver) > + { > + return Boolean.valueOf(driver.findElements(By.cssSelector("[id='xclass_XWiki.XWikiUsers'] .xobject")) > + .size() == 2); > + } > + }); Isn't this an api missing in Page Objects (what does it do)? Thanks -Vincent

2 2