October 2012 - xwiki-devs@xwiki.org

[xwiki-devs] [VOTE] REST API Changes not passing CLIRR. Ignore errors
by Ludovic Dubost 19 Oct '12

19 Oct '12

As part of rest improvements to display pretty names of users and other improvements, I'm getting CLIRR errors because of API changes of the model and of public class: 1/ Model CLIRR error because the version field has been moved to PageSummary from Page. Page extends PageSummary. I need the version field also in representations sending back only PageSummaries. Unfortunately CLIRR does not realize that the version field is still there when moved to the super class. I believe it's safe to ignore this error. Howerver I've put ignore all errors on the Page class as I don't have a way to ignore this specific error 2/ CLIRR errors because of parameter additions to objects that are used (I think) only internally by the REST server API. Here are the errors: [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.Attachment createAttachment(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, com.xpn.xwiki.api.Attachment, java.lang.String, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.Attachment createAttachmentAtVersion(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, com.xpn.xwiki.api.Attachment, java.lang.String, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.Comment createComment(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, com.xpn.xwiki.api.Document, com.xpn.xwiki.api.Object)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.HistorySummary createHistorySummary(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, java.lang.String, java.lang.String, java.lang.String, java.lang.String, org.suigeneris.jrcs.rcs.Version, java.lang.String, java.util.Date)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.Object createObject(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, com.xpn.xwiki.XWikiContext, com.xpn.xwiki.api.Document, com.xpn.xwiki.objects.BaseObject, boolean)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.ObjectSummary createObjectSummary(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, com.xpn.xwiki.XWikiContext, com.xpn.xwiki.api.Document, com.xpn.xwiki.objects.BaseObject, boolean)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.Page createPage(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, java.net.URI, com.xpn.xwiki.api.Document, boolean, com.xpn.xwiki.api.XWiki)' the number of arguments has changed [ERROR] org.xwiki.rest.DomainObjectFactory: In method 'public org.xwiki.rest.model.jaxb.PageSummary createPageSummary(org.xwiki.rest.model.jaxb.ObjectFactory, java.net.URI, com.xpn.xwiki.api.Document, com.xpn.xwiki.api.XWiki)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.BaseAttachmentsResource: In method 'public org.xwiki.rest.model.jaxb.Attachments getAttachments(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.BaseAttachmentsResource: In method 'protected org.xwiki.rest.model.jaxb.Attachments getAttachmentsForDocument(com.xpn.xwiki.api.Document, int, int)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.BaseSearchResult: In method 'protected java.util.List search(java.util.List, java.lang.String, java.lang.String, java.lang.String, boolean, int)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.BaseSearchResult: In method 'protected java.util.List searchObjects(java.lang.String, java.lang.String, java.lang.String, boolean, int)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.BaseSearchResult: In method 'protected java.util.List searchPages(java.util.List, java.lang.String, java.lang.String, java.lang.String, boolean, int)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.BaseSearchResult: In method 'protected java.util.List searchSpaces(java.lang.String, java.lang.String, boolean, int)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.ModificationsResource: In method 'public org.xwiki.rest.model.jaxb.History getModifications(java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String, java.lang.Long)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.attachments.AttachmentsAtPageVersionResource: In method 'public org.xwiki.rest.model.jaxb.Attachments getAttachmentsAtPageVersion(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.attachments.AttachmentsResource: In method 'public org.xwiki.rest.model.jaxb.Attachments getAttachments(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.comments.CommentResource: In method 'public org.xwiki.rest.model.jaxb.Comment getComment(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.comments.CommentVersionResource: In method 'public org.xwiki.rest.model.jaxb.Comment getCommentVersion(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.comments.CommentsResource: In method 'public org.xwiki.rest.model.jaxb.Comments getComments(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.comments.CommentsVersionResource: In method 'public org.xwiki.rest.model.jaxb.Comments getCommentsVersion(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.AllObjectsForClassNameResource: In method 'public org.xwiki.rest.model.jaxb.Objects getObjects(java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectAtPageVersionResource: In method 'public org.xwiki.rest.model.jaxb.Object getObject(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectPropertiesAtPageVersionResource: In method 'public org.xwiki.rest.model.jaxb.Properties getObjectProperties(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectPropertiesResource: In method 'public org.xwiki.rest.model.jaxb.Properties getObjectProperties(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectPropertyAtPageVersionResource: In method 'public org.xwiki.rest.model.jaxb.Property getObjectProperty(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectPropertyResource: In method 'public org.xwiki.rest.model.jaxb.Property getObjectProperty(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectResource: In method 'public org.xwiki.rest.model.jaxb.Object getObject(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectsAtPageVersionResource: In method 'public org.xwiki.rest.model.jaxb.Objects getObjects(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectsForClassNameResource: In method 'public org.xwiki.rest.model.jaxb.Objects getObjects(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.objects.ObjectsResource: In method 'public org.xwiki.rest.model.jaxb.Objects getObjects(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageChildrenResource: In method 'public org.xwiki.rest.model.jaxb.Pages getPageChildren(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageHistoryResource: In method 'public org.xwiki.rest.model.jaxb.History getPageHistory(java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageResource: In method 'public org.xwiki.rest.model.jaxb.Page getPage(java.lang.String, java.lang.String, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageTranslationHistoryResource: In method 'public org.xwiki.rest.model.jaxb.History getPageTranslationHistory(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageTranslationResource: In method 'public org.xwiki.rest.model.jaxb.Page getPageTranslation(java.lang.String, java.lang.String, java.lang.String, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageTranslationVersionResource: In method 'public org.xwiki.rest.model.jaxb.Page getPageTranslationVersion(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PageVersionResource: In method 'public org.xwiki.rest.model.jaxb.Page getPageVersion(java.lang.String, java.lang.String, java.lang.String, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.pages.PagesResource: In method 'public org.xwiki.rest.model.jaxb.Pages getPages(java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer, java.lang.String)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.spaces.SpaceAttachmentsResource: In method 'public org.xwiki.rest.model.jaxb.Attachments getAttachments(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.spaces.SpaceSearchResource: In method 'public org.xwiki.rest.model.jaxb.SearchResults search(java.lang.String, java.lang.String, java.lang.String, java.util.List, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.tags.PagesForTagsResource: In method 'public org.xwiki.rest.model.jaxb.Pages getTags(java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.wikis.WikiAttachmentsResource: In method 'public org.xwiki.rest.model.jaxb.Attachments getAttachments(java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.String, java.lang.Integer, java.lang.Integer)' the number of arguments has changed [ERROR] org.xwiki.rest.resources.wikis.WikiSearchResource: In method 'public org.xwiki.rest.model.jaxb.SearchResults search(java.lang.String, java.lang.String, java.util.List, java.lang.Integer)' the number of arguments has changed Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

6 18

[xwiki-devs] 4.3M1 release is Monday 22nd - please stabilize
by Vincent Massol 19 Oct '12

19 Oct '12

To all devs, The 4.3M1 release is for Monday. Could all devs please fix the build so that it passes and so that we can release on Monday? Make sure to not commit anything more for 4.3M1. What's not committed should now go for 4.3M2 unless it's a blocker. All make sure all your issues are closed with proper documentation fields. Thanks -Vincent

1 0

[xwiki-devs] [PROPOSAL] Execution context property declarations and property metadata attributes
by Andreas Jonsson 17 Oct '12

17 Oct '12

Hi everyone, I would like to propose to introduce a possibility to associate properties in the execution context with metadata by declaring them. We introduce the class 'ExecutionContextProperty' that will store the metadata attributes, in addition to the actual property value. /** * Declare a property in the execution context. * * @param key The key that names the property * @param property The property to declare. */ public void declareProperty(String key, ExecutionContextProperty property) The metadata governs how the property should be treated when managing the execution contexts. For instance, these attributes could be supported: * Read-only - The value may not be updated within the the execution context. * Inherited - The property will be inherited from the current context when replacing the execution context within the scope of a request. * Clone - Also clone the value when the execution context is cloned. * Type - The class of the value, for typechecking when replacing the value. * Non-null - The value may not be null So, the arguments for this proposal are at least two: 1. Catch errors early and simplify debugging. 2. Convenience of having properties automatically maintained across execution contexts within the same request cycle. What do you think? I would like to implement and merge this ASAP. Best Regards, /Andreas

3 10

[xwiki-devs] [Proposal] Improving our handling of Patches/PR (second step)
by Vincent Massol 17 Oct '12

17 Oct '12

Hi devs, Now that we've decided about our mini workflow to know which issues having patches have been answered by us or not, that leaves us with this status: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10000#Issue-Statis… Namely: - 28 issues containing patches that we need to review - 16 issues that we've reviewed and for which we're waiting for an answer from the contributor - 1 waiting for a pull request I think that so far we've not been very good at answering quickly contributors who post patches. I know it's difficult. I'm proposing 2 ways to improve this: * Send a weekly email about issues having patches and awaiting committer feedback * Schedule a "patch day" where devs would work primarily on reviewing issues with patches and applying where possible. At the minimum the goal would be to reply to the issues. WDYT? Thanks -Vincent

6 7

[xwiki-devs] Contribution Translations
by Richard Hierlmeier 17 Oct '12

17 Oct '12

Hi guys, I tried to contribute some translations for the repository extension at http://l10n.xwiki.org. However the message keys for the repository extension are unknown. What is the proposed way to contribute translations for extensions? Here are the translations for German language: ## Translations for the livetables column titles extension.repository.emptyvalue= extension.repository.name=Name extension.repository.summary=Zusammenfassung extension.repository.type=Typ extension.repository.authors=Autoren extension.repository.doc.creationDate=Erzeugt am extension.repository.doc.date=Letzte Änderung ## Administration UI admin.repository=Repository mit Erweiterungen</content> Richard

2 1

[xwiki-devs] Should we have a vm file or a REST URL for getting a page's content?
by Vincent Massol 16 Oct '12

16 Oct '12

Hi devs, Just realized that we don't have direct way of getting a page's content (only the content)… The best we can do is: http://playground.xwiki.org/xwiki/bin/view/Sandbox/WebHome?xpage=plain&outp… But that converts the content to XWiki Syntax. Shouldn't we have a vm for just displaying the content? Or even better a REST URL? Thanks -Vincent

5 6

[xwiki-devs] Issue with maven generation of the javadoc for SRD
by Ludovic Dubost 11 Oct '12

11 Oct '12

Hi, I found an issue with the maven project to generate the javadocs for SRD. Apparently all the internal packages are ignored. This is no necessarly a problem unless we want them in the javadocs. Now there is a problem as some APIs are in internal, which does not seem normal. This is the case of: org.xwiki.officeimporter.internal.script.OfficeImporterScriptService org.xwiki.officeimporter.internal.openoffice.script.OpenOfficeManagerScriptService org.xwiki.office.viewer.internal.DefaultOfficeViewerScriptService Until we find a solution i've reverted to the javadocs manually generated (without the maven project). Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

6 10

[xwiki-devs] SRD (Scripting Reference Documentation) Annoucement
by Ludovic Dubost 10 Oct '12

10 Oct '12

Hi, I'm happy to announce the first release of the Scripting Reference Documentation (SRD). The objective of this documentation is to have a quick access to the relevant javadoc or documentation page to perfom XWiki scripting. The SRD is available at: http://platform.xwiki.org/xwiki/bin/view/SRD/Navigation?xpage=embed It contains: - javadoc links to Velocity and Groovy bindings, including the main API ($xwiki, $doc, $request, $response, $context) as well as XWiki services and plugins, as well as Velocity Tools. - links to the Velocity and Groovy language documentation This documentation is currently available for XWiki 4.1.x an 4.2.x. This is a very good tools for beginners with XWiki scripting. We do still recommend the development tutorials on the XWiki Dev Guide (http://platform.xwiki.org/xwiki/bin/view/DevGuide/WebHome) Please let us know on the dev list for any feedback on this new documentation. Ludovic -- Ludovic Dubost Founder and CEO Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

2 2

[xwiki-devs] Mark user as deactivated/spammer
by Felix AtCurriki 10 Oct '12

10 Oct '12

Hi all, At Curriki we currently work on a small tool which allows us to search users and apply changes to their "active/inactive" and "email_undeliverable" values easily without the need of editing the user objects manually. That gives us the following combinations for user states which are already in use (e.g. in the registration process): - User state: Active Values: (active:"Active", email_undeliverable:No) - User state: Inactive Values: (active:"Inactive", email_undeliverable:Yes) - The user needs to revalidate his email address Now if we want users to be marked as deactivated/spammers do you think would it be a good way to define an additional user state by expressing it through boolean combinations like this: - User state: Deactivated/Spammer Values: (active:"Inactive", email_undeliverable:*No*) Or do you think it would it be better to add an entry to the choices of the "active" value in the user object which explicitly says "deactivated" or "spammer". Or do you have any other best practice solutions? Thank you in advance!

4 4

[xwiki-devs] SRD bugs for $services
by Vincent Massol 10 Oct '12

10 Oct '12

Hi (Ludovic), Cool that you applied http://platform.xwiki.org/xwiki/bin/view/SRD/Navigation?xpage=embed I've noticed some bugs in the services listing, like $services.class, $services.line, $services.currentmixed, etc. Also note that the Bindings filter is missing the $services binding. Thanks -Vincent

2 10