July 2017 - xwiki-devs@xwiki.org

[xwiki-devs] [Brainstorming] Increase QA team visibility
by Vincent Massol 11 Jul '17

11 Jul '17

Hi, We’ve been having 3 persons in the community who help test XWiki every day and who report jira issues: Ilie, Gabriela and Manuel. Manuel has been doing this over 4 years now (close to 5 actually)! They’re important and they help XWiki get better every day and release over release. I think we should recognize them more in the project. I have 2 ideas: * Mention this role of QA engineer on http://dev.xwiki.org/xwiki/bin/view/Community/HallOfFame and make it more “official" * Make them visible in the RN. Right now in the RN we mention everyone who contributed code. I think we could also mention everyone who created a JIRA issue that got fixed during that release. WDYT? Any other idea? Thanks -Vincent PS: I forgot if I already sent a mail on this topic or not (couldn’t find one but it vaguely rings a bell). Anyone remembers? :)

2 4

[xwiki-devs] [PROPOSAL] So which Standard flavor dependencies should be optional
by Thomas Mortagne 10 Jul '17

10 Jul '17

Hi everyone, I just implemented https://jira.xwiki.org/browse/XCOMMONS-1229 which allows to indicate that a dependency will be installed by default but does not have a string dependency link with the extension, meaning that uninstalling it won't impact the backward dependencies (so they are not really backward dependencies in that case :)). Now we need to decide what exactly is optional in Standard flavor. Here are some ideas: * application-help-center * xwiki-platform-menu-ui * xwiki-platform-wiki-ui-mainwiki * xwiki-platform-office-ui * xwiki-platform-invitation-ui * xwiki-platform-appwithinminutes-ui * xwiki-platform-linkchecker-ui * xwiki-platform-sandbox * xwiki-platform-sharepage-ui * xwiki-platform-distribution-flavor-tour * application-templates-ui I did not actually tried to uninstall those so it's possible it's not a good idea to uninstall some of them right now (hardcoded use somewhere maybe). WDYT ? -- Thomas Mortagne

6 25

[xwiki-devs] [Brainstorming] Location of login/Register buttons
by Vincent Massol 07 Jul '17

07 Jul '17

Hi devs, We’ve moved the register/login buttons inside the drawer. However one consequence is that users don’t notice it anymore. I’d like this thread to be a brainstorming about what we could do about it and whether you agree it’s an issue that we need to fix. Ideas? One idea could to reuse the Avatar image location to have some icon to register/login when not logged in. WDYT? Thanks -Vincent

4 6

[xwiki-devs] [VOTE] Optional dependencies and Maven
by Thomas Mortagne 06 Jul '17

06 Jul '17

Hi devs, So we now have the concept of optional dependencies at Extension Manager level. This are dependencies that are installed by default (but if they fail they don't fail the whole install) and which can be uninstalled without any impact on what is no longer it's backward dependency. On Maven -> EM side what I did is reuse <optional>true</optional> mostly the following reason: there is no way in pom.xml to put custom stuff in <dependency> so it would be a huge pain to maintain a list of optional dependencies from a property at general pom level. The issue is that the behavior of this <optional> is not exactly the same in EM and Maven: in Maven those dependencies are NOT triggered by default. Still, apart from this it's supposed to be the same meaning and it should not be an issue to install this dependency (if it is then it means you should have used something else like <scope>provided</scope>) but as usually since there is no official way in Maven to say "I just want to use that during the build and it does not make any sens to get this dependency" some projects may have used it that way. So do you think it is OK ? It's not acceptable and we absolutely need to move this kind of information in some general property in the pom <properties> ? -- Thomas Mortagne

3 4

[xwiki-devs] [XWiki Day] BFD#145
by Alexandru Cotiuga 06 Jul '17

06 Jul '17

Hello devs, Today is BFD#145: http://dev.xwiki.org/xwiki/bin/view/Community/XWikiDays#HBugfixingdays Our current status is: * -40 bugs over 120 days (4 months), i.e. we need to close 40 bugs to have created bugs # = closed bugs # * -19 bugs over 365 days (1 year). * -49 bugs over 500 days (between 1 and 2 years) * -13 bugs over 1600 days (4.3 years) * -779 bugs since the beginning of XWiki See https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#145 dashboard to follow the progress during the day: https://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=13900 Happy BugFixing Day, Alex

1 0

[xwiki-devs] [Brainstorming] How can we send live notification e-mails ?
by Clément Aubin 03 Jul '17

03 Jul '17

Hi devs ! Currently working on [XWIKI-14353](https://jira.xwiki.org/browse/XWIKI-14353), I think that the live e-mail notification system could be implement as 2 different ways : 1. In its notification preferences, a user can select if he wants a mail daily, hourly or weekly (that’s already in place). We could add a new "live" option that does exactly what is expected : it sends a mail as soon as a document has been updated. 2. We could also provide a completely different option that sends live e-mails, but regular notification mails are still sent depending on the user preference and acts as a hourly / daily or weekly "digest". Finally one idea would be to use the same system that is implemented in discourse : a mail is sent approximately 10 minutes after an event is triggered, this means that if a user A is subscribed to the events coming form a document X, if this document is updated by someone else, the updates coming from the document in the next 10 minutes will be grouped in a single mail that will be sent to A. This could potentially be more scalable as less mails are sent to the users. WDYT ? Thanks, -- Clément Aubin Web Developer Intern @XWiki SAS clement.aubin(a)xwiki.com More about us at http://www.xwiki.com

3 3

[xwiki-devs] [GSOC Update 3] RedPen Integration
by deshengchuan 03 Jul '17

03 Jul '17

Hi all! This is the third update regarding the progress of the Redpen integration project. Some of the info can also be accessed in the design page over here: <http://design.xwiki.org/xwiki/bin/view/Proposal/RedPenIntegration> I have created a UI on XWiki. The two main parts are such: First, the application homepage will allow users to key in possible spelling and expression errors, and their recommended corrections. I have not started on building the backend in Java to process this database yet, but I'll start on it within the next couple of weeks. Second, there is a setting page within the global administration wiki that allows the user to key in basic settings parameters e.g. setting maximum sentence length. The functionality is still restricted to validating a wiki page on document save, but I will be implementing the function to run redpen validation as a Job next, right after i finish fixing and stabilising some issues within the code. Any comments? -- View this message in context: http://xwiki.475771.n2.nabble.com/GSOC-Update-3-RedPen-Integration-tp760425… Sent from the XWiki- Dev mailing list archive at Nabble.com.

2 5

Re: [xwiki-devs] Glossary Application [GSoC][Update]
by Vincent Massol 02 Jul '17

02 Jul '17

Hi Sarthak, > On 28 Jun 2017, at 20:35, Sarthak Gupta <sarthakgupta072(a)gmail.com> wrote: > > Hello Vincent, > > On Wed, Jun 28, 2017 at 1:30 PM, Vincent Massol <vincent(a)massol.net> wrote: > Hi Sarthak, > > > On 27 Jun 2017, at 14:58, Sarthak Gupta <sarthakgupta072(a)gmail.com> wrote: > > > > Hi all, > > This mail is regarding the status of the project Glossary Application. > > I have developed the basic UI for the application which enables a user to > > add a glossary application and also search the already existing glossary > > item in the glossary space. The UI is still not very user-friendly as I had > > decided to finish off the leftover designing part after adding more > > features and just before the release of the first version. > > > > The next part of the project was "adding transformations". I have written > > the code for basic transformation but still facing some errors in it. Hope > > the errors may be rectified after some code review. > > > > The task that will be left before releasing the first basic version will be > > "the ability to add glossary items from the wiki pages by selecting the > > words on Wiki pages". More details on > > http://design.xwiki.org/xwiki/bin/view/Proposal/GlossaryApplication > > <http://design.xwiki.org/xwiki/bin/view/Proposal/GlossaryApplication>. > > > > Also, tests are to be written for each fo the above. > > > > Rest of the features which are to be added (See Design Page) will be > > implemented after the release of the first version. :) > > Thanks for the update. > > Some general comments first: I found that the work is going too slow and I’m a bit disappointed by the progress. At this stage you’re actually less advanced than the FAQ application and the Glossary app is really just a copy of that (the part located in wiki pages). You should have finished both the UI and the Transformation at this point. TBH the work done shouldn’t amount for more than 2-3 days of work for someone new to XWiki. > > > Yes, I totally agree and deeply regret that the work done is too less than expected. The main reason for this was that I was basically facing problem with the language. I was hearing some things for the first time in my life, I used to google them a lot but because of having a very less experience in programming(1 year roughly), I was finding difficulty to relate things with each other thus not able to find the right resources to understand the concepts properly, so used to get stuck on them for days. I still face these things but certainly I am better now and will try to catch up. :) > > Some more specific comments on the code of what I’ve reviewed: > * The POMs have plenty of errors and you haven’t used the information that can be found http://contrib.xwiki.org nor the FAQ application’s POM as I have explained a few times (missing licenses, missing metadata, etc), incorrect README. > * You committed IDE files in the SCM (see the rules from http://dev.xwiki.org) > > * Would be better to use nested pages and put the Code space under the Glossary space. > > Could you please explain the one point above. Not getting it. See http://dev.xwiki.org/xwiki/bin/view/Community/ApplicationDevelopmentBestPra… and especially: "Technical pages must be put in a subspace named Code” Would be great if you could review those best practices btw. XWiki supports nested pages, see http://platform.xwiki.org/xwiki/bin/view/Features/ContentOrganization/ for more details. > > * You’re using the wrong package for your java class (it should be in org.xwiki.contrib and not org.xwiki.rendering): https://github.com/xwiki-contrib/application-glossary/blob/master/applicati… > * Would be great if you could add some unit tests for the transformation (again check the wikioword transformation which has tests). Without it, it’s hard to test and I can’t help you without that (would take too long to debug in XWiki). > > I will correct all the above errors ASAP. > > * Note that you haven’t implemented yet a cache in the transformation and tight now your transformation would simply slow down the whole XWiki :) > > Could you provide some pointers on this?Some example or guide that I can refer to? This means implementing an Event Listener that listens to glossary xobjects addition/deletion/updates and updates a cache of glossary keys and document references. A cache can be a simple structure such as a Map. You can google “xwiki event listener” for more info on that. There are also several examples in xwiki-platform. Check classes implementing the EventLiostener interface. Thanks! -Vincent > > Maybe you need to catch up technically on several technologies and that’s why the progress is a bit slow. I hope you’re learning a lot which would be good! > > > That's right! I am learning a lot.. :) > > Thanks > Sarthak Gupta > > Thanks > -Vincent > > > > > Thanks > > Sarthak Gupta

1 0