- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] Problem with XWikiLDAPUtils class
by Eric Kimn 10 Feb '14

10 Feb '14

Hey all, I managed to view the code for this class by a google search. But i’m noticing a problem with the getGroupMembers logic and I’m experiencing it myself in my 5.4 install of xwiki. Some background: I am using Apple’s open directory as my ldap server. My ldap config is as such (using the LDAP application): Restrict to group: cn=mygroup LDAP base dn: dc=mycompany,dc=com LDAP UID Attribute name memberUid The symptom: When XWiki tries to locate the members of a group, it finds only one, typically the alphabetically first one, and not all. The source of the problem: The entry point is here: public Map<String, String> getGroupMembers(String groupDN, XWikiContext context) which calls with a new map of <String, String> for members, this line -> boolean isGroup = getGroupMembers(groupDN, members, new ArrayList<String>(), context); That method has this signature -> public boolean getGroupMembers(String groupDN, Map<String, String> memberMap, List<String> subgroups, XWikiContext context) which falls to if (searchAttributeList != null) { isGroup = getGroupMembers(fixedDN, memberMap, subgroups, searchAttributeList, context); } But of course there are search attributes, so it calls this-> public boolean getGroupMembers(String groupDN, Map<String, String> memberMap, List<String> subgroups, List<XWikiLDAPSearchAttribute> searchAttributeList, XWikiContext context) And this is where the problem is: It for loops through the search attributes and executes a query, if it gets a response that isn’t a group and the member map doesn’t already contain that key, it will add it: if (!memberMap.containsKey(groupDN)) { memberMap.put(groupDN.toLowerCase(), id == null ? "" : id.toLowerCase()); } But then it RETURNS isGroup, which is now true, And that flows back up the chain, except it never iterates through the rest of the entries. My logs show: 2014-02-08 17:45:22,858 [http://myserver/xwiki/bin/loginsubmit/XWiki/XWikiLogin] DEBUG c.x.x.p.l.XWikiLDAPUtils - Looks like [cn=mygroup] is not a DN, lets try filter or id 2014-02-08 17:45:22,858 [http://myserver/xwiki/bin/loginsubmit/XWiki/XWikiLogin] DEBUG c.x.x.p.l.XWikiLDAPConnection - LDAP search: baseDN=[dc=mycompany,dc=com] query=[cn=mygroup] attr=[[objectClass, uid, memberuid, memberUid]] ldapScope=[2] 2014-02-08 17:45:22,864 [http://myserver/xwiki/bin/loginsubmit/XWiki/XWikiLogin] DEBUG c.x.x.p.l.XWikiLDAPUtils - Found group [cn=mygroup] members [{cn=mygroup,cn=groups,dc=mycompany,dc=com=member1}] 2014-02-08 17:45:22,864 [http://myserver/xwiki/bin/loginsubmit/XWiki/XWikiLogin] DEBUG c.x.x.p.l.XWikiLDAPUtils - Found user dn in user group [null] 2014-02-08 17:45:22,865 [http://myserver/xwiki/bin/loginsubmit/XWiki/XWikiLogin] DEBUG u.i.L.XWikiLDAPAuthServiceImpl - Local LDAP authentication failed. com.xpn.xwiki.XWikiException: Error number 8001 in 8: LDAP user member2 does not belong to LDAP group cn=mygroup. Am I reading the logs or code wrong? If I am, then what am I doing wrong with my ldap configuration? I’m clearly part of mygroup but it consistently fails to find me. Best, Eric Kyungsuk Kimn 김경석 Senior Back End Developer ekimn(a)apple.com

2 15

[xwiki-devs] [VOTE] Move to Java 7 as minimum supported version
by Thomas Mortagne 09 Feb '14

09 Feb '14

Hi devs, I would like to propose that we move to Java 7 as minimum version in XWiki 6.0. You can look at http://jira.xwiki.org/browse/XCOMMONS-432 for details on why and why not. The only cons basically is that Java 6 may still be used in production but we are talking about a version that won't be used in production before at least 3 months. WDYT ? Here is my +1 -- Thomas Mortagne

11 12

[xwiki-devs] [Reminder] BFD#54
by vincent＠massol.net 09 Feb '14

09 Feb '14

Hi devs, Today is Bug Fixing Day 54. We're currently at -50 bugs for the 1600 days period: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=10352 Here's the BFD#54 dashboard to follow the progress during the day: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=12000 Happy BFD! -Vincent

1 1

[xwiki-devs] [Proposal] WebJar integration in XWiki
by Vincent Massol 08 Feb '14

08 Feb '14

Hi devs, I'd like to make it easy in XWiki to use javascript frameworks required by extensions. I've found the webjars project (http://webjars.org) which packages javascript frameworks in JAR files available in Maven Central. They work out of the box if you drop them in WEB-INF/lib in a Servlet 3.0 container (like Jetty 7). It works because the 3.0 spec says that any files located in META-INF/resources/<path> will be made available by the servlet container as static resources (accessible as <path>). However the servlet 3.0 specs doesn't support adding those JAR dynamically outside of WEB-INF/lib so it doesn't work with our extension mechanism. Thus I'm proposing the following (which I have tested to work): * Add a new WebJarFilter filter to web.xml * The URL to access, for ex, angular.js packaged in the http://repo2.maven.org/maven2/org/webjars/angularjs/1.1.5-1/angularjs-1.1.5… jar would be: /xwiki/webjar/angularjs/1.1.5/angular.js This allows for example to have a dep on: <dependency> <groupId>org.webjars</groupId> <artifactId>angularjs</artifactId> <version>1.1.5-1</version> <scope>runtime</scope> </dependency> Then in a JSX object: require(["/xwiki/webjar/angularjs/1.1.5/angular.js"], function() { … }); WDYT? Thanks -Vincent

5 11

[xwiki-devs] [Proposal] Release 5.4.1 next Tuesday
by vincent＠massol.net 07 Feb '14

07 Feb '14

Hi Devs, Since we’ve found an important issue in 5.4 (see http://www.xwiki.org/xwiki/bin/view/ReleaseNotes/ReleaseNotesXWiki54) and Denis has also fixed a security issue, I’d like to propose releasing 5.4.1 earlier than planned (it was planned for the 17th of Feb) and schedule a 5.4.2 with the leftover. GuillaumeD has proposed to be the RM for 5.4.1. Here’s what has been fixed so far in 5.4.1: http://jira.xwiki.org/secure/Dashboard.jspa?selectPageId=12003 There are 14 issues so far which makes it more than enough IMO. WDYT? Thanks -Vincent

4 3

[xwiki-devs] 6.x performances work
by Thomas Mortagne 07 Feb '14

07 Feb '14

Hi devs, Here is a mail to talk about what I plan to do during 6.x related to performances. I don't have detailed plan for 6.0 yet, I still have work to do on unfinished 5.x stuff and my priority will goes to that but before working on it lets present what I already have in mind about performances and gather some other ideas. I did not really made much new reseachs yet, it's mostly things I have in mind since some time for most of them. First thing first: having good performance is everyone's work, don't expect me to review everything you do and do all the thinking about how to design each feature so that it has good performances. My main job is do things we always puh back because we don't have time so here it is. = Automated speed report with history I plan to write a build dedicated to test performances (of XE for now) and provide stored and compared reports about it. My plan is to combine the following tools: * JMeter and more precisely some jmeter Maven plugin (probably https://github.com/Ronnie76er/jmeter-maven-plugin/) * Jenkins Performance Plugin (https://wiki.jenkins-ci.org/display/JENKINS/Performance+Plugin) to put a nice UI around that And probably run that build something like once a day on master branch for example. The first step is to report it, second will probably be to set a maximum timeout (that we ideally reduce over time ;)) to fail the build when it become too slow (but that will be only after we actually improved it). I hope to finish this in 6.0. = Spot worst places I plan to do hand testing with a profiler (probably YourKit) and write detailed reports in jira issues for the slowest parts or our code during a request (and not only for view, save is a realy a pain sometimes) and what seems weird so that we find solutions (or not) for each one. Same, I think I should have moved forward on it during 6.0 timeframe. = Things we already know but for which I don't have yet a definitive solution == Too much database requests Loading a single document generate tons of requests. The document cache hide this a little. Maybe start include some lazy loading of objects in document or things like this but it's hard since we don't have any real clean interface and only XWikiDocument to work on it. == The UI is very expensive Loading a page with /get/ action for example is a lot quicker (often more than 5 times quicker) than loading it with the full UI (/view/ action) even a page with lots of content including content we generally consider very slow like code macro. = Some ideas of refactoring or new features I already have in mind (not specifically done by me, it's just ideas of things to look at) == Async events I don't think there is much related issues in view but we are doing way too much blocking stuff when modifying a document so I plan to allow a listener to declare that it's ok for it to receive asynchronous events (events sent in a different thread than the one who actually saved the document) and review the listeners that could use that (the first one I have in mind is user cleaner but I'm also thinking about wiki extension module which execute several requests at each save for example and all the code responsible for parsing and storing backlinks in modified documents). == Activity stream UI This is nothing new and a project of it's own, the UI of Activity Stream is super slow and probably require a complete analysis and rewrite by a dedicated developer. <put other ideas here ;)> -- Thomas Mortagne

2 1

[xwiki-devs] [ANN] XWiki User Map - Please add yourself!
by vincent＠massol.net 07 Feb '14

07 Feb '14

Hi XWiki users, We’re trying to create a user map of all XWiki users. There are 2 nice effects from this: 1) Increase the feeling of a community 2) Find out other XWiki users close to where you are. The next step will be to organize some XWiki User Group in places where there’s a cluster of xwiki users! Please join the xwiki community by adding yourself to: https://maps.google.com/maps/ms?msid=210331808187331529022.0004f02bd076d94d… Thanks a lot -Vincent Massol

1 0

[xwiki-devs] [Proposal] Remove the panel "Wiki Information" in default subwiki configuration
by Guillaume "Louis-Marie" Delhumeau 06 Feb '14

06 Feb '14

Before 5.3, we used to have panel "Wiki Information" [1], by default, on the right column of new workspaces. In regular subwikis (not workspaces), we did not have this panel. I propose to not have it by default on the subwiki configuration. It will still be possible to add it manually since the panel will still be bundled in the subwiki application. Here is my +1. Louis-Marie [1] http://jira.xwiki.org/secure/attachment/27198/missing-panel.png

5 4

[xwiki-devs] [Brainstorming] Default rights in subwikis
by Guillaume "Louis-Marie" Delhumeau 06 Feb '14

06 Feb '14

Hi devs. Since 5.3, we have this issue opened: http://jira.xwiki.org/browse/XWIKI-9726 - The default rights of subwikis has changed. I am not shocked by the new settings - same as in the main wiki - but it is different from what Workspaces used to be. What do you think about it? Thanks, Louis-Marie

5 8

[xwiki-devs] [Proposal] XWiki 6.x cycle dates
by vincent＠massol.net 06 Feb '14

06 Feb '14

Hi devs, We’ve already decided on the 6.x cycle and on the 6.0 roadmap and dates. I’d like to propose the following global schedule for the full 6.x cycle: * 6.0: April 2014 * 6.1: June 2014 * 6.2: August 2014 * 6.3: October 2014 * 6.4: December 2014 Note that I’m implicitly proposing to change one rule defined at http://dev.xwiki.org/xwiki/bin/view/Community/VersioningAndReleasePractices… I’m proposing to have 5 release per cycle instead of 6 in order to make a cycle fit in 1 year (we did this for 5.x btw). Also note that I’ve put slightly shorter release times for releases (between 1.5 to 2 months, except for the 1st one for which I’ve allowed 2.5 months). WDYT? Thanks -Vincent

1 0