- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [Discussion] Integrating officepreview module into main source tree
by Asiri Rathnayake 05 Jul '10

05 Jul '10

Hi Devs, I have almost completed my work on officepreview module and I would like to discuss about integrating it into main source tree (and release it with 2.4M1). There are a couple of things to discuss: 1. officepreview module have to depend on xwiki-core for the time being because with current component approach there is no way of determining the version of an attachment (officepreview module needs to know attachment version). 2. Need a couple of tests - I'm working on this. 3. Where to place the officepreview module in main source tree. My initial idea for (3) was to create a /platform/core/trunk/xwiki-officepreview submodule. However, since officepreview module depends on officeimporter module, I'm not sure if we should create a parent module that would host both of these projects. Another problem lingering in my mind is that with recent changes xwiki-officeimporter module encapsulates two sub modules - a module capable of converting documents from one format to another (this is a generic converter api kind of thing) and another module which is importing office documents into xwiki specific formats (XDOMOfficeDocumentBuilder, PresentationBuilder etc.). I'm not sure if these two modules should be seperated out, but may be that's a separate discussion. Please let me know your comments about above points. Thanks. - Asiri

2 5

Re: [xwiki-devs] [xwiki-notifications] r29965 - contrib/sandbox/xwiki-officepreview
by Vincent Massol 04 Jul '10

04 Jul '10

Actually the solution is to simply add: ... </build> <properties>  <xwiki.clirr.skip>true</xwiki.clirr.skip> </properties> </project> Thanks -Vincent On Jul 4, 2010, at 2:51 PM, asiri (SVN) wrote: > Author: asiri > Date: 2010-07-04 14:51:21 +0200 (Sun, 04 Jul 2010) > New Revision: 29965 > > Modified: > contrib/sandbox/xwiki-officepreview/pom.xml > Log: > * Removed clirr plugin checks because we don't have a previous version of xwiki-core-officepreview artifact. > > Modified: contrib/sandbox/xwiki-officepreview/pom.xml > =================================================================== > --- contrib/sandbox/xwiki-officepreview/pom.xml 2010-07-04 01:50:57 UTC (rev 29964) > +++ contrib/sandbox/xwiki-officepreview/pom.xml 2010-07-04 12:51:21 UTC (rev 29965) > @@ -97,6 +97,13 @@ > </excludes> > </configuration> > </plugin> > + <plugin> > + <groupId>org.codehaus.mojo</groupId> > + <artifactId>clirr-maven-plugin</artifactId> > + <configuration> > + <skip>true</skip> > + </configuration> > + </plugin> > </plugins> > </build> > -</project> > \ No newline at end of file > +</project>

2 1

Re: [xwiki-devs] [xwiki-notifications] r29958 - in platform/core/trunk: . xwiki-chart/xwiki-chart-renderer xwiki-core
by Thomas Mortagne 04 Jul '10

04 Jul '10

On Sat, Jul 3, 2010 at 20:08, vmassol <platform-notifications(a)xwiki.org> wrote: > Author: vmassol > Date: 2010-07-03 20:08:56 +0200 (Sat, 03 Jul 2010) > New Revision: 29958 > > Modified: > platform/core/trunk/pom.xml > platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml > platform/core/trunk/xwiki-core/pom.xml > Log: > XWIKI-867: Move to the latest JFreeChart library version > > * Fixed missing dependency in POM > > Modified: platform/core/trunk/pom.xml > =================================================================== > --- platform/core/trunk/pom.xml 2010-07-03 16:38:29 UTC (rev 29957) > +++ platform/core/trunk/pom.xml 2010-07-03 18:08:56 UTC (rev 29958) > @@ -70,6 +70,13 @@ > <artifactId>jfreechart</artifactId> > <version>1.0.13</version> > </dependency> > +  > + <dependency> > + <groupId>jfree</groupId> > + <artifactId>jcommon</artifactId> > + <version>1.0.15</version> > + </dependency> > </dependencies> > </dependencyManagement> > <build> Thanks, I was wondering why it did not worked when looking at hudson but did not had time to look yet. > > Modified: platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml 2010-07-03 16:38:29 UTC (rev 29957) > +++ platform/core/trunk/xwiki-chart/xwiki-chart-renderer/pom.xml 2010-07-03 18:08:56 UTC (rev 29958) > @@ -41,6 +41,12 @@ > <groupId>jfree</groupId> > <artifactId>jfreechart</artifactId> > </dependency> > +  > + <dependency> > + <groupId>jfree</groupId> > + <artifactId>jcommon</artifactId> > + </dependency> >  > <dependency> > <groupId>org.xwiki.platform</groupId> > > Modified: platform/core/trunk/xwiki-core/pom.xml > =================================================================== > --- platform/core/trunk/xwiki-core/pom.xml 2010-07-03 16:38:29 UTC (rev 29957) > +++ platform/core/trunk/xwiki-core/pom.xml 2010-07-03 18:08:56 UTC (rev 29958) > @@ -134,6 +134,12 @@ > <groupId>jfree</groupId> > <artifactId>jfreechart</artifactId> > </dependency> > +  > + <dependency> > + <groupId>jfree</groupId> > + <artifactId>jcommon</artifactId> > + </dependency> > >  > <dependency> > > _______________________________________________ > notifications mailing list > notifications(a)xwiki.org > http://lists.xwiki.org/mailman/listinfo/notifications > -- Thomas Mortagne

1 0

Re: [xwiki-devs] [xwiki-notifications] r29955 - platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx
by Vincent Massol 03 Jul '10

03 Jul '10

On Jul 3, 2010, at 4:21 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2010-07-03 16:21:17 +0200 (Sat, 03 Jul 2010) > New Revision: 29955 > > Modified: > platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java > Log: > [misc] Improved URL escaping method > > Modified: platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java > =================================================================== > --- platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java 2010-07-03 12:50:27 UTC (rev 29954) > +++ platform/xwiki-plugins/trunk/skinx/src/main/java/com/xpn/xwiki/plugin/skinx/AbstractSkinExtensionPlugin.java 2010-07-03 14:21:17 UTC (rev 29955) > @@ -20,6 +20,8 @@ > > package com.xpn.xwiki.plugin.skinx; > > +import java.io.UnsupportedEncodingException; > +import java.net.URLEncoder; > import java.util.Collections; > import java.util.HashMap; > import java.util.LinkedHashSet; > @@ -27,7 +29,6 @@ > import java.util.Set; > import java.util.Map.Entry; > > -import org.apache.commons.lang.StringUtils; > import org.apache.commons.logging.Log; > import org.apache.commons.logging.LogFactory; > > @@ -307,10 +308,11 @@ > protected String sanitize(String value) > { > String result = value; > - result = StringUtils.replace(result, "\"", "%22"); > - result = StringUtils.replace(result, "'", "%27"); > - result = StringUtils.replace(result, "<", "%3C"); > - result = StringUtils.replace(result, ">", "%3E"); > + try { > + result = URLEncoder.encode(value, "UTF-8"); > + } catch (UnsupportedEncodingException ex) { > + // Should never happen. > + } What if it happens (if the exception is there it means it can happen)? Shouldn't you at least log an error or warning that says the result is left as is without being encoded? Thanks -Vincent

2 4

[xwiki-devs] [VOTE] Remote org.jfree.chart.plot.Plot#setDataAreaRatio call and upgrade to jfreechart 1.0.13
by Thomas Mortagne 03 Jul '10

03 Jul '10

Hi devs, Currently we are using some custom 1.0.0RC1 version of jfreechart and keep using it for only one reason: we are using org.jfree.chart.plot.Plot#setDataAreaRatio API in the old chart plugin and we can't find a proper equivalent (i don't even see what this is doing since it does not change anything in the chart i tried like in statistics). My proposal is to simply remove it so that we can move on. In any case there is a new charting component that should be the one use and which is already built with recent jfreechart API (we are pretty lucky that it simply work in such conditions since we distribute XE with 1.0.0RC1) and if setDataAreaRatio is really related to en important feature it should be supported by the new component if not already done. WDYT ? Here is my +1 -- Thomas Mortagne

5 5

Re: [xwiki-devs] [xwiki-notifications] r29950 - enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui
by Vincent Massol 03 Jul '10

03 Jul '10

Hi Sergiu, On Jul 3, 2010, at 12:56 AM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2010-07-03 00:56:27 +0200 (Sat, 03 Jul 2010) > New Revision: 29950 > > Modified: > enterprise/trunk/distribution-test/ui-tests/src/test/it/org/xwiki/it/ui/EditObjectsTest.java > Log: > [misc] New test: adding an object by clicking the inline "New <class> object" [snip] > + > + @Test > + public void testInlineObjectAddButton() > + { > + ObjectEditPage oep = new ObjectEditPage(); > + oep.switchToEdit("Test", "EditObjectsTestObject"); > + oep.addObject("XWiki.XWikiUsers"); > + > + getDriver().findElement(By.cssSelector("[id='add_xobject_XWiki.XWikiUsers'] .xobject-add-control")).click(); > + Wait<WebDriver> wait = new WebDriverWait(getDriver(), getUtil().getTimeout()); > + wait.until(new ExpectedCondition<Boolean>() > + { > + public Boolean apply(WebDriver driver) > + { > + return Boolean.valueOf(driver.findElements(By.cssSelector("[id='xclass_XWiki.XWikiUsers'] .xobject")) > + .size() == 2); > + } > + }); Isn't this an api missing in Page Objects (what does it do)? Thanks -Vincent

2 2

[xwiki-devs] FAQ sorting
by Sales, G. (Grant) 30 Jun '10

30 Jun '10

http://www.xwiki.org/xwiki/bin/view/FAQ/#Attachments Three Questions. 1) how can I sort my FAQ into these two columns ? 2) Can I see the wiki code for this page? 3) How can I get the Author and Modifier at the bottom of the page like that? Grant Sales Security Operations Analyst ING 20 Washington Ave South Minneapolis, MN 55401 Tel: 612.342.7889 Fax: 612.342.3428 Cell: 320.761.0966 Email: grant.sales(a)us.ing.com www.ing-usa.com ING. Your future. Made easier. (r) --------------------------------------------------------- NOTICE: The information contained in this electronic mail message is confidential and intended only for certain recipients. If you are not an intended recipient, you are hereby notified that any disclosure, reproduction, distribution or other use of this communication and any attachments is strictly prohibited. If you have received this communication in error, please notify the sender by reply transmission and delete the message without copying or disclosing it. ============================================================================================

5 21

[xwiki-devs] [ANN] XWiki Enterprise 2.4 Milestone 2 Released
by Thomas Mortagne 30 Jun '10

30 Jun '10

The XWiki development team is pleased to announce the release of XWiki Enterprise 2.4 Milestone 2. Go grab it at http://www.xwiki.org/xwiki/bin/view/Main/Download This is second and last milestone of the XWiki Enterprise 2.4 version. Main changes from XWiki Enterprise 2.4 Milestone 2: * Objects and classes editor improvements * New Template-based page creation * New Invitation Manager application * New search application improvements * WYSIWYG Improvements * JMX Administration Console * Watchlist improvements * Script improvements * Javascript improvements * Lots of bugs fixes For more information see the Release notes at: http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise24M2 Thanks - The XWiki dev team

1 0

[xwiki-devs] [HELP NEEDED] we urgently need references with more than 1000 users to get XWiki in the Gartner report
by Ludovic Dubost 30 Jun '10

30 Jun '10

Hi XWiki users, We have an urgent request, as we need to be able to make a response TONIGHT (it's not that we did it at the last moment, but that we got the information very late). We would like to have XWiki included in the Gartner "Magic Quadrant for Social Software in the Workplace", which has some tough criterias to get in. The criterias are to have: - at least 100000 users (internal to companies, all deployments included) AND - at least 4 companies with more than 5000 users (internal to companies) willing to talk to Gartner about their usage. While we do have at XWiki SAS companies we work with that we know the deployment size and that we can contact to see if they are willing to talk to Gartner, we do need more. If you have or know of a deployment with more than 1000 users of the Wiki for INTERNAL USAGE (not public web sites), it would be great if you can contact us ASAP at marketing(a)xwiki.com If you have more than 5000 users, please do contact us even more. Even if you are not sure that you can talk to Gartner please do tell us, as we need to answer before tonight if we meet the inclusion criterias. Then there is a follow-up process and we can verify then if talking with Gartner is possible (we would need at least the deployment acknowledged) This is very important for XWiki as in can give a lot of visibility to XWiki and widden the user base thanks to this visibility. Thanks for your help Ludovic Dubost XWiki SAS CEO and XWiki creator -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

1 0

[xwiki-devs] [VOTE] Release XE 2.4M1
by Thomas Mortagne 29 Jun '10

29 Jun '10

Hi devs, We are already a bit late so i would like to release XE 2.4M1, there is only some flickering test remaining plus mostly inline style DWG validation failure. You can see the started release note at http://www.xwiki.org/xwiki/bin/view/Main/ReleaseNotesXWikiEnterprise24M2 WDYT ? -- Thomas Mortagne

2 1