- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [Proposal] Adding a new option for the livetable macro: summary
by Vincent Massol 16 Nov '09

16 Nov '09

Hi, For WCAG we need to add summary attributes to our tables. I'm proposing to allow the user to pass such a summary to the livetable macro through a new option. For ex: [...] #set($options = { "className":"XWiki.XWikiUsers", "translationPrefix" : "xe.index.users.", "tagCloud" : true, "rowCount": 15, "summary: "the summary here" }) #livetable("userstable" $columns $columnsProperties $options) WDYT? ok? Thanks -Vincent

5 5

[xwiki-devs] Protection against Cross-Site Request Forgery?
by Sergiu Dumitriu 15 Nov '09

15 Nov '09

Hi devs, Should XWiki protect itself against CSRF? See http://www.owasp.org/index.php/Cross-Site_Request_Forgery_%28CSRF%29 and http://www.owasp.org/index.php/Cross-Site_Request_Forgery_%28CSRF%29_Preven… for details. In short: an attacker could use something like: <img src="http://xwikiserver/bin/save/Some/Document?content=Hacked"/> to alter the wiki using another user's account. Protection usually involves embedding tokens in submitted forms and URLs. The good news is that it can be done transparently using a LGPL tool from OWASP. The bad news is that it does not protect against attacks from the same wiki, but only for Cross-Site attacks. And it also breaks direct manipulation using URLs (as an expert user, I do enter URLs directly instead of clicking through the interface, and I won't like it if I couldn't do it anymore). So, WDYT? -- Sergiu Dumitriu http://purl.org/net/sergiu/

3 2

[xwiki-devs] configuration issue
by MOUZELER Cyril 14 Nov '09

14 Nov '09

Hi all, I have installed xwiki enterprise manager on Windows in a Jetty Container based on Oracle. It works fine. But i 've got a problem to reach it in my web browser. My Windows server has an IP 10.10.10.10 for example and a name : xwiki-corner.domain.com for example. In my browser, I am not able to access to http://xwiki-corner.domain.com but http://10.10.10.10 works very well. I 've checked nslookup, ping ... this is not the problem: it seems to be a redirect issue... So could you help me ? Cyril -------------------------------------------------------------------------------- This e-mail is intended only for the addressee named above. It does not bind the sender, except in the case of an existing written convention with the addressee. This e-mail may contain material that is confidential and privileged for the sole use of the intended recipient. Any review, reliance or distribution by others or forwarding without express permission is strictly prohibited and may be unlawful. If you are not the intended recipient, please contact the sender and delete all copies. While reasonable precautions have been taken to ensure that this e-mail and any attachments are free from any computer virus or similar defect, no liability will be accepted in that respect. Anyone accessing this e-mail must take their own precautions as to security and virus protection. KBL European Private Bankers S.A., 43 boulevard Royal L-2955 Luxembourg, R.C.S. Luxembourg B 6395, T (352) 47 97 1

3 2

Re: [xwiki-devs] [xwiki-notifications] r25059 - in platform: core/trunk/xwiki-core/src/main/resources web/trunk/standard/src/main/webapp/templates
by Vincent Massol 14 Nov '09

14 Nov '09

On Nov 14, 2009, at 2:53 PM, Jerome Velociter wrote: > On 11/14/09 2:52 PM, Jerome Velociter wrote: >> On 11/13/09 5:19 PM, vmassol (SVN) wrote: >>> Author: vmassol >>> Date: 2009-11-13 17:19:01 +0100 (Fri, 13 Nov 2009) >>> New Revision: 25059 >>> >>> Modified: >>> platform/core/trunk/xwiki-core/src/main/resources/ >>> ApplicationResources.properties >>> platform/web/trunk/standard/src/main/webapp/templates/macros.vm >>> Log: >>> XWIKI-4588: Associate labels with livetable filter inputs and >>> improve livetable title attributes >>> >>> * TODO: add labels for lists too >>> >>> Modified: platform/core/trunk/xwiki-core/src/main/resources/ >>> ApplicationResources.properties >>> =================================================================== >>> --- platform/core/trunk/xwiki-core/src/main/resources/ >>> ApplicationResources.properties 2009-11-13 16:18:12 UTC (rev 25058) >>> +++ platform/core/trunk/xwiki-core/src/main/resources/ >>> ApplicationResources.properties 2009-11-13 16:19:01 UTC (rev 25059) >>> @@ -1843,7 +1843,7 @@ >>> xe.livetable._actions.rename=rename >>> xe.livetable._actions.rights=rights >>> xe.livetable._actions.copy=copy >>> -xe.livetable.filters.title=Enter a filter for this field >>> +xe.livetable.filters.title=Filter for the {0} column >>> xe.livetable.loading=Loading... >>> xe.livetable.tags.help=Click on one or more tags to filter the >>> list >>> xe.livetable.tags.help.cancel=and click again on a tag to cancel >>> the filter >>> >>> Modified: platform/web/trunk/standard/src/main/webapp/templates/ >>> macros.vm >>> =================================================================== >>> --- platform/web/trunk/standard/src/main/webapp/templates/ >>> macros.vm 2009-11-13 16:18:12 UTC (rev 25058) >>> +++ platform/web/trunk/standard/src/main/webapp/templates/ >>> macros.vm 2009-11-13 16:19:01 UTC (rev 25059) >>> @@ -1564,6 +1564,11 @@ >>> <tr> >>> #foreach($colname in $collist) >>> #set($colprop = $colprops.get($colname)) >>> + #if(("$!colprop.filterable" == "" || >>> $colprop.filterable != false)&& "$!colname" != "_actions") >>> + #set($isFilterable = true) >>> + #else >>> + #set($isFilterable = false) >>> + #end >>> #if(("$!colprop.sortable" == "" || >>> $colprop.sortable != false)&& "$!colname" != "_actions") >>> #set($isSortable = true) >>> #else >>> @@ -1572,7 +1577,9 @@ >>> #if($colname != "_actions" || $hasAdmin) >>> <th class="xwiki-livetable-display-header-text >>> #if($isSortable)sortable #if($colname == $selectedColumn)selected >>> $defaultOrder#else asc#end#end" #if("$!colprop.type"=="hidden") >>> style="display: none" #end> >>> #if($isSortable)<a rel="${colname}">#end >>> + #if($isFilterable&& ("$! >>> colprop.type"=="text"||"$!colprop.type"=="number"))<label >>> for="xwiki-livetable-filter-${velocityCount}">#end >> >> With this, we'll have ID collision if several live tables are >> displayed >> on the page. >> >> You need to add the table identifier (passed as a parameter of the >> macro >> AFAIR) in the field ID. > > Sorry for the noise, just seen you've fixed it already. Yep :) Thanks for checking! -Vincent >> Jerome. >>> $msg.get("${transprefix}${colname}") >>> + #if($isFilterable)</label>#end >>> #if($isSortable)</a>#end >>> </th> >>> #end >>> @@ -1604,7 +1611,7 @@ >>> </select> >>> </td> >>> #elseif( ("$!colprop.type"=="text"||"$! >>> colprop.type"=="number")&& $isFilterable) >>> -<td class="xwiki-livetable-display-header-filter"><input name="$ >>> {colname}" type="text" #if("!$colprop.size"!="") size="$ >>> {colprop.size}" #end >>> title="$msg.get('xe.livetable.filters.title')" /></td> >>> +<td class="xwiki-livetable-display-header-filter"><input >>> id="xwiki-livetable-filter-${velocityCount}" name="${colname}" >>> type="text" #if("!$colprop.size"!="") size="${colprop.size}" >>> title="$msg.get('xe.livetable.filters.title', [$msg.get("$ >>> {transprefix}${colname}")])"#end /></td> >>> #elseif("$!colprop.type"=="hidden") >>> #elseif($colname != "_actions" || $hasAdmin) >>> <td class="xwiki-livetable-display-header- >>> filter"></td>

1 0

[xwiki-devs] More xwiki macro parameter type. boolean, enumeration?
by Zhaolin Feng 14 Nov '09

14 Nov '09

I'm learning to implement a macro for Lightbox Application as suggested by Guillaume. So far I've read: http://platform.xwiki.org/xwiki/bin/view/DevGuide/WritingMacros And I have a question. Is it possible to have other macro parameter types besides string? For examples, boolean, enumeration, filename, image, color. And it's even better to have color picker, image picker dialog automatically popped up when clicking. I see the HTML macro have boolean parameters. How is it achieved? Is is possible to reuse the image picker of the WYSIWYG editor? -- -- Currahee! We stand alone together!

2 3

[xwiki-devs] [Idea] Post-loaded JSX
by Jerome Velociter 14 Nov '09

14 Nov '09

Hello all, I think it would be nice to have the possibility to post-load some of the JavaScript extensions, as a way to ease performance best practices for developers. (See http://developer.yahoo.com/performance/rules.html#postload for example). It would also allow people to easily add hungry third party scripts (like the google analytics tracker) in a non intrusive manner and not sacrificing performance (no need to modify/override htmlfooter.vm for example, a simple SX always-use will do). I see different ways of doing that : 1) Either we say all document JSX are post-loaded, and we move the hook down the DOM just before the closing </body> tag. 2) Either we have 2 hooks and we leave it as an option to be post-loaded. My preference goes to 1), as I don't see any good use case where a extension would need not to be post-loaded; and 2) is not so elegant to implement with the current SX mecanism. WDYT ? (Note: I'm not talking about file-system extensions here (JSFX), though the question could be asked for them as well - I need to give it more thoughts) Jerome.

6 15

[xwiki-devs] WCAG 1.0 status + Need help
by Vincent Massol 14 Nov '09

14 Nov '09

Hi, Here's a status of the past few days I have spent looking at fixing our pages so that we pass the WCAG 1.0 tests (the automated part of it). * I've fixed the home page so no more issues in it * I've tested the other pages using http://www.tawdis.net/ingles.html?lang=en and here's the results: - priority 1: only 2 issues - priority 2: about 162 * 7 = 1134 issues - priority 3: about 120 issues That's quite a lot but they are easy to fix. Most of them are about: - tables missing summary attributes - associate labels with <input> (using a <for>) In order to reproduce it's very easy. Use this link to run TAW: http://www.tawdis.net/taw3/descargas/jws/es/taw3.jnlp Then run XE locally and feed it to TAW. I need help to fix all these remaining issues. Who can help me? Thanks -Vincent Note that the Dutch guidelines add a bit more to WCAG 1.0 but not much and passing WCAG is already a good first step.

2 4

[xwiki-devs] Using Lightbox Application with syntax 2.0 page
by Zhaolin Feng 14 Nov '09

14 Nov '09

I'm trying to use http://code.xwiki.org/xwiki/bin/view/Applications/LightboxApplication, but encountered an issue with the WYSIWYG editor. When I input the following code in the SOURCE mode and afterward switch to WYSIWYG mode and then switch back, some garbage is appended at the end. {{velocity output="false"}} $xwiki.jsfx.use("js/scriptaculous/scriptaculous.js") $xwiki.ssx.use("XWiki.Lightbox") $xwiki.jsx.use("XWiki.Lightbox") {{/velocity}} Switching back to SOURCE mode, it becomes: {{velocity output="false"}} $xwiki.jsfx.use("js/scriptaculous/scriptaculous.js") $xwiki.ssx.use("XWiki.Lightbox") $xwiki.jsx.use("XWiki.Lightbox") {{/velocity}} (% id="overlay" style="display: none;" %) ((( ))) (% id="lightbox" style="display: none;" %) ((( (% id="outerImageContainer" style="width: 250px; height: 250px;" %) ((( (% id="imageContainer" %) ((( (% id="hoverNav" %) ((( [[#||id="prevLink"]][[#||id="nextLink"]] ))) (% id="loading" %) ((( [[image:/xwiki/bin/download/XWiki/Lightbox/loading.gif]][[#||id="loadingLink"]] ))) ))) ))) (% id="imageDataContainer" %) ((( (% id="imageData" %) ((( (% id="imageDetails" %) ((( ))) (% id="bottomNav" %) ((( [[image:/xwiki/bin/download/XWiki/Lightbox/closelabel.gif]][[#||id="bottomNavClose"]] ))) ))) ))) ))) Question1 : Do you have any idea how to fix it? Question2 : A suggestion. Lightbox is really a great extension. So I think the standard [[image:picture.png||width="25" height="25"]] should do something similar. WDYT? -- -- Currahee! We stand alone together!

3 6

[xwiki-devs] [VOTE] Introduce new "accessibility" CSS class for skins
by Vincent Massol 13 Nov '09

13 Nov '09

Hi, While working on WCAG we've found that we need to hide some content so that it's not displayed visually but it's used by assistive devices (such as a web browser reader). For example for label texts in compact forms (where we put the label inside the field -e.g. the search box). Another example are "skip content" and "got to top" features. Thus I'd like to propose adding a new public CSS class called "accessibility": .accessibility { display: none } We need a vote since it's public and would be used for example in the form located in Main.Spaces. This means that all skins (ours or custom skins done by users) must have it (or the label will be displayed). WDYT? Here's my +1 Thanks -Vincent PS: BTW this raises the question of public vs non public CSS classes. Do we have a list somewhere? If not shouldn't we have one to let skin authors know what class must absolutely exist and also to ensure we don't use non public classes in document content or in templates (non skin templates)?

5 9

[xwiki-devs] Proposal to redesign code.xwiki.org
by Ludovic Dubost 13 Nov '09

13 Nov '09

Hi, I started working on a proposal to redesign code.xwiki.org http://dev.xwiki.org/xwiki/bin/view/Drafts/XWikiExtensionRepositoryRedesign Please comment and/or modify this document. The main thing would be to agree that there should be one "unique" repository for anything related to XWiki. If we agree on that, I would like to start a vote for the name. The name could be I think any combination of a "prefix" or "suffix" or a magical unrelated name. * Possible Prefix o Add-On o Extension o App o Store o Modules o Plugins * Possible Suffix o Directory o Repository o Store o Catalog I believe we should make this not feel "technical" but understandable by non technical users. Any other ideas of prefixes or suffixes or other names before we start a vote ? Ludovic -- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost

8 8