- xwiki-devs@xwiki.org - lists.xwiki.org

[xwiki-devs] [VOTE] Create a criteriaService
by Jean-Vincent Drean 07 Mar '08

07 Mar '08

Hi, I'd like to commit a new service : criteriaService [1]. This service, both available from java and velocity, allow to get various criteria (most of them extracted from the statistics plugin) : - Duration, a length of time - Period, a length of time defined by a min date and a max date - Range (formerly named Interval), an integer range (also allow to sublist a list according to the range) - RevisionCriteria, criteria to match document revisions (author, min date, max date, minor edits) - Scope, define an xwiki scope (page, space, wiki) Since 4 of those objects are from the statistics I've refactored the plugin and the application. Modifications in the public APIs : duration,period,range and scope factories won't be available from the statsService anymore since they have moved to criteriaService. Please shout if you're using any of those methods from velocity : - $xwiki.getStatsService().getDurationFactory() - $xwiki.getStatsService().getPeriodFactory() - $xwiki.getStatsService().getIntervalFactory() - $xwiki.getStatsService().getScopeFactory() Additions : - Document.getRevisions(RevisionCriteria), allowing to get document revisions matching the criteria - ListTool added to the rendering velocity context ($listtool) First use case, in the watchlist plugin the diffs sent by email will contain all the revisions since the last email notification (was : a diff between the last 2 revisions) [2]. [1] http://jira.xwiki.org/jira/browse/XWIKI-2159 [2] http://jira.xwiki.org/jira/browse/XPWATCHLIST-15 JV.

5 5

[xwiki-devs] Component Based Architecture (help)
by Asiri Rathnayake 07 Mar '08

07 Mar '08

Hi Devs, Where can i find more details about the Component Based Architecture of XWiki ? I need as much information as possible. Sorry if the source of information is obvious, i couldn't do much search coz my machine is almost stuck running a neural network training algorithm (for my final year project) Thanks a lot. - Asiri

1 1

[xwiki-devs] [VOTE] XE 1.3 release + dependent modules
by Vincent Massol 07 Mar '08

07 Mar '08

Hi, I'm planning the release 1.3 tomorrow with the following module releases: * Albatross Skin 1.4 * Toucan Skin 1.2 * Watchlist 1.3 * Core+Web+XE 1.3 Here's my +1 Thanks -Vincent

7 6

[xwiki-devs] Why are certain Plugin classes final
by Sachin Mittal 07 Mar '08

07 Mar '08

Hi, I was in a dire need to extended on of the xwiki plugin classes MailSenderPlugin because xwiki implementation does not handle the password authentication to smtp servers that require one. I was unable to do so because the said class is declared final. My only option is to modify the xwiki code itself to make the desired change, but I certainly want to avoid this as I want to use only xwiki binaries to take advantage of future functionality implementation and bug fixes in by xwiki team. So is there any specific reason why these classes were defined as final? Is there anyway I can add such functionalities to xwki plugins without modifying the xwiki source. Thanks Sachin ----- http://www.assembla.com/wiki/show/sachin_mittal about me: -- View this message in context: http://www.nabble.com/Why-are-certain-Plugin-classes-final-tp15891099p15891… Sent from the XWiki- Dev mailing list archive at Nabble.com.

1 0

[xwiki-devs] [ANN] DocHour day!
by Vincent Massol 07 Mar '08

07 Mar '08

Here's the new concept: as much people as possible in the XWiki community must spend 1 hour on Wednesday, 5th of March 2008 (today, sorry for the late announcement) and write documentation for 1 hour on xwiki.org. This is an effort to improve the quality and content of our documentation. Rules: * 1 hour * You choose at what time you want to work on the documentation. However most of us will be starting at 14:00 GMT+1. * On xwiki.org * You choose to document what you want. Ideas of missing documentation: - In JIRA: http://tinyurl.com/3xtn8t - Improve existing documentation - XWiki Watch documentation on http://watch.xwiki.org - XEM Documentation on http://manager.xwiki.org * Make sure you create a jira issue for the work you're doing and assign to yourself. The issue should be created in the XWiki Core project, with a "documentation" component. * If you can't do it on the 5th, then you can still do it on another day, as close as possible to the 5th of March ;) * The idea is to repeat this event every month or every 2 months. Thanks everyone, let's see what we can do with the power of the community! :) -Vincent

2 5

[xwiki-devs] [VOTE] Move XWiki.getFlash()/flash.vm in a flash macro in macros.vm
by Vincent Massol 06 Mar '08

06 Mar '08

Hi, I've just seen that we have a XWiki.getFlash() method which just renders a flash.vm template which simply output an <object classid=...> to display a flash animation. This has nothing to do in the core proper IMO. I propose to move this in the macro.vm as a #flash macro. WDYT? Here's my +1 Thanks -Vincent

4 3

[xwiki-devs] [vote] removing the LinkMacro
by Stéphane Laurière 06 Mar '08

06 Mar '08

Hi everyone, During the documentation hour today [1] we noticed that the LinkMacro coming from Radeox is actually not useful: it's entirely available from standard XWiki links (possibly with images additionally). Hence I propose that: 1) we disable it (and even remove it from our custom Radeox) 2) we close as "won't fix" JIRA#XWIKI-1481 Here's my +1 for both [1] http://intranet.xpertnet.biz/xwiki/bin/view/Tech/DocHour20080305 Stéphane -- Stéphane Laurière slauriere(a)xwiki.com XWiki http://www.xwiki.com http://concerto.xwiki.com http://nepomuk.semanticdesktop.org

4 5

Re: [xwiki-devs] [xwiki-notifications] r8200 - in xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki: . web
by Vincent Massol 06 Mar '08

06 Mar '08

Hi Sergiu, First let me say this is cool! :) Some minor comments below. On Mar 4, 2008, at 10:55 PM, sdumitriu (SVN) wrote: > Author: sdumitriu > Date: 2008-03-04 22:55:30 +0100 (Tue, 04 Mar 2008) > New Revision: 8200 > > Modified: > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java > xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > web/XWikiAction.java > Log: > XWIKI-1522: Rewrite the notification mechanism > Notifications are sent > > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/XWiki.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-03-04 18:33:04 UTC (rev 8199) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > XWiki.java 2008-03-04 21:55:30 UTC (rev 8200) > @@ -76,6 +76,11 @@ > import org.exoplatform.container.RootContainer; > import org.hibernate.HibernateException; > import org.securityfilter.filter.URLPatternMatcher; > +import org.xwiki.observation.ObservationManager; > +import org.xwiki.observation.event.ActionExecutionEvent; > +import org.xwiki.observation.event.DocumentDeleteEvent; > +import org.xwiki.observation.event.DocumentSaveEvent; > +import org.xwiki.observation.event.DocumentUpdateEvent; > > import com.xpn.xwiki.api.Api; > import com.xpn.xwiki.api.Document; > @@ -1070,14 +1075,37 @@ > XWikiDocument originalDocument = doc.getOriginalDocument(); > > // Notify listeners about the document change > - getNotificationManager().preverify(doc, originalDocument, > - XWikiDocChangeNotificationInterface.EVENT_CHANGE, > context); > + if (originalDocument == null || > originalDocument.isNew()) { > + getNotificationManager().preverify(doc, > originalDocument, > + XWikiDocChangeNotificationInterface.EVENT_NEW, > context); > + } else { > + getNotificationManager().preverify(doc, > originalDocument, > + > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + } > > getStore().saveXWikiDoc(doc, context); > > - // Notify listeners about the document change > - getNotificationManager().verify(doc, originalDocument, > - XWikiDocChangeNotificationInterface.EVENT_CHANGE, > context); > + try { > + ObservationManager om = > + (ObservationManager) > Utils.getComponent(ObservationManager.ROLE, null, > + context); > + // Notify listeners about the document change > + if (originalDocument == null || > originalDocument.isNew()) { > + getNotificationManager().verify(doc, > originalDocument, > + > XWikiDocChangeNotificationInterface.EVENT_NEW, context); > + if (om != null) { > + om.notify(new > DocumentSaveEvent(doc.getFullName()), doc, context); > + } It seems you're using both notification mechanisms, which is fine but I think this warrants some javadoc explanations. > > + } else { > + getNotificationManager().verify(doc, > originalDocument, > + > XWikiDocChangeNotificationInterface.EVENT_CHANGE, context); > + if (om != null) { > + om.notify(new > DocumentUpdateEvent(doc.getFullName()), doc, context); > + } > + } > + } catch (Exception ex) { > + LOG.warn("Failed to send document notifications", > ex); Our rule is: no stack trace printing for warnings. Only for errors. I would consider this an error. Also I would put more information in the text like for what document it failed. > + } > } finally { > if ((server != null) && (database != null)) { > context.setDatabase(database); > @@ -3406,8 +3434,16 @@ > true); > } > getStore().deleteXWikiDoc(doc, context); > - getNotificationManager().verify(new > XWikiDocument(doc.getSpace(), doc.getName()), doc, > - XWikiDocChangeNotificationInterface.EVENT_CHANGE, > context); > + try { > + getNotificationManager().verify(new > XWikiDocument(doc.getSpace(), doc.getName()), doc, > + XWikiDocChangeNotificationInterface.EVENT_DELETE, > context); > + ObservationManager om = > + (ObservationManager) > Utils.getComponent(ObservationManager.ROLE, null, > + context); > + om.notify(new DocumentDeleteEvent(doc.getFullName()), > doc, context); > + } catch (Exception ex) { > + LOG.warn("Failed to send document notifications", ex); > + } Same comments here. > > } > > public String getDatabase() > > Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/ > xwiki/web/XWikiAction.java > =================================================================== > --- xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > web/XWikiAction.java 2008-03-04 18:33:04 UTC (rev 8199) > +++ xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ > web/XWikiAction.java 2008-03-04 21:55:30 UTC (rev 8200) > @@ -35,6 +35,8 @@ > import org.apache.struts.action.ActionForward; > import org.apache.struts.action.ActionMapping; > import org.apache.velocity.VelocityContext; > +import org.xwiki.observation.ObservationManager; > +import org.xwiki.observation.event.ActionExecutionEvent; > > import com.xpn.xwiki.XWiki; > import com.xpn.xwiki.XWikiContext; > @@ -284,6 +286,14 @@ > } catch (Throwable e) { > e.printStackTrace(); > } > + try { > + ObservationManager om = > + (ObservationManager) > Utils.getComponent(ObservationManager.ROLE, null, > + context); > + om.notify(new > ActionExecutionEvent(mapping.getName()), context.getDoc(), context); > + } catch (Throwable ex) { > + LOG.warn("Cannot send notifications", ex); Same here too. > > + } > > if (monitor != null) { > monitor.endTimer("notify"); Thanks -Vincent

2 1

[xwiki-devs] bypass hasProgrammingRights()
by Raffaele Viola 05 Mar '08

05 Mar '08

Hi all, how can I bypass hasProgrammingRights() in the mathod getDocument() of the class com.xpn.xwiki.api.Document ? Thanks raffo

2 1

[xwiki-devs] Moving to continuum 1.1
by Vincent Massol 05 Mar '08

05 Mar '08

Hi, I'm moving our CI build to continuum today. More precisely: * I've modified the TC build so that it does only "mvn clean install" instead of "mvn clean deploy". I've left the site deployment for now though. I've also removed the email notifications. * I've modified our continuum instance to do "mvn clean deploy". I'm going to work today on stabilizing the build to ensure all is ok and when this is the case I'll add the email notifications. http://continuum.xwiki.org/continuum/projectGroupSummary.action?projectGrou… Thanks -Vincent

1 0