[xwiki-devs] [VOTE] Move wiki macro instantiation code into xwiki-core
Hi Devs, This is about the wiki-macro-bridge. According to our previous discussion, I was going to put document listening, macro creation and macro registration logic into xwiki-core-rendering-macro-wikibridge module. But as it seems the macro creation part is going to be highly dependant on bridges (DAB) and would require a couple of more methods on DAB. Since DAB is becomming heavy and poluted, I'm proposing that we split the wikimacrobridge as follows: * Keep document listening, macro registration and macro de-registration logic inside xwiki-core-rendering-macro-wikibridge module as it is. * Differ the macro instantiation logic into some component interface (WikiMacroGenerator). * Have the default WikiMacroGenerator in xwiki-core. (perhaps inside com.xpn.xwiki.doc? any other place?) Here is my +1. Thanks. - Asiri
Asiri Rathnayake a écrit :
Hi Devs,
This is about the wiki-macro-bridge. According to our previous discussion, I was going to put document listening, macro creation and macro registration logic into xwiki-core-rendering-macro-wikibridge module. But as it seems the macro creation part is going to be highly dependant on bridges (DAB) and would require a couple of more methods on DAB. Since DAB is becomming heavy and poluted, I'm proposing that we split the wikimacrobridge as follows:
* Keep document listening, macro registration and macro de-registration logic inside xwiki-core-rendering-macro-wikibridge module as it is.
* Differ the macro instantiation logic into some component interface (WikiMacroGenerator).
* Have the default WikiMacroGenerator in xwiki-core. (perhaps inside com.xpn.xwiki.doc? any other place?)
Here is my +1.
+1
Thanks.
- Asiri _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
+1 On Tue, Jul 7, 2009 at 15:57, Asiri Rathnayake<asiri.rathnayake@gmail.com> wrote:
Hi Devs,
This is about the wiki-macro-bridge. According to our previous discussion, I was going to put document listening, macro creation and macro registration logic into xwiki-core-rendering-macro-wikibridge module. But as it seems the macro creation part is going to be highly dependant on bridges (DAB) and would require a couple of more methods on DAB. Since DAB is becomming heavy and poluted, I'm proposing that we split the wikimacrobridge as follows:
* Keep document listening, macro registration and macro de-registration logic inside xwiki-core-rendering-macro-wikibridge module as it is.
* Differ the macro instantiation logic into some component interface (WikiMacroGenerator).
* Have the default WikiMacroGenerator in xwiki-core. (perhaps inside com.xpn.xwiki.doc? any other place?)
Here is my +1.
Thanks.
- Asiri _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+0 Thanks, Marius Asiri Rathnayake wrote:
Hi Devs,
This is about the wiki-macro-bridge. According to our previous discussion, I was going to put document listening, macro creation and macro registration logic into xwiki-core-rendering-macro-wikibridge module. But as it seems the macro creation part is going to be highly dependant on bridges (DAB) and would require a couple of more methods on DAB. Since DAB is becomming heavy and poluted, I'm proposing that we split the wikimacrobridge as follows:
* Keep document listening, macro registration and macro de-registration logic inside xwiki-core-rendering-macro-wikibridge module as it is.
* Differ the macro instantiation logic into some component interface (WikiMacroGenerator).
* Have the default WikiMacroGenerator in xwiki-core. (perhaps inside com.xpn.xwiki.doc? any other place?)
Here is my +1.
Thanks.
- Asiri _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Asiri Rathnayake wrote:
Hi Devs,
This is about the wiki-macro-bridge. According to our previous discussion, I was going to put document listening, macro creation and macro registration logic into xwiki-core-rendering-macro-wikibridge module. But as it seems the macro creation part is going to be highly dependant on bridges (DAB) and would require a couple of more methods on DAB. Since DAB is becomming heavy and poluted, I'm proposing that we split the wikimacrobridge as follows:
* Keep document listening, macro registration and macro de-registration logic inside xwiki-core-rendering-macro-wikibridge module as it is.
* Differ the macro instantiation logic into some component interface (WikiMacroGenerator).
What about WikiMacroBuilder ?
* Have the default WikiMacroGenerator in xwiki-core. (perhaps inside com.xpn.xwiki.doc? any other place?)
Here is my +1.
+1 Jerome
Thanks.
- Asiri _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Wed, Jul 8, 2009 at 10:41 AM, Jerome Velociter <jerome@xwiki.com> wrote:
Asiri Rathnayake wrote:
Hi Devs,
This is about the wiki-macro-bridge. According to our previous discussion, I was going to put document listening, macro creation and macro registration logic into xwiki-core-rendering-macro-wikibridge module. But as it seems the macro creation part is going to be highly dependant on bridges (DAB) and would require a couple of more methods on DAB. Since DAB is becomming heavy and poluted, I'm proposing that we split the wikimacrobridge as follows:
* Keep document listening, macro registration and macro de-registration logic inside xwiki-core-rendering-macro-wikibridge module as it is.
* Differ the macro instantiation logic into some component interface (WikiMacroGenerator).
What about WikiMacroBuilder ?
Yes, sounds better. Thanks. - Asiri
participants (5)
-
Asiri Rathnayake -
Jerome Velociter -
Ludovic Dubost -
Marius Dumitru Florea -
Thomas Mortagne