[xwiki-devs] XWiki.CopyDocument and copy.vm
Hi devs, I just noticed that we have two forms for copying a document: Space/Page?xpage=copy and XWiki/CopyDocument?sourcedoc=Space.Page copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy. Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages). I'd like to do this asap. Thanks, Marius
+1 Jerome On Sat, Mar 5, 2011 at 10:51 AM, Marius Dumitru Florea <mariusdumitru.florea@xwiki.com> wrote:
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
Thanks, Marius _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Currently if I'm correct copy.vm cannot copy because it requires programming rights. If this issue has not been fixed, I suggest that at the same time we make a "copy" implementation that does not need programming rights on the source document. A clean copy implementation needs to verify: Read access on the source Write access at the target Ludovic Le 05/03/11 10:51, Marius Dumitru Florea a écrit :
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
Thanks, Marius _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
On 03/05/2011 12:10 PM, Ludovic Dubost wrote:
Currently if I'm correct copy.vm cannot copy because it requires programming rights. If this issue has not been fixed, I suggest that at the same time we make a "copy" implementation that does not need programming rights on the source document. A clean copy implementation needs to verify:
Read access on the source Write access at the target
I already fix this in http://jira.xwiki.org/jira/browse/XWIKI-3961 . Thanks, Marius
Ludovic
Le 05/03/11 10:51, Marius Dumitru Florea a écrit :
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
Thanks, Marius _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Great. +1 to get rid of CopyDocument Ludovic Le 05/03/11 11:36, Marius Dumitru Florea a écrit :
On 03/05/2011 12:10 PM, Ludovic Dubost wrote:
Currently if I'm correct copy.vm cannot copy because it requires programming rights. If this issue has not been fixed, I suggest that at the same time we make a "copy" implementation that does not need programming rights on the source document. A clean copy implementation needs to verify:
Read access on the source Write access at the target I already fix this in http://jira.xwiki.org/jira/browse/XWIKI-3961 .
Thanks, Marius
Ludovic
Le 05/03/11 10:51, Marius Dumitru Florea a écrit :
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
Thanks, Marius _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Ludovic Dubost Blog: http://blog.ludovic.org/ XWiki: http://www.xwiki.com Skype: ldubost GTalk: ldubost
On 03/05/2011 10:51 AM, Marius Dumitru Florea wrote:
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
http://jira.xwiki.org/jira/browse/XWIKI-5932 +1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 On Sat, Mar 5, 2011 at 10:51, Marius Dumitru Florea <mariusdumitru.florea@xwiki.com> wrote:
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
Thanks, Marius _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 Thanks. On Sat, Mar 5, 2011 at 19:08, Thomas Mortagne <thomas.mortagne@xwiki.com>wrote:
+1
On Sat, Mar 5, 2011 at 10:51, Marius Dumitru Florea <mariusdumitru.florea@xwiki.com> wrote:
Hi devs,
I just noticed that we have two forms for copying a document:
Space/Page?xpage=copy
and
XWiki/CopyDocument?sourcedoc=Space.Page
copy.vm has been recently updated to follow the vertical form layout standard and its code was also cleaned. XWiki.CopyDocument wasn't updated and I find its code a bit buggy.
Maintaining both of them is wrong so I propose to remove XWiki.CopyDocument from the XE xar and update LiveTableResultsMacros to use xpage=copy for the copy link in the action column (I couldn't find any other usages).
I'd like to do this asap.
Thanks, Marius _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
participants (6)
-
Denis Gervalle -
Jerome Velociter -
Ludovic Dubost -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne