On May 20, 2008, at 11:27 AM, Sergiu Dumitriu wrote:

vmassol (SVN) wrote:

...

Author: vmassol Date: 2008-05-19 09:08:08 +0200 (Mon, 19 May 2008) New Revision: 9854

Modified: xwiki-platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ xmlrpc/XWikiXmlRpcHandler.java Log: * Replaced log.info with log.debug calls since we only want to print in the console when there are problems or for very important information (such as the XWiki version) in order not to "pollute" the output. * Fixed some copy paste errors ;)

None of the error messages uses [] around parameters; I thought that was a convention for XWiki...

It is. Fabio could you please fix them?

...

@@ -287,7 +289,7 @@ if (!xwiki.getSpaces().contains(spaceKey)) { throw new XmlRpcException(String.format("[Space '%s' does not exist.]", spaceKey)); [what's with the brackets?]

Same.

...

@@ -345,7 +347,7 @@ String pageFullName = String.format("%s.%s", spaceKey, pageName);

if (!xwiki.exists(pageFullName)) { - log.warn(String.format( + LOG.warn(String.format( "[Page '%s' appears to be in space '%s' but no information is available.]", pageName)); } else {

This will throw an exception, since it expects 2 arguments instead of 1.

Fabio? Thanks -Vincent PS: Sergiu, this is not code I wrote. I just fixed one aspect of the code which was the usage of info instead of debug for the logs.