[xwiki-devs] [Proposal] Behaviour change when restoring a document regarding its history
Hi devs, I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document. We used to add a revision with a comment text of "Restored from recycle bin”. After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document. We need to decide if that’s what we want. Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document. WDYT? Personally I think this could be acceptable but I’m not sure. Thanks -Vincent
On 5 Feb 2016 at 14:06:23, vincent@massol.net (vincent@massol.net(mailto:vincent@massol.net)) wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
Thomas just told me that in practice this behavior was there prior to XWIKI-9960 (possibly done a long time ago) and that XWIKI-9960 has just fixed the issue for documents *with* attachments, so that all documents now work the same. It’s possible that this change was done involuntarily as a side effect of other issues we fixed (when playing with doc meta data dirty and content dirty flags). So while this is not a regression for 7.4.1/8.0M1, it would still be interesting to confirm here if that’s the behavior we want. WDYT? Thanks -Vincent
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent
Can't we just keep the version, but change/overwrite the comment text to "Restored from recycle bin"? On Fri, Feb 5, 2016 at 3:17 PM, vincent@massol.net <vincent@massol.net> wrote:
On 5 Feb 2016 at 14:06:23, vincent@massol.net (vincent@massol.net(mailto: vincent@massol.net)) wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
Thomas just told me that in practice this behavior was there prior to XWIKI-9960 (possibly done a long time ago) and that XWIKI-9960 has just fixed the issue for documents *with* attachments, so that all documents now work the same.
It’s possible that this change was done involuntarily as a side effect of other issues we fixed (when playing with doc meta data dirty and content dirty flags).
So while this is not a regression for 7.4.1/8.0M1, it would still be interesting to confirm here if that’s the behavior we want.
WDYT?
Thanks -Vincent
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent
devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On 5 Feb 2016 at 14:27:11, Ecaterina Moraru (Valica) (valicac@gmail.com(mailto:valicac@gmail.com)) wrote:
Can't we just keep the version, but change/overwrite the comment text to "Restored from recycle bin”?
Ah no I’d be -1 for that. You’d loose the comment for whoever did the previous change. Thanks -Vincent
On Fri, Feb 5, 2016 at 3:17 PM, vincent@massol.net wrote:
On 5 Feb 2016 at 14:06:23, vincent@massol.net (vincent@massol.net(mailto: vincent@massol.net)) wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
Thomas just told me that in practice this behavior was there prior to XWIKI-9960 (possibly done a long time ago) and that XWIKI-9960 has just fixed the issue for documents *with* attachments, so that all documents now work the same.
It’s possible that this change was done involuntarily as a side effect of other issues we fixed (when playing with doc meta data dirty and content dirty flags).
So while this is not a regression for 7.4.1/8.0M1, it would still be interesting to confirm here if that’s the behavior we want.
WDYT?
Thanks -Vincent
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent
On my side it's: +1 for getting the exact thing you deleted (so no extra version, the behavior we have in 8.0-SNASHOT basically) +0 for the extra version since I'm not strongly against it On Fri, Feb 5, 2016 at 2:17 PM, vincent@massol.net <vincent@massol.net> wrote:
On 5 Feb 2016 at 14:06:23, vincent@massol.net (vincent@massol.net(mailto:vincent@massol.net)) wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
Thomas just told me that in practice this behavior was there prior to XWIKI-9960 (possibly done a long time ago) and that XWIKI-9960 has just fixed the issue for documents *with* attachments, so that all documents now work the same.
It’s possible that this change was done involuntarily as a side effect of other issues we fixed (when playing with doc meta data dirty and content dirty flags).
So while this is not a regression for 7.4.1/8.0M1, it would still be interesting to confirm here if that’s the behavior we want.
WDYT?
Thanks -Vincent
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent
devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Fri, Feb 5, 2016 at 3:06 PM, vincent@massol.net <vincent@massol.net> wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
"Alice has deleted this page" and "Bob has restored this page from recycle bin" are *activity stream* events more than history entries (versions). There's no need to be able to revert, compare or blame such a "version". There may be other page actions like this too, that should appear in the activity stream (for a page) but that don't necessarily generate a new version in the history. So we could imagine having another "Activity Stream" tab/viewer besides History, or a unified History viewer that shows both activity stream events and page versions.
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Tue, Mar 1, 2016 at 6:09 PM, Marius Dumitru Florea <mariusdumitru.florea@xwiki.com> wrote:
On Fri, Feb 5, 2016 at 3:06 PM, vincent@massol.net <vincent@massol.net> wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
"Alice has deleted this page" and "Bob has restored this page from recycle bin" are *activity stream* events more than history entries (versions). There's no need to be able to revert, compare or blame such a "version". There may be other page actions like this too, that should appear in the activity stream (for a page) but that don't necessarily generate a new version in the history. So we could imagine having another "Activity Stream" tab/viewer besides History, or a unified History viewer that shows both activity stream events and page versions.
Indeed, like the distinction Jira makes between history and activity.
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On 1 Mar 2016 at 18:23:14, Thomas Mortagne (thomas.mortagne@xwiki.com(mailto:thomas.mortagne@xwiki.com)) wrote:
On Tue, Mar 1, 2016 at 6:09 PM, Marius Dumitru Florea wrote:
On Fri, Feb 5, 2016 at 3:06 PM, vincent@massol.net wrote:
Hi devs,
I’ve just realized (thanks to a failing functional test) that we’ve changed the behavior we had when we restore a deleted document.
We used to add a revision with a comment text of "Restored from recycle bin”.
After https://jira.xwiki.org/browse/XWIKI-9960, there’s no new revision created when restoring a deleted document.
We need to decide if that’s what we want.
Apart from the fact that it’s a minor backward-compatibility breakage (for tools/scripts expecting that revision), the only downside I can see is that by looking at a document history you won’t be able to get the full list of what happened to this doc, i.e. that such user has restored the document.
WDYT?
"Alice has deleted this page" and "Bob has restored this page from recycle bin" are *activity stream* events more than history entries (versions).
I agree
There's no need to be able to revert, compare or blame such a "version". There may be other page actions like this too, that should appear in the activity stream (for a page) but that don't necessarily generate a new version in the history. So we could imagine having another "Activity Stream" tab/viewer besides History, or a unified History viewer that shows both activity stream events and page versions.
Indeed, like the distinction Jira makes between history and activity.
It’s a nice idea. I’ve created http://jira.xwiki.org/browse/XWIKI-13169 Thanks -Vincent
Personally I think this could be acceptable but I’m not sure.
Thanks -Vincent
participants (4)
-
Ecaterina Moraru (Valica) -
Marius Dumitru Florea -
Thomas Mortagne -
vincent＠massol.net