RE: [xwiki-commits] r1396 - in xwiki/trunk: . core lib src/main/web/WEB-INF
-----Original Message----- From: Vincent Massol [mailto:vmassol@users.forge.objectweb.org] Sent: lundi 16 octobre 2006 20:14 To: xwiki-commits@objectweb.org Subject: [xwiki-commits] r1396 - in xwiki/trunk: . core lib src/main/web/WEB-INF
[snip]
Modified: xwiki/trunk/src/main/web/WEB-INF/version.properties =================================================================== --- xwiki/trunk/src/main/web/WEB-INF/version.properties 2006-10-16 06:33:23 UTC (rev 1395) +++ xwiki/trunk/src/main/web/WEB-INF/version.properties 2006-10-16 18:14:00 UTC (rev 1396) @@ -1,2 +1,2 @@ -#Sun Aug 20 09:09:03 CEST 2006 -build.number=0021 +#Mon Oct 16 18:05:24 GMT 2006 +build.number=0022
I've committed this by mistake. It's really a bad practice to modify source files in the source tree and not in the build tree as this leads to this type of errors. Do I need to revert this? Thanks -Vincent ___________________________________________________________________________ D�couvrez une nouvelle fa�on d'obtenir des r�ponses � toutes vos questions ! Demandez � ceux qui savent sur Yahoo! Questions/R�ponses http://fr.answers.yahoo.com
Hi, No you don't need to revert this. I understand it is bad to handle this on the build platform, but this is the only way I've found to make sure each builds generates a different war name which allows us the recognize the build. Maybe we should now use the SVN version number which would be a good build ID Ludovic Vincent Massol a écrit :
-----Original Message----- From: Vincent Massol [mailto:vmassol@users.forge.objectweb.org] Sent: lundi 16 octobre 2006 20:14 To: xwiki-commits@objectweb.org Subject: [xwiki-commits] r1396 - in xwiki/trunk: . core lib src/main/web/WEB-INF
[snip]
Modified: xwiki/trunk/src/main/web/WEB-INF/version.properties =================================================================== --- xwiki/trunk/src/main/web/WEB-INF/version.properties 2006-10-16 06:33:23 UTC (rev 1395) +++ xwiki/trunk/src/main/web/WEB-INF/version.properties 2006-10-16 18:14:00 UTC (rev 1396) @@ -1,2 +1,2 @@ -#Sun Aug 20 09:09:03 CEST 2006 -build.number=0021 +#Mon Oct 16 18:05:24 GMT 2006 +build.number=0022
I've committed this by mistake. It's really a bad practice to modify source files in the source tree and not in the build tree as this leads to this type of errors.
Do I need to revert this?
Thanks -Vincent
___________________________________________________________________________ D�couvrez une nouvelle fa�on d'obtenir des r�ponses � toutes vos questions ! Demandez � ceux qui savent sur Yahoo! Questions/R�ponses http://fr.answers.yahoo.com
------------------------------------------------------------------------
-- You receive this message as a subscriber of the xwiki-dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
-- Ludovic Dubost XPertNet: http://www.xpertnet.fr/ Blog: http://www.ludovic.org/blog/ XWiki: http://www.xwiki.com Skype: ldubost AIM: nvludo Yahoo: ludovic
participants (2)
-
Ludovic Dubost -
Vincent Massol