[xwiki-devs] [VOTE] Add a page size chooser to livetables
Hi devs, I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer I would like to apply this patch for XE2.4M1. Here is my +1 Denis -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
On May 10, 2010, at 1:28 PM, Denis Gervalle wrote:
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
Question: is the developer-defined size available in the select? (the size specified in the #livetable macro call). +0 for me. I'd like this to be an option in the livetable macro call (in $options). The reason for an option is that as a developer I choose the number of items to be displayed based on several criteria and it may happen that on some pages I don't want the livetable to be able to be resized for some reason. I'd be ok that this option be on by default if we think it's best (I'm neutral on this). Note that I haven't checked the patch. Thanks -Vincent
On Mon, May 10, 2010 at 13:43, Vincent Massol <vincent@massol.net> wrote:
On May 10, 2010, at 1:28 PM, Denis Gervalle wrote:
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here:
http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
Question: is the developer-defined size available in the select? (the size specified in the #livetable macro call).
Yes, if it is not part of the proposed size, it is inserted in the right place by the livetable.js in all cases.
+0 for me. I'd like this to be an option in the livetable macro call (in $options). The reason for an option is that as a developer I choose the number of items to be displayed based on several criteria and it may happen that on some pages I don't want the livetable to be able to be resized for some reason. I'd be ok that this option be on by default if we think it's best (I'm neutral on this).
You may both disable the control and/or chose the pages bounds (min, max, steps) by options to the #livetable macro. If you do not use the livetable macro, but directle the livetable.js, the control only appears if there is a node for it to be injected, and you may precise the bound as well. The default bounds are 10 to 100 by 10.
Note that I haven't checked the patch.
No problem. Denis
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
+0 On Mon, May 10, 2010 at 13:28, Denis Gervalle <dgl@softec.lu> wrote:
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
Denis
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Hi, On Mon, May 10, 2010 at 13:57, Thomas Mortagne <thomas.mortagne@xwiki.com>wrote:
+0
On Mon, May 10, 2010 at 13:28, Denis Gervalle <dgl@softec.lu> wrote:
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here:
http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
+1 too as long as both settings (on/ off and nb of pages to show) can be defined in the livetable $options. Guillaume
Denis
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Guillaume Lerouge Product Manager - XWiki SAS Skype: wikibc Twitter: glerouge http://guillaumelerouge.com/
+1 Thanks, Marius On 05/10/2010 02:28 PM, Denis Gervalle wrote:
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
Denis
I'm not very fan of the interaction (the fact that the loader comes and replace the page sizer select) ; but I won't strongly oppose it either (I don't have much alternative proposals, except maybe displaying the loader right next to the select, or under the result line). So, 0 from me Jerome.
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here: http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
Denis
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Mon, May 10, 2010 at 16:51, Jerome Velociter <jerome@xwiki.com> wrote:
I'm not very fan of the interaction (the fact that the loader comes and replace the page sizer select) ; but I won't strongly oppose it either (I don't have much alternative proposals, except maybe displaying the loader right next to the select, or under the result line).
Just to explains my choice, putting the loading bar next to it would have require increasing the minimal width of the skin, since it takes more place than available and therefore, the header would have wrapped to the next line on small screen. I was not fan either, but after trying it, I finally found that it looks nice. Denis
So, 0 from me
Jerome.
Hi devs,
I want to add a control to choose the page size of livetables. I have made a proposal, and Guillaume Lerouge has suggested to show it by the default when using the #livetable macro. This addition is not intrusive, takes no additional place in the UI and does not require additional support on the server side. My updated proposal is resumed here:
http://incubator.myxwiki.org/xwiki/bin/view/Improvements/LivetablePageSizer
I would like to apply this patch for XE2.4M1.
Here is my +1
Denis
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
2x +1, 3x 0, 0x -1, I will commit these changes and consider this to be a first step that may be improved. Denis -- Denis Gervalle SOFTEC sa - CEO eGuilde sarl - CTO
participants (6)
-
Denis Gervalle -
Guillaume Lerouge -
Jerome Velociter -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol