Re: [xwiki-devs] [xwiki-notifications] r23282 - platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/classes
On Sep 4, 2009, at 4:08 PM, tmortagne (SVN) wrote:
Author: tmortagne Date: 2009-09-04 16:08:55 +0200 (Fri, 04 Sep 2009) New Revision: 23282
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/ classes/DBListClass.java Log: [misc] Improve log
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java =================================================================== --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 13:46:26 UTC (rev 23281) +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 14:08:55 UTC (rev 23282) @@ -286,8 +286,7 @@ try { sql = context.getWiki().parseContent(sql, context); } catch (Exception e) { - LOG.warn("Failed to parse SQL script [" + sql + "]. Internal error [" + e.getMessage() - + "]. Continuing with non-rendered script."); + LOG.warn("Failed to parse SQL script [" + sql + "]. Continuing with non-rendered script.", e);
Thomas, why is that better? Thanks -Vincent
On Fri, Sep 4, 2009 at 16:21, Vincent Massol<vincent@massol.net> wrote:
On Sep 4, 2009, at 4:08 PM, tmortagne (SVN) wrote:
Author: tmortagne Date: 2009-09-04 16:08:55 +0200 (Fri, 04 Sep 2009) New Revision: 23282
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/objects/ classes/DBListClass.java Log: [misc] Improve log
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java =================================================================== --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 13:46:26 UTC (rev 23281) +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 14:08:55 UTC (rev 23282) @@ -286,8 +286,7 @@ try { sql = context.getWiki().parseContent(sql, context); } catch (Exception e) { - LOG.warn("Failed to parse SQL script [" + sql + "]. Internal error [" + e.getMessage() - + "]. Continuing with non-rendered script."); + LOG.warn("Failed to parse SQL script [" + sql + "]. Continuing with non-rendered script.", e);
Thomas, why is that better?
Because this is not supposed to append so it's better to have the clean stack trace to debug it.
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Sep 4, 2009, at 4:23 PM, Thomas Mortagne wrote:
On Fri, Sep 4, 2009 at 16:21, Vincent Massol<vincent@massol.net> wrote:
On Sep 4, 2009, at 4:08 PM, tmortagne (SVN) wrote:
Author: tmortagne Date: 2009-09-04 16:08:55 +0200 (Fri, 04 Sep 2009) New Revision: 23282
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/ classes/DBListClass.java Log: [misc] Improve log
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/ xwiki/ objects/classes/DBListClass.java =================================================================== --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 13:46:26 UTC (rev 23281) +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 14:08:55 UTC (rev 23282) @@ -286,8 +286,7 @@ try { sql = context.getWiki().parseContent(sql, context); } catch (Exception e) { - LOG.warn("Failed to parse SQL script [" + sql + "]. Internal error [" + e.getMessage() - + "]. Continuing with non-rendered script."); + LOG.warn("Failed to parse SQL script [" + sql + "]. Continuing with non-rendered script.", e);
Thomas, why is that better?
Because this is not supposed to append so it's better to have the clean stack trace to debug it.
Ok I see. However we had a rule defined that warning should not print stack traces. Only error. So you might want to use an error then if it's not a warning? Thanks -Vincent
On Fri, Sep 4, 2009 at 16:31, Vincent Massol<vincent@massol.net> wrote:
On Sep 4, 2009, at 4:23 PM, Thomas Mortagne wrote:
On Fri, Sep 4, 2009 at 16:21, Vincent Massol<vincent@massol.net> wrote:
On Sep 4, 2009, at 4:08 PM, tmortagne (SVN) wrote:
Author: tmortagne Date: 2009-09-04 16:08:55 +0200 (Fri, 04 Sep 2009) New Revision: 23282
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/ classes/DBListClass.java Log: [misc] Improve log
Modified: platform/core/trunk/xwiki-core/src/main/java/com/xpn/ xwiki/ objects/classes/DBListClass.java =================================================================== --- platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 13:46:26 UTC (rev 23281) +++ platform/core/trunk/xwiki-core/src/main/java/com/xpn/xwiki/ objects/classes/DBListClass.java 2009-09-04 14:08:55 UTC (rev 23282) @@ -286,8 +286,7 @@ try { sql = context.getWiki().parseContent(sql, context); } catch (Exception e) { - LOG.warn("Failed to parse SQL script [" + sql + "]. Internal error [" + e.getMessage() - + "]. Continuing with non-rendered script."); + LOG.warn("Failed to parse SQL script [" + sql + "]. Continuing with non-rendered script.", e);
Thomas, why is that better?
Because this is not supposed to append so it's better to have the clean stack trace to debug it.
Ok I see.
However we had a rule defined that warning should not print stack traces. Only error. So you might want to use an error then if it's not a warning?
Fixed
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
participants (2)
-
Thomas Mortagne -
Vincent Massol