On Mon, Jul 16, 2012 at 10:44 PM, Caleb James DeLisle <calebdelisle@lavabit.com> wrote:

Hi,

Here I "fixed" the failing attachment test to prove what it sets out to prove. https://github.com/xwiki/xwiki-enterprise/commit/a59168b23dfb254d67a24caf985... I also added 2 new tests, one of which checks if a modified document is the same after saving and the other checks if the '$doc' reference points to the same document.

It turns out that one of the tests fails, meaning any code which modified it's own page, saves it, and expects it's handle on '$doc' to still contain the modified document will break.

It is relatively common for some scripts to modify their own document, esp. adding objects and if they do multiple save operations, the content from only the last save will be preserved since it will overwrite the older saves.

IMO we really need M1 but we should report a blocker on this as soon as it is released.

I reported http://jira.xwiki.org/browse/XWIKI-8104 and I committed https://github.com/xwiki/xwiki-platform/commit/007c0e969e3efc163a8dc6351393d... . Let's see if it fixes the problem and if there aren't any side effects. Thanks, Marius

Caleb

_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs