Import do not properly handle file encodings
Hi all, I'm currently evaluating xwiki for a local install and found severall issues. Here is the first one. When importing a xar file, all contained documents are parsed using the default encoding of the server JVM, regardless of the effective encoding of the files. This leads to incorrect documents when running the server in an UTF-8 configuration and importing the released xar (as they are encoded using ISO-8859-1, and as they effectively contain iso-8859-1 characters, which are, BTW typos coming from French). I already corrected this pb on the current svn snapshot. I'll post the patch in a comment of the JIVA issue I created. Regards, Gilles, -- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
Hi, I posted a patch in JIVA issue XWIKI-827. Is there a way to get code style used for xwiki on eclipse so that patches will be coherent with the general code style of the project? I had to use standard diff with ignore blanks) to get it correctly, but this is less readable than the internal svn diff command. Regards, Gilles, On 8 févr. 07, at 17:48, Gilles Serasset wrote:
Hi all,
I'm currently evaluating xwiki for a local install and found severall issues. Here is the first one.
When importing a xar file, all contained documents are parsed using the default encoding of the server JVM, regardless of the effective encoding of the files.
This leads to incorrect documents when running the server in an UTF-8 configuration and importing the released xar (as they are encoded using ISO-8859-1, and as they effectively contain iso-8859-1 characters, which are, BTW typos coming from French).
I already corrected this pb on the current svn snapshot. I'll post the patch in a comment of the JIVA issue I created.
Regards,
Gilles,
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
-- You receive this message as a subscriber of the xwiki- dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
Hi Gilles, On Feb 8, 2007, at 6:55 PM, Gilles Serasset wrote:
Hi,
I posted a patch in JIVA issue XWIKI-827.
Is there a way to get code style used for xwiki on eclipse so that patches will be coherent with the general code style of the project? I had to use standard diff with ignore blanks) to get it correctly, but this is less readable than the internal svn diff command.
Thanks for the patch. Could you please post it as an attachment to the jira issue so that it can be more easily applied? Regarding the code style see http://www.xwiki.org/xwiki/bin/view/ Community/. There are also other interesting resources to read on that page for contributors and developers. Thanks! -Vincent
On 8 févr. 07, at 17:48, Gilles Serasset wrote:
Hi all,
I'm currently evaluating xwiki for a local install and found severall issues. Here is the first one.
When importing a xar file, all contained documents are parsed using the default encoding of the server JVM, regardless of the effective encoding of the files.
This leads to incorrect documents when running the server in an UTF-8 configuration and importing the released xar (as they are encoded using ISO-8859-1, and as they effectively contain iso-8859-1 characters, which are, BTW typos coming from French).
I already corrected this pb on the current svn snapshot. I'll post the patch in a comment of the JIVA issue I created.
Regards,
Gilles,
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
-- You receive this message as a subscriber of the xwiki- dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http:// www.objectweb.org/wws
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
-- You receive this message as a subscriber of the xwiki- dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
___________________________________________________________________________ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com
Hi Vincent, I attached to files to the JIRA issue. They are diffs on the 2 modified files (standard diff syntax, ignoring spaces to avoid reproducing code style modifications). Regards, Gilles, On 9 févr. 07, at 08:56, Vincent Massol wrote:
Hi Gilles,
On Feb 8, 2007, at 6:55 PM, Gilles Serasset wrote:
Hi,
I posted a patch in JIVA issue XWIKI-827.
Is there a way to get code style used for xwiki on eclipse so that patches will be coherent with the general code style of the project? I had to use standard diff with ignore blanks) to get it correctly, but this is less readable than the internal svn diff command.
Thanks for the patch. Could you please post it as an attachment to the jira issue so that it can be more easily applied?
Regarding the code style see http://www.xwiki.org/xwiki/bin/view/ Community/. There are also other interesting resources to read on that page for contributors and developers.
Thanks! -Vincent
On 8 févr. 07, at 17:48, Gilles Serasset wrote:
Hi all,
I'm currently evaluating xwiki for a local install and found severall issues. Here is the first one.
When importing a xar file, all contained documents are parsed using the default encoding of the server JVM, regardless of the effective encoding of the files.
This leads to incorrect documents when running the server in an UTF-8 configuration and importing the released xar (as they are encoded using ISO-8859-1, and as they effectively contain iso-8859-1 characters, which are, BTW typos coming from French).
I already corrected this pb on the current svn snapshot. I'll post the patch in a comment of the JIVA issue I created.
Regards,
Gilles,
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
-- You receive this message as a subscriber of the xwiki- dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http:// www.objectweb.org/wws
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
-- You receive this message as a subscriber of the xwiki- dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http:// www.objectweb.org/wws
______________________________________________________________________ _____ Yahoo! Mail réinvente le mail ! Découvrez le nouveau Yahoo! Mail et son interface révolutionnaire. http://fr.mail.yahoo.com
-- You receive this message as a subscriber of the xwiki- dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/ wws
-- Gilles Sérasset GETA-CLIPS-IMAG (UJF, INPG & CNRS) BP 53 - F-38041 Grenoble Cedex 9 Phone: +33 4 76 51 43 80 Fax: +33 4 76 44 66 75
participants (2)
-
Gilles Serasset -
Vincent Massol