[xwiki-devs] [VOTE] Use SLF4J directly instead of inventing xwiki-commons-logging
Hi devs, After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name. So my proposal is that we standardize on the SLF4J API and use it directly without any facade. The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience Here's my +1 Thanks -Vincent
Some reading on this topic from SLF4J's FAQ: http://www.slf4j.org/faq.html#optional_dependency -Vincent On May 11, 2011, at 2:24 PM, Vincent Massol wrote:
Hi devs,
After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name.
So my proposal is that we standardize on the SLF4J API and use it directly without any facade.
The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience
Here's my +1
Thanks -Vincent
On Wed, May 11, 2011 at 14:24, Vincent Massol <vincent@massol.net> wrote:
Hi devs,
After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name.
So my proposal is that we standardize on the SLF4J API and use it directly without any facade.
The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience
Here's my +1
+1, the idea is that we need an API which is not linked to a specific implementation and that's exactly how slf4j has been designed and we don't need to have everything we use to be branded XWiki
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On 05/11/2011 02:24 PM, Vincent Massol wrote:
Hi devs,
After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name.
So my proposal is that we standardize on the SLF4J API and use it directly without any facade.
The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience
Here's my +1
Big +1. -- Sergiu Dumitriu http://purl.org/net/sergiu/
+1, JV. On Wed, May 11, 2011 at 2:24 PM, Vincent Massol <vincent@massol.net> wrote:
Hi devs,
After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name.
So my proposal is that we standardize on the SLF4J API and use it directly without any facade.
The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience
Here's my +1
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 Thanks, Marius On 05/11/2011 03:24 PM, Vincent Massol wrote:
Hi devs,
After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name.
So my proposal is that we standardize on the SLF4J API and use it directly without any facade.
The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience
Here's my +1
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 On Wed, May 11, 2011 at 2:24 PM, Vincent Massol <vincent@massol.net> wrote:
Hi devs,
After progressing on the new logging implementation I've come to the conclusion that we don't need our own facade in xwiki-commons-logging. I started doing the facade and then hit the issue that we need a facade for the MDC feature too (Mapped Diagnostic Context) so that would be one more class to add. If you follow in the direction what will happen is that we will, in the end, completely copy the slf4j-api sources, just under a different name.
So my proposal is that we standardize on the SLF4J API and use it directly without any facade.
The rationale is: * The SLF4J API is in a single jar (slf4j-api.jar) which is a minimal JAR weighting 23KB (small) * The SLF4J API can be implemented over all existing logging systems. There are currently implementation for at least log4j, jdk14 logging, commons logging, logback and more. So it's ensured that if we wanted we would be able to write our own implementation of it for whatever log system that can come up. * That's one more thing that we don't have to maintain * It's very mature since the guy who wrote it (Ceki) has gone through the log4j experience
Here's my +1
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
participants (6)
-
Fabio Mancinelli -
Jean-Vincent Drean -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol