[xwiki-devs] Name of color theme that was bundled in XE 3.3
Hi (Sergiu), I see you've committed Caty's pull requests. Thanks for that it's very nice! :) One little detail: the name of the color theme that was bundled in XE 3.3 Right now it's "XE33Default". I think this is not correct since the colortheme application is not supposed to be linked to XE. We're actually moving it to platform. So I'd rather call it something like "XWiki33Default" with a title of "XWiki 3.3 Default" instead. WDYT? Thanks -Vincent
On 01/05/2012 03:19 AM, Vincent Massol wrote:
Hi (Sergiu),
I see you've committed Caty's pull requests. Thanks for that it's very nice! :)
One little detail: the name of the color theme that was bundled in XE 3.3
Right now it's "XE33Default". I think this is not correct since the colortheme application is not supposed to be linked to XE. We're actually moving it to platform.
So I'd rather call it something like "XWiki33Default" with a title of "XWiki 3.3 Default" instead.
WDYT?
I think a nicer name should be used, one that's not so technical. Something like Sky, or Seaside? -- Sergiu Dumitriu http://purl.org/net/sergiu/
I would like to deprecate the existing old ColorThemes and make them align to the recent changes. This means deleting some not that nice themes (like Peach, etc.) and modify/add themes like Bordo, in order to have at least 3 themes that look good on the current variables. Because I will make changes to the XE33Default makes sense to give it a nice name (since it will be a different theme, but with the same flavor - blue colors). If ok, I will make these changes until 3.4 final. Thanks, Caty On Thu, Jan 5, 2012 at 10:49, Sergiu Dumitriu <sergiu@xwiki.com> wrote:
On 01/05/2012 03:19 AM, Vincent Massol wrote:
Hi (Sergiu),
I see you've committed Caty's pull requests. Thanks for that it's very nice! :)
One little detail: the name of the color theme that was bundled in XE 3.3
Right now it's "XE33Default". I think this is not correct since the colortheme application is not supposed to be linked to XE. We're actually moving it to platform.
So I'd rather call it something like "XWiki33Default" with a title of "XWiki 3.3 Default" instead.
WDYT?
I think a nicer name should be used, one that's not so technical. Something like Sky, or Seaside?
-- Sergiu Dumitriu http://purl.org/net/sergiu/
______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
On Jan 5, 2012, at 9:54 AM, Ecaterina Moraru (Valica) wrote:
I would like to deprecate the existing old ColorThemes and make them align to the recent changes. This means deleting some not that nice themes (like Peach, etc.) and modify/add themes like Bordo, in order to have at least 3 themes that look good on the current variables.
Because I will make changes to the XE33Default makes sense to give it a nice name (since it will be a different theme, but with the same flavor - blue colors).
If ok, I will make these changes until 3.4 final.
We need to keep existing themes for people who want to keep them. But we don't need to make them available bundled. They could be made optional extensions on extensions.xwiki.org. Thanks -Vincent
Thanks, Caty
On Thu, Jan 5, 2012 at 10:49, Sergiu Dumitriu <sergiu@xwiki.com> wrote:
On 01/05/2012 03:19 AM, Vincent Massol wrote:
Hi (Sergiu),
I see you've committed Caty's pull requests. Thanks for that it's very nice! :)
One little detail: the name of the color theme that was bundled in XE 3.3
Right now it's "XE33Default". I think this is not correct since the colortheme application is not supposed to be linked to XE. We're actually moving it to platform.
So I'd rather call it something like "XWiki33Default" with a title of "XWiki 3.3 Default" instead.
WDYT?
I think a nicer name should be used, one that's not so technical. Something like Sky, or Seaside?
-- Sergiu Dumitriu http://purl.org/net/sergiu/
______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Jan 5, 2012, at 9:49 AM, Sergiu Dumitriu wrote:
On 01/05/2012 03:19 AM, Vincent Massol wrote:
Hi (Sergiu),
I see you've committed Caty's pull requests. Thanks for that it's very nice! :)
One little detail: the name of the color theme that was bundled in XE 3.3
Right now it's "XE33Default". I think this is not correct since the colortheme application is not supposed to be linked to XE. We're actually moving it to platform.
So I'd rather call it something like "XWiki33Default" with a title of "XWiki 3.3 Default" instead.
WDYT?
I think a nicer name should be used, one that's not so technical. Something like Sky, or Seaside?
Yes what we could do is use a similar name than the others for the page name and in title use something like: "Seaside (XWiki 3.3 Default Theme)"? Unless we don't care showing that it was the default theme prior to 3.3. I'm fine either way. Thanks -Vincent
participants (3)
-
Ecaterina Moraru (Valica) -
Sergiu Dumitriu -
Vincent Massol