[xwiki-devs] [VOTE] merge branch 'feature-solr-search' into 'master' for 4.3M2
Hi devs, I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap. Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4] The pull requests [5][6] are available for reviewing so start shooting :) Thanks, Eduard ---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2] https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade [3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34
Hi Edy, This is great. I've seen you've fixed the lock issue ; I have had that issue when working on the 4.0 branch, I will merge it there and test the migration. In any case I would like to continue this migration as my time allows. My objective is to play with the new spatial submodule (which is also integrated in solr as I understand) and try and contribute a "LatLon" XClass property type. +1 for going forward with Solr, Jerome On 11/05/2012 11:26 AM, Eduard Moraru wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2] https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade [3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34 _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 I've played a bit with it and looks really nice (especially the highlight feature and the ability to filter) Thanks, Caty On Mon, Nov 5, 2012 at 12:35 PM, Jerome Velociter <jerome@velociter.fr>wrote:
Hi Edy,
This is great. I've seen you've fixed the lock issue ; I have had that issue when working on the 4.0 branch, I will merge it there and test the migration. In any case I would like to continue this migration as my time allows. My objective is to play with the new spatial submodule (which is also integrated in solr as I understand) and try and contribute a "LatLon" XClass property type.
+1 for going forward with Solr,
Jerome
On 11/05/2012 11:26 AM, Eduard Moraru wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/**XWIKI-8407<http://jira.xwiki.org/browse/XWIKI-8407> [2] https://github.com/xwiki/**xwiki-platform/tree/feature-** lucene-4.0.0-upgrade<https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade> [3] http://jira.xwiki.org/browse/**XWIKI-8406<http://jira.xwiki.org/browse/XWIKI-8406> [4] http://jira.xwiki.org/browse/**XWIKI-8408<http://jira.xwiki.org/browse/XWIKI-8408> [5] https://github.com/xwiki/**xwiki-platform/pull/73<https://github.com/xwiki/xwiki-platform/pull/73> [6] https://github.com/xwiki/**xwiki-enterprise/pull/34<https://github.com/xwiki/xwiki-enterprise/pull/34> ______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<http://lists.xwiki.org/mailman/listinfo/devs>
I`ve also attached a few screenshots to the original jira issue if anybody is interested. Please see http://jira.xwiki.org/browse/XWIKI-5676 Thanks, Eduard On Mon, Nov 5, 2012 at 12:49 PM, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote:
+1 I've played a bit with it and looks really nice (especially the highlight feature and the ability to filter)
Thanks, Caty
On Mon, Nov 5, 2012 at 12:35 PM, Jerome Velociter <jerome@velociter.fr
wrote:
Hi Edy,
This is great. I've seen you've fixed the lock issue ; I have had that issue when working on the 4.0 branch, I will merge it there and test the migration. In any case I would like to continue this migration as my time allows. My objective is to play with the new spatial submodule (which is also integrated in solr as I understand) and try and contribute a "LatLon" XClass property type.
+1 for going forward with Solr,
Jerome
On 11/05/2012 11:26 AM, Eduard Moraru wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/**XWIKI-8407<; http://jira.xwiki.org/browse/XWIKI-8407> [2] https://github.com/xwiki/**xwiki-platform/tree/feature-** lucene-4.0.0-upgrade< https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade> [3] http://jira.xwiki.org/browse/**XWIKI-8406<; http://jira.xwiki.org/browse/XWIKI-8406> [4] http://jira.xwiki.org/browse/**XWIKI-8408<; http://jira.xwiki.org/browse/XWIKI-8408> [5] https://github.com/xwiki/**xwiki-platform/pull/73<; https://github.com/xwiki/xwiki-platform/pull/73> [6] https://github.com/xwiki/**xwiki-enterprise/pull/34<; https://github.com/xwiki/xwiki-enterprise/pull/34> ______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<; http://lists.xwiki.org/mailman/listinfo/devs>
______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<; http://lists.xwiki.org/mailman/listinfo/devs>
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Eduard, that's nice to see it progresses. I have not had the time to review but the screenshot help me do so quickly. Small comments: - Do you want to keep debug always on? I would disable the debug links and checkbox for normal users, activating if globalAdmin or if a setting is defined - Query boost does not sound right to me. I'd name this "query form" or "query expansion" (the boost is a single exponent) For sure my +1 for you to merge and make it the default. I wonder if there's a hope to disable the Lucene plugin one day since probably many elaborate infrastructures have come to rely on it. paul Le 5 nov. 2012 à 12:27, Eduard Moraru a écrit :
I`ve also attached a few screenshots to the original jira issue if anybody is interested.
Please see http://jira.xwiki.org/browse/XWIKI-5676
Thanks, Eduard
On Mon, Nov 5, 2012 at 12:49 PM, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote:
+1 I've played a bit with it and looks really nice (especially the highlight feature and the ability to filter)
Thanks, Caty
On Mon, Nov 5, 2012 at 12:35 PM, Jerome Velociter <jerome@velociter.fr
wrote:
Hi Edy,
This is great. I've seen you've fixed the lock issue ; I have had that issue when working on the 4.0 branch, I will merge it there and test the migration. In any case I would like to continue this migration as my time allows. My objective is to play with the new spatial submodule (which is also integrated in solr as I understand) and try and contribute a "LatLon" XClass property type.
+1 for going forward with Solr,
Jerome
On 11/05/2012 11:26 AM, Eduard Moraru wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/**XWIKI-8407<; http://jira.xwiki.org/browse/XWIKI-8407> [2] https://github.com/xwiki/**xwiki-platform/tree/feature-** lucene-4.0.0-upgrade< https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade> [3] http://jira.xwiki.org/browse/**XWIKI-8406<; http://jira.xwiki.org/browse/XWIKI-8406> [4] http://jira.xwiki.org/browse/**XWIKI-8408<; http://jira.xwiki.org/browse/XWIKI-8408> [5] https://github.com/xwiki/**xwiki-platform/pull/73<; https://github.com/xwiki/xwiki-platform/pull/73> [6] https://github.com/xwiki/**xwiki-enterprise/pull/34<; https://github.com/xwiki/xwiki-enterprise/pull/34> ______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<; http://lists.xwiki.org/mailman/listinfo/devs>
______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<; http://lists.xwiki.org/mailman/listinfo/devs>
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Hi Paul, Yes, you are right. I have hidden the debug stuff and it is now only visible if you manually add &debug=on/true/whatever to the URL. About query boost, we can discuss more about it. It actually sets the "qf" (Query Fields) parameter that basically says what (space separated) fields to query and what boost to attach to each of them. Thanks, Eduard On Tue, Nov 6, 2012 at 9:44 AM, Paul Libbrecht <paul@hoplahup.net> wrote:
Eduard,
that's nice to see it progresses. I have not had the time to review but the screenshot help me do so quickly.
Small comments: - Do you want to keep debug always on? I would disable the debug links and checkbox for normal users, activating if globalAdmin or if a setting is defined - Query boost does not sound right to me. I'd name this "query form" or "query expansion" (the boost is a single exponent)
For sure my +1 for you to merge and make it the default.
I wonder if there's a hope to disable the Lucene plugin one day since probably many elaborate infrastructures have come to rely on it.
paul
Le 5 nov. 2012 à 12:27, Eduard Moraru a écrit :
I`ve also attached a few screenshots to the original jira issue if anybody is interested.
Please see http://jira.xwiki.org/browse/XWIKI-5676
Thanks, Eduard
On Mon, Nov 5, 2012 at 12:49 PM, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote:
+1 I've played a bit with it and looks really nice (especially the highlight feature and the ability to filter)
Thanks, Caty
On Mon, Nov 5, 2012 at 12:35 PM, Jerome Velociter <jerome@velociter.fr
wrote:
Hi Edy,
This is great. I've seen you've fixed the lock issue ; I have had that issue when working on the 4.0 branch, I will merge it there and test the migration. In any case I would like to continue this migration as my time allows. My objective is to play with the new spatial submodule (which is also integrated in solr as I understand) and try and contribute a "LatLon" XClass property type.
+1 for going forward with Solr,
Jerome
On 11/05/2012 11:26 AM, Eduard Moraru wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/**XWIKI-8407<; http://jira.xwiki.org/browse/XWIKI-8407> [2] https://github.com/xwiki/**xwiki-platform/tree/feature-** lucene-4.0.0-upgrade<
https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade>
[3] http://jira.xwiki.org/browse/**XWIKI-8406<; http://jira.xwiki.org/browse/XWIKI-8406> [4] http://jira.xwiki.org/browse/**XWIKI-8408<; http://jira.xwiki.org/browse/XWIKI-8408> [5] https://github.com/xwiki/**xwiki-platform/pull/73<; https://github.com/xwiki/xwiki-platform/pull/73> [6] https://github.com/xwiki/**xwiki-enterprise/pull/34<; https://github.com/xwiki/xwiki-enterprise/pull/34> ______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<; http://lists.xwiki.org/mailman/listinfo/devs>
______________________________**_________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/**mailman/listinfo/devs<; http://lists.xwiki.org/mailman/listinfo/devs>
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 Thanks, Marius On Mon, Nov 5, 2012 at 12:26 PM, Eduard Moraru <enygma2002@gmail.com> wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2] https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade [3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34 _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 On Mon, Nov 5, 2012 at 11:26 AM, Eduard Moraru <enygma2002@gmail.com> wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2] https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade [3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34 _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Since we are a bit late with the release, I`m going to rush things a bit. 6 +1s (counting mine as well from the initial mail), no +0, no -1. Done. Thanks, Eduard On Tue, Nov 6, 2012 at 10:57 AM, Thomas Mortagne <thomas.mortagne@xwiki.com>wrote:
+1
On Mon, Nov 5, 2012 at 11:26 AM, Eduard Moraru <enygma2002@gmail.com> wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2]
https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade
[3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34 _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 but I haven't reviewed the code so I don't know how good it is ATM. What's important to ensure is that there are enough unit and functional tests. Also don't forget to set the clover percentage for the new modules (you can verify it works by running mvn clean install -Pquality). Thanks -Vincent <off topic - would need a separate thread in itself> PS: Next time, it would be better to have regular small commits in master IMO. I really believe Git is a bad tool in that regard and working on a branch till a feature is "ready" is detrimental to the project for the following top reasons: - you don't test integration and integration is the most difficult part (yes I know this can be improved by setting up the branch on CI but it's not as good a regular commits in master) - you don't get committer review because committers care most about master and not about all those feature branches lying around (it's hard to monitor them all and review them all) - you are tempted to code on your branch till the last moment meaning that the merge is done close to the release end date leaving not enough time for integration and further testing/reviews </off topic> On Nov 5, 2012, at 11:26 AM, Eduard Moraru <enygma2002@gmail.com> wrote:
Hi devs,
I would like your vote on merging the 'feature-solr-search' branch with 'master' for 4.3M2 as planned in the Roadmap.
Merge Notes: - A first version of the Solr search is bundled by default as experimental with XE, but Lucene is still the default search engine. --- Lucene has been upgraded to 3.6.1 [1] and Solr has been downgraded to the same (3.6.1) version in order to achieve the peaceful cohabitation between the 2 search versions. If we want Solr 4.0, we need to work a bit more on the Lucene search, since Lucene 4.0 comes with a considerable number of refactorings. ----- I have just noticed Jerome's feature-lucene-4.0.0-upgrade [2] branch. - The admin needs to use the Search Administration to switch from Lucene to Solr and back. (each engine has its own index) - The back-end contains a SolrIndex for add/delete operations and a QueryExecutor to query the index trough XWiki's Query API using the 'solr' language. - Indexing is only manually performed for now, from the Search Administration, blocking the request until the operation is complete. - Search highlighting is available - The default search looks only for Documents. Filtered/Advanced search options can be used to change some of the search parameters. - Lucene/Solr syntax is supported in the query string - Faceted search is currently hidden because it is not yet in an usable state. - SearchSuggest is still using Lucene, no matter what the configuration in Search Administration says - The merge also contains a fix for a pretty nasty yet easily fixable Lucene deadlock [3] (introduced 10 months ago) and some Search Admin UI improvements [4]
The pull requests [5][6] are available for reviewing so start shooting :)
Thanks, Eduard
---------- [1] http://jira.xwiki.org/browse/XWIKI-8407 [2] https://github.com/xwiki/xwiki-platform/tree/feature-lucene-4.0.0-upgrade [3] http://jira.xwiki.org/browse/XWIKI-8406 [4] http://jira.xwiki.org/browse/XWIKI-8408 [5] https://github.com/xwiki/xwiki-platform/pull/73 [6] https://github.com/xwiki/xwiki-enterprise/pull/34 _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
participants (7)
-
Ecaterina Moraru (Valica) -
Eduard Moraru -
Jerome Velociter -
Marius Dumitru Florea -
Paul Libbrecht -
Thomas Mortagne -
Vincent Massol