Re: [xwiki-devs] [xwiki-notifications] r8703 - xwiki-platform/core/trunk/xwiki-core/src/main/resources
Hi, Sergiu. 1. lazy="true" should be in <property>. (eclipse validation fails) 2. lazy feature is working while session is open. So only in storage level. If we'll call DeletedAttachment#getXml() or #restoreAttachment outside store, we'll get a exception. This is very bad. That is why I've separated XWikiRCSNode into RCSInfo and RCSContent. Maybe there is another way to accomplish this? I think we need not lazy for DeletedAttachment now. sdumitriu (SVN) wrote:
Author: sdumitriu Date: 2008-03-27 02:51:12 +0100 (Thu, 27 Mar 2008) New Revision: 8703
Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/xwiki.derby.hbm.xml xwiki-platform/core/trunk/xwiki-core/src/main/resources/xwiki.hbm.xml xwiki-platform/core/trunk/xwiki-core/src/main/resources/xwiki.oracle.hbm.xml Log: XWIKI-2254: Attachment recycle bin XWIKI-37: Deleted attachments not accessible via document history Added hibernate mapping
<snip>
+ <!-- This one is lazy as the XML isn't always needed. Does improve performance when there are several deleted attachments with the same name. --> + <!-- TODO: Should this be lazy or not? Need to run a profiler... --> + <property name="xml" type="text"> + <column name="XDA_XML" sql-type="clob" not-null="true" length="1000000000" lazy="true" /> + </property>
-- Artem Melentyev
I removed the "lazy" attribute completely, as it didn't actually improve performance in real usage, and it's better to be on the safe side. Thanks. Artem Melentyev wrote:
Hi, Sergiu.
1. lazy="true" should be in <property>. (eclipse validation fails)
2. lazy feature is working while session is open. So only in storage level. If we'll call DeletedAttachment#getXml() or #restoreAttachment outside store, we'll get a exception. This is very bad. That is why I've separated XWikiRCSNode into RCSInfo and RCSContent. Maybe there is another way to accomplish this?
I think we need not lazy for DeletedAttachment now.
sdumitriu (SVN) wrote:
Author: sdumitriu Date: 2008-03-27 02:51:12 +0100 (Thu, 27 Mar 2008) New Revision: 8703
Modified: xwiki-platform/core/trunk/xwiki-core/src/main/resources/xwiki.derby.hbm.xml xwiki-platform/core/trunk/xwiki-core/src/main/resources/xwiki.hbm.xml xwiki-platform/core/trunk/xwiki-core/src/main/resources/xwiki.oracle.hbm.xml Log: XWIKI-2254: Attachment recycle bin XWIKI-37: Deleted attachments not accessible via document history Added hibernate mapping
<snip>
+ <!-- This one is lazy as the XML isn't always needed. Does improve performance when there are several deleted attachments with the same name. --> + <!-- TODO: Should this be lazy or not? Need to run a profiler... --> + <property name="xml" type="text"> + <column name="XDA_XML" sql-type="clob" not-null="true" length="1000000000" lazy="true" /> + </property>
-- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Artem Melentyev -
Sergiu Dumitriu