Re: [xwiki-commits] r4023 - xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/it/com/xpn/xwiki/it
Hi Catalin, On Jul 25, 2007, at 12:25 PM, Catalin Hritcu wrote:
Author: hritcu Date: 2007-07-25 12:25:45 +0200 (Wed, 25 Jul 2007) New Revision: 4023
Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/ it/com/xpn/xwiki/it/DeletePageTest.java Log: Test for the presence of bug XWIKI-1388 (the test currently fails)
Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ src/test/it/com/xpn/xwiki/it/DeletePageTest.java =================================================================== --- xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 08:45:50 UTC (rev 4022) +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 10:25:45 UTC (rev 4023) @@ -109,6 +109,18 @@ } }
+ /* + * This tests for regression of XWIKI-1388 + */
This should be a javadoc I think.
+ public void testUserStaysLoggedInWhileDeleting() + { + logInAndCreatePageToBeDeleted("DeleteTest"); + clickDeletePage(); + + assertTrue("The interface should not show the user as logged out while deleting", + isAuthenticated()); + } +
I don't think we should commit test that make the build fail. We should commit them at the same time as we commit the fix IMO. When you don't have the implementation ready, then I suggest putting them in the JIRA issue related to the problem. That's what I did in the past. WDYT? Thanks -Vincent
Hi Vincent, Sergiu fixed the bug now. But you are right, tests that exhibit a bug that is not fixed yet should go to the JIRA issue and not to the SVN. Thanks, Catalin On 7/25/07, Vincent Massol <vincent@massol.net> wrote:
Hi Catalin,
On Jul 25, 2007, at 12:25 PM, Catalin Hritcu wrote:
Author: hritcu Date: 2007-07-25 12:25:45 +0200 (Wed, 25 Jul 2007) New Revision: 4023
Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/src/test/ it/com/xpn/xwiki/it/DeletePageTest.java Log: Test for the presence of bug XWIKI-1388 (the test currently fails)
Modified: xwiki-products/xwiki-enterprise/trunk/distribution-test/ src/test/it/com/xpn/xwiki/it/DeletePageTest.java =================================================================== --- xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 08:45:50 UTC (rev 4022) +++ xwiki-products/xwiki-enterprise/trunk/distribution-test/src/ test/it/com/xpn/xwiki/it/DeletePageTest.java 2007-07-25 10:25:45 UTC (rev 4023) @@ -109,6 +109,18 @@ } }
+ /* + * This tests for regression of XWIKI-1388 + */
This should be a javadoc I think.
+ public void testUserStaysLoggedInWhileDeleting() + { + logInAndCreatePageToBeDeleted("DeleteTest"); + clickDeletePage(); + + assertTrue("The interface should not show the user as logged out while deleting", + isAuthenticated()); + } +
I don't think we should commit test that make the build fail. We should commit them at the same time as we commit the fix IMO. When you don't have the implementation ready, then I suggest putting them in the JIRA issue related to the problem. That's what I did in the past.
WDYT?
Thanks -Vincent
-- You receive this message as a subscriber of the xwiki-dev@objectweb.org mailing list. To unsubscribe: mailto:xwiki-dev-unsubscribe@objectweb.org For general help: mailto:sympa@objectweb.org?subject=help ObjectWeb mailing lists service home page: http://www.objectweb.org/wws
On 7/25/07, teamcity@xwiki.org <teamcity@xwiki.org> wrote:
Build XWiki Enterprise::Maven2 #340 failed Agent: Default agent Build results: http://teamcity.xwiki.org/viewLog.html?buildId=1462&buildTypeId=bt10
Changes included (1 change) ==================================================== Change 4024 by hritcu (1 file): Test for the presence of bug XWIKI-1388 (the test currently fails)
see more information about changed files: http://teamcity.xwiki.org/viewLog.html?tab=buildChangesDiv&buildId=1462&buil...
============================================================================ Configure email notifications: http://teamcity.xwiki.org/profile.html?init=1#notifications
participants (2)
-
Catalin Hritcu -
Vincent Massol