[xwiki-devs] [Proposal] Package organization for ui-tests
Hi devs, I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page. WDYT? Thanks -Vincent
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this: org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests WDYT? Thanks -Vincent
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future): Generic stuff: org.xwiki.ui.test.framework.elements.* XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.* WDYT? Thanks -Vincent
On Tue, Jun 22, 2010 at 14:37, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
For example, are tests on admin app org.xwiki.ui.test.admin.* or org.xwiki.ui.test.xe.* ? (I would prefer org.xwiki.ui.test.admin.*)
WDYT?
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Tue, Jun 22, 2010 at 14:46, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Tue, Jun 22, 2010 at 14:37, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
For example, are tests on admin app org.xwiki.ui.test.admin.* or org.xwiki.ui.test.xe.* ?
(I would prefer org.xwiki.ui.test.admin.*)
Forgot to say that appart from this question, the proposal sounds good.
WDYT?
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
On Tue, Jun 22, 2010 at 14:51, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Tue, Jun 22, 2010 at 14:46, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Tue, Jun 22, 2010 at 14:37, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
For example, are tests on admin app org.xwiki.ui.test.admin.* or org.xwiki.ui.test.xe.* ?
(I would prefer org.xwiki.ui.test.admin.*)
On the same subject: what about wiki edition tests ? org.xwiki.ui.test.platform.* or org.xwiki.ui.test.xe.* ?
Forgot to say that appart from this question, the proposal sounds good.
WDYT?
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
-- Thomas Mortagne
On Jun 22, 2010, at 2:52 PM, Thomas Mortagne wrote:
On Tue, Jun 22, 2010 at 14:51, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Tue, Jun 22, 2010 at 14:46, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Tue, Jun 22, 2010 at 14:37, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
For example, are tests on admin app org.xwiki.ui.test.admin.* or org.xwiki.ui.test.xe.* ?
(I would prefer org.xwiki.ui.test.admin.*)
On the same subject: what about wiki edition tests ? org.xwiki.ui.test.platform.* or org.xwiki.ui.test.xe.* ?
Right now I have put generic tests that don't belong to an app in the org.xwiki.it.ui package (next to AllTest). Thanks -Vincent
Forgot to say that appart from this question, the proposal sounds good.
WDYT?
Thanks -Vincent
On Jun 22, 2010, at 2:46 PM, Thomas Mortagne wrote:
On Tue, Jun 22, 2010 at 14:37, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
For example, are tests on admin app org.xwiki.ui.test.admin.* or org.xwiki.ui.test.xe.* ?
They are in org.xwiki.ui.administration (I haven't put tests in a specific "test" package).
(I would prefer org.xwiki.ui.test.admin.*)
Me too :) Thanks -Vincent
WDYT?
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Hi Vincent, On 06/22/2010 03:37 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where<application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.*<-- elements org.xwiki.ui.test.<application name>.*<-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
WDYT?
I'm a bit puzzled. The proposal you made above is clear, but in this thread you also say: "Right now I have put generic tests that don't belong to an app in the org.xwiki.it.ui package (next to AllTest)." and "They are in org.xwiki.ui.administration (I haven't put tests in a specific "test" package)." So is it: org.xwiki.ui.test.administration.* or org.xwiki.ui.administration.* or org.xwiki.it.ui.test.administration.* or org.xwiki.it.ui.administration.* ? Thanks, Marius
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Jun 22, 2010, at 11:17 PM, Marius Dumitru Florea wrote:
Hi Vincent,
On 06/22/2010 03:37 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where<application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.*<-- elements org.xwiki.ui.test.<application name>.*<-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
WDYT?
I'm a bit puzzled. The proposal you made above is clear, but in this thread you also say:
"Right now I have put generic tests that don't belong to an app in the org.xwiki.it.ui package (next to AllTest)."
and
"They are in org.xwiki.ui.administration (I haven't put tests in a specific "test" package)."
- Tests for the admin app are in admin (org.xwiki.it.ui.administration) - Generic tests (no app) are in org.xwiki.it.ui See http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tes... Thanks -Vincent
So is it:
org.xwiki.ui.test.administration.* or org.xwiki.ui.administration.* or org.xwiki.it.ui.test.administration.* or org.xwiki.it.ui.administration.* ?
Thanks, Marius
On Wed, Jun 23, 2010 at 08:14, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 11:17 PM, Marius Dumitru Florea wrote:
Hi Vincent,
On 06/22/2010 03:37 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where<application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.*<-- elements org.xwiki.ui.test.<application name>.*<-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
WDYT?
I'm a bit puzzled. The proposal you made above is clear, but in this thread you also say:
"Right now I have put generic tests that don't belong to an app in the org.xwiki.it.ui package (next to AllTest)."
and
"They are in org.xwiki.ui.administration (I haven't put tests in a specific "test" package)."
- Tests for the admin app are in admin (org.xwiki.it.ui.administration) - Generic tests (no app) are in org.xwiki.it.ui
So why is your proposal org.xwiki.ui.test.<application name> and not org.xwiki.ui.<application name> ?
See http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tes...
Thanks -Vincent
So is it:
org.xwiki.ui.test.administration.* or org.xwiki.ui.administration.* or org.xwiki.it.ui.test.administration.* or org.xwiki.it.ui.administration.* ?
Thanks, Marius
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Jun 23, 2010, at 8:17 AM, Thomas Mortagne wrote:
On Wed, Jun 23, 2010 at 08:14, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 11:17 PM, Marius Dumitru Florea wrote:
Hi Vincent,
On 06/22/2010 03:37 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where<application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.*<-- elements org.xwiki.ui.test.<application name>.*<-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
WDYT?
I'm a bit puzzled. The proposal you made above is clear, but in this thread you also say:
"Right now I have put generic tests that don't belong to an app in the org.xwiki.it.ui package (next to AllTest)."
and
"They are in org.xwiki.ui.administration (I haven't put tests in a specific "test" package)."
- Tests for the admin app are in admin (org.xwiki.it.ui.administration) - Generic tests (no app) are in org.xwiki.it.ui
So why is your proposal org.xwiki.ui.test.<application name> and not org.xwiki.ui.<application name> ?
Because it's an error of the proposal :) I didn't plan to change the current package prefix used which is: org.xwiki.it.ui. I was only talking about the suffix starting at that level. Please check what I've done in the following dir and let me know if that's ok: http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tes... Thanks -Vincent
See http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tes...
Thanks -Vincent
So is it:
org.xwiki.ui.test.administration.* or org.xwiki.ui.administration.* or org.xwiki.it.ui.test.administration.* or org.xwiki.it.ui.administration.* ?
Thanks, Marius
On Wed, Jun 23, 2010 at 08:26, Vincent Massol <vincent@massol.net> wrote:
On Jun 23, 2010, at 8:17 AM, Thomas Mortagne wrote:
On Wed, Jun 23, 2010 at 08:14, Vincent Massol <vincent@massol.net> wrote:
On Jun 22, 2010, at 11:17 PM, Marius Dumitru Florea wrote:
Hi Vincent,
On 06/22/2010 03:37 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:33 PM, Vincent Massol wrote:
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
> Hi devs, > > I'm proposing to have org.xwiki.it.ui.elements.<application name> where<application name> is the name of the application containing the page. > > WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.*<-- elements org.xwiki.ui.test.<application name>.*<-- tests
We also need a place for generic stuff and for XE-specific pages (althought they should disappear in the future):
Generic stuff: org.xwiki.ui.test.framework.elements.*
XE: org.xwiki.ui.test.xe.elements.* org.xwiki.ui.test.xe.*
WDYT?
I'm a bit puzzled. The proposal you made above is clear, but in this thread you also say:
"Right now I have put generic tests that don't belong to an app in the org.xwiki.it.ui package (next to AllTest)."
and
"They are in org.xwiki.ui.administration (I haven't put tests in a specific "test" package)."
- Tests for the admin app are in admin (org.xwiki.it.ui.administration) - Generic tests (no app) are in org.xwiki.it.ui
So why is your proposal org.xwiki.ui.test.<application name> and not org.xwiki.ui.<application name> ?
Because it's an error of the proposal :)
Ok so that's why me and Marius did not understood what happen then.
I didn't plan to change the current package prefix used which is: org.xwiki.it.ui. I was only talking about the suffix starting at that level.
Please check what I've done in the following dir and let me know if that's ok: http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tes...
Thanks -Vincent
See http://svn.xwiki.org/svnroot/xwiki/enterprise/trunk/distribution-test/ui-tes...
Thanks -Vincent
So is it:
org.xwiki.ui.test.administration.* or org.xwiki.ui.administration.* or org.xwiki.it.ui.test.administration.* or org.xwiki.it.ui.administration.* ?
Thanks, Marius
devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1, I like the idea. Jerome. ----- Original Message ----- From: "Vincent Massol" <vincent@massol.net> To: "XWiki Developers" <devs@xwiki.org> Sent: Tuesday, June 22, 2010 2:33:42 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [xwiki-devs] [Proposal] Package organization for ui-tests On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this: org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests WDYT? Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
+1 There aren't very many tests and it's already turning into a mess. For what it's worth I'm for the package name being exactly the same as the name of the directory in /applications/. Minor detail though. Caleb Jerome Velociter wrote:
+1, I like the idea.
Jerome.
----- Original Message ----- From: "Vincent Massol" <vincent@massol.net> To: "XWiki Developers" <devs@xwiki.org> Sent: Tuesday, June 22, 2010 2:33:42 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [xwiki-devs] [Proposal] Package organization for ui-tests
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
WDYT?
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Jun 22, 2010, at 9:17 PM, Caleb James DeLisle wrote:
+1 There aren't very many tests and it's already turning into a mess.
For what it's worth I'm for the package name being exactly the same as the name of the directory in /applications/. Minor detail though.
I completely agree, that's what I meant. -Vincent
Caleb
Jerome Velociter wrote:
+1, I like the idea.
Jerome.
----- Original Message ----- From: "Vincent Massol" <vincent@massol.net> To: "XWiki Developers" <devs@xwiki.org> Sent: Tuesday, June 22, 2010 2:33:42 PM GMT +01:00 Amsterdam / Berlin / Bern / Rome / Stockholm / Vienna Subject: Re: [xwiki-devs] [Proposal] Package organization for ui-tests
On Jun 22, 2010, at 2:29 PM, Vincent Massol wrote:
Hi devs,
I'm proposing to have org.xwiki.it.ui.elements.<application name> where <application name> is the name of the application containing the page.
WDYT?
We also need to separate the tests themselves so we need a larger proposal. I'm now proposing this:
org.xwiki.ui.test.<application name>.elements.* <-- elements org.xwiki.ui.test.<application name>.* <-- tests
WDYT?
Thanks -Vincent
participants (5)
-
Caleb James DeLisle -
Jerome Velociter -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol