[xwiki-devs] About the broken build
Hi devs. As you might know, the build is currently broken for ~2 weeks. It is due to the fact that I have set Flamingo by default since August, 6th. I have not changed the functional tests that are still designed for Colibri so they fails because some behaviours has changed (like clicking on a menu instead of hovering it to see a submenu, etc...). I'm sorry about all the inconveniences that the broken build have made for the community (public image, difficulty to point out which commit have introduced a regression, etc...). I am now working at fixing the failing tests. It should take time and any help is welcome. Please tell me if it creates problems for you. The other solution would be to put flamingo by default on a distinct branch and to merge it when all tests pass, but it would slow down the Flamingo skin stabilization by not being viewable by everybody. Thanks, Guillaume
Hi Guillaume, Just a small mention is that the build has not been broken entirely, just some of the tests. It's only the past few days that we have actual build problems (i.e. code not building successfully). Anyway, we`ve decided that we focus on build issues today so we should be able to fix some/most problems :) Thanks, Eduard On Tue, Aug 19, 2014 at 6:01 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau@xwiki.com> wrote:
Hi devs.
As you might know, the build is currently broken for ~2 weeks. It is due to the fact that I have set Flamingo by default since August, 6th. I have not changed the functional tests that are still designed for Colibri so they fails because some behaviours has changed (like clicking on a menu instead of hovering it to see a submenu, etc...).
I'm sorry about all the inconveniences that the broken build have made for the community (public image, difficulty to point out which commit have introduced a regression, etc...). I am now working at fixing the failing tests. It should take time and any help is welcome.
Please tell me if it creates problems for you. The other solution would be to put flamingo by default on a distinct branch and to merge it when all tests pass, but it would slow down the Flamingo skin stabilization by not being viewable by everybody.
Thanks, Guillaume _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Hi. xwiki-enterprise-test-webstandards fails as well. It is due to the fact what currently Flamingo does not generate valid HTML5 code, and the HTML5 validator has not been enabled yet. Actually, there is a list of steps to perform to fix this issue: http://jira.xwiki.org/browse/XWIKI-7552 and we do not have the time to do it for 6.2. So what Vincent and I propose is to temporary disable the validation tests for 6.2, and to enable them back as soon as we can (during the 6.3 period), and to accept the fact that 6.2 won't be HTML valid (except by using colibri). I know it is not the perfect solution but in my opinion it is the only way to have Flamingo by default in 6.2 without postponing the release. Please send an e-mail if it's an issue for you. Thanks, Guillaume 2014-08-21 10:23 GMT+02:00 Eduard Moraru <enygma2002@gmail.com>:
Hi Guillaume,
Just a small mention is that the build has not been broken entirely, just some of the tests. It's only the past few days that we have actual build problems (i.e. code not building successfully).
Anyway, we`ve decided that we focus on build issues today so we should be able to fix some/most problems :)
Thanks, Eduard
On Tue, Aug 19, 2014 at 6:01 PM, Guillaume "Louis-Marie" Delhumeau < gdelhumeau@xwiki.com> wrote:
Hi devs.
As you might know, the build is currently broken for ~2 weeks. It is due to the fact that I have set Flamingo by default since August, 6th. I have not changed the functional tests that are still designed for Colibri so they fails because some behaviours has changed (like clicking on a menu instead of hovering it to see a submenu, etc...).
I'm sorry about all the inconveniences that the broken build have made for the community (public image, difficulty to point out which commit have introduced a regression, etc...). I am now working at fixing the failing tests. It should take time and any help is welcome.
Please tell me if it creates problems for you. The other solution would be to put flamingo by default on a distinct branch and to merge it when all tests pass, but it would slow down the Flamingo skin stabilization by not being viewable by everybody.
Thanks, Guillaume _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
participants (2)
-
Eduard Moraru -
Guillaume "Louis-Marie" Delhumeau