[xwiki-devs] [VOTE] Deprecated and remove MediaWiki parser from xwiki-rendering
Hi devs, I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki. So I propose to get rid of the old one and retire it in contrib organization. WDYT ? here is my +1 -- Thomas Mortagne PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
Hi Thomas,
On 23 Jun 2016, at 13:01, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
+1 from me. I just hope that the “bliki” parser has good support for the future. So right now all the tests that were previously passing are passing with the new parser? Or is there still work to be done? Will you have a production-ready release before XWiki 8.2 final is released? Does it work to install it as a extension in XWiki 8.2? (I had issues with markdown and I hope you don’t have similar issues) Do you plan to make it work with older XWiki versions? (if so you may need to have special install instructions on e.x.o - maybe it requires removing the mediawiki jars from web-inf/lib because it uses the same syntax id, etc?) Thanks! -Vincent
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
On 23 Jun 2016, at 13:08, Vincent Massol <vincent@massol.net> wrote:
Hi Thomas,
On 23 Jun 2016, at 13:01, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
+1 from me. I just hope that the “bliki” parser has good support for the future.
So right now all the tests that were previously passing are passing with the new parser? Or is there still work to be done?
Will you have a production-ready release before XWiki 8.2 final is released?
Does it work to install it as a extension in XWiki 8.2? (I had issues with markdown and I hope you don’t have similar issues)
Do you plan to make it work with older XWiki versions? (if so you may need to have special install instructions on e.x.o - maybe it requires removing the mediawiki jars from web-inf/lib because it uses the same syntax id, etc?)
It could be nice to also update the doc for all extensions on e.x.o using the old mediawiki parser since they might not work anymore. Or is it transparent (same syntax id)? Thanks -Vincent
Thanks! -Vincent
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
+1 Thanks, Caty On Thu, Jun 23, 2016 at 2:10 PM, Vincent Massol <vincent@massol.net> wrote:
On 23 Jun 2016, at 13:08, Vincent Massol <vincent@massol.net> wrote:
Hi Thomas,
On 23 Jun 2016, at 13:01, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
+1 from me. I just hope that the “bliki” parser has good support for the future.
So right now all the tests that were previously passing are passing with the new parser? Or is there still work to be done?
Will you have a production-ready release before XWiki 8.2 final is released?
Does it work to install it as a extension in XWiki 8.2? (I had issues with markdown and I hope you don’t have similar issues)
Do you plan to make it work with older XWiki versions? (if so you may need to have special install instructions on e.x.o - maybe it requires removing the mediawiki jars from web-inf/lib because it uses the same syntax id, etc?)
It could be nice to also update the doc for all extensions on e.x.o using the old mediawiki parser since they might not work anymore. Or is it transparent (same syntax id)?
Thanks -Vincent
Thanks! -Vincent
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Thu, Jun 23, 2016 at 1:08 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Thomas,
On 23 Jun 2016, at 13:01, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
+1 from me. I just hope that the “bliki” parser has good support for the future.
We'll see. It has much better support than our old parser at least :)
So right now all the tests that were previously passing are passing with the new parser? Or is there still work to be done?
Same tests plus much more and Jenkins seems happy with it: http://jenkins.xwiki.org/job/Contrib%20-%20MediaWiki/.
Will you have a production-ready release before XWiki 8.2 final is released?
The current version is 1.2 and it's probably not perfect but looks much better than the old one already :)
Does it work to install it as a extension in XWiki 8.2? (I had issues with markdown and I hope you don’t have similar issues)
bliki does not have much dependencies so no issue here.
Do you plan to make it work with older XWiki versions? (if so you may need to have special install instructions on e.x.o - maybe it requires removing the mediawiki jars from web-inf/lib because it uses the same syntax id, etc?)
Depends what you mean by older version. The extension depends on 7.4 right now. Nothing to remove, as usual it's a new id since it's a completely different implementation (plus it's not the same syntax for macros so that would be an important breakage probably). The id of the new parser is mediawiki/1.6 (the current version of the mediawiki syntax specs is 1.6 so I used that). For edge cases I also provided another extension which have the same id than the old one and use the new parser behind the scene if for some reason you really have to use this id but want new parser stuff.
Thanks! -Vincent
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On 23 Jun 2016, at 14:05, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Thu, Jun 23, 2016 at 1:08 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Thomas,
On 23 Jun 2016, at 13:01, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
+1 from me. I just hope that the “bliki” parser has good support for the future.
We'll see. It has much better support than our old parser at least :)
So right now all the tests that were previously passing are passing with the new parser? Or is there still work to be done?
Same tests plus much more and Jenkins seems happy with it: http://jenkins.xwiki.org/job/Contrib%20-%20MediaWiki/.
Will you have a production-ready release before XWiki 8.2 final is released?
The current version is 1.2 and it's probably not perfect but looks much better than the old one already :)
Does it work to install it as a extension in XWiki 8.2? (I had issues with markdown and I hope you don’t have similar issues)
bliki does not have much dependencies so no issue here.
Do you plan to make it work with older XWiki versions? (if so you may need to have special install instructions on e.x.o - maybe it requires removing the mediawiki jars from web-inf/lib because it uses the same syntax id, etc?)
Depends what you mean by older version. The extension depends on 7.4 right now.
Nothing to remove, as usual it's a new id since it's a completely different implementation (plus it's not the same syntax for macros so that would be an important breakage probably). The id of the new parser is mediawiki/1.6 (the current version of the mediawiki syntax specs is 1.6 so I used that).
Interesting, didn’t know they had a versioned spec. Any link? Is version 1.6 in https://github.com/xwiki-contrib/mediawiki/tree/master/mediawiki-syntax ? Shouldn’t we name it mediawiki-syntax-1.6 (or mediawiki-syntax-16)? I see in the pom: <artifactId>mediawiki-syntax</artifactId> <name>MediaWiki - Syntax</name> <description>MediaWiki Syntax parser</description> <properties> <!-- Name to display by the Extension Manager --> <xwiki.extension.name>MediaWiki Syntax</xwiki.extension.name> I think we should use 1.6 in all these places to namespace it and make way for future implementations of other spec versions. WDYT? The EM should also display “MediaWiki Syntax 1.6” IMO. What is https://github.com/xwiki-contrib/mediawiki/tree/master/mediawiki-syntax10ove... ?
For edge cases I also provided another extension which have the same id than the old one and use the new parser behind the scene if for some reason you really have to use this id but want new parser stuff.
This is https://github.com/xwiki-contrib/syntax-mediawiki-1.0 (missing some README ATM)? Thanks -Vincent
Thanks!
-Vincent
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
On Thu, Jun 23, 2016 at 2:17 PM, Vincent Massol <vincent@massol.net> wrote:
On 23 Jun 2016, at 14:05, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Thu, Jun 23, 2016 at 1:08 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Thomas,
On 23 Jun 2016, at 13:01, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
+1 from me. I just hope that the “bliki” parser has good support for the future.
We'll see. It has much better support than our old parser at least :)
So right now all the tests that were previously passing are passing with the new parser? Or is there still work to be done?
Same tests plus much more and Jenkins seems happy with it: http://jenkins.xwiki.org/job/Contrib%20-%20MediaWiki/.
Will you have a production-ready release before XWiki 8.2 final is released?
The current version is 1.2 and it's probably not perfect but looks much better than the old one already :)
Does it work to install it as a extension in XWiki 8.2? (I had issues with markdown and I hope you don’t have similar issues)
bliki does not have much dependencies so no issue here.
Do you plan to make it work with older XWiki versions? (if so you may need to have special install instructions on e.x.o - maybe it requires removing the mediawiki jars from web-inf/lib because it uses the same syntax id, etc?)
Depends what you mean by older version. The extension depends on 7.4 right now.
Nothing to remove, as usual it's a new id since it's a completely different implementation (plus it's not the same syntax for macros so that would be an important breakage probably). The id of the new parser is mediawiki/1.6 (the current version of the mediawiki syntax specs is 1.6 so I used that).
Interesting, didn’t know they had a versioned spec. Any link?
See http://extensions.xwiki.org/xwiki/bin/view/Extension/MediaWiki/MediaWiki+Syn....
Is version 1.6 in https://github.com/xwiki-contrib/mediawiki/tree/master/mediawiki-syntax ? Shouldn’t we name it mediawiki-syntax-1.6 (or mediawiki-syntax-16)?
I did not put the version to make clear this is the current MediaWiki syntax. If we even have a new one, we'll see. Pretty sure people don't care what is the version of MediaWiki syntax, they just want the current MediaWiki syntax.
I see in the pom:
<artifactId>mediawiki-syntax</artifactId> <name>MediaWiki - Syntax</name> <description>MediaWiki Syntax parser</description> <properties> <!-- Name to display by the Extension Manager --> <xwiki.extension.name>MediaWiki Syntax</xwiki.extension.name>
I think we should use 1.6 in all these places to namespace it and make way for future implementations of other spec versions. WDYT?
The EM should also display “MediaWiki Syntax 1.6” IMO.
What is https://github.com/xwiki-contrib/mediawiki/tree/master/mediawiki-syntax10ove... ?
For edge cases I also provided another extension which have the same id than the old one and use the new parser behind the scene if for some reason you really have to use this id but want new parser stuff.
This is https://github.com/xwiki-contrib/syntax-mediawiki-1.0 (missing some README ATM)?
You have documentation on http://extensions.xwiki.org/xwiki/bin/view/Extension/MediaWiki/Override+of+M... and I written in the previous mail what this module is about: "" For edge cases I also provided another extension which have the same id than the old one and use the new parser behind the scene if for some reason you really have to use this id but want new parser stuff. ""
Thanks -Vincent
Thanks!
-Vincent
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :)
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+0 Thanks, Marius On Thu, Jun 23, 2016 at 2:01 PM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I just released as a contrib extension a new MediaWiki parser which covers the old one located on xwiki-rendering (and also fix many issues that were not even listed). The big change is that the actual parser is https://bitbucket.org/axelclk/info.bliki.wiki/wiki/Home and not done by us anymore, we just produce event from the DOM provided by bliki.
So I propose to get rid of the old one and retire it in contrib organization.
WDYT ?
here is my +1
-- Thomas Mortagne
PS: OK I already did it and then Vincent reminded me that it would be nice to have a mail about it :) _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
participants (4)
-
Ecaterina Moraru (Valica) -
Marius Dumitru Florea -
Thomas Mortagne -
Vincent Massol