[xwiki-devs] [Proposal][UX] Notifications Improvements 9.8+
Hi, I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x Let me know what you think. Thanks, Caty
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app? For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification? Thanks -Vincent
Thanks, Caty
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x#... Thanks, Caty On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x#...
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) However I don’t think it scales since it means one unique icon per combination of app type + event type. What would scale better is two icons: one for the app type and one for the event type. For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed You wouldn’t be able to use the RSS icon to represent the 3 events. BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. WDYT? Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
Another feedback/questions: * Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS) Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x#...
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done? Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x#...
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion. Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x#...
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com>
wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: > > Hi, > > I've created some improvements suggestions for our Notifications UI, see > http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x > > Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
> > Thanks, > Caty
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face. Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling. Nice work anyway, as usual :) Guillaume 2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <
valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/Notification
sImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
> Hi Caty, > >> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> > wrote: >> >> Hi, >> >> I've created some improvements suggestions for our Notifications UI, see >> http://design.xwiki.org/xwiki/bin/view/Proposal/ > NotificationsImprovements9x >> >> Let me know what you think. > > Re the overview, I don’t see where you mention the app? > > For example, could you show how a new Blog post would be displayed and you > differentiate that for example from a Page creation or modification? > > Thanks > -Vincent > >> >> Thanks, >> Caty > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On 3 Oct 2017, at 09:54, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
On this aspect, I think that the social aspect is important to make people contribute so I kind of like that we’re showing avatars. They do seem a bit on the largish side in the screenshot. In any case, I think we need 2 icons: one for the app type and one for the event type so that should possibly reduce the size of the visible avatar. Thanks -Vincent
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <
valicac@gmail.com> wrote:
> > Event Type: BlogPostPublishedEvent > from > http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
> Thanks, > Caty > > On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote: > >> Hi Caty, >> >>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >> wrote: >>> >>> Hi, >>> >>> I've created some improvements suggestions for our Notifications UI, see >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9x >>> >>> Let me know what you think. >> >> Re the overview, I don’t see where you mention the app? >> >> For example, could you show how a new Blog post would be displayed and you >> differentiate that for example from a Page creation or modification? >> >> Thanks >> -Vincent >> >>> >>> Thanks, >>> Caty >> >>
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <
valicac@gmail.com> wrote:
> > Event Type: BlogPostPublishedEvent > from > http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
> Thanks, > Caty > > On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote: > >> Hi Caty, >> >>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >> wrote: >>> >>> Hi, >>> >>> I've created some improvements suggestions for our Notifications UI, see >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9x >>> >>> Let me know what you think. >> >> Re the overview, I don’t see where you mention the app? >> >> For example, could you show how a new Blog post would be displayed and you >> differentiate that for example from a Page creation or modification? >> >> Thanks >> -Vincent >> >>> >>> Thanks, >>> Caty >> >>
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page
events
so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I
created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
> > >> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >> >> Event Type: BlogPostPublishedEvent >> from >> http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9x#HEventTypes > > ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) > > However I don’t think it scales since it means one unique icon per combination of app type + event type. > > What would scale better is two icons: one for the app type and one for the event type. > > For example imagine that the Blog app had the following events: > * When a blog post is published > * When a blog post is created > * When a blog post is removed > > You wouldn’t be able to use the RSS icon to represent the 3 events. > > BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. > > That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. > > WDYT? > > Thanks > -Vincent > >> Thanks, >> Caty >> >> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >> >>> Hi Caty, >>> >>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>> wrote: >>>> >>>> Hi, >>>> >>>> I've created some improvements suggestions for our Notifications UI, see >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>> NotificationsImprovements9x >>>> >>>> Let me know what you think. >>> >>> Re the overview, I don’t see where you mention the app? >>> >>> For example, could you show how a new Blog post would be displayed and you >>> differentiate that for example from a Page creation or modification? >>> >>> Thanks >>> -Vincent >>> >>>> >>>> Thanks, >>>> Caty >>> >>> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
But Facebook, for example, is a social network. It focuses on people by nature. On XWiki, it is not that evident. In the case of a knowledge base, you focus more on the content (the knowledge) than on the people. On xwiki.org, I guess you prefer seeing what's change instead of who made some changes... If we define XWiki as a collaboration tool, then you collaborate to create something and so the focus is naturally more on that "something". Just my 2 cents :)
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net>
wrote:
> > Another feedback/questions: > > * Is the avatar icon clickable and leading to the user profile? > * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
Thanks -Vincent
> > Thanks > -Vincent > >> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>> >> >>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >>> >>> Event Type: BlogPostPublishedEvent >>> from >>> http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9x#HEventTypes >> >> ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) >> >> However I don’t think it scales since it means one unique icon per combination of app type + event type. >> >> What would scale better is two icons: one for the app type and one for the event type. >> >> For example imagine that the Blog app had the following events: >> * When a blog post is published >> * When a blog post is created >> * When a blog post is removed >> >> You wouldn’t be able to use the RSS icon to represent the 3 events. >> >> BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. >> >> That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. >> >> WDYT? >> >> Thanks >> -Vincent >> >>> Thanks, >>> Caty >>> >>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >>> >>>> Hi Caty, >>>> >>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I've created some improvements suggestions for our Notifications UI, see >>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>> NotificationsImprovements9x >>>>> >>>>> Let me know what you think. >>>> >>>> Re the overview, I don’t see where you mention the app? >>>> >>>> For example, could you show how a new Blog post would be displayed and you >>>> differentiate that for example from a Page creation or modification? >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>> Thanks, >>>>> Caty >>>> >>>> >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Wed, Oct 4, 2017 at 3:04 PM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
But Facebook, for example, is a social network. It focuses on people by nature. On XWiki, it is not that evident. In the case of a knowledge base, you focus more on the content (the knowledge) than on the people. On xwiki.org, I guess you prefer seeing what's change instead of who made some changes...
If we define XWiki as a collaboration tool, then you collaborate to create something and so the focus is naturally more on that "something".
Just my 2 cents :)
Some for me, if "the majority of notifcations in the wild" only refer to social networks and communication tools then it's not a good input for a wiki IMO.
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> > >> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: >> >> Another feedback/questions: >> >> * Is the avatar icon clickable and leading to the user profile? >> * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS) > > * Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
> > Thanks > -Vincent > >> >> Thanks >> -Vincent >> >>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>>> >>> >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >>>> >>>> Event Type: BlogPostPublishedEvent >>>> from >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9x#HEventTypes >>> >>> ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) >>> >>> However I don’t think it scales since it means one unique icon per combination of app type + event type. >>> >>> What would scale better is two icons: one for the app type and one for the event type. >>> >>> For example imagine that the Blog app had the following events: >>> * When a blog post is published >>> * When a blog post is created >>> * When a blog post is removed >>> >>> You wouldn’t be able to use the RSS icon to represent the 3 events. >>> >>> BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. >>> >>> That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. >>> >>> WDYT? >>> >>> Thanks >>> -Vincent >>> >>>> Thanks, >>>> Caty >>>> >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >>>> >>>>> Hi Caty, >>>>> >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>>>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I've created some improvements suggestions for our Notifications UI, see >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>> NotificationsImprovements9x >>>>>> >>>>>> Let me know what you think. >>>>> >>>>> Re the overview, I don’t see where you mention the app? >>>>> >>>>> For example, could you show how a new Blog post would be displayed and you >>>>> differentiate that for example from a Page creation or modification? >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> Thanks, >>>>>> Caty >>>>> >>>>> >>> >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
On big instances such as Wikipedia, you might not even know personally who is the user who contributed (but notifications might not scale in a Wikipedia instance anyway). 2017-10-04 15:13 GMT+02:00 Thomas Mortagne <thomas.mortagne@xwiki.com>:
On Wed, Oct 4, 2017 at 3:04 PM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com :
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
But Facebook, for example, is a social network. It focuses on people by nature. On XWiki, it is not that evident. In the case of a knowledge base, you focus more on the content (the knowledge) than on the people. On xwiki.org, I guess you prefer seeing what's change instead of who made some changes...
If we define XWiki as a collaboration tool, then you collaborate to create something and so the focus is naturally more on that "something".
Just my 2 cents :)
Some for me, if "the majority of notifcations in the wild" only refer to social networks and communication tools then it's not a good input for a wiki IMO.
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
> > > On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> > > > > >> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: > >> > >> Another feedback/questions: > >> > >> * Is the avatar icon clickable and leading to the user profile? > >> * We need a way to link directly to the diff, at least for page events > so that the user can see what was modified (as we have currently
in
the AS)
> > > > * Maybe “2 hours ago” is not precise enough. In your example I see I > created and modified the Roadmap page but they both say “2 hours ago”. > Shouldn’t I be able to see how far away both events were done? > > My understanding is that events are grouped by app+type but not by entity > anymore (for page events) and thus you can have 3 events displayed for the > same page, f.ex: Creation, Modification, Deletion. >
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
> > Thanks > -Vincent > > > > > Thanks > > -Vincent > > > >> > >> Thanks > >> -Vincent > >> > >>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote: > >>> > >>> > >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < > valicac@gmail.com> wrote: > >>>> > >>>> Event Type: BlogPostPublishedEvent > >>>> from > >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/Notification > sImprovements9x#HEventTypes > >>> > >>> ok thanks, had missed this since I was reading from top to bottom and > stopped at the overview :) > >>> > >>> However I don’t think it scales since it means one unique icon per > combination of app type + event type. > >>> > >>> What would scale better is two icons: one for the app type and one > for the event type. > >>> > >>> For example imagine that the Blog app had the following events: > >>> * When a blog post is published > >>> * When a blog post is created > >>> * When a blog post is removed > >>> > >>> You wouldn’t be able to use the RSS icon to represent the 3 events. > >>> > >>> BTW the RSS icon isn’t necessarily representative of the Blog app. A > lot of apps can have a RSS feed. > >>> > >>> That’s the main remark I have: it’s going to be harder and harder to > find unique icons as we had more events to apps, especially if there’s only > 1 icon that is supposed to combine both app type + event type. > >>> > >>> WDYT? > >>> > >>> Thanks > >>> -Vincent > >>> > >>>> Thanks, > >>>> Caty > >>>> > >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> > wrote: > >>>> > >>>>> Hi Caty, > >>>>> > >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < > valicac@gmail.com> > >>>>> wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I've created some improvements suggestions for our Notifications > UI, see > >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ > >>>>> NotificationsImprovements9x > >>>>>> > >>>>>> Let me know what you think. > >>>>> > >>>>> Re the overview, I don’t see where you mention the app? > >>>>> > >>>>> For example, could you show how a new Blog post would be displayed > and you > >>>>> differentiate that for example from a Page creation or modification? > >>>>> > >>>>> Thanks > >>>>> -Vincent > >>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Caty > >>>>> > >>>>> > >>> > >> > > > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Wed, Oct 4, 2017 at 4:04 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
But Facebook, for example, is a social network. It focuses on people by nature. On XWiki, it is not that evident. In the case of a knowledge base, you focus more on the content (the knowledge) than on the people. On xwiki.org, I guess you prefer seeing what's change instead of who made some changes...
I know the pages are important, that's why the first link and item displayed is the page name. I want to know if a spam user did something. Thanks, Caty
If we define XWiki as a collaboration tool, then you collaborate to create something and so the focus is naturally more on that "something".
Just my 2 cents :)
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> > >> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: >> >> Another feedback/questions: >> >> * Is the avatar icon clickable and leading to the user profile? >> * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS) > > * Maybe “2 hours ago” is not precise enough. In your example I
see
I
created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
Thanks -Vincent
> > Thanks > -Vincent > >> >> Thanks >> -Vincent >> >>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>>> >>> >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >>>> >>>> Event Type: BlogPostPublishedEvent >>>> from >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9x#HEventTypes >>> >>> ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) >>> >>> However I don’t think it scales since it means one unique icon per combination of app type + event type. >>> >>> What would scale better is two icons: one for the app type and one for the event type. >>> >>> For example imagine that the Blog app had the following events: >>> * When a blog post is published >>> * When a blog post is created >>> * When a blog post is removed >>> >>> You wouldn’t be able to use the RSS icon to represent the 3 events. >>> >>> BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. >>> >>> That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. >>> >>> WDYT? >>> >>> Thanks >>> -Vincent >>> >>>> Thanks, >>>> Caty >>>> >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >>>> >>>>> Hi Caty, >>>>> >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>>>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I've created some improvements suggestions for our Notifications UI, see >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>> NotificationsImprovements9x >>>>>> >>>>>> Let me know what you think. >>>>> >>>>> Re the overview, I don’t see where you mention the app? >>>>> >>>>> For example, could you show how a new Blog post would be displayed and you >>>>> differentiate that for example from a Page creation or modification? >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> Thanks, >>>>>> Caty >>>>> >>>>> >>> >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hi, I was wondering if we could identify the center point of an notification by considering the action that the current user (receiving the notification) did to subscribe to that event, i.e. what actually interests the current user. 1) Now, if we consider the Watchlist approach where a user goes to a page/wiki and clicks "watch"/"subscribe", then we could see the point of interest as the content... since the user wants to be notified when changes are made to that content... by whoever. ... in this case, it makes sense to see the events of, say the recent 24 hours, grouped by pages and only in their details to see which users and what even types they performed. 2) If we consider going to the user profile and clicking "follow", then the current user is interested in the getting notifications of the changes done by that particular user, no matter the page. ... in this case, I would imagine the user expecting to see events in the last 24 hours grouped by users "i.e. user X worked on 5 pages" and, when expanding, to see which pages and what type of events... 3) Finally, there are applications, where events could be sent by either users of the application (e.g. Blog, AWM, etc.) or by the application itself (e.g. Meeting Manager/Calendar sending a reminder to the participants, 30 minutes before, about an upcoming meeting/event). ... in this case, the user subscribes to the application (or is automatically subscribed and can unsubscribe). Not sure if this helps to the discussion, just thought I'd share. Thanks, Eduard On Thu, Oct 5, 2017 at 4:58 PM, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
On Wed, Oct 4, 2017 at 4:04 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com :
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
But Facebook, for example, is a social network. It focuses on people by nature. On XWiki, it is not that evident. In the case of a knowledge base, you focus more on the content (the knowledge) than on the people. On xwiki.org, I guess you prefer seeing what's change instead of who made some changes...
I know the pages are important, that's why the first link and item displayed is the page name. I want to know if a spam user did something.
Thanks, Caty
If we define XWiki as a collaboration tool, then you collaborate to create something and so the focus is naturally more on that "something".
Just my 2 cents :)
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
> > > On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> > > > > >> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: > >> > >> Another feedback/questions: > >> > >> * Is the avatar icon clickable and leading to the user
profile?
> >> * We need a way to link directly to the diff, at least for page events > so that the user can see what was modified (as we have currently in the AS) > > > > * Maybe “2 hours ago” is not precise enough. In your example I see I > created and modified the Roadmap page but they both say “2 hours ago”. > Shouldn’t I be able to see how far away both events were done? > > My understanding is that events are grouped by app+type but not by entity > anymore (for page events) and thus you can have 3 events displayed for the > same page, f.ex: Creation, Modification, Deletion. >
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
> > Thanks > -Vincent > > > > > Thanks > > -Vincent > > > >> > >> Thanks > >> -Vincent > >> > >>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote: > >>> > >>> > >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < > valicac@gmail.com> wrote: > >>>> > >>>> Event Type: BlogPostPublishedEvent > >>>> from > >>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/Notification > sImprovements9x#HEventTypes > >>> > >>> ok thanks, had missed this since I was reading from top to bottom and > stopped at the overview :) > >>> > >>> However I don’t think it scales since it means one unique icon per > combination of app type + event type. > >>> > >>> What would scale better is two icons: one for the app type and one > for the event type. > >>> > >>> For example imagine that the Blog app had the following events: > >>> * When a blog post is published > >>> * When a blog post is created > >>> * When a blog post is removed > >>> > >>> You wouldn’t be able to use the RSS icon to represent the 3 events. > >>> > >>> BTW the RSS icon isn’t necessarily representative of the Blog app. A > lot of apps can have a RSS feed. > >>> > >>> That’s the main remark I have: it’s going to be harder and harder to > find unique icons as we had more events to apps, especially if there’s only > 1 icon that is supposed to combine both app type + event type. > >>> > >>> WDYT? > >>> > >>> Thanks > >>> -Vincent > >>> > >>>> Thanks, > >>>> Caty > >>>> > >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> > wrote: > >>>> > >>>>> Hi Caty, > >>>>> > >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < > valicac@gmail.com> > >>>>> wrote: > >>>>>> > >>>>>> Hi, > >>>>>> > >>>>>> I've created some improvements suggestions for our Notifications > UI, see > >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ > >>>>> NotificationsImprovements9x > >>>>>> > >>>>>> Let me know what you think. > >>>>> > >>>>> Re the overview, I don’t see where you mention the app? > >>>>> > >>>>> For example, could you show how a new Blog post would be displayed > and you > >>>>> differentiate that for example from a Page creation or modification? > >>>>> > >>>>> Thanks > >>>>> -Vincent > >>>>> > >>>>>> > >>>>>> Thanks, > >>>>>> Caty > >>>>> > >>>>> > >>> > >> > > > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
2017-10-07 2:08 GMT+02:00 Eduard Moraru <enygma2002@gmail.com>:
Hi,
I was wondering if we could identify the center point of an notification by considering the action that the current user (receiving the notification) did to subscribe to that event, i.e. what actually interests the current user.
1) Now, if we consider the Watchlist approach where a user goes to a page/wiki and clicks "watch"/"subscribe", then we could see the point of interest as the content... since the user wants to be notified when changes are made to that content... by whoever. ... in this case, it makes sense to see the events of, say the recent 24 hours, grouped by pages and only in their details to see which users and what even types they performed.
2) If we consider going to the user profile and clicking "follow", then the current user is interested in the getting notifications of the changes done by that particular user, no matter the page. ... in this case, I would imagine the user expecting to see events in the last 24 hours grouped by users "i.e. user X worked on 5 pages" and, when expanding, to see which pages and what type of events...
3) Finally, there are applications, where events could be sent by either users of the application (e.g. Blog, AWM, etc.) or by the application itself (e.g. Meeting Manager/Calendar sending a reminder to the participants, 30 minutes before, about an upcoming meeting/event). ... in this case, the user subscribes to the application (or is automatically subscribed and can unsubscribe).
Not sure if this helps to the discussion, just thought I'd share.
The user could have done many of these actions. So we need to chose a standard "view" in that case.
Thanks, Eduard
On Thu, Oct 5, 2017 at 4:58 PM, Ecaterina Moraru (Valica) < valicac@gmail.com
wrote:
On Wed, Oct 4, 2017 at 4:04 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:34 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
On Tue, Oct 3, 2017 at 11:27 AM, Thomas Mortagne < thomas.mortagne@xwiki.com> wrote:
On Tue, Oct 3, 2017 at 9:54 AM, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
So your proposal focuses a lot more on the users instead of the apps (like facebook for example). It's OK for me, but I think the type icon (create, edit, comment, etc...) is too small compared to the user face.
Actually when I see these screenshot, my first impression is that the user has been modified :) Would it be nice to have the type icon bigger than the user face? To me, what happened is more important than who made it, but maybe it's only my feeling.
Pretty much the same comments on my side. I find weird to focus that much on users, I would have preferred images corresponding on the change made.
Depends on what we want to focus on and also on what are user's expectations. If you look at the majority of notifcations in the wild, the user is the focus. People want to know who did what, on what page, when.
But Facebook, for example, is a social network. It focuses on people by nature. On XWiki, it is not that evident. In the case of a knowledge base, you focus more on the content (the knowledge) than on the people. On xwiki.org, I guess you prefer seeing what's change instead of who made some changes...
I know the pages are important, that's why the first link and item displayed is the page name. I want to know if a spam user did something.
Thanks, Caty
If we define XWiki as a collaboration tool, then you collaborate to create something and so the focus is naturally more on that "something".
Just my 2 cents :)
Nice work anyway, as usual :)
Guillaume
2017-10-03 9:50 GMT+02:00 Guillaume Delhumeau <
guillaume.delhumeau@xwiki.com
>:
> > > 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: > >> >> > On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
>> > >> > >> >> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net
wrote:
>> >> >> >> Another feedback/questions: >> >> >> >> * Is the avatar icon clickable and leading to the user profile? >> >> * We need a way to link directly to the diff, at least for page events >> so that the user can see what was modified (as we have currently in the AS) >> > >> > * Maybe “2 hours ago” is not precise enough. In your example I see I >> created and modified the Roadmap page but they both say “2 hours ago”. >> Shouldn’t I be able to see how far away both events were done? >> >> My understanding is that events are grouped by app+type but not by entity >> anymore (for page events) and thus you can have 3 events displayed for the >> same page, f.ex: Creation, Modification, Deletion. >> > > And you could also have different users grouped in the same composite > event. So when you display the details, it would be nice to show which user > made each event, and I see you have removed this info. > > > >> >> Thanks >> -Vincent >> >> > >> > Thanks >> > -Vincent >> > >> >> >> >> Thanks >> >> -Vincent >> >> >> >>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net> wrote: >> >>> >> >>> >> >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >> valicac@gmail.com> wrote: >> >>>> >> >>>> Event Type: BlogPostPublishedEvent >> >>>> from >> >>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/Notification >> sImprovements9x#HEventTypes >> >>> >> >>> ok thanks, had missed this since I was reading from top to bottom and >> stopped at the overview :) >> >>> >> >>> However I don’t think it scales since it means one unique icon per >> combination of app type + event type. >> >>> >> >>> What would scale better is two icons: one for the app type and one >> for the event type. >> >>> >> >>> For example imagine that the Blog app had the following events: >> >>> * When a blog post is published >> >>> * When a blog post is created >> >>> * When a blog post is removed >> >>> >> >>> You wouldn’t be able to use the RSS icon to represent the 3 events. >> >>> >> >>> BTW the RSS icon isn’t necessarily representative of the Blog app. A >> lot of apps can have a RSS feed. >> >>> >> >>> That’s the main remark I have: it’s going to be harder and harder to >> find unique icons as we had more events to apps, especially if there’s only >> 1 icon that is supposed to combine both app type + event type. >> >>> >> >>> WDYT? >> >>> >> >>> Thanks >> >>> -Vincent >> >>> >> >>>> Thanks, >> >>>> Caty >> >>>> >> >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> >> wrote: >> >>>> >> >>>>> Hi Caty, >> >>>>> >> >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >> valicac@gmail.com> >> >>>>> wrote: >> >>>>>> >> >>>>>> Hi, >> >>>>>> >> >>>>>> I've created some improvements suggestions for our Notifications >> UI, see >> >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> >>>>> NotificationsImprovements9x >> >>>>>> >> >>>>>> Let me know what you think. >> >>>>> >> >>>>> Re the overview, I don’t see where you mention the app? >> >>>>> >> >>>>> For example, could you show how a new Blog post would be displayed >> and you >> >>>>> differentiate that for example from a Page creation or modification? >> >>>>> >> >>>>> Thanks >> >>>>> -Vincent >> >>>>> >> >>>>>> >> >>>>>> Thanks, >> >>>>>> Caty >> >>>>> >> >>>>> >> >>> >> >> >> > >> >> > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Thomas Mortagne
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the
AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I
created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <
valicac@gmail.com>
wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
> Hi Caty, > >> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> > wrote: >> >> Hi, >> >> I've created some improvements suggestions for our Notifications UI, see >> http://design.xwiki.org/xwiki/bin/view/Proposal/ > NotificationsImprovements9x >> >> Let me know what you think. > > Re the overview, I don’t see where you mention the app? > > For example, could you show how a new Blog post would be displayed and you > differentiate that for example from a Page creation or modification? > > Thanks > -Vincent > >> >> Thanks, >> Caty > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page
events
so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I
created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
But it's the way it is implemented right now. If we change that, it's not only an UI change, it's also on the API-side too. Or maybe we could display more than one avatar ? Other problem: the emails that the notifications module send are supposed to replace the watchlist at some point. Vincent already complained about the fact the events concerning documents are not displayed as a tree, corresponding to the hierarchy of the pages. I could think of a way to display the events as a tree, but if we decide to focus more on the users, we are going in two opposite directions. Do you plan to cover the email case in your proposals? Thanks,
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <
valicac@gmail.com> wrote:
> > Event Type: BlogPostPublishedEvent > from > http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
> Thanks, > Caty > > On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: > >> Hi Caty, >> >>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >> wrote: >>> >>> Hi, >>> >>> I've created some improvements suggestions for our Notifications UI, see >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9x >>> >>> Let me know what you think. >> >> Re the overview, I don’t see where you mention the app? >> >> For example, could you show how a new Blog post would be displayed and you >> differentiate that for example from a Page creation or modification? >> >> Thanks >> -Vincent >> >>> >>> Thanks, >>> Caty >> >>
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Wed, Oct 4, 2017 at 1:00 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net>
wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page
events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
But it's the way it is implemented right now. If we change that, it's not only an UI change, it's also on the API-side too. Or maybe we could display more than one avatar ?
The proposal is done as a prototype and I had no problems in displaying the events. Maybe there is something I'm missing? In theory, if another person changed something too, it should be displayed as a separate entry.
Other problem: the emails that the notifications module send are supposed to replace the watchlist at some point. Vincent already complained about the fact the events concerning documents are not displayed as a tree, corresponding to the hierarchy of the pages. I could think of a way to display the events as a tree, but if we decide to focus more on the users, we are going in two opposite directions.
Do you plan to cover the email case in your proposals?
I don't plan to cover that case. I am not sure what exactly it's the problem with the watchlist and why it should be displayed as a tree. If we like to propose an alternative view we could do it in a separate page, but the "Notifications menu" should be what users expect from a notification system and what they are used to see in other applications. If we want to propose something extra, more powerful, it should be additional and not the main design. Thanks, Caty
Thanks,
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
> > >> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >> >> Event Type: BlogPostPublishedEvent >> from >> http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes > > ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) > > However I don’t think it scales since it means one unique icon
per
combination of app type + event type.
> > What would scale better is two icons: one for the app type and one for the event type. > > For example imagine that the Blog app had the following events: > * When a blog post is published > * When a blog post is created > * When a blog post is removed > > You wouldn’t be able to use the RSS icon to represent the 3 events. > > BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. > > That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. > > WDYT? > > Thanks > -Vincent > >> Thanks, >> Caty >> >> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >> >>> Hi Caty, >>> >>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>> wrote: >>>> >>>> Hi, >>>> >>>> I've created some improvements suggestions for our Notifications UI, see >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>> NotificationsImprovements9x >>>> >>>> Let me know what you think. >>> >>> Re the overview, I don’t see where you mention the app? >>> >>> For example, could you show how a new Blog post would be displayed and you >>> differentiate that for example from a Page creation or modification? >>> >>> Thanks >>> -Vincent >>> >>>> >>>> Thanks, >>>> Caty >>> >>> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On 4 Oct 2017, at 12:34, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Wed, Oct 4, 2017 at 1:00 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net>
wrote:
> > Another feedback/questions: > > * Is the avatar icon clickable and leading to the user profile? > * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
But it's the way it is implemented right now. If we change that, it's not only an UI change, it's also on the API-side too. Or maybe we could display more than one avatar ?
The proposal is done as a prototype and I had no problems in displaying the events. Maybe there is something I'm missing? In theory, if another person changed something too, it should be displayed as a separate entry.
Other problem: the emails that the notifications module send are supposed to replace the watchlist at some point. Vincent already complained about the fact the events concerning documents are not displayed as a tree, corresponding to the hierarchy of the pages. I could think of a way to display the events as a tree, but if we decide to focus more on the users, we are going in two opposite directions.
Do you plan to cover the email case in your proposals?
I don't plan to cover that case.
Actually, could you cover it too please in your designs? It’s important that we cover it because we’re planning to replace the watchlist email with the notifications email so we need to have something at least as good from user/usability POV.
I am not sure what exactly it's the problem with the watchlist and why it should be displayed as a tree.
If you check the watchlist emails we receive from xwiki.org you’ll see the TOC at the top right of the mail. This is very useful to navigate the email, when there are several page changes. Since 99% of the events we send and that will arrive in the watchlist are document-related events, I would find it a pity that we drop the concept of having a watchlist email TOC that helps you navigate in the mail. We don’t necessarily need the same TOC but I think we need some kind of TOC to navigate the mail (which can be large pretty fast). When users upgrade to XWiki 9.10+ and start receiving the new notification emails they need to find it better than what they had previously. If we remove the TOC, will they still be able to think that? That’s the question we need to answer. They won’t care that our system is more generic if it’s less usable. Thanks -Vincent
If we like to propose an alternative view we could do it in a separate page, but the "Notifications menu" should be what users expect from a notification system and what they are used to see in other applications. If we want to propose something extra, more powerful, it should be additional and not the main design.
Thanks, Caty
Thanks,
Thanks -Vincent
Thanks -Vincent
> > Thanks > -Vincent > >> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>> >> >>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >>> >>> Event Type: BlogPostPublishedEvent >>> from >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes >> >> ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) >> >> However I don’t think it scales since it means one unique icon
per
combination of app type + event type.
>> >> What would scale better is two icons: one for the app type and one for the event type. >> >> For example imagine that the Blog app had the following events: >> * When a blog post is published >> * When a blog post is created >> * When a blog post is removed >> >> You wouldn’t be able to use the RSS icon to represent the 3 events. >> >> BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. >> >> That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. >> >> WDYT? >> >> Thanks >> -Vincent >> >>> Thanks, >>> Caty >>> >>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >>> >>>> Hi Caty, >>>> >>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I've created some improvements suggestions for our Notifications UI, see >>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>> NotificationsImprovements9x >>>>> >>>>> Let me know what you think. >>>> >>>> Re the overview, I don’t see where you mention the app? >>>> >>>> For example, could you show how a new Blog post would be displayed and you >>>> differentiate that for example from a Page creation or modification? >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>> Thanks, >>>>> Caty >>>> >>>> >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page
events
so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I
created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png Thanks,
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <
valicac@gmail.com> wrote:
> > Event Type: BlogPostPublishedEvent > from > http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
> Thanks, > Caty > > On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: > >> Hi Caty, >> >>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >> wrote: >>> >>> Hi, >>> >>> I've created some improvements suggestions for our Notifications UI, see >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9x >>> >>> Let me know what you think. >> >> Re the overview, I don’t see where you mention the app? >> >> For example, could you show how a new Blog post would be displayed and you >> differentiate that for example from a Page creation or modification? >> >> Thanks >> -Vincent >> >>> >>> Thanks, >>> Caty >> >>
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xE... I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar. What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling. You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.) Let me know, Caty On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net>
wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page
events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png
On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png
Thanks,
Thanks -Vincent
Thanks -Vincent
Thanks -Vincent
> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
> > >> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >> >> Event Type: BlogPostPublishedEvent >> from >> http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes > > ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :) > > However I don’t think it scales since it means one unique icon
per
combination of app type + event type.
> > What would scale better is two icons: one for the app type and one for the event type. > > For example imagine that the Blog app had the following events: > * When a blog post is published > * When a blog post is created > * When a blog post is removed > > You wouldn’t be able to use the RSS icon to represent the 3 events. > > BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. > > That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. > > WDYT? > > Thanks > -Vincent > >> Thanks, >> Caty >> >> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >> >>> Hi Caty, >>> >>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>> wrote: >>>> >>>> Hi, >>>> >>>> I've created some improvements suggestions for our Notifications UI, see >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>> NotificationsImprovements9x >>>> >>>> Let me know what you think. >>> >>> Re the overview, I don’t see where you mention the app? >>> >>> For example, could you show how a new Blog post would be displayed and you >>> differentiate that for example from a Page creation or modification? >>> >>> Thanks >>> -Vincent >>> >>>> >>>> Thanks, >>>> Caty >>> >>> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
First of all, it looks very nice. Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example. Nice CSS expand! Thanks you, 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail
I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar.
What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling.
You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result
If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.)
Let me know, Caty
On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com :
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net>
wrote:
> > Another feedback/questions: > > * Is the avatar icon clickable and leading to the user profile? > * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png
On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png
Thanks,
Thanks -Vincent
Thanks -Vincent
> > Thanks > -Vincent > >> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>> >> >>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >>> >>> Event Type: BlogPostPublishedEvent >>> from >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes >> >> ok thanks, had missed this since I was reading from top to
bottom
and
stopped at the overview :)
>> >> However I don’t think it scales since it means one unique icon per combination of app type + event type. >> >> What would scale better is two icons: one for the app type and one for the event type. >> >> For example imagine that the Blog app had the following events: >> * When a blog post is published >> * When a blog post is created >> * When a blog post is removed >> >> You wouldn’t be able to use the RSS icon to represent the 3 events. >> >> BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. >> >> That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. >> >> WDYT? >> >> Thanks >> -Vincent >> >>> Thanks, >>> Caty >>> >>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >>> >>>> Hi Caty, >>>> >>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>>> wrote: >>>>> >>>>> Hi, >>>>> >>>>> I've created some improvements suggestions for our Notifications UI, see >>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>> NotificationsImprovements9x >>>>> >>>>> Let me know what you think. >>>> >>>> Re the overview, I don’t see where you mention the app? >>>> >>>> For example, could you show how a new Blog post would be displayed and you >>>> differentiate that for example from a Page creation or modification? >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>> Thanks, >>>>> Caty >>>> >>>> >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Looks nice. Does it work in all mail clients that support HTML? I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you want to check everything). Same as Guillaume: not all events are page-related events. So we need to handle those too. Thanks! -Vincent
On 12 Oct 2017, at 15:03, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
First of all, it looks very nice.
Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example.
Nice CSS expand!
Thanks you,
2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail
I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar.
What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling.
You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result
If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.)
Let me know, Caty
On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com :
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net>
wrote:
> > >> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: >> >> Another feedback/questions: >> >> * Is the avatar icon clickable and leading to the user profile? >> * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS) > > * Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
My understanding is that events are grouped by app+type but not by entity anymore (for page events) and thus you can have 3 events displayed for the same page, f.ex: Creation, Modification, Deletion.
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png
On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png
Thanks,
Thanks -Vincent
> > Thanks > -Vincent > >> >> Thanks >> -Vincent >> >>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>>> >>> >>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote: >>>> >>>> Event Type: BlogPostPublishedEvent >>>> from >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes >>> >>> ok thanks, had missed this since I was reading from top to
bottom
and
stopped at the overview :) >>> >>> However I don’t think it scales since it means one unique icon per combination of app type + event type. >>> >>> What would scale better is two icons: one for the app type and one for the event type. >>> >>> For example imagine that the Blog app had the following events: >>> * When a blog post is published >>> * When a blog post is created >>> * When a blog post is removed >>> >>> You wouldn’t be able to use the RSS icon to represent the 3 events. >>> >>> BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed. >>> >>> That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type. >>> >>> WDYT? >>> >>> Thanks >>> -Vincent >>> >>>> Thanks, >>>> Caty >>>> >>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> wrote: >>>> >>>>> Hi Caty, >>>>> >>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> >>>>> wrote: >>>>>> >>>>>> Hi, >>>>>> >>>>>> I've created some improvements suggestions for our Notifications UI, see >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>> NotificationsImprovements9x >>>>>> >>>>>> Let me know what you think. >>>>> >>>>> Re the overview, I don’t see where you mention the app? >>>>> >>>>> For example, could you show how a new Blog post would be displayed and you >>>>> differentiate that for example from a Page creation or modification? >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> Thanks, >>>>>> Caty >>>>> >>>>> >>> >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Some ideas. I have feedback about the fact the diff is way too technical for users. Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png So we could hide this in a "technical details" link. The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details view). In the body of the event, in addition with the title of the document, we could add some extracts of the diff. Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png I hope it helps, Thanks 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you want to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
First of all, it looks very nice.
Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example.
Nice CSS expand!
Thanks you,
2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com :
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail
I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar.
What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling.
You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result
If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.)
Let me know, Caty
On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>:
> >> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote: >> >> >>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: >>> >>> Another feedback/questions: >>> >>> * Is the avatar icon clickable and leading to the user profile? >>> * We need a way to link directly to the diff, at least for page events > so that the user can see what was modified (as we have currently in the AS) >> >> * Maybe “2 hours ago” is not precise enough. In your example I see I > created and modified the Roadmap page but they both say “2 hours ago”. > Shouldn’t I be able to see how far away both events were done? > > My understanding is that events are grouped by app+type but not by entity > anymore (for page events) and thus you can have 3 events displayed for the > same page, f.ex: Creation, Modification, Deletion. >
And you could also have different users grouped in the same composite event. So when you display the details, it would be nice to show which user made each event, and I see you have removed this info.
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png
On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png
Thanks,
> > Thanks > -Vincent > >> >> Thanks >> -Vincent >> >>> >>> Thanks >>> -Vincent >>> >>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net>
wrote:
>>>> >>>> >>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < valicac@gmail.com> > wrote: >>>>> >>>>> Event Type: BlogPostPublishedEvent >>>>> from >>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ > NotificationsImprovements9x#HEventTypes >>>> >>>> ok thanks, had missed this since I was reading from top to
bottom
and
> stopped at the overview :) >>>> >>>> However I don’t think it scales since it means one unique icon per > combination of app type + event type. >>>> >>>> What would scale better is two icons: one for the app type and one for > the event type. >>>> >>>> For example imagine that the Blog app had the following events: >>>> * When a blog post is published >>>> * When a blog post is created >>>> * When a blog post is removed >>>> >>>> You wouldn’t be able to use the RSS icon to represent the 3 events. >>>> >>>> BTW the RSS icon isn’t necessarily representative of the Blog app. A > lot of apps can have a RSS feed. >>>> >>>> That’s the main remark I have: it’s going to be harder and harder to > find unique icons as we had more events to apps, especially if there’s only > 1 icon that is supposed to combine both app type + event type. >>>> >>>> WDYT? >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> Thanks, >>>>> Caty >>>>> >>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> > wrote: >>>>> >>>>>> Hi Caty, >>>>>> >>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < > valicac@gmail.com> >>>>>> wrote: >>>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> I've created some improvements suggestions for our Notifications > UI, see >>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>> NotificationsImprovements9x >>>>>>> >>>>>>> Let me know what you think. >>>>>> >>>>>> Re the overview, I don’t see where you mention the app? >>>>>> >>>>>> For example, could you show how a new Blog post would be displayed > and you >>>>>> differentiate that for example from a Page creation or modification? >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Caty >>>>>> >>>>>> >>>> >>> >> > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs. For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once. Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details view).
In the body of the event, in addition with the title of the document, we could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you want to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
First of all, it looks very nice.
Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example.
Nice CSS expand!
Thanks you,
2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com :
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail
I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar.
What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling.
You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result
If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.)
Let me know, Caty
On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: > >> >>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote: >>> >>> >>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: >>>> >>>> Another feedback/questions: >>>> >>>> * Is the avatar icon clickable and leading to the user profile? >>>> * We need a way to link directly to the diff, at least for page events >> so that the user can see what was modified (as we have currently in the > AS) >>> >>> * Maybe “2 hours ago” is not precise enough. In your example I see I >> created and modified the Roadmap page but they both say “2 hours ago”. >> Shouldn’t I be able to see how far away both events were done? >> >> My understanding is that events are grouped by app+type but not by entity >> anymore (for page events) and thus you can have 3 events displayed for > the >> same page, f.ex: Creation, Modification, Deletion. >> > > And you could also have different users grouped in the same composite > event. So when you display the details, it would be nice to show which user > made each event, and I see you have removed this info. >
The focus of this proposal is on user, compared to the old one, when it was on the app/doc. Close to what we have on Facebool. So it didn't made sense that we say that a page has been edited by vmassol, and that the details showcase that multiple user actually did the edit.
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png
On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png
Thanks,
> > > >> >> Thanks >> -Vincent >> >>> >>> Thanks >>> -Vincent >>> >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote: >>>>> >>>>> >>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < > valicac@gmail.com> >> wrote: >>>>>> >>>>>> Event Type: BlogPostPublishedEvent >>>>>> from >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9x#HEventTypes >>>>> >>>>> ok thanks, had missed this since I was reading from top to
bottom
and >> stopped at the overview :) >>>>> >>>>> However I don’t think it scales since it means one unique icon per >> combination of app type + event type. >>>>> >>>>> What would scale better is two icons: one for the app type and one > for >> the event type. >>>>> >>>>> For example imagine that the Blog app had the following events: >>>>> * When a blog post is published >>>>> * When a blog post is created >>>>> * When a blog post is removed >>>>> >>>>> You wouldn’t be able to use the RSS icon to represent the 3 events. >>>>> >>>>> BTW the RSS icon isn’t necessarily representative of the Blog app. A >> lot of apps can have a RSS feed. >>>>> >>>>> That’s the main remark I have: it’s going to be harder and harder to >> find unique icons as we had more events to apps, especially if there’s > only >> 1 icon that is supposed to combine both app type + event type. >>>>> >>>>> WDYT? >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> Thanks, >>>>>> Caty >>>>>> >>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < vincent@massol.net> >> wrote: >>>>>> >>>>>>> Hi Caty, >>>>>>> >>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >> valicac@gmail.com> >>>>>>> wrote: >>>>>>>> >>>>>>>> Hi, >>>>>>>> >>>>>>>> I've created some improvements suggestions for our Notifications >> UI, see >>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>> NotificationsImprovements9x >>>>>>>> >>>>>>>> Let me know what you think. >>>>>>> >>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>> >>>>>>> For example, could you show how a new Blog post would be displayed >> and you >>>>>>> differentiate that for example from a Page creation or > modification? >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Caty >>>>>>> >>>>>>> >>>>> >>>> >>> >> >> > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/83b76ed4c26954aa2755bbdce23b32c... but it's not documented yet. This mail template allows you to customize the header and the footer of the email, but not the actual content. To be precise, each *event type* can have its own template or failback to the default one ( https://github.com/xwiki/xwiki-platform/blob/acdf68f4c0d20a9b44ea48eec4df808... ) So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example. 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details
view).
In the body of the event, in addition with the title of the document, we could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you
want
to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
First of all, it looks very nice.
Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example.
Nice CSS expand!
Thanks you,
2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail
I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar.
What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling.
You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result
If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.)
Let me know, Caty
On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: > >> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: >> >>> >>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> wrote: >>>> >>>> >>>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote: >>>>> >>>>> Another feedback/questions: >>>>> >>>>> * Is the avatar icon clickable and leading to the user profile? >>>>> * We need a way to link directly to the diff, at least for page > events >>> so that the user can see what was modified (as we have currently in the >> AS) >>>> >>>> * Maybe “2 hours ago” is not precise enough. In your example I see I >>> created and modified the Roadmap page but they both say “2 hours ago”. >>> Shouldn’t I be able to see how far away both events were done? >>> >>> My understanding is that events are grouped by app+type but not by > entity >>> anymore (for page events) and thus you can have 3 events displayed for >> the >>> same page, f.ex: Creation, Modification, Deletion. >>> >> >> And you could also have different users grouped in the same composite >> event. So when you display the details, it would be nice to show which > user >> made each event, and I see you have removed this info. >> > > The focus of this proposal is on user, compared to the old one, when it was > on the app/doc. > Close to what we have on Facebool. So it didn't made sense that we say that > a page has been edited by vmassol, and that the details showcase that > multiple user actually did the edit. >
In Facebook, you have it actually: https://pasteboard.co/GOioRAT.png
On XWiki, we have the following (already implemented): https://pasteboard.co/GOiqgYf.png
Thanks,
> > >> >> >> >>> >>> Thanks >>> -Vincent >>> >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> > wrote: >>>>>> >>>>>> >>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >> valicac@gmail.com> >>> wrote: >>>>>>> >>>>>>> Event Type: BlogPostPublishedEvent >>>>>>> from >>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>> NotificationsImprovements9x#HEventTypes >>>>>> >>>>>> ok thanks, had missed this since I was reading from top to bottom > and >>> stopped at the overview :) >>>>>> >>>>>> However I don’t think it scales since it means one unique icon per >>> combination of app type + event type. >>>>>> >>>>>> What would scale better is two icons: one for the app type and one >> for >>> the event type. >>>>>> >>>>>> For example imagine that the Blog app had the following events: >>>>>> * When a blog post is published >>>>>> * When a blog post is created >>>>>> * When a blog post is removed >>>>>> >>>>>> You wouldn’t be able to use the RSS icon to represent the 3 events. >>>>>> >>>>>> BTW the RSS icon isn’t necessarily representative of the Blog app. > A >>> lot of apps can have a RSS feed. >>>>>> >>>>>> That’s the main remark I have: it’s going to be harder and harder > to >>> find unique icons as we had more events to apps, especially if there’s >> only >>> 1 icon that is supposed to combine both app type + event type. >>>>>> >>>>>> WDYT? >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> Thanks, >>>>>>> Caty >>>>>>> >>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < > vincent@massol.net> >>> wrote: >>>>>>> >>>>>>>> Hi Caty, >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>> valicac@gmail.com> >>>>>>>> wrote: >>>>>>>>> >>>>>>>>> Hi, >>>>>>>>> >>>>>>>>> I've created some improvements suggestions for our Notifications >>> UI, see >>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>> NotificationsImprovements9x >>>>>>>>> >>>>>>>>> Let me know what you think. >>>>>>>> >>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>> >>>>>>>> For example, could you show how a new Blog post would be > displayed >>> and you >>>>>>>> differentiate that for example from a Page creation or >> modification? >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Caty >>>>>>>> >>>>>>>> >>>>>> >>>>> >>>> >>> >>> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Any news on this? I'd like to implement this quickly because 9.10 is coming :) 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer of the email, but not the actual content.
To be precise, each *event type* can have its own template or failback to the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details
view).
In the body of the event, in addition with the title of the document, we could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you
want
to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
First of all, it looks very nice.
Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example.
Nice CSS expand!
Thanks you,
2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
This is a proposal for the Notifications mail: http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail
I've continued with the 'user' avatar focused proposal, since I've currently focused on the email template. If we drop the user avatar (since we group multiple users) then we can have the event/app icon instead of the avatar.
What I want to have feedback on is the email layout, functionality (tree navigation, details expanding) and styling.
You can play with the Prototype http://jsfiddle.net/risherry/cj25759w/embedded/#Result
If we were to translate to the mail template, there are still some things to be tested (like translating the CSS selectors into inline, decide what email clients we support, etc.)
Let me know, Caty
On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com > : > >> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >> >>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: >>> >>>> >>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> > wrote: >>>>> >>>>> >>>>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> > wrote: >>>>>> >>>>>> Another feedback/questions: >>>>>> >>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>> * We need a way to link directly to the diff, at least for page >> events >>>> so that the user can see what was modified (as we have currently in > the >>> AS) >>>>> >>>>> * Maybe “2 hours ago” is not precise enough. In your example I see > I >>>> created and modified the Roadmap page but they both say “2 hours > ago”. >>>> Shouldn’t I be able to see how far away both events were done? >>>> >>>> My understanding is that events are grouped by app+type but not by >> entity >>>> anymore (for page events) and thus you can have 3 events displayed > for >>> the >>>> same page, f.ex: Creation, Modification, Deletion. >>>> >>> >>> And you could also have different users grouped in the same composite >>> event. So when you display the details, it would be nice to show which >> user >>> made each event, and I see you have removed this info. >>> >> >> The focus of this proposal is on user, compared to the old one, when it > was >> on the app/doc. >> Close to what we have on Facebool. So it didn't made sense that we say > that >> a page has been edited by vmassol, and that the details showcase that >> multiple user actually did the edit. >> > > In Facebook, you have it actually: > https://pasteboard.co/GOioRAT.png > > On XWiki, we have the following (already implemented): > https://pasteboard.co/GOiqgYf.png > > > Thanks, > > >> >> >>> >>> >>> >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> >> wrote: >>>>>>> >>>>>>> >>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>> valicac@gmail.com> >>>> wrote: >>>>>>>> >>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>> from >>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>> NotificationsImprovements9x#HEventTypes >>>>>>> >>>>>>> ok thanks, had missed this since I was reading from top to bottom >> and >>>> stopped at the overview :) >>>>>>> >>>>>>> However I don’t think it scales since it means one unique icon > per >>>> combination of app type + event type. >>>>>>> >>>>>>> What would scale better is two icons: one for the app type and > one >>> for >>>> the event type. >>>>>>> >>>>>>> For example imagine that the Blog app had the following events: >>>>>>> * When a blog post is published >>>>>>> * When a blog post is created >>>>>>> * When a blog post is removed >>>>>>> >>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 > events. >>>>>>> >>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog > app. >> A >>>> lot of apps can have a RSS feed. >>>>>>> >>>>>>> That’s the main remark I have: it’s going to be harder and harder >> to >>>> find unique icons as we had more events to apps, especially if > there’s >>> only >>>> 1 icon that is supposed to combine both app type + event type. >>>>>>> >>>>>>> WDYT? >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> Thanks, >>>>>>>> Caty >>>>>>>> >>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >> vincent@massol.net> >>>> wrote: >>>>>>>> >>>>>>>>> Hi Caty, >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>> valicac@gmail.com> >>>>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Hi, >>>>>>>>>> >>>>>>>>>> I've created some improvements suggestions for our > Notifications >>>> UI, see >>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>> NotificationsImprovements9x >>>>>>>>>> >>>>>>>>>> Let me know what you think. >>>>>>>>> >>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>> >>>>>>>>> For example, could you show how a new Blog post would be >> displayed >>>> and you >>>>>>>>> differentiate that for example from a Page creation or >>> modification? >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Caty >>>>>>>>> >>>>>>>>> >>>>>>> >>>>>> >>>>> >>>> >>>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >>> >> > > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points So I guess we need to decide about whether we show the avatar as in Caty’s proposal or not, right? Is that what you’re asking about Guillaume? On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events. Thanks -Vincent
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer of the email, but not the actual content.
To be precise, each *event type* can have its own template or failback to the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details
view).
In the body of the event, in addition with the title of the document, we could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you
want
to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
First of all, it looks very nice.
Now, you said the events are displayed like in the notifications, but in the notifications they are ordered by dates, not by pages. Does your proposal imply to change the ordering? What about events that do not concern any page (like: "a new wiki has been created" or "a new XWiki version is available")? We don't have such events for now but we plan to have some soon. We could display them last for example.
Nice CSS expand!
Thanks you,
2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com :
> This is a proposal for the Notifications mail: > http://design.xwiki.org/xwiki/bin/view/Proposal/ > NotificationsImprovements9xEmail > > I've continued with the 'user' avatar focused proposal, since I've > currently focused on the email template. If we drop the user avatar (since > we group multiple users) then we can have the event/app icon instead of the > avatar. > > What I want to have feedback on is the email layout, functionality (tree > navigation, details expanding) and styling. > > You can play with the Prototype > http://jsfiddle.net/risherry/cj25759w/embedded/#Result > > If we were to translate to the mail template, there are still some things > to be tested (like translating the CSS selectors into inline, decide what > email clients we support, etc.) > > Let me know, > Caty > > > On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: > >> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com >> : >> >>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>> >>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>> >>>>> >>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> >> wrote: >>>>>> >>>>>> >>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> >> wrote: >>>>>>> >>>>>>> Another feedback/questions: >>>>>>> >>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>> * We need a way to link directly to the diff, at least for page >>> events >>>>> so that the user can see what was modified (as we have currently in >> the >>>> AS) >>>>>> >>>>>> * Maybe “2 hours ago” is not precise enough. In your example I > see >> I >>>>> created and modified the Roadmap page but they both say “2 hours >> ago”. >>>>> Shouldn’t I be able to see how far away both events were done? >>>>> >>>>> My understanding is that events are grouped by app+type but not by >>> entity >>>>> anymore (for page events) and thus you can have 3 events displayed >> for >>>> the >>>>> same page, f.ex: Creation, Modification, Deletion. >>>>> >>>> >>>> And you could also have different users grouped in the same composite >>>> event. So when you display the details, it would be nice to show > which >>> user >>>> made each event, and I see you have removed this info. >>>> >>> >>> The focus of this proposal is on user, compared to the old one, when it >> was >>> on the app/doc. >>> Close to what we have on Facebool. So it didn't made sense that we say >> that >>> a page has been edited by vmassol, and that the details showcase that >>> multiple user actually did the edit. >>> >> >> In Facebook, you have it actually: >> https://pasteboard.co/GOioRAT.png >> >> On XWiki, we have the following (already implemented): >> https://pasteboard.co/GOiqgYf.png >> >> >> Thanks, >> >> >>> >>> >>>> >>>> >>>> >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> >>> wrote: >>>>>>>> >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>> valicac@gmail.com> >>>>> wrote: >>>>>>>>> >>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>> from >>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>> NotificationsImprovements9x#HEventTypes >>>>>>>> >>>>>>>> ok thanks, had missed this since I was reading from top to > bottom >>> and >>>>> stopped at the overview :) >>>>>>>> >>>>>>>> However I don’t think it scales since it means one unique icon >> per >>>>> combination of app type + event type. >>>>>>>> >>>>>>>> What would scale better is two icons: one for the app type and >> one >>>> for >>>>> the event type. >>>>>>>> >>>>>>>> For example imagine that the Blog app had the following events: >>>>>>>> * When a blog post is published >>>>>>>> * When a blog post is created >>>>>>>> * When a blog post is removed >>>>>>>> >>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >> events. >>>>>>>> >>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >> app. >>> A >>>>> lot of apps can have a RSS feed. >>>>>>>> >>>>>>>> That’s the main remark I have: it’s going to be harder and > harder >>> to >>>>> find unique icons as we had more events to apps, especially if >> there’s >>>> only >>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>> >>>>>>>> WDYT? >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Caty >>>>>>>>> >>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>> vincent@massol.net> >>>>> wrote: >>>>>>>>> >>>>>>>>>> Hi Caty, >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>> valicac@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Hi, >>>>>>>>>>> >>>>>>>>>>> I've created some improvements suggestions for our >> Notifications >>>>> UI, see >>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>> >>>>>>>>>>> Let me know what you think. >>>>>>>>>> >>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>> >>>>>>>>>> For example, could you show how a new Blog post would be >>> displayed >>>>> and you >>>>>>>>>> differentiate that for example from a Page creation or >>>> modification? >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Caty >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>> >>>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>>> >>> >> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >> >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
I don't have any new proposal right now. I could do another iteration starting from tomorrow. Thanks, Caty On Tue, Oct 24, 2017 at 12:12 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
So I guess we need to decide about whether we show the avatar as in Caty’s proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer of the email, but not the actual content.
To be precise, each *event type* can have its own template or failback
to
the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details
view).
In the body of the event, in addition with the title of the document,
we
could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you want to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote: > > First of all, it looks very nice. > > Now, you said the events are displayed like in the notifications, but in > the notifications they are ordered by dates, not by pages. Does your > proposal imply to change the ordering? What about events that do not > concern any page (like: "a new wiki has been created" or "a new XWiki > version is available")? We don't have such events for now but we plan to > have some soon. We could display them last for example. > > Nice CSS expand! > > Thanks you, > > 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com > : > >> This is a proposal for the Notifications mail: >> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9xEmail >> >> I've continued with the 'user' avatar focused proposal, since I've >> currently focused on the email template. If we drop the user avatar (since >> we group multiple users) then we can have the event/app icon instead of the >> avatar. >> >> What I want to have feedback on is the email layout, functionality (tree >> navigation, details expanding) and styling. >> >> You can play with the Prototype >> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >> >> If we were to translate to the mail template, there are still some things >> to be tested (like translating the CSS selectors into inline, decide what >> email clients we support, etc.) >> >> Let me know, >> Caty >> >> >> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >> >>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com >>> : >>> >>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>> >>>>>> >>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> >>> wrote: >>>>>>> >>>>>>> >>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> >>> wrote: >>>>>>>> >>>>>>>> Another feedback/questions: >>>>>>>> >>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>> * We need a way to link directly to the diff, at least for page >>>> events >>>>>> so that the user can see what was modified (as we have currently in >>> the >>>>> AS) >>>>>>> >>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >> see >>> I >>>>>> created and modified the Roadmap page but they both say “2 hours >>> ago”. >>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>> >>>>>> My understanding is that events are grouped by app+type but not by >>>> entity >>>>>> anymore (for page events) and thus you can have 3 events displayed >>> for >>>>> the >>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>> >>>>> >>>>> And you could also have different users grouped in the same composite >>>>> event. So when you display the details, it would be nice to show >> which >>>> user >>>>> made each event, and I see you have removed this info. >>>>> >>>> >>>> The focus of this proposal is on user, compared to the old one, when it >>> was >>>> on the app/doc. >>>> Close to what we have on Facebool. So it didn't made sense that we say >>> that >>>> a page has been edited by vmassol, and that the details showcase that >>>> multiple user actually did the edit. >>>> >>> >>> In Facebook, you have it actually: >>> https://pasteboard.co/GOioRAT.png >>> >>> On XWiki, we have the following (already implemented): >>> https://pasteboard.co/GOiqgYf.png >>> >>> >>> Thanks, >>> >>> >>>> >>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net
>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>> valicac@gmail.com> >>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>> from >>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>> >>>>>>>>> ok thanks, had missed this since I was reading from top to >> bottom >>>> and >>>>>> stopped at the overview :) >>>>>>>>> >>>>>>>>> However I don’t think it scales since it means one unique icon >>> per >>>>>> combination of app type + event type. >>>>>>>>> >>>>>>>>> What would scale better is two icons: one for the app type and >>> one >>>>> for >>>>>> the event type. >>>>>>>>> >>>>>>>>> For example imagine that the Blog app had the following events: >>>>>>>>> * When a blog post is published >>>>>>>>> * When a blog post is created >>>>>>>>> * When a blog post is removed >>>>>>>>> >>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>> events. >>>>>>>>> >>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>> app. >>>> A >>>>>> lot of apps can have a RSS feed. >>>>>>>>> >>>>>>>>> That’s the main remark I have: it’s going to be harder and >> harder >>>> to >>>>>> find unique icons as we had more events to apps, especially if >>> there’s >>>>> only >>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>> >>>>>>>>> WDYT? >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Caty >>>>>>>>>> >>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>> vincent@massol.net> >>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Caty, >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>> valicac@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> I've created some improvements suggestions for our >>> Notifications >>>>>> UI, see >>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>> >>>>>>>>>>>> Let me know what you think. >>>>>>>>>>> >>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>> >>>>>>>>>>> For example, could you show how a new Blog post would be >>>> displayed >>>>>> and you >>>>>>>>>>> differentiate that for example from a Page creation or >>>>> modification? >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Caty >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>>> >>>> >>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >>> >> > > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
2017-10-24 11:16 GMT+02:00 Ecaterina Moraru (Valica) <valicac@gmail.com>:
I don't have any new proposal right now. I could do another iteration starting from tomorrow.
If you need help, please ask me. I'll switch to an other topic until I can implement your ideas. Thanks,
Thanks, Caty
On Tue, Oct 24, 2017 at 12:12 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
So I guess we need to decide about whether we show the avatar as in Caty’s proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer
of
the email, but not the actual content.
To be precise, each *event type* can have its own template or failback to the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical
details view).
In the body of the event, in addition with the title of the
document, we
could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
> Looks nice. Does it work in all mail clients that support HTML? > > I'd like an option to show the details for all events as otherwise it's > too painful to have to open all one by one (for the use case when you want > to check everything). > > Same as Guillaume: not all events are page-related events. So we need to > handle those too. > > Thanks! > -Vincent > >> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: >> >> First of all, it looks very nice. >> >> Now, you said the events are displayed like in the notifications, but in >> the notifications they are ordered by dates, not by pages. Does your >> proposal imply to change the ordering? What about events that do not >> concern any page (like: "a new wiki has been created" or "a new XWiki >> version is available")? We don't have such events for now but we plan to >> have some soon. We could display them last for example. >> >> Nice CSS expand! >> >> Thanks you, >> >> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com >> : >> >>> This is a proposal for the Notifications mail: >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>> NotificationsImprovements9xEmail >>> >>> I've continued with the 'user' avatar focused proposal, since I've >>> currently focused on the email template. If we drop the user avatar > (since >>> we group multiple users) then we can have the event/app icon instead of > the >>> avatar. >>> >>> What I want to have feedback on is the email layout, functionality (tree >>> navigation, details expanding) and styling. >>> >>> You can play with the Prototype >>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>> >>> If we were to translate to the mail template, there are still some > things >>> to be tested (like translating the CSS selectors into inline, decide > what >>> email clients we support, etc.) >>> >>> Let me know, >>> Caty >>> >>> >>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>> >>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < > valicac@gmail.com >>>> : >>>> >>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>> >>>>>>> >>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net
>>>> wrote: >>>>>>>> >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>> wrote: >>>>>>>>> >>>>>>>>> Another feedback/questions: >>>>>>>>> >>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>> events >>>>>>> so that the user can see what was modified (as we have currently in >>>> the >>>>>> AS) >>>>>>>> >>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>> see >>>> I >>>>>>> created and modified the Roadmap page but they both say “2 hours >>>> ago”. >>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>> >>>>>>> My understanding is that events are grouped by app+type but not by >>>>> entity >>>>>>> anymore (for page events) and thus you can have 3 events displayed >>>> for >>>>>> the >>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>> >>>>>> >>>>>> And you could also have different users grouped in the same composite >>>>>> event. So when you display the details, it would be nice to show >>> which >>>>> user >>>>>> made each event, and I see you have removed this info. >>>>>> >>>>> >>>>> The focus of this proposal is on user, compared to the old one, when > it >>>> was >>>>> on the app/doc. >>>>> Close to what we have on Facebool. So it didn't made sense that we say >>>> that >>>>> a page has been edited by vmassol, and that the details showcase that >>>>> multiple user actually did the edit. >>>>> >>>> >>>> In Facebook, you have it actually: >>>> https://pasteboard.co/GOioRAT.png >>>> >>>> On XWiki, we have the following (already implemented): >>>> https://pasteboard.co/GOiqgYf.png >>>> >>>> >>>> Thanks, >>>> >>>> >>>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net
>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>> valicac@gmail.com> >>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>> from >>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>> >>>>>>>>>> ok thanks, had missed this since I was reading from top to >>> bottom >>>>> and >>>>>>> stopped at the overview :) >>>>>>>>>> >>>>>>>>>> However I don’t think it scales since it means one unique icon >>>> per >>>>>>> combination of app type + event type. >>>>>>>>>> >>>>>>>>>> What would scale better is two icons: one for the app type and >>>> one >>>>>> for >>>>>>> the event type. >>>>>>>>>> >>>>>>>>>> For example imagine that the Blog app had the following events: >>>>>>>>>> * When a blog post is published >>>>>>>>>> * When a blog post is created >>>>>>>>>> * When a blog post is removed >>>>>>>>>> >>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>> events. >>>>>>>>>> >>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>> app. >>>>> A >>>>>>> lot of apps can have a RSS feed. >>>>>>>>>> >>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>> harder >>>>> to >>>>>>> find unique icons as we had more events to apps, especially if >>>> there’s >>>>>> only >>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>> >>>>>>>>>> WDYT? >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Caty >>>>>>>>>>> >>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>> vincent@massol.net> >>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Caty, >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>> valicac@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> I've created some improvements suggestions for our >>>> Notifications >>>>>>> UI, see >>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>> >>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>> >>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>> >>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>> displayed >>>>>>> and you >>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>> modification? >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Caty >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>>> >>> >> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hello 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
So I guess we need to decide about whether we show the avatar as in Caty’s proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer of the email, but not the actual content.
To be precise, each *event type* can have its own template or failback
to
the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details
view).
In the body of the event, in addition with the title of the document,
we
could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
Looks nice. Does it work in all mail clients that support HTML?
I'd like an option to show the details for all events as otherwise it's too painful to have to open all one by one (for the use case when you want to check everything).
Same as Guillaume: not all events are page-related events. So we need to handle those too.
Thanks! -Vincent
> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote: > > First of all, it looks very nice. > > Now, you said the events are displayed like in the notifications, but in > the notifications they are ordered by dates, not by pages. Does your > proposal imply to change the ordering? What about events that do not > concern any page (like: "a new wiki has been created" or "a new XWiki > version is available")? We don't have such events for now but we plan to > have some soon. We could display them last for example. > > Nice CSS expand! > > Thanks you, > > 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com > : > >> This is a proposal for the Notifications mail: >> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9xEmail >> >> I've continued with the 'user' avatar focused proposal, since I've >> currently focused on the email template. If we drop the user avatar (since >> we group multiple users) then we can have the event/app icon instead of the >> avatar. >> >> What I want to have feedback on is the email layout, functionality (tree >> navigation, details expanding) and styling. >> >> You can play with the Prototype >> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >> >> If we were to translate to the mail template, there are still some things >> to be tested (like translating the CSS selectors into inline, decide what >> email clients we support, etc.) >> >> Let me know, >> Caty >> >> >> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >> >>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com >>> : >>> >>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>> >>>>>> >>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> >>> wrote: >>>>>>> >>>>>>> >>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> >>> wrote: >>>>>>>> >>>>>>>> Another feedback/questions: >>>>>>>> >>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>> * We need a way to link directly to the diff, at least for page >>>> events >>>>>> so that the user can see what was modified (as we have currently in >>> the >>>>> AS) >>>>>>> >>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >> see >>> I >>>>>> created and modified the Roadmap page but they both say “2 hours >>> ago”. >>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>> >>>>>> My understanding is that events are grouped by app+type but not by >>>> entity >>>>>> anymore (for page events) and thus you can have 3 events displayed >>> for >>>>> the >>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>> >>>>> >>>>> And you could also have different users grouped in the same composite >>>>> event. So when you display the details, it would be nice to show >> which >>>> user >>>>> made each event, and I see you have removed this info. >>>>> >>>> >>>> The focus of this proposal is on user, compared to the old one, when it >>> was >>>> on the app/doc. >>>> Close to what we have on Facebool. So it didn't made sense that we say >>> that >>>> a page has been edited by vmassol, and that the details showcase that >>>> multiple user actually did the edit. >>>> >>> >>> In Facebook, you have it actually: >>> https://pasteboard.co/GOioRAT.png >>> >>> On XWiki, we have the following (already implemented): >>> https://pasteboard.co/GOiqgYf.png >>> >>> >>> Thanks, >>> >>> >>>> >>>> >>>>> >>>>> >>>>> >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net
>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>> valicac@gmail.com> >>>>>> wrote: >>>>>>>>>> >>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>> from >>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>> >>>>>>>>> ok thanks, had missed this since I was reading from top to >> bottom >>>> and >>>>>> stopped at the overview :) >>>>>>>>> >>>>>>>>> However I don’t think it scales since it means one unique icon >>> per >>>>>> combination of app type + event type. >>>>>>>>> >>>>>>>>> What would scale better is two icons: one for the app type and >>> one >>>>> for >>>>>> the event type. >>>>>>>>> >>>>>>>>> For example imagine that the Blog app had the following events: >>>>>>>>> * When a blog post is published >>>>>>>>> * When a blog post is created >>>>>>>>> * When a blog post is removed >>>>>>>>> >>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>> events. >>>>>>>>> >>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>> app. >>>> A >>>>>> lot of apps can have a RSS feed. >>>>>>>>> >>>>>>>>> That’s the main remark I have: it’s going to be harder and >> harder >>>> to >>>>>> find unique icons as we had more events to apps, especially if >>> there’s >>>>> only >>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>> >>>>>>>>> WDYT? >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> Caty >>>>>>>>>> >>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>> vincent@massol.net> >>>>>> wrote: >>>>>>>>>> >>>>>>>>>>> Hi Caty, >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>> valicac@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Hi, >>>>>>>>>>>> >>>>>>>>>>>> I've created some improvements suggestions for our >>> Notifications >>>>>> UI, see >>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>> >>>>>>>>>>>> Let me know what you think. >>>>>>>>>>> >>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>> >>>>>>>>>>> For example, could you show how a new Blog post would be >>>> displayed >>>>>> and you >>>>>>>>>>> differentiate that for example from a Page creation or >>>>> modification? >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Caty >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>>> >>>> >>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >>> >> > > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On 24 Oct 2017, at 11:24, Guillaume Delhumeau <guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions: * Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user. Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in Caty’s proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer of the email, but not the actual content.
To be precise, each *event type* can have its own template or failback
to
the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Some ideas.
I have feedback about the fact the diff is way too technical for users.
Example: "What does it means???" https://img15.hostingpics.net/ pics/670307example1.png
So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
The "details" link could be replaced by a "more" link, with a very simplified diff (the complete diff would go the the technical details
view).
In the body of the event, in addition with the title of the document,
we
could add some extracts of the diff.
Example taken on gmail: https://img15.hostingpics.net/pics/763456example2.png
I hope it helps,
Thanks
2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>:
> Looks nice. Does it work in all mail clients that support HTML? > > I'd like an option to show the details for all events as otherwise it's > too painful to have to open all one by one (for the use case when you want > to check everything). > > Same as Guillaume: not all events are page-related events. So we need to > handle those too. > > Thanks! > -Vincent > >> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: >> >> First of all, it looks very nice. >> >> Now, you said the events are displayed like in the notifications, but in >> the notifications they are ordered by dates, not by pages. Does your >> proposal imply to change the ordering? What about events that do not >> concern any page (like: "a new wiki has been created" or "a new XWiki >> version is available")? We don't have such events for now but we plan to >> have some soon. We could display them last for example. >> >> Nice CSS expand! >> >> Thanks you, >> >> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com >> : >> >>> This is a proposal for the Notifications mail: >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>> NotificationsImprovements9xEmail >>> >>> I've continued with the 'user' avatar focused proposal, since I've >>> currently focused on the email template. If we drop the user avatar > (since >>> we group multiple users) then we can have the event/app icon instead of > the >>> avatar. >>> >>> What I want to have feedback on is the email layout, functionality (tree >>> navigation, details expanding) and styling. >>> >>> You can play with the Prototype >>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>> >>> If we were to translate to the mail template, there are still some > things >>> to be tested (like translating the CSS selectors into inline, decide > what >>> email clients we support, etc.) >>> >>> Let me know, >>> Caty >>> >>> >>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>> >>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < > valicac@gmail.com >>>> : >>>> >>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>>> >>>>>>> >>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net> >>>> wrote: >>>>>>>> >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> >>>> wrote: >>>>>>>>> >>>>>>>>> Another feedback/questions: >>>>>>>>> >>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>> events >>>>>>> so that the user can see what was modified (as we have currently in >>>> the >>>>>> AS) >>>>>>>> >>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>> see >>>> I >>>>>>> created and modified the Roadmap page but they both say “2 hours >>>> ago”. >>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>> >>>>>>> My understanding is that events are grouped by app+type but not by >>>>> entity >>>>>>> anymore (for page events) and thus you can have 3 events displayed >>>> for >>>>>> the >>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>> >>>>>> >>>>>> And you could also have different users grouped in the same composite >>>>>> event. So when you display the details, it would be nice to show >>> which >>>>> user >>>>>> made each event, and I see you have removed this info. >>>>>> >>>>> >>>>> The focus of this proposal is on user, compared to the old one, when > it >>>> was >>>>> on the app/doc. >>>>> Close to what we have on Facebool. So it didn't made sense that we say >>>> that >>>>> a page has been edited by vmassol, and that the details showcase that >>>>> multiple user actually did the edit. >>>>> >>>> >>>> In Facebook, you have it actually: >>>> https://pasteboard.co/GOioRAT.png >>>> >>>> On XWiki, we have the following (already implemented): >>>> https://pasteboard.co/GOiqgYf.png >>>> >>>> >>>> Thanks, >>>> >>>> >>>>> >>>>> >>>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net
>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>> valicac@gmail.com> >>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>> from >>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>> >>>>>>>>>> ok thanks, had missed this since I was reading from top to >>> bottom >>>>> and >>>>>>> stopped at the overview :) >>>>>>>>>> >>>>>>>>>> However I don’t think it scales since it means one unique icon >>>> per >>>>>>> combination of app type + event type. >>>>>>>>>> >>>>>>>>>> What would scale better is two icons: one for the app type and >>>> one >>>>>> for >>>>>>> the event type. >>>>>>>>>> >>>>>>>>>> For example imagine that the Blog app had the following events: >>>>>>>>>> * When a blog post is published >>>>>>>>>> * When a blog post is created >>>>>>>>>> * When a blog post is removed >>>>>>>>>> >>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>> events. >>>>>>>>>> >>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>> app. >>>>> A >>>>>>> lot of apps can have a RSS feed. >>>>>>>>>> >>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>> harder >>>>> to >>>>>>> find unique icons as we had more events to apps, especially if >>>> there’s >>>>>> only >>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>> >>>>>>>>>> WDYT? >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> Caty >>>>>>>>>>> >>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>> vincent@massol.net> >>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>>> Hi Caty, >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>> valicac@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi, >>>>>>>>>>>>> >>>>>>>>>>>>> I've created some improvements suggestions for our >>>> Notifications >>>>>>> UI, see >>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>> >>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>> >>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>> >>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>> displayed >>>>>>> and you >>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>> modification? >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Caty >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>>> >>> >> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hi, So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xT... I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names. Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes. Thanks, Caty On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer
of
the email, but not the actual content.
To be precise, each *event type* can have its own template or failback to the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote: > > Some ideas. > > I have feedback about the fact the diff is way too technical for users. > > Example: "What does it means???" https://img15.hostingpics.net/ > pics/670307example1.png > > So we could hide this in a "technical details" link.
That’s one option but there’s another which is to provide the ability to choose which mail template to use in the Admin and provide several templates for different needs.
For example for the xwiki.org watchlist we absolutely need to be able to see the diffs without clicking a “technical details” link for each notification. It could be ok if there’s a single “technical details” link for ALL notifications that shows all diffs at once.
Thanks -Vincent
> > The "details" link could be replaced by a "more" link, with a very > simplified diff (the complete diff would go the the technical details view). > > In the body of the event, in addition with the title of the document, we > could add some extracts of the diff. > > Example taken on gmail: > https://img15.hostingpics.net/pics/763456example2.png > > I hope it helps, > > Thanks > > > > 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: > >> Looks nice. Does it work in all mail clients that support HTML? >> >> I'd like an option to show the details for all events as otherwise it's >> too painful to have to open all one by one (for the use case when you want >> to check everything). >> >> Same as Guillaume: not all events are page-related events. So we need to >> handle those too. >> >> Thanks! >> -Vincent >> >>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >>> >>> First of all, it looks very nice. >>> >>> Now, you said the events are displayed like in the notifications, but in >>> the notifications they are ordered by dates, not by pages. Does your >>> proposal imply to change the ordering? What about events that do not >>> concern any page (like: "a new wiki has been created" or "a new XWiki >>> version is available")? We don't have such events for now but we plan to >>> have some soon. We could display them last for example. >>> >>> Nice CSS expand! >>> >>> Thanks you, >>> >>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < valicac@gmail.com >>> : >>> >>>> This is a proposal for the Notifications mail: >>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>> NotificationsImprovements9xEmail >>>> >>>> I've continued with the 'user' avatar focused proposal, since I've >>>> currently focused on the email template. If we drop the user avatar >> (since >>>> we group multiple users) then we can have the event/app icon instead of >> the >>>> avatar. >>>> >>>> What I want to have feedback on is the email layout, functionality (tree >>>> navigation, details expanding) and styling. >>>> >>>> You can play with the Prototype >>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>> >>>> If we were to translate to the mail template, there are still some >> things >>>> to be tested (like translating the CSS selectors into inline, decide >> what >>>> email clients we support, etc.) >>>> >>>> Let me know, >>>> Caty >>>> >>>> >>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >> valicac@gmail.com >>>>> : >>>>> >>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>>> >>>>>>>> >>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net
>>>>> wrote: >>>>>>>>> >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>> wrote: >>>>>>>>>> >>>>>>>>>> Another feedback/questions: >>>>>>>>>> >>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>> events >>>>>>>> so that the user can see what was modified (as we have currently in >>>>> the >>>>>>> AS) >>>>>>>>> >>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>> see >>>>> I >>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>> ago”. >>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>> >>>>>>>> My understanding is that events are grouped by app+type but not by >>>>>> entity >>>>>>>> anymore (for page events) and thus you can have 3 events displayed >>>>> for >>>>>>> the >>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>> >>>>>>> >>>>>>> And you could also have different users grouped in the same composite >>>>>>> event. So when you display the details, it would be nice to show >>>> which >>>>>> user >>>>>>> made each event, and I see you have removed this info. >>>>>>> >>>>>> >>>>>> The focus of this proposal is on user, compared to the old one, when >> it >>>>> was >>>>>> on the app/doc. >>>>>> Close to what we have on Facebool. So it didn't made sense that we say >>>>> that >>>>>> a page has been edited by vmassol, and that the details showcase that >>>>>> multiple user actually did the edit. >>>>>> >>>>> >>>>> In Facebook, you have it actually: >>>>> https://pasteboard.co/GOioRAT.png >>>>> >>>>> On XWiki, we have the following (already implemented): >>>>> https://pasteboard.co/GOiqgYf.png >>>>> >>>>> >>>>> Thanks, >>>>> >>>>> >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net
>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>> valicac@gmail.com> >>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>> from >>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>> >>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>> bottom >>>>>> and >>>>>>>> stopped at the overview :) >>>>>>>>>>> >>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>> per >>>>>>>> combination of app type + event type. >>>>>>>>>>> >>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>> one >>>>>>> for >>>>>>>> the event type. >>>>>>>>>>> >>>>>>>>>>> For example imagine that the Blog app had the following events: >>>>>>>>>>> * When a blog post is published >>>>>>>>>>> * When a blog post is created >>>>>>>>>>> * When a blog post is removed >>>>>>>>>>> >>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>> events. >>>>>>>>>>> >>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>> app. >>>>>> A >>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>> >>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>> harder >>>>>> to >>>>>>>> find unique icons as we had more events to apps, especially if >>>>> there’s >>>>>>> only >>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>> >>>>>>>>>>> WDYT? >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Caty >>>>>>>>>>>> >>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>> vincent@massol.net> >>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>> valicac@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>> >>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>> Notifications >>>>>>>> UI, see >>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>> >>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>> >>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>> >>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>> displayed >>>>>>>> and you >>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>> modification? >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Caty >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>>> >>>> >>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >> > > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hello ! On 10/27/2017 05:31 PM, Ecaterina Moraru (Valica) wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xT...
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes.
I really like the Event-focused "Description with small avatars" options: * The notification title does not mentions the full name of the users involved in this notification (if multiple) ; this reduces the size of the title. Also, the users involved in the notifications are still available through their icons. * The main focus isn't on the users involved in the notification, but on its content. Hope it helps, Thanks, Clément
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer
of
the email, but not the actual content.
To be precise, each *event type* can have its own template or failback to the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
> Hi Guillaume, > >> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: >> >> Some ideas. >> >> I have feedback about the fact the diff is way too technical for users. >> >> Example: "What does it means???" https://img15.hostingpics.net/ >> pics/670307example1.png >> >> So we could hide this in a "technical details" link. > > That’s one option but there’s another which is to provide the ability to > choose which mail template to use in the Admin and provide several > templates for different needs. > > For example for the xwiki.org watchlist we absolutely need to be able to > see the diffs without clicking a “technical details” link for each > notification. It could be ok if there’s a single “technical details” link > for ALL notifications that shows all diffs at once. > > Thanks > -Vincent > >> >> The "details" link could be replaced by a "more" link, with a very >> simplified diff (the complete diff would go the the technical details > view). >> >> In the body of the event, in addition with the title of the document, we >> could add some extracts of the diff. >> >> Example taken on gmail: >> https://img15.hostingpics.net/pics/763456example2.png >> >> I hope it helps, >> >> Thanks >> >> >> >> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >> >>> Looks nice. Does it work in all mail clients that support HTML? >>> >>> I'd like an option to show the details for all events as otherwise it's >>> too painful to have to open all one by one (for the use case when you > want >>> to check everything). >>> >>> Same as Guillaume: not all events are page-related events. So we need > to >>> handle those too. >>> >>> Thanks! >>> -Vincent >>> >>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>> First of all, it looks very nice. >>>> >>>> Now, you said the events are displayed like in the notifications, but > in >>>> the notifications they are ordered by dates, not by pages. Does your >>>> proposal imply to change the ordering? What about events that do not >>>> concern any page (like: "a new wiki has been created" or "a new XWiki >>>> version is available")? We don't have such events for now but we plan > to >>>> have some soon. We could display them last for example. >>>> >>>> Nice CSS expand! >>>> >>>> Thanks you, >>>> >>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < > valicac@gmail.com >>>> : >>>> >>>>> This is a proposal for the Notifications mail: >>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>> NotificationsImprovements9xEmail >>>>> >>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>> currently focused on the email template. If we drop the user avatar >>> (since >>>>> we group multiple users) then we can have the event/app icon instead > of >>> the >>>>> avatar. >>>>> >>>>> What I want to have feedback on is the email layout, functionality > (tree >>>>> navigation, details expanding) and styling. >>>>> >>>>> You can play with the Prototype >>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>> >>>>> If we were to translate to the mail template, there are still some >>> things >>>>> to be tested (like translating the CSS selectors into inline, decide >>> what >>>>> email clients we support, etc.) >>>>> >>>>> Let me know, >>>>> Caty >>>>> >>>>> >>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>> valicac@gmail.com >>>>>> : >>>>>> >>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>>>> >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net
>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Another feedback/questions: >>>>>>>>>>> >>>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>>> events >>>>>>>>> so that the user can see what was modified (as we have currently > in >>>>>> the >>>>>>>> AS) >>>>>>>>>> >>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>> see >>>>>> I >>>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>>> ago”. >>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>> >>>>>>>>> My understanding is that events are grouped by app+type but not > by >>>>>>> entity >>>>>>>>> anymore (for page events) and thus you can have 3 events > displayed >>>>>> for >>>>>>>> the >>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>> >>>>>>>> >>>>>>>> And you could also have different users grouped in the same > composite >>>>>>>> event. So when you display the details, it would be nice to show >>>>> which >>>>>>> user >>>>>>>> made each event, and I see you have removed this info. >>>>>>>> >>>>>>> >>>>>>> The focus of this proposal is on user, compared to the old one, > when >>> it >>>>>> was >>>>>>> on the app/doc. >>>>>>> Close to what we have on Facebool. So it didn't made sense that we > say >>>>>> that >>>>>>> a page has been edited by vmassol, and that the details showcase > that >>>>>>> multiple user actually did the edit. >>>>>>> >>>>>> >>>>>> In Facebook, you have it actually: >>>>>> https://pasteboard.co/GOioRAT.png >>>>>> >>>>>> On XWiki, we have the following (already implemented): >>>>>> https://pasteboard.co/GOiqgYf.png >>>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net
>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>> valicac@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>> from >>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>> >>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>> bottom >>>>>>> and >>>>>>>>> stopped at the overview :) >>>>>>>>>>>> >>>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>>> per >>>>>>>>> combination of app type + event type. >>>>>>>>>>>> >>>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>>> one >>>>>>>> for >>>>>>>>> the event type. >>>>>>>>>>>> >>>>>>>>>>>> For example imagine that the Blog app had the following > events: >>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>> >>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>> events. >>>>>>>>>>>> >>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>>> app. >>>>>>> A >>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>> >>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>> harder >>>>>>> to >>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>> there’s >>>>>>>> only >>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>> >>>>>>>>>>>> WDYT? >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Caty >>>>>>>>>>>>> >>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>> vincent@massol.net> >>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>> Notifications >>>>>>>>> UI, see >>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>> >>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>> displayed >>>>>>>>> and you >>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>> modification? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>> >> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hello. My personal favorite is http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... With this "details" section: http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... Could we consider having a little extract of the document's content in the notification. For a blog post, I could imagine a little extract, such as: *This release focused on fixing bugs on Notifications, Office Viewer and
Solr Search. The server is...*
(extract from http://www.xwiki.org/xwiki/bin/view/Blog/XWiki%2099%20Released ) Thanks, Guillaume 2017-10-27 20:04 GMT+02:00 Clément Aubin <aubincleme@gmail.com>:
Hello !
On 10/27/2017 05:31 PM, Ecaterina Moraru (Valica) wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes.
I really like the Event-focused "Description with small avatars" options:
* The notification title does not mentions the full name of the users involved in this notification (if multiple) ; this reduces the size of the title. Also, the users involved in the notifications are still available through their icons. * The main focus isn't on the users involved in the notification, but on its content.
Hope it helps, Thanks,
Clément
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the
need
to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
> Note that you have a mail template for the notifications too. It's > https://github.com/xwiki/xwiki-platform/blob/ > 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- > core/xwiki-platform-notifications/xwiki-platform- > notifications-ui/src/main/resources/XWiki/Notifications/ > MailTemplate.xml#L23 but it's not documented yet. > > This mail template allows you to customize the header and the footer
of
> the email, but not the actual content. > > To be precise, each *event type* can have its own template or failback to > the default one (https://github.com/xwiki/xwiki-platform/blob/ > acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- > core/xwiki-platform-web/src/main/webapp/templates/ > notification/email/default.html.vm) > > So it's a template *per event type* and it's not linked to any user > choice. But we could add some options in the default template for example. > > 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: > >> Hi Guillaume, >> >>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >>> >>> Some ideas. >>> >>> I have feedback about the fact the diff is way too technical for users. >>> >>> Example: "What does it means???" https://img15.hostingpics.net/ >>> pics/670307example1.png >>> >>> So we could hide this in a "technical details" link. >> >> That’s one option but there’s another which is to provide the ability to >> choose which mail template to use in the Admin and provide several >> templates for different needs. >> >> For example for the xwiki.org watchlist we absolutely need to be able to >> see the diffs without clicking a “technical details” link for each >> notification. It could be ok if there’s a single “technical details” link >> for ALL notifications that shows all diffs at once. >> >> Thanks >> -Vincent >> >>> >>> The "details" link could be replaced by a "more" link, with a very >>> simplified diff (the complete diff would go the the technical details >> view). >>> >>> In the body of the event, in addition with the title of the document, we >>> could add some extracts of the diff. >>> >>> Example taken on gmail: >>> https://img15.hostingpics.net/pics/763456example2.png >>> >>> I hope it helps, >>> >>> Thanks >>> >>> >>> >>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >>> >>>> Looks nice. Does it work in all mail clients that support HTML? >>>> >>>> I'd like an option to show the details for all events as otherwise it's >>>> too painful to have to open all one by one (for the use case when you >> want >>>> to check everything). >>>> >>>> Same as Guillaume: not all events are page-related events. So we need >> to >>>> handle those too. >>>> >>>> Thanks! >>>> -Vincent >>>> >>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>> First of all, it looks very nice. >>>>> >>>>> Now, you said the events are displayed like in the notifications, but >> in >>>>> the notifications they are ordered by dates, not by pages. Does your >>>>> proposal imply to change the ordering? What about events that do not >>>>> concern any page (like: "a new wiki has been created" or "a new XWiki >>>>> version is available")? We don't have such events for now but we plan >> to >>>>> have some soon. We could display them last for example. >>>>> >>>>> Nice CSS expand! >>>>> >>>>> Thanks you, >>>>> >>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >> valicac@gmail.com >>>>> : >>>>> >>>>>> This is a proposal for the Notifications mail: >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>> NotificationsImprovements9xEmail >>>>>> >>>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>>> currently focused on the email template. If we drop the user avatar >>>> (since >>>>>> we group multiple users) then we can have the event/app icon instead >> of >>>> the >>>>>> avatar. >>>>>> >>>>>> What I want to have feedback on is the email layout, functionality >> (tree >>>>>> navigation, details expanding) and styling. >>>>>> >>>>>> You can play with the Prototype >>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>> >>>>>> If we were to translate to the mail template, there are still some >>>> things >>>>>> to be tested (like translating the CSS selectors into inline, decide >>>> what >>>>>> email clients we support, etc.) >>>>>> >>>>>> Let me know, >>>>>> Caty >>>>>> >>>>>> >>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>> valicac@gmail.com >>>>>>> : >>>>>>> >>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>> >>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net
>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>> >>>>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>>>> events >>>>>>>>>> so that the user can see what was modified (as we have currently >> in >>>>>>> the >>>>>>>>> AS) >>>>>>>>>>> >>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>>> see >>>>>>> I >>>>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>>>> ago”. >>>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>>> >>>>>>>>>> My understanding is that events are grouped by app+type but not >> by >>>>>>>> entity >>>>>>>>>> anymore (for page events) and thus you can have 3 events >> displayed >>>>>>> for >>>>>>>>> the >>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>> >>>>>>>>> >>>>>>>>> And you could also have different users grouped in the same >> composite >>>>>>>>> event. So when you display the details, it would be nice to show >>>>>> which >>>>>>>> user >>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>> >>>>>>>> >>>>>>>> The focus of this proposal is on user, compared to the old one, >> when >>>> it >>>>>>> was >>>>>>>> on the app/doc. >>>>>>>> Close to what we have on Facebool. So it didn't made sense that we >> say >>>>>>> that >>>>>>>> a page has been edited by vmassol, and that the details showcase >> that >>>>>>>> multiple user actually did the edit. >>>>>>>> >>>>>>> >>>>>>> In Facebook, you have it actually: >>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>> >>>>>>> On XWiki, we have the following (already implemented): >>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net
>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>> from >>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>> >>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>> bottom >>>>>>>> and >>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>> >>>>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>>>> per >>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>> >>>>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>>>> one >>>>>>>>> for >>>>>>>>>> the event type. >>>>>>>>>>>>> >>>>>>>>>>>>> For example imagine that the Blog app had the following >> events: >>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>> >>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>>> events. >>>>>>>>>>>>> >>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>>>> app. >>>>>>>> A >>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>> >>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>> harder >>>>>>>> to >>>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>>> there’s >>>>>>>>> only >>>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>>> >>>>>>>>>>>>> WDYT? >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Caty >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>> vincent@massol.net> >>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>> Notifications >>>>>>>>>> UI, see >>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>> displayed >>>>>>>>>> and you >>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>> modification? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>> Committer on the XWiki.org project >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>> >>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >> >> > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Mon, Oct 30, 2017 at 12:21 PM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello.
My personal favorite is http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/eventCentered_smallAvatars.png
With this "details" section: http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_uncropped.png
I've iterated on this, see http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xT...
Could we consider having a little extract of the document's content in the notification. For a blog post, I could imagine a little extract, such as:
*This release focused on fixing bugs on Notifications, Office Viewer and
Solr Search. The server is...*
(extract from http://www.xwiki.org/xwiki/bin/view/Blog/XWiki%2099% 20Released )
Thanks,
Guillaume
2017-10-27 20:04 GMT+02:00 Clément Aubin <aubincleme@gmail.com>:
Hello !
On 10/27/2017 05:31 PM, Ecaterina Moraru (Valica) wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes.
I really like the Event-focused "Description with small avatars" options:
* The notification title does not mentions the full name of the users involved in this notification (if multiple) ; this reduces the size of the title. Also, the users involved in the notifications are still available through their icons. * The main focus isn't on the users involved in the notification, but on its content.
Hope it helps, Thanks,
Clément
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote: > > Any news on this? I'd like to implement this quickly because 9.10
is
coming > :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
> > 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com>: > >> Note that you have a mail template for the notifications too. It's >> https://github.com/xwiki/xwiki-platform/blob/ >> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >> core/xwiki-platform-notifications/xwiki-platform- >> notifications-ui/src/main/resources/XWiki/Notifications/ >> MailTemplate.xml#L23 but it's not documented yet. >> >> This mail template allows you to customize the header and the
footer of
>> the email, but not the actual content. >> >> To be precise, each *event type* can have its own template or failback to >> the default one (https://github.com/xwiki/xwiki-platform/blob/ >> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >> core/xwiki-platform-web/src/main/webapp/templates/ >> notification/email/default.html.vm) >> >> So it's a template *per event type* and it's not linked to any user >> choice. But we could add some options in the default template for example. >> >> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: >> >>> Hi Guillaume, >>> >>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>> Some ideas. >>>> >>>> I have feedback about the fact the diff is way too technical for users. >>>> >>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>> pics/670307example1.png >>>> >>>> So we could hide this in a "technical details" link. >>> >>> That’s one option but there’s another which is to provide the ability to >>> choose which mail template to use in the Admin and provide several >>> templates for different needs. >>> >>> For example for the xwiki.org watchlist we absolutely need to be able to >>> see the diffs without clicking a “technical details” link for each >>> notification. It could be ok if there’s a single “technical details” link >>> for ALL notifications that shows all diffs at once. >>> >>> Thanks >>> -Vincent >>> >>>> >>>> The "details" link could be replaced by a "more" link, with a very >>>> simplified diff (the complete diff would go the the technical details >>> view). >>>> >>>> In the body of the event, in addition with the title of the document, we >>>> could add some extracts of the diff. >>>> >>>> Example taken on gmail: >>>> https://img15.hostingpics.net/pics/763456example2.png >>>> >>>> I hope it helps, >>>> >>>> Thanks >>>> >>>> >>>> >>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>> >>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>> >>>>> I'd like an option to show the details for all events as otherwise it's >>>>> too painful to have to open all one by one (for the use case when you >>> want >>>>> to check everything). >>>>> >>>>> Same as Guillaume: not all events are page-related events. So we need >>> to >>>>> handle those too. >>>>> >>>>> Thanks! >>>>> -Vincent >>>>> >>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>> First of all, it looks very nice. >>>>>> >>>>>> Now, you said the events are displayed like in the notifications, but >>> in >>>>>> the notifications they are ordered by dates, not by pages. Does your >>>>>> proposal imply to change the ordering? What about events that do not >>>>>> concern any page (like: "a new wiki has been created" or "a new XWiki >>>>>> version is available")? We don't have such events for now but we plan >>> to >>>>>> have some soon. We could display them last for example. >>>>>> >>>>>> Nice CSS expand! >>>>>> >>>>>> Thanks you, >>>>>> >>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>> valicac@gmail.com >>>>>> : >>>>>> >>>>>>> This is a proposal for the Notifications mail: >>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>> NotificationsImprovements9xEmail >>>>>>> >>>>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>>>> currently focused on the email template. If we drop the user avatar >>>>> (since >>>>>>> we group multiple users) then we can have the event/app icon instead >>> of >>>>> the >>>>>>> avatar. >>>>>>> >>>>>>> What I want to have feedback on is the email layout, functionality >>> (tree >>>>>>> navigation, details expanding) and styling. >>>>>>> >>>>>>> You can play with the Prototype >>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>> >>>>>>> If we were to translate to the mail template, there are still some >>>>> things >>>>>>> to be tested (like translating the CSS selectors into inline, decide >>>>> what >>>>>>> email clients we support, etc.) >>>>>>> >>>>>>> Let me know, >>>>>>> Caty >>>>>>> >>>>>>> >>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>> valicac@gmail.com >>>>>>>> : >>>>>>>> >>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>> >>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net
>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>> >>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>>>>> events >>>>>>>>>>> so that the user can see what was modified (as we have currently >>> in >>>>>>>> the >>>>>>>>>> AS) >>>>>>>>>>>> >>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>>>> see >>>>>>>> I >>>>>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>>>>> ago”. >>>>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>>>> >>>>>>>>>>> My understanding is that events are grouped by app+type but not >>> by >>>>>>>>> entity >>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>> displayed >>>>>>>> for >>>>>>>>>> the >>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> And you could also have different users grouped in the same >>> composite >>>>>>>>>> event. So when you display the details, it would be nice to show >>>>>>> which >>>>>>>>> user >>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>> >>>>>>>>> >>>>>>>>> The focus of this proposal is on user, compared to the old one, >>> when >>>>> it >>>>>>>> was >>>>>>>>> on the app/doc. >>>>>>>>> Close to what we have on Facebool. So it didn't made sense that we >>> say >>>>>>>> that >>>>>>>>> a page has been edited by vmassol, and that the details showcase >>> that >>>>>>>>> multiple user actually did the edit. >>>>>>>>> >>>>>>>> >>>>>>>> In Facebook, you have it actually: >>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>> >>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net > >>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>> valicac@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>> from >>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>> >>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>>> bottom >>>>>>>>> and >>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>> >>>>>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>>>>> per >>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>> >>>>>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>>>>> one >>>>>>>>>> for >>>>>>>>>>> the event type. >>>>>>>>>>>>>> >>>>>>>>>>>>>> For example imagine that the Blog app had the following >>> events: >>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>> >>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>>>> events. >>>>>>>>>>>>>> >>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>>>>> app. >>>>>>>>> A >>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>> >>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>>> harder >>>>>>>>> to >>>>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>>>> there’s >>>>>>>>>> only >>>>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>>>> >>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>> vincent@massol.net> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>> Notifications >>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>>> displayed >>>>>>>>>>> and you >>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>> modification? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>> >>> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >> > > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
Hi Caty, Thanks! There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1. For me we always need 2 icons: * one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post) So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much. Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event. I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text. In your variations I don’t see one where the app icon is on the left. Thanks -Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xT...
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes.
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the need to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
Note that you have a mail template for the notifications too. It's https://github.com/xwiki/xwiki-platform/blob/ 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- core/xwiki-platform-notifications/xwiki-platform- notifications-ui/src/main/resources/XWiki/Notifications/ MailTemplate.xml#L23 but it's not documented yet.
This mail template allows you to customize the header and the footer
of
the email, but not the actual content.
To be precise, each *event type* can have its own template or failback to the default one (https://github.com/xwiki/xwiki-platform/blob/ acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- core/xwiki-platform-web/src/main/webapp/templates/ notification/email/default.html.vm)
So it's a template *per event type* and it's not linked to any user choice. But we could add some options in the default template for example.
2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>:
> Hi Guillaume, > >> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: >> >> Some ideas. >> >> I have feedback about the fact the diff is way too technical for users. >> >> Example: "What does it means???" https://img15.hostingpics.net/ >> pics/670307example1.png >> >> So we could hide this in a "technical details" link. > > That’s one option but there’s another which is to provide the ability to > choose which mail template to use in the Admin and provide several > templates for different needs. > > For example for the xwiki.org watchlist we absolutely need to be able to > see the diffs without clicking a “technical details” link for each > notification. It could be ok if there’s a single “technical details” link > for ALL notifications that shows all diffs at once. > > Thanks > -Vincent > >> >> The "details" link could be replaced by a "more" link, with a very >> simplified diff (the complete diff would go the the technical details > view). >> >> In the body of the event, in addition with the title of the document, we >> could add some extracts of the diff. >> >> Example taken on gmail: >> https://img15.hostingpics.net/pics/763456example2.png >> >> I hope it helps, >> >> Thanks >> >> >> >> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >> >>> Looks nice. Does it work in all mail clients that support HTML? >>> >>> I'd like an option to show the details for all events as otherwise it's >>> too painful to have to open all one by one (for the use case when you > want >>> to check everything). >>> >>> Same as Guillaume: not all events are page-related events. So we need > to >>> handle those too. >>> >>> Thanks! >>> -Vincent >>> >>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>> First of all, it looks very nice. >>>> >>>> Now, you said the events are displayed like in the notifications, but > in >>>> the notifications they are ordered by dates, not by pages. Does your >>>> proposal imply to change the ordering? What about events that do not >>>> concern any page (like: "a new wiki has been created" or "a new XWiki >>>> version is available")? We don't have such events for now but we plan > to >>>> have some soon. We could display them last for example. >>>> >>>> Nice CSS expand! >>>> >>>> Thanks you, >>>> >>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < > valicac@gmail.com >>>> : >>>> >>>>> This is a proposal for the Notifications mail: >>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>> NotificationsImprovements9xEmail >>>>> >>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>> currently focused on the email template. If we drop the user avatar >>> (since >>>>> we group multiple users) then we can have the event/app icon instead > of >>> the >>>>> avatar. >>>>> >>>>> What I want to have feedback on is the email layout, functionality > (tree >>>>> navigation, details expanding) and styling. >>>>> >>>>> You can play with the Prototype >>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>> >>>>> If we were to translate to the mail template, there are still some >>> things >>>>> to be tested (like translating the CSS selectors into inline, decide >>> what >>>>> email clients we support, etc.) >>>>> >>>>> Let me know, >>>>> Caty >>>>> >>>>> >>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>> valicac@gmail.com >>>>>> : >>>>>> >>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>>>> >>>>>>>>> >>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol <vincent@massol.net
>>>>>> wrote: >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> Another feedback/questions: >>>>>>>>>>> >>>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>>> events >>>>>>>>> so that the user can see what was modified (as we have currently > in >>>>>> the >>>>>>>> AS) >>>>>>>>>> >>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>> see >>>>>> I >>>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>>> ago”. >>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>> >>>>>>>>> My understanding is that events are grouped by app+type but not > by >>>>>>> entity >>>>>>>>> anymore (for page events) and thus you can have 3 events > displayed >>>>>> for >>>>>>>> the >>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>> >>>>>>>> >>>>>>>> And you could also have different users grouped in the same > composite >>>>>>>> event. So when you display the details, it would be nice to show >>>>> which >>>>>>> user >>>>>>>> made each event, and I see you have removed this info. >>>>>>>> >>>>>>> >>>>>>> The focus of this proposal is on user, compared to the old one, > when >>> it >>>>>> was >>>>>>> on the app/doc. >>>>>>> Close to what we have on Facebool. So it didn't made sense that we > say >>>>>> that >>>>>>> a page has been edited by vmassol, and that the details showcase > that >>>>>>> multiple user actually did the edit. >>>>>>> >>>>>> >>>>>> In Facebook, you have it actually: >>>>>> https://pasteboard.co/GOioRAT.png >>>>>> >>>>>> On XWiki, we have the following (already implemented): >>>>>> https://pasteboard.co/GOiqgYf.png >>>>>> >>>>>> >>>>>> Thanks, >>>>>> >>>>>> >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net
>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>> valicac@gmail.com> >>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>> from >>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>> >>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>> bottom >>>>>>> and >>>>>>>>> stopped at the overview :) >>>>>>>>>>>> >>>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>>> per >>>>>>>>> combination of app type + event type. >>>>>>>>>>>> >>>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>>> one >>>>>>>> for >>>>>>>>> the event type. >>>>>>>>>>>> >>>>>>>>>>>> For example imagine that the Blog app had the following > events: >>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>> >>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>> events. >>>>>>>>>>>> >>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>>> app. >>>>>>> A >>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>> >>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>> harder >>>>>>> to >>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>> there’s >>>>>>>> only >>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>> >>>>>>>>>>>> WDYT? >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> Caty >>>>>>>>>>>>> >>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>> vincent@massol.net> >>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>> Notifications >>>>>>>>> UI, see >>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>> >>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>> displayed >>>>>>>>> and you >>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>> modification? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>>> >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>> >> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
There is only 1 icon if the action is done by the "Pages" app, coming from XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
For me we always need 2 icons: * one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event.
I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text.
I wouldn't drop the event icon since that's the most important piece of information now. The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
In your variations I don’t see one where the app icon is on the left.
I have put all the icons on the left in order to be easier to scan for them in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them. So Guillaume and Clement like the event-focused view. I don't particularly like the big event icons. I find them more cold and less personal. So I prefer the users-centered version. I like: http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... Now I haven't created versions for all the combinations, but we should decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important when there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always; I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed? Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity? I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice. Thanks, Caty
Thanks -Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes.
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Any news on this? I'd like to implement this quickly because 9.10 is coming :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the
need
to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < guillaume.delhumeau@xwiki.com>:
> Note that you have a mail template for the notifications too. It's > https://github.com/xwiki/xwiki-platform/blob/ > 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- > core/xwiki-platform-notifications/xwiki-platform- > notifications-ui/src/main/resources/XWiki/Notifications/ > MailTemplate.xml#L23 but it's not documented yet. > > This mail template allows you to customize the header and the footer
of
> the email, but not the actual content. > > To be precise, each *event type* can have its own template or failback to > the default one (https://github.com/xwiki/xwiki-platform/blob/ > acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- > core/xwiki-platform-web/src/main/webapp/templates/ > notification/email/default.html.vm) > > So it's a template *per event type* and it's not linked to any user > choice. But we could add some options in the default template for example. > > 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: > >> Hi Guillaume, >> >>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >>> >>> Some ideas. >>> >>> I have feedback about the fact the diff is way too technical for users. >>> >>> Example: "What does it means???" https://img15.hostingpics.net/ >>> pics/670307example1.png >>> >>> So we could hide this in a "technical details" link. >> >> That’s one option but there’s another which is to provide the ability to >> choose which mail template to use in the Admin and provide several >> templates for different needs. >> >> For example for the xwiki.org watchlist we absolutely need to be able to >> see the diffs without clicking a “technical details” link for each >> notification. It could be ok if there’s a single “technical details” link >> for ALL notifications that shows all diffs at once. >> >> Thanks >> -Vincent >> >>> >>> The "details" link could be replaced by a "more" link, with a very >>> simplified diff (the complete diff would go the the technical details >> view). >>> >>> In the body of the event, in addition with the title of the document, we >>> could add some extracts of the diff. >>> >>> Example taken on gmail: >>> https://img15.hostingpics.net/pics/763456example2.png >>> >>> I hope it helps, >>> >>> Thanks >>> >>> >>> >>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >>> >>>> Looks nice. Does it work in all mail clients that support HTML? >>>> >>>> I'd like an option to show the details for all events as otherwise it's >>>> too painful to have to open all one by one (for the use case when you >> want >>>> to check everything). >>>> >>>> Same as Guillaume: not all events are page-related events. So we need >> to >>>> handle those too. >>>> >>>> Thanks! >>>> -Vincent >>>> >>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>> First of all, it looks very nice. >>>>> >>>>> Now, you said the events are displayed like in the notifications, but >> in >>>>> the notifications they are ordered by dates, not by pages. Does your >>>>> proposal imply to change the ordering? What about events that do not >>>>> concern any page (like: "a new wiki has been created" or "a new XWiki >>>>> version is available")? We don't have such events for now but we plan >> to >>>>> have some soon. We could display them last for example. >>>>> >>>>> Nice CSS expand! >>>>> >>>>> Thanks you, >>>>> >>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >> valicac@gmail.com >>>>> : >>>>> >>>>>> This is a proposal for the Notifications mail: >>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>> NotificationsImprovements9xEmail >>>>>> >>>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>>> currently focused on the email template. If we drop the user avatar >>>> (since >>>>>> we group multiple users) then we can have the event/app icon instead >> of >>>> the >>>>>> avatar. >>>>>> >>>>>> What I want to have feedback on is the email layout, functionality >> (tree >>>>>> navigation, details expanding) and styling. >>>>>> >>>>>> You can play with the Prototype >>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>> >>>>>> If we were to translate to the mail template, there are still some >>>> things >>>>>> to be tested (like translating the CSS selectors into inline, decide >>>> what >>>>>> email clients we support, etc.) >>>>>> >>>>>> Let me know, >>>>>> Caty >>>>>> >>>>>> >>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>> valicac@gmail.com >>>>>>> : >>>>>>> >>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>> >>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>> >>>>>>>>>> >>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net
>>>>>>> wrote: >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>> >>>>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>>>> events >>>>>>>>>> so that the user can see what was modified (as we have currently >> in >>>>>>> the >>>>>>>>> AS) >>>>>>>>>>> >>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>>> see >>>>>>> I >>>>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>>>> ago”. >>>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>>> >>>>>>>>>> My understanding is that events are grouped by app+type but not >> by >>>>>>>> entity >>>>>>>>>> anymore (for page events) and thus you can have 3 events >> displayed >>>>>>> for >>>>>>>>> the >>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>> >>>>>>>>> >>>>>>>>> And you could also have different users grouped in the same >> composite >>>>>>>>> event. So when you display the details, it would be nice to show >>>>>> which >>>>>>>> user >>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>> >>>>>>>> >>>>>>>> The focus of this proposal is on user, compared to the old one, >> when >>>> it >>>>>>> was >>>>>>>> on the app/doc. >>>>>>>> Close to what we have on Facebool. So it didn't made sense that we >> say >>>>>>> that >>>>>>>> a page has been edited by vmassol, and that the details showcase >> that >>>>>>>> multiple user actually did the edit. >>>>>>>> >>>>>>> >>>>>>> In Facebook, you have it actually: >>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>> >>>>>>> On XWiki, we have the following (already implemented): >>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> >>>>>>> >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net
>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com> >>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>> from >>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>> >>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>> bottom >>>>>>>> and >>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>> >>>>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>>>> per >>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>> >>>>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>>>> one >>>>>>>>> for >>>>>>>>>> the event type. >>>>>>>>>>>>> >>>>>>>>>>>>> For example imagine that the Blog app had the following >> events: >>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>> >>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>>> events. >>>>>>>>>>>>> >>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>>>> app. >>>>>>>> A >>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>> >>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>> harder >>>>>>>> to >>>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>>> there’s >>>>>>>>> only >>>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>>> >>>>>>>>>>>>> WDYT? >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> Caty >>>>>>>>>>>>>> >>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>> vincent@massol.net> >>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>> Notifications >>>>>>>>>> UI, see >>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>> displayed >>>>>>>>>> and you >>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>> modification? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>> Committer on the XWiki.org project >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>>> >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>> >>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >> >> > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
There is only 1 icon if the action is done by the "Pages" app, coming from XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
I find this highly confusing for my part :)
For me we always need 2 icons:
* one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event.
I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text.
I wouldn't drop the event icon since that's the most important piece of information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication. I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally. If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left. In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
In your variations I don’t see one where the app icon is on the left.
I have put all the icons on the left in order to be easier to scan for them in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them.
So Guillaume and Clement like the event-focused view.
I don't particularly like the big event icons. I find them more cold and less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
I like: http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement...
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Now I haven't created versions for all the combinations, but we should decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important when there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always;
I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed?
Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that. Thanks -Vincent
I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice.
Thanks, Caty
Thanks -Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes if you want to make some small changes.
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
Hi Guillaume,
> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote: > > Any news on this? I'd like to implement this quickly because 9.10 is coming > :)
This the current status: * Caty proposed some improved layout for displaying notifications * I commented about the need to display event + type, and about the
need
to have a link to see the diff. I also mentioned that we need to work on the mail template display * Caty replied and updated her proposal to take into account those comments. * I kind of like Caty’s proposal focused on the user. We want to favor contributions and I think it helps. It also makes the UI more appealing visually. * You mentioned that you’d prefer a proposal more focused on the event rather than the user * Thomas agrees with you * Edy mentioned some extra points
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
So I guess we need to decide about whether we show the avatar as in
Caty’s
proposal or not, right? Is that what you’re asking about Guillaume?
On my side, I don’t see the issue in displaying the user avatar large vs small. The events are still ordered by page events.
Thanks -Vincent
Thanks
> > 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com>: > >> Note that you have a mail template for the notifications too. It's >> https://github.com/xwiki/xwiki-platform/blob/ >> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >> core/xwiki-platform-notifications/xwiki-platform- >> notifications-ui/src/main/resources/XWiki/Notifications/ >> MailTemplate.xml#L23 but it's not documented yet. >> >> This mail template allows you to customize the header and the footer
of
>> the email, but not the actual content. >> >> To be precise, each *event type* can have its own template or failback to >> the default one (https://github.com/xwiki/xwiki-platform/blob/ >> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >> core/xwiki-platform-web/src/main/webapp/templates/ >> notification/email/default.html.vm) >> >> So it's a template *per event type* and it's not linked to any user >> choice. But we could add some options in the default template for example. >> >> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: >> >>> Hi Guillaume, >>> >>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>> Some ideas. >>>> >>>> I have feedback about the fact the diff is way too technical for users. >>>> >>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>> pics/670307example1.png >>>> >>>> So we could hide this in a "technical details" link. >>> >>> That’s one option but there’s another which is to provide the ability to >>> choose which mail template to use in the Admin and provide several >>> templates for different needs. >>> >>> For example for the xwiki.org watchlist we absolutely need to be able to >>> see the diffs without clicking a “technical details” link for each >>> notification. It could be ok if there’s a single “technical details” link >>> for ALL notifications that shows all diffs at once. >>> >>> Thanks >>> -Vincent >>> >>>> >>>> The "details" link could be replaced by a "more" link, with a very >>>> simplified diff (the complete diff would go the the technical details >>> view). >>>> >>>> In the body of the event, in addition with the title of the document, we >>>> could add some extracts of the diff. >>>> >>>> Example taken on gmail: >>>> https://img15.hostingpics.net/pics/763456example2.png >>>> >>>> I hope it helps, >>>> >>>> Thanks >>>> >>>> >>>> >>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>> >>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>> >>>>> I'd like an option to show the details for all events as otherwise it's >>>>> too painful to have to open all one by one (for the use case when you >>> want >>>>> to check everything). >>>>> >>>>> Same as Guillaume: not all events are page-related events. So we need >>> to >>>>> handle those too. >>>>> >>>>> Thanks! >>>>> -Vincent >>>>> >>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>> First of all, it looks very nice. >>>>>> >>>>>> Now, you said the events are displayed like in the notifications, but >>> in >>>>>> the notifications they are ordered by dates, not by pages. Does your >>>>>> proposal imply to change the ordering? What about events that do not >>>>>> concern any page (like: "a new wiki has been created" or "a new XWiki >>>>>> version is available")? We don't have such events for now but we plan >>> to >>>>>> have some soon. We could display them last for example. >>>>>> >>>>>> Nice CSS expand! >>>>>> >>>>>> Thanks you, >>>>>> >>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>> valicac@gmail.com >>>>>> : >>>>>> >>>>>>> This is a proposal for the Notifications mail: >>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>> NotificationsImprovements9xEmail >>>>>>> >>>>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>>>> currently focused on the email template. If we drop the user avatar >>>>> (since >>>>>>> we group multiple users) then we can have the event/app icon instead >>> of >>>>> the >>>>>>> avatar. >>>>>>> >>>>>>> What I want to have feedback on is the email layout, functionality >>> (tree >>>>>>> navigation, details expanding) and styling. >>>>>>> >>>>>>> You can play with the Prototype >>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>> >>>>>>> If we were to translate to the mail template, there are still some >>>>> things >>>>>>> to be tested (like translating the CSS selectors into inline, decide >>>>> what >>>>>>> email clients we support, etc.) >>>>>>> >>>>>>> Let me know, >>>>>>> Caty >>>>>>> >>>>>>> >>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>> valicac@gmail.com >>>>>>>> : >>>>>>>> >>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>> >>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net
>>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>> >>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user profile? >>>>>>>>>>>>> * We need a way to link directly to the diff, at least for page >>>>>>>>> events >>>>>>>>>>> so that the user can see what was modified (as we have currently >>> in >>>>>>>> the >>>>>>>>>> AS) >>>>>>>>>>>> >>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>>>> see >>>>>>>> I >>>>>>>>>>> created and modified the Roadmap page but they both say “2 hours >>>>>>>> ago”. >>>>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>>>> >>>>>>>>>>> My understanding is that events are grouped by app+type but not >>> by >>>>>>>>> entity >>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>> displayed >>>>>>>> for >>>>>>>>>> the >>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> And you could also have different users grouped in the same >>> composite >>>>>>>>>> event. So when you display the details, it would be nice to show >>>>>>> which >>>>>>>>> user >>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>> >>>>>>>>> >>>>>>>>> The focus of this proposal is on user, compared to the old one, >>> when >>>>> it >>>>>>>> was >>>>>>>>> on the app/doc. >>>>>>>>> Close to what we have on Facebool. So it didn't made sense that we >>> say >>>>>>>> that >>>>>>>>> a page has been edited by vmassol, and that the details showcase >>> that >>>>>>>>> multiple user actually did the edit. >>>>>>>>> >>>>>>>> >>>>>>>> In Facebook, you have it actually: >>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>> >>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>> >>>>>>>> >>>>>>>> Thanks, >>>>>>>> >>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net > >>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>> valicac@gmail.com> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>> from >>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>> >>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>>> bottom >>>>>>>>> and >>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>> >>>>>>>>>>>>>> However I don’t think it scales since it means one unique icon >>>>>>>> per >>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>> >>>>>>>>>>>>>> What would scale better is two icons: one for the app type and >>>>>>>> one >>>>>>>>>> for >>>>>>>>>>> the event type. >>>>>>>>>>>>>> >>>>>>>>>>>>>> For example imagine that the Blog app had the following >>> events: >>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>> >>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>>>> events. >>>>>>>>>>>>>> >>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the Blog >>>>>>>> app. >>>>>>>>> A >>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>> >>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>>> harder >>>>>>>>> to >>>>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>>>> there’s >>>>>>>>>> only >>>>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>>>> >>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>> vincent@massol.net> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>> Notifications >>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>>> displayed >>>>>>>>>>> and you >>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>> modification? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>> >>> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project >> > > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net> wrote:
On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
There is only 1 icon if the action is done by the "Pages" app, coming from XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
I find this highly confusing for my part :)
For me we always need 2 icons:
* one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event.
I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text.
I wouldn't drop the event icon since that's the most important piece of information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
In your variations I don’t see one where the app icon is on the left.
I have put all the icons on the left in order to be easier to scan for
them
in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them.
So Guillaume and Clement like the event-focused view.
I don't particularly like the big event icons. I find them more cold and less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
I like: http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
Now I haven't created versions for all the combinations, but we should decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important when there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always;
I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed?
Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice.
Thanks, Caty
Thanks -Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes
if
you want to make some small changes.
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
Hello
2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>:
> Hi Guillaume, > >> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: >> >> Any news on this? I'd like to implement this quickly because 9.10
is
> coming >> :) > > This the current status: > * Caty proposed some improved layout for displaying notifications > * I commented about the need to display event + type, and about the need > to have a link to see the diff. I also mentioned that we need to work on > the mail template display > * Caty replied and updated her proposal to take into account those > comments. > * I kind of like Caty’s proposal focused on the user. We want to favor > contributions and I think it helps. It also makes the UI more appealing > visually. > * You mentioned that you’d prefer a proposal more focused on the event > rather than the user > * Thomas agrees with you > * Edy mentioned some extra points >
I have also mentioned that the diff we propose is too technical for many users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
> So I guess we need to decide about whether we show the avatar as in
Caty’s
> proposal or not, right? Is that what you’re asking about Guillaume? > > On my side, I don’t see the issue in displaying the user avatar large vs > small. The events are still ordered by page events. > > Thanks > -Vincent >
Thanks
> >> >> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com>: >> >>> Note that you have a mail template for the notifications too. It's >>> https://github.com/xwiki/xwiki-platform/blob/ >>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>> core/xwiki-platform-notifications/xwiki-platform- >>> notifications-ui/src/main/resources/XWiki/Notifications/ >>> MailTemplate.xml#L23 but it's not documented yet. >>> >>> This mail template allows you to customize the header and the footer of >>> the email, but not the actual content. >>> >>> To be precise, each *event type* can have its own template or failback > to >>> the default one (https://github.com/xwiki/xwiki-platform/blob/ >>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>> core/xwiki-platform-web/src/main/webapp/templates/ >>> notification/email/default.html.vm) >>> >>> So it's a template *per event type* and it's not linked to any user >>> choice. But we could add some options in the default template for > example. >>> >>> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: >>> >>>> Hi Guillaume, >>>> >>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>> Some ideas. >>>>> >>>>> I have feedback about the fact the diff is way too technical for > users. >>>>> >>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>> pics/670307example1.png >>>>> >>>>> So we could hide this in a "technical details" link. >>>> >>>> That’s one option but there’s another which is to provide the ability > to >>>> choose which mail template to use in the Admin and provide several >>>> templates for different needs. >>>> >>>> For example for the xwiki.org watchlist we absolutely need to be able > to >>>> see the diffs without clicking a “technical details” link for each >>>> notification. It could be ok if there’s a single “technical details” > link >>>> for ALL notifications that shows all diffs at once. >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>> The "details" link could be replaced by a "more" link, with a very >>>>> simplified diff (the complete diff would go the the technical details >>>> view). >>>>> >>>>> In the body of the event, in addition with the title of the document, > we >>>>> could add some extracts of the diff. >>>>> >>>>> Example taken on gmail: >>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>> >>>>> I hope it helps, >>>>> >>>>> Thanks >>>>> >>>>> >>>>> >>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>> >>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>> >>>>>> I'd like an option to show the details for all events as otherwise > it's >>>>>> too painful to have to open all one by one (for the use case when you >>>> want >>>>>> to check everything). >>>>>> >>>>>> Same as Guillaume: not all events are page-related events. So we need >>>> to >>>>>> handle those too. >>>>>> >>>>>> Thanks! >>>>>> -Vincent >>>>>> >>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>> First of all, it looks very nice. >>>>>>> >>>>>>> Now, you said the events are displayed like in the notifications, > but >>>> in >>>>>>> the notifications they are ordered by dates, not by pages. Does your >>>>>>> proposal imply to change the ordering? What about events that do not >>>>>>> concern any page (like: "a new wiki has been created" or "a new > XWiki >>>>>>> version is available")? We don't have such events for now but we > plan >>>> to >>>>>>> have some soon. We could display them last for example. >>>>>>> >>>>>>> Nice CSS expand! >>>>>>> >>>>>>> Thanks you, >>>>>>> >>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>> valicac@gmail.com >>>>>>> : >>>>>>> >>>>>>>> This is a proposal for the Notifications mail: >>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>> NotificationsImprovements9xEmail >>>>>>>> >>>>>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>>>>> currently focused on the email template. If we drop the user avatar >>>>>> (since >>>>>>>> we group multiple users) then we can have the event/app icon > instead >>>> of >>>>>> the >>>>>>>> avatar. >>>>>>>> >>>>>>>> What I want to have feedback on is the email layout, functionality >>>> (tree >>>>>>>> navigation, details expanding) and styling. >>>>>>>> >>>>>>>> You can play with the Prototype >>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>> >>>>>>>> If we were to translate to the mail template, there are still some >>>>>> things >>>>>>>> to be tested (like translating the CSS selectors into inline, > decide >>>>>> what >>>>>>>> email clients we support, etc.) >>>>>>>> >>>>>>>> Let me know, >>>>>>>> Caty >>>>>>>> >>>>>>>> >>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>> >>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>> valicac@gmail.com >>>>>>>>> : >>>>>>>>> >>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>> >>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net
>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>> >>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user > profile? >>>>>>>>>>>>>> * We need a way to link directly to the diff, at least for > page >>>>>>>>>> events >>>>>>>>>>>> so that the user can see what was modified (as we have > currently >>>> in >>>>>>>>> the >>>>>>>>>>> AS) >>>>>>>>>>>>> >>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>>>>> see >>>>>>>>> I >>>>>>>>>>>> created and modified the Roadmap page but they both say “2 > hours >>>>>>>>> ago”. >>>>>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>>>>> >>>>>>>>>>>> My understanding is that events are grouped by app+type but not >>>> by >>>>>>>>>> entity >>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>> displayed >>>>>>>>> for >>>>>>>>>>> the >>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> And you could also have different users grouped in the same >>>> composite >>>>>>>>>>> event. So when you display the details, it would be nice to show >>>>>>>> which >>>>>>>>>> user >>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> The focus of this proposal is on user, compared to the old one, >>>> when >>>>>> it >>>>>>>>> was >>>>>>>>>> on the app/doc. >>>>>>>>>> Close to what we have on Facebool. So it didn't made sense that > we >>>> say >>>>>>>>> that >>>>>>>>>> a page has been edited by vmassol, and that the details showcase >>>> that >>>>>>>>>> multiple user actually did the edit. >>>>>>>>>> >>>>>>>>> >>>>>>>>> In Facebook, you have it actually: >>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>> >>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>> >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> >>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks >>>>>>>>>>>> -Vincent >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net >> >>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>>>> bottom >>>>>>>>>> and >>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> However I don’t think it scales since it means one unique > icon >>>>>>>>> per >>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> What would scale better is two icons: one for the app type > and >>>>>>>>> one >>>>>>>>>>> for >>>>>>>>>>>> the event type. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>> events: >>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>>>>> events. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the > Blog >>>>>>>>> app. >>>>>>>>>> A >>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>>>> harder >>>>>>>>>> to >>>>>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>>>>> there’s >>>>>>>>>>> only >>>>>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>> vincent@massol.net> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>> Notifications >>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>>>> displayed >>>>>>>>>>>> and you >>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>> modification? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>> Committer on the XWiki.org project >>>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>> >>>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >>> >> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project > >
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net> wrote:
On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
There is only 1 icon if the action is done by the "Pages" app, coming from XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
I find this highly confusing for my part :)
For me we always need 2 icons:
* one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event.
I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text.
I wouldn't drop the event icon since that's the most important piece of information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
In your variations I don’t see one where the app icon is on the left.
I have put all the icons on the left in order to be easier to scan for
them
in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them.
So Guillaume and Clement like the event-focused view.
I don't particularly like the big event icons. I find them more cold and less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
I like: http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
There’s another problem too actually. Not all events are related to people. For example the “A new version of XWiki is available” event would not have an avatar. However we could decide to use an “X” icon, representing the xwiki.org entity/avatar. What I wouldn’t like is some generic image such as a bland group image. I find that this breaks the concept of showing avatars. Thanks -Vincent
Now I haven't created versions for all the combinations, but we should decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important when there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always;
I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed?
Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice.
Thanks, Caty
Thanks -Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes
if
you want to make some small changes.
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net> wrote:
> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote: > > Hello > > 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>: > >> Hi Guillaume, >> >>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >>> >>> Any news on this? I'd like to implement this quickly because 9.10
is
>> coming >>> :) >> >> This the current status: >> * Caty proposed some improved layout for displaying notifications >> * I commented about the need to display event + type, and about the need >> to have a link to see the diff. I also mentioned that we need to work on >> the mail template display >> * Caty replied and updated her proposal to take into account those >> comments. >> * I kind of like Caty’s proposal focused on the user. We want to favor >> contributions and I think it helps. It also makes the UI more appealing >> visually. >> * You mentioned that you’d prefer a proposal more focused on the event >> rather than the user >> * Thomas agrees with you >> * Edy mentioned some extra points >> > > I have also mentioned that the diff we propose is too technical for many > users.
Yes and we have 4 solutions:
* Solution 1: make it simpler to understand for everyone * Solution 2: have a wiki admin UI level option to select whether to include diff or not in the default template + user-level profile UI option (ie. per user) * Solution 3: have a singe button in the mail, that, when clicked, displays the diff (which is hidden by default) * Solution 4: implement 2 mail templates (one for simple users and one for advanced users) and let the users choose in their profile which one they want to receive + have a wiki admin UI level option to decide which is the default when not overridden by the user.
Thanks -Vincent
> >> So I guess we need to decide about whether we show the avatar as in Caty’s >> proposal or not, right? Is that what you’re asking about Guillaume? >> >> On my side, I don’t see the issue in displaying the user avatar large vs >> small. The events are still ordered by page events. >> >> Thanks >> -Vincent >> > > Thanks > > >> >>> >>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com>: >>> >>>> Note that you have a mail template for the notifications too. It's >>>> https://github.com/xwiki/xwiki-platform/blob/ >>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>>> core/xwiki-platform-notifications/xwiki-platform- >>>> notifications-ui/src/main/resources/XWiki/Notifications/ >>>> MailTemplate.xml#L23 but it's not documented yet. >>>> >>>> This mail template allows you to customize the header and the footer of >>>> the email, but not the actual content. >>>> >>>> To be precise, each *event type* can have its own template or failback >> to >>>> the default one (https://github.com/xwiki/xwiki-platform/blob/ >>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>>> core/xwiki-platform-web/src/main/webapp/templates/ >>>> notification/email/default.html.vm) >>>> >>>> So it's a template *per event type* and it's not linked to any user >>>> choice. But we could add some options in the default template for >> example. >>>> >>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>> >>>>> Hi Guillaume, >>>>> >>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>> Some ideas. >>>>>> >>>>>> I have feedback about the fact the diff is way too technical for >> users. >>>>>> >>>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>>> pics/670307example1.png >>>>>> >>>>>> So we could hide this in a "technical details" link. >>>>> >>>>> That’s one option but there’s another which is to provide the ability >> to >>>>> choose which mail template to use in the Admin and provide several >>>>> templates for different needs. >>>>> >>>>> For example for the xwiki.org watchlist we absolutely need to be able >> to >>>>> see the diffs without clicking a “technical details” link for each >>>>> notification. It could be ok if there’s a single “technical details” >> link >>>>> for ALL notifications that shows all diffs at once. >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>>>> >>>>>> The "details" link could be replaced by a "more" link, with a very >>>>>> simplified diff (the complete diff would go the the technical details >>>>> view). >>>>>> >>>>>> In the body of the event, in addition with the title of the document, >> we >>>>>> could add some extracts of the diff. >>>>>> >>>>>> Example taken on gmail: >>>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>>> >>>>>> I hope it helps, >>>>>> >>>>>> Thanks >>>>>> >>>>>> >>>>>> >>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>>> >>>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>>> >>>>>>> I'd like an option to show the details for all events as otherwise >> it's >>>>>>> too painful to have to open all one by one (for the use case when you >>>>> want >>>>>>> to check everything). >>>>>>> >>>>>>> Same as Guillaume: not all events are page-related events. So we need >>>>> to >>>>>>> handle those too. >>>>>>> >>>>>>> Thanks! >>>>>>> -Vincent >>>>>>> >>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>> >>>>>>>> First of all, it looks very nice. >>>>>>>> >>>>>>>> Now, you said the events are displayed like in the notifications, >> but >>>>> in >>>>>>>> the notifications they are ordered by dates, not by pages. Does your >>>>>>>> proposal imply to change the ordering? What about events that do not >>>>>>>> concern any page (like: "a new wiki has been created" or "a new >> XWiki >>>>>>>> version is available")? We don't have such events for now but we >> plan >>>>> to >>>>>>>> have some soon. We could display them last for example. >>>>>>>> >>>>>>>> Nice CSS expand! >>>>>>>> >>>>>>>> Thanks you, >>>>>>>> >>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>>> valicac@gmail.com >>>>>>>> : >>>>>>>> >>>>>>>>> This is a proposal for the Notifications mail: >>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>> NotificationsImprovements9xEmail >>>>>>>>> >>>>>>>>> I've continued with the 'user' avatar focused proposal, since I've >>>>>>>>> currently focused on the email template. If we drop the user avatar >>>>>>> (since >>>>>>>>> we group multiple users) then we can have the event/app icon >> instead >>>>> of >>>>>>> the >>>>>>>>> avatar. >>>>>>>>> >>>>>>>>> What I want to have feedback on is the email layout, functionality >>>>> (tree >>>>>>>>> navigation, details expanding) and styling. >>>>>>>>> >>>>>>>>> You can play with the Prototype >>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>>> >>>>>>>>> If we were to translate to the mail template, there are still some >>>>>>> things >>>>>>>>> to be tested (like translating the CSS selectors into inline, >> decide >>>>>>> what >>>>>>>>> email clients we support, etc.) >>>>>>>>> >>>>>>>>> Let me know, >>>>>>>>> Caty >>>>>>>>> >>>>>>>>> >>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>> >>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>> valicac@gmail.com >>>>>>>>>> : >>>>>>>>>> >>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net > : >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net > >>>>>>>>>> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < vincent@massol.net> >>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user >> profile? >>>>>>>>>>>>>>> * We need a way to link directly to the diff, at least for >> page >>>>>>>>>>> events >>>>>>>>>>>>> so that the user can see what was modified (as we have >> currently >>>>> in >>>>>>>>>> the >>>>>>>>>>>> AS) >>>>>>>>>>>>>> >>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your example I >>>>>>>>> see >>>>>>>>>> I >>>>>>>>>>>>> created and modified the Roadmap page but they both say “2 >> hours >>>>>>>>>> ago”. >>>>>>>>>>>>> Shouldn’t I be able to see how far away both events were done? >>>>>>>>>>>>> >>>>>>>>>>>>> My understanding is that events are grouped by app+type but not >>>>> by >>>>>>>>>>> entity >>>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>>> displayed >>>>>>>>>> for >>>>>>>>>>>> the >>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> And you could also have different users grouped in the same >>>>> composite >>>>>>>>>>>> event. So when you display the details, it would be nice to show >>>>>>>>> which >>>>>>>>>>> user >>>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> The focus of this proposal is on user, compared to the old one, >>>>> when >>>>>>> it >>>>>>>>>> was >>>>>>>>>>> on the app/doc. >>>>>>>>>>> Close to what we have on Facebool. So it didn't made sense that >> we >>>>> say >>>>>>>>>> that >>>>>>>>>>> a page has been edited by vmassol, and that the details showcase >>>>> that >>>>>>>>>>> multiple user actually did the edit. >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> In Facebook, you have it actually: >>>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>>> >>>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks, >>>>>>>>>> >>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks >>>>>>>>>>>>> -Vincent >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < vincent@massol.net >>> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>>>>> bottom >>>>>>>>>>> and >>>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> However I don’t think it scales since it means one unique >> icon >>>>>>>>>> per >>>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> What would scale better is two icons: one for the app type >> and >>>>>>>>>> one >>>>>>>>>>>> for >>>>>>>>>>>>> the event type. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>>> events: >>>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the 3 >>>>>>>>>> events. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the >> Blog >>>>>>>>>> app. >>>>>>>>>>> A >>>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>>>>> harder >>>>>>>>>>> to >>>>>>>>>>>>> find unique icons as we had more events to apps, especially if >>>>>>>>>> there’s >>>>>>>>>>>> only >>>>>>>>>>>>> 1 icon that is supposed to combine both app type + event type. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>>> vincent@massol.net> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>>> Notifications >>>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>>>>> displayed >>>>>>>>>>>>> and you >>>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>>> modification? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>> >>>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>>> >>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project >> >> > > > -- > Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) > Research & Development Engineer at XWiki SAS > Committer on the XWiki.org project
I've iterated how it would look inside the mail, see http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xE... Still haven't found a solution for the avatar's group image, but the thing is that when the user selects to receive the diffs in the mail, this user grouping is confusing. For some events we display just the last change, not all the changes, or we display the whole diff, so it's kind of hard to tell which user did what. A solution would be to display the entries separate, each with its own diff. Not sure what is the best approach. Thanks, Caty On Mon, Oct 30, 2017 at 4:26 PM, Vincent Massol <vincent@massol.net> wrote:
On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net> wrote:
On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net>
wrote:
Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
There is only 1 icon if the action is done by the "Pages" app, coming
from
XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
I find this highly confusing for my part :)
For me we always need 2 icons:
* one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event.
I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text.
I wouldn't drop the event icon since that's the most important piece of information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
In your variations I don’t see one where the app icon is on the left.
I have put all the icons on the left in order to be easier to scan for
them
in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them.
So Guillaume and Clement like the event-focused view.
I don't particularly like the big event icons. I find them more cold
and
less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
I like: http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
There’s another problem too actually. Not all events are related to people. For example the “A new version of XWiki is available” event would not have an avatar. However we could decide to use an “X” icon, representing the xwiki.org entity/avatar.
What I wouldn’t like is some generic image such as a bland group image. I find that this breaks the concept of showing avatars.
Thanks -Vincent
Now I haven't created versions for all the combinations, but we should decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important
when
there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always;
I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed?
Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice.
Thanks, Caty
Thanks -Vincent
On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) < valicac@gmail.com
wrote:
Hi,
So these are some more iterations for the notifications layout http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9xTypes
I've played with User centered vs. Event centered and variants for displaying the avatars, user names and event names.
Let me know what version you prefer. Also you can fork the prototypes
if
you want to make some small changes.
Thanks, Caty
On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net
wrote:
> >> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < > guillaume.delhumeau@xwiki.com> wrote: >> >> Hello >> >> 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>: >> >>> Hi Guillaume, >>> >>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>> Any news on this? I'd like to implement this quickly because 9.10
is
>>> coming >>>> :) >>> >>> This the current status: >>> * Caty proposed some improved layout for displaying notifications >>> * I commented about the need to display event + type, and about the need >>> to have a link to see the diff. I also mentioned that we need to work on >>> the mail template display >>> * Caty replied and updated her proposal to take into account those >>> comments. >>> * I kind of like Caty’s proposal focused on the user. We want to favor >>> contributions and I think it helps. It also makes the UI more appealing >>> visually. >>> * You mentioned that you’d prefer a proposal more focused on the event >>> rather than the user >>> * Thomas agrees with you >>> * Edy mentioned some extra points >>> >> >> I have also mentioned that the diff we propose is too technical for many >> users. > > Yes and we have 4 solutions: > > * Solution 1: make it simpler to understand for everyone > * Solution 2: have a wiki admin UI level option to select whether to > include diff or not in the default template + user-level profile UI option > (ie. per user) > * Solution 3: have a singe button in the mail, that, when clicked, > displays the diff (which is hidden by default) > * Solution 4: implement 2 mail templates (one for simple users and one for > advanced users) and let the users choose in their profile which one they > want to receive + have a wiki admin UI level option to decide which is the > default when not overridden by the user. > > Thanks > -Vincent > >> >>> So I guess we need to decide about whether we show the avatar as in > Caty’s >>> proposal or not, right? Is that what you’re asking about Guillaume? >>> >>> On my side, I don’t see the issue in displaying the user avatar large vs >>> small. The events are still ordered by page events. >>> >>> Thanks >>> -Vincent >>> >> >> Thanks >> >> >>> >>>> >>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com>: >>>> >>>>> Note that you have a mail template for the notifications too. It's >>>>> https://github.com/xwiki/xwiki-platform/blob/ >>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>>>> core/xwiki-platform-notifications/xwiki-platform- >>>>> notifications-ui/src/main/resources/XWiki/Notifications/ >>>>> MailTemplate.xml#L23 but it's not documented yet. >>>>> >>>>> This mail template allows you to customize the header and the footer > of >>>>> the email, but not the actual content. >>>>> >>>>> To be precise, each *event type* can have its own template or failback >>> to >>>>> the default one (https://github.com/xwiki/xwiki-platform/blob/ >>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>>>> core/xwiki-platform-web/src/main/webapp/templates/ >>>>> notification/email/default.html.vm) >>>>> >>>>> So it's a template *per event type* and it's not linked to any user >>>>> choice. But we could add some options in the default template for >>> example. >>>>> >>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>> >>>>>> Hi Guillaume, >>>>>> >>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>> Some ideas. >>>>>>> >>>>>>> I have feedback about the fact the diff is way too technical for >>> users. >>>>>>> >>>>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>>>> pics/670307example1.png >>>>>>> >>>>>>> So we could hide this in a "technical details" link. >>>>>> >>>>>> That’s one option but there’s another which is to provide the ability >>> to >>>>>> choose which mail template to use in the Admin and provide several >>>>>> templates for different needs. >>>>>> >>>>>> For example for the xwiki.org watchlist we absolutely need to be > able >>> to >>>>>> see the diffs without clicking a “technical details” link for each >>>>>> notification. It could be ok if there’s a single “technical details” >>> link >>>>>> for ALL notifications that shows all diffs at once. >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>>>> >>>>>>> The "details" link could be replaced by a "more" link, with a very >>>>>>> simplified diff (the complete diff would go the the technical > details >>>>>> view). >>>>>>> >>>>>>> In the body of the event, in addition with the title of the > document, >>> we >>>>>>> could add some extracts of the diff. >>>>>>> >>>>>>> Example taken on gmail: >>>>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>>>> >>>>>>> I hope it helps, >>>>>>> >>>>>>> Thanks >>>>>>> >>>>>>> >>>>>>> >>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>>> >>>>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>>>> >>>>>>>> I'd like an option to show the details for all events as otherwise >>> it's >>>>>>>> too painful to have to open all one by one (for the use case when > you >>>>>> want >>>>>>>> to check everything). >>>>>>>> >>>>>>>> Same as Guillaume: not all events are page-related events. So we > need >>>>>> to >>>>>>>> handle those too. >>>>>>>> >>>>>>>> Thanks! >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>> >>>>>>>>> First of all, it looks very nice. >>>>>>>>> >>>>>>>>> Now, you said the events are displayed like in the notifications, >>> but >>>>>> in >>>>>>>>> the notifications they are ordered by dates, not by pages. Does > your >>>>>>>>> proposal imply to change the ordering? What about events that do > not >>>>>>>>> concern any page (like: "a new wiki has been created" or "a new >>> XWiki >>>>>>>>> version is available")? We don't have such events for now but we >>> plan >>>>>> to >>>>>>>>> have some soon. We could display them last for example. >>>>>>>>> >>>>>>>>> Nice CSS expand! >>>>>>>>> >>>>>>>>> Thanks you, >>>>>>>>> >>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>> valicac@gmail.com >>>>>>>>> : >>>>>>>>> >>>>>>>>>> This is a proposal for the Notifications mail: >>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>> NotificationsImprovements9xEmail >>>>>>>>>> >>>>>>>>>> I've continued with the 'user' avatar focused proposal, since > I've >>>>>>>>>> currently focused on the email template. If we drop the user > avatar >>>>>>>> (since >>>>>>>>>> we group multiple users) then we can have the event/app icon >>> instead >>>>>> of >>>>>>>> the >>>>>>>>>> avatar. >>>>>>>>>> >>>>>>>>>> What I want to have feedback on is the email layout, > functionality >>>>>> (tree >>>>>>>>>> navigation, details expanding) and styling. >>>>>>>>>> >>>>>>>>>> You can play with the Prototype >>>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>>>> >>>>>>>>>> If we were to translate to the mail template, there are still > some >>>>>>>> things >>>>>>>>>> to be tested (like translating the CSS selectors into inline, >>> decide >>>>>>>> what >>>>>>>>>> email clients we support, etc.) >>>>>>>>>> >>>>>>>>>> Let me know, >>>>>>>>>> Caty >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>> >>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>> valicac@gmail.com >>>>>>>>>>> : >>>>>>>>>>> >>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net >> : >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net >> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < > vincent@massol.net> >>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user >>> profile? >>>>>>>>>>>>>>>> * We need a way to link directly to the diff, at least for >>> page >>>>>>>>>>>> events >>>>>>>>>>>>>> so that the user can see what was modified (as we have >>> currently >>>>>> in >>>>>>>>>>> the >>>>>>>>>>>>> AS) >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your > example I >>>>>>>>>> see >>>>>>>>>>> I >>>>>>>>>>>>>> created and modified the Roadmap page but they both say “2 >>> hours >>>>>>>>>>> ago”. >>>>>>>>>>>>>> Shouldn’t I be able to see how far away both events were > done? >>>>>>>>>>>>>> >>>>>>>>>>>>>> My understanding is that events are grouped by app+type but > not >>>>>> by >>>>>>>>>>>> entity >>>>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>>>> displayed >>>>>>>>>>> for >>>>>>>>>>>>> the >>>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> And you could also have different users grouped in the same >>>>>> composite >>>>>>>>>>>>> event. So when you display the details, it would be nice to > show >>>>>>>>>> which >>>>>>>>>>>> user >>>>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> The focus of this proposal is on user, compared to the old one, >>>>>> when >>>>>>>> it >>>>>>>>>>> was >>>>>>>>>>>> on the app/doc. >>>>>>>>>>>> Close to what we have on Facebool. So it didn't made sense that >>> we >>>>>> say >>>>>>>>>>> that >>>>>>>>>>>> a page has been edited by vmassol, and that the details > showcase >>>>>> that >>>>>>>>>>>> multiple user actually did the edit. >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> In Facebook, you have it actually: >>>>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>>>> >>>>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> Thanks, >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < > vincent@massol.net >>>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>>>>>> bottom >>>>>>>>>>>> and >>>>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> However I don’t think it scales since it means one unique >>> icon >>>>>>>>>>> per >>>>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> What would scale better is two icons: one for the app type >>> and >>>>>>>>>>> one >>>>>>>>>>>>> for >>>>>>>>>>>>>> the event type. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>>>> events: >>>>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the > 3 >>>>>>>>>>> events. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the >>> Blog >>>>>>>>>>> app. >>>>>>>>>>>> A >>>>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>>>>>> harder >>>>>>>>>>>> to >>>>>>>>>>>>>> find unique icons as we had more events to apps, especially > if >>>>>>>>>>> there’s >>>>>>>>>>>>> only >>>>>>>>>>>>>> 1 icon that is supposed to combine both app type + event > type. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>>>> vincent@massol.net> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>>>> Notifications >>>>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>>>>>> displayed >>>>>>>>>>>>>> and you >>>>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>>>> modification? >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>> >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>>> >>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project >>> >>> >> >> >> -- >> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >> Research & Development Engineer at XWiki SAS >> Committer on the XWiki.org project
On 30 Oct 2017, at 18:46, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
I've iterated how it would look inside the mail, see http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xE...
Thanks Caty. In your proposal I don’t see where you put the TOC for non-page events.
Still haven't found a solution for the avatar's group image, but the thing is that when the user selects to receive the diffs in the mail, this user grouping is confusing.
Indeed, we cannot group diffs I think. The diff needs to be under each change, not under the whole grouped change.
For some events we display just the last change, not all the changes, or we display the whole diff, so it's kind of hard to tell which user did what.
A solution would be to display the entries separate, each with its own diff. Not sure what is the best approach.
Yep Thanks -Vincent
Thanks, Caty
On Mon, Oct 30, 2017 at 4:26 PM, Vincent Massol <vincent@massol.net> wrote:
On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net> wrote:
On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net>
wrote:
Hi Caty,
Thanks!
There’ s something I don’t understand. Sometimes you have 2 icons and sometimes only 1.
There is only 1 icon if the action is done by the "Pages" app, coming
from
XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
I find this highly confusing for my part :)
For me we always need 2 icons:
* one to represent the application (e.g. Pages app, Blog app, etc) * one to represent the event (e.g. for the Paged app: Create, Modify, Delete, Comment. For the Blog app: Publish a blog post)
So if we display the avatar this means 3 icons: one for the avatar, one for the app and one for the event. Maybe that’s a bit too much.
Right now, on the proposals I see, I find it very confusing and I can never figure out which is the app and which is the event.
I think I would prefer the following: * On the left, avatar in big + app in smaller on top of it * On the right, icon for the event. Actually the icon could be in addition to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted by”, etc) or we could drop the icon for the event and only keep the text.
I wouldn't drop the event icon since that's the most important piece of information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
In your variations I don’t see one where the app icon is on the left.
I have put all the icons on the left in order to be easier to scan for
them
in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them.
So Guillaume and Clement like the event-focused view.
I don't particularly like the big event icons. I find them more cold
and
less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
I like: http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
There’s another problem too actually. Not all events are related to people. For example the “A new version of XWiki is available” event would not have an avatar. However we could decide to use an “X” icon, representing the xwiki.org entity/avatar.
What I wouldn’t like is some generic image such as a bland group image. I find that this breaks the concept of showing avatars.
Thanks -Vincent
Now I haven't created versions for all the combinations, but we should decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important
when
there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always;
I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed?
Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice.
Thanks, Caty
Thanks -Vincent
> On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) < valicac@gmail.com
wrote: > > Hi, > > So these are some more iterations for the notifications layout > http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xTypes > > I've played with User centered vs. Event centered and variants for > displaying the avatars, user names and event names. > > Let me know what version you prefer. Also you can fork the prototypes if > you want to make some small changes. > > Thanks, > Caty > > On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol <vincent@massol.net
wrote: > >> >>> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < >> guillaume.delhumeau@xwiki.com> wrote: >>> >>> Hello >>> >>> 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>: >>> >>>> Hi Guillaume, >>>> >>>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>> Any news on this? I'd like to implement this quickly because 9.10 is >>>> coming >>>>> :) >>>> >>>> This the current status: >>>> * Caty proposed some improved layout for displaying notifications >>>> * I commented about the need to display event + type, and about the need >>>> to have a link to see the diff. I also mentioned that we need to work on >>>> the mail template display >>>> * Caty replied and updated her proposal to take into account those >>>> comments. >>>> * I kind of like Caty’s proposal focused on the user. We want to favor >>>> contributions and I think it helps. It also makes the UI more appealing >>>> visually. >>>> * You mentioned that you’d prefer a proposal more focused on the event >>>> rather than the user >>>> * Thomas agrees with you >>>> * Edy mentioned some extra points >>>> >>> >>> I have also mentioned that the diff we propose is too technical for many >>> users. >> >> Yes and we have 4 solutions: >> >> * Solution 1: make it simpler to understand for everyone >> * Solution 2: have a wiki admin UI level option to select whether to >> include diff or not in the default template + user-level profile UI option >> (ie. per user) >> * Solution 3: have a singe button in the mail, that, when clicked, >> displays the diff (which is hidden by default) >> * Solution 4: implement 2 mail templates (one for simple users and one for >> advanced users) and let the users choose in their profile which one they >> want to receive + have a wiki admin UI level option to decide which is the >> default when not overridden by the user. >> >> Thanks >> -Vincent >> >>> >>>> So I guess we need to decide about whether we show the avatar as in >> Caty’s >>>> proposal or not, right? Is that what you’re asking about Guillaume? >>>> >>>> On my side, I don’t see the issue in displaying the user avatar large vs >>>> small. The events are still ordered by page events. >>>> >>>> Thanks >>>> -Vincent >>>> >>> >>> Thanks >>> >>> >>>> >>>>> >>>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com>: >>>>> >>>>>> Note that you have a mail template for the notifications too. It's >>>>>> https://github.com/xwiki/xwiki-platform/blob/ >>>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>>>>> core/xwiki-platform-notifications/xwiki-platform- >>>>>> notifications-ui/src/main/resources/XWiki/Notifications/ >>>>>> MailTemplate.xml#L23 but it's not documented yet. >>>>>> >>>>>> This mail template allows you to customize the header and the footer >> of >>>>>> the email, but not the actual content. >>>>>> >>>>>> To be precise, each *event type* can have its own template or failback >>>> to >>>>>> the default one (https://github.com/xwiki/xwiki-platform/blob/ >>>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>>>>> core/xwiki-platform-web/src/main/webapp/templates/ >>>>>> notification/email/default.html.vm) >>>>>> >>>>>> So it's a template *per event type* and it's not linked to any user >>>>>> choice. But we could add some options in the default template for >>>> example. >>>>>> >>>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>>>> >>>>>>> Hi Guillaume, >>>>>>> >>>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>> >>>>>>>> Some ideas. >>>>>>>> >>>>>>>> I have feedback about the fact the diff is way too technical for >>>> users. >>>>>>>> >>>>>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>>>>> pics/670307example1.png >>>>>>>> >>>>>>>> So we could hide this in a "technical details" link. >>>>>>> >>>>>>> That’s one option but there’s another which is to provide the ability >>>> to >>>>>>> choose which mail template to use in the Admin and provide several >>>>>>> templates for different needs. >>>>>>> >>>>>>> For example for the xwiki.org watchlist we absolutely need to be >> able >>>> to >>>>>>> see the diffs without clicking a “technical details” link for each >>>>>>> notification. It could be ok if there’s a single “technical details” >>>> link >>>>>>> for ALL notifications that shows all diffs at once. >>>>>>> >>>>>>> Thanks >>>>>>> -Vincent >>>>>>> >>>>>>>> >>>>>>>> The "details" link could be replaced by a "more" link, with a very >>>>>>>> simplified diff (the complete diff would go the the technical >> details >>>>>>> view). >>>>>>>> >>>>>>>> In the body of the event, in addition with the title of the >> document, >>>> we >>>>>>>> could add some extracts of the diff. >>>>>>>> >>>>>>>> Example taken on gmail: >>>>>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>>>>> >>>>>>>> I hope it helps, >>>>>>>> >>>>>>>> Thanks >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>>>> >>>>>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>>>>> >>>>>>>>> I'd like an option to show the details for all events as otherwise >>>> it's >>>>>>>>> too painful to have to open all one by one (for the use case when >> you >>>>>>> want >>>>>>>>> to check everything). >>>>>>>>> >>>>>>>>> Same as Guillaume: not all events are page-related events. So we >> need >>>>>>> to >>>>>>>>> handle those too. >>>>>>>>> >>>>>>>>> Thanks! >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>> >>>>>>>>>> First of all, it looks very nice. >>>>>>>>>> >>>>>>>>>> Now, you said the events are displayed like in the notifications, >>>> but >>>>>>> in >>>>>>>>>> the notifications they are ordered by dates, not by pages. Does >> your >>>>>>>>>> proposal imply to change the ordering? What about events that do >> not >>>>>>>>>> concern any page (like: "a new wiki has been created" or "a new >>>> XWiki >>>>>>>>>> version is available")? We don't have such events for now but we >>>> plan >>>>>>> to >>>>>>>>>> have some soon. We could display them last for example. >>>>>>>>>> >>>>>>>>>> Nice CSS expand! >>>>>>>>>> >>>>>>>>>> Thanks you, >>>>>>>>>> >>>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>> valicac@gmail.com >>>>>>>>>> : >>>>>>>>>> >>>>>>>>>>> This is a proposal for the Notifications mail: >>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>> NotificationsImprovements9xEmail >>>>>>>>>>> >>>>>>>>>>> I've continued with the 'user' avatar focused proposal, since >> I've >>>>>>>>>>> currently focused on the email template. If we drop the user >> avatar >>>>>>>>> (since >>>>>>>>>>> we group multiple users) then we can have the event/app icon >>>> instead >>>>>>> of >>>>>>>>> the >>>>>>>>>>> avatar. >>>>>>>>>>> >>>>>>>>>>> What I want to have feedback on is the email layout, >> functionality >>>>>>> (tree >>>>>>>>>>> navigation, details expanding) and styling. >>>>>>>>>>> >>>>>>>>>>> You can play with the Prototype >>>>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>>>>> >>>>>>>>>>> If we were to translate to the mail template, there are still >> some >>>>>>>>> things >>>>>>>>>>> to be tested (like translating the CSS selectors into inline, >>>> decide >>>>>>>>> what >>>>>>>>>>> email clients we support, etc.) >>>>>>>>>>> >>>>>>>>>>> Let me know, >>>>>>>>>>> Caty >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>> >>>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com >>>>>>>>>>>> : >>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < vincent@massol.net >>> : >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < vincent@massol.net >>> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < >> vincent@massol.net> >>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user >>>> profile? >>>>>>>>>>>>>>>>> * We need a way to link directly to the diff, at least for >>>> page >>>>>>>>>>>>> events >>>>>>>>>>>>>>> so that the user can see what was modified (as we have >>>> currently >>>>>>> in >>>>>>>>>>>> the >>>>>>>>>>>>>> AS) >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your >> example I >>>>>>>>>>> see >>>>>>>>>>>> I >>>>>>>>>>>>>>> created and modified the Roadmap page but they both say “2 >>>> hours >>>>>>>>>>>> ago”. >>>>>>>>>>>>>>> Shouldn’t I be able to see how far away both events were >> done? >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> My understanding is that events are grouped by app+type but >> not >>>>>>> by >>>>>>>>>>>>> entity >>>>>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>>>>> displayed >>>>>>>>>>>> for >>>>>>>>>>>>>> the >>>>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> And you could also have different users grouped in the same >>>>>>> composite >>>>>>>>>>>>>> event. So when you display the details, it would be nice to >> show >>>>>>>>>>> which >>>>>>>>>>>>> user >>>>>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> The focus of this proposal is on user, compared to the old one, >>>>>>> when >>>>>>>>> it >>>>>>>>>>>> was >>>>>>>>>>>>> on the app/doc. >>>>>>>>>>>>> Close to what we have on Facebool. So it didn't made sense that >>>> we >>>>>>> say >>>>>>>>>>>> that >>>>>>>>>>>>> a page has been edited by vmassol, and that the details >> showcase >>>>>>> that >>>>>>>>>>>>> multiple user actually did the edit. >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> In Facebook, you have it actually: >>>>>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>>>>> >>>>>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < >> vincent@massol.net >>>>> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top to >>>>>>>>>>> bottom >>>>>>>>>>>>> and >>>>>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> However I don’t think it scales since it means one unique >>>> icon >>>>>>>>>>>> per >>>>>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> What would scale better is two icons: one for the app type >>>> and >>>>>>>>>>>> one >>>>>>>>>>>>>> for >>>>>>>>>>>>>>> the event type. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>>>>> events: >>>>>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent the >> 3 >>>>>>>>>>>> events. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the >>>> Blog >>>>>>>>>>>> app. >>>>>>>>>>>>> A >>>>>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder and >>>>>>>>>>> harder >>>>>>>>>>>>> to >>>>>>>>>>>>>>> find unique icons as we had more events to apps, especially >> if >>>>>>>>>>>> there’s >>>>>>>>>>>>>> only >>>>>>>>>>>>>>> 1 icon that is supposed to combine both app type + event >> type. >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>>>>> vincent@massol.net> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>>>>> Notifications >>>>>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the app? >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would be >>>>>>>>>>>>> displayed >>>>>>>>>>>>>>> and you >>>>>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>>>>> modification? >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>> Committer on the XWiki.org project >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project >>>> >>>> >>> >>> >>> -- >>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>> Research & Development Engineer at XWiki SAS >>> Committer on the XWiki.org project
2017-10-30 18:59 GMT+01:00 Vincent Massol <vincent@massol.net>:
On 30 Oct 2017, at 18:46, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
I've iterated how it would look inside the mail, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xEmail#HProposal2
Thanks Caty. In your proposal I don’t see where you put the TOC for non-page events.
Still haven't found a solution for the avatar's group image, but the thing is that when the user selects to receive the diffs in the mail, this user grouping is confusing.
Indeed, we cannot group diffs I think. The diff needs to be under each change, not under the whole grouped change.
This is not the case in the watchlist. In the watchlist, you see the diff for the whole changes on each listed page. I don't think you want to have each individual diff when you look on what's changed in the wiki.
For some events we display just the last change, not all the changes, or we display the whole diff, so it's kind of hard to tell which user did what.
A solution would be to display the entries separate, each with its own diff. Not sure what is the best approach.
Yep
Thanks -Vincent
Thanks, Caty
On Mon, Oct 30, 2017 at 4:26 PM, Vincent Massol <vincent@massol.net>
wrote:
On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net>
wrote:
On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <
valicac@gmail.com
wrote:
On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <vincent@massol.net
wrote:
> Hi Caty, > > Thanks! > > There’ s something I don’t understand. Sometimes you have 2 icons
and
> sometimes only 1. >
There is only 1 icon if the action is done by the "Pages" app, coming from XWiki. I've considered that this is the main/default app, so we don't display it. It's the default. So if you have created, edited, delete, commented on a normal page, you get just the event action. If the page is special, coming from a particular application, then you have an additional icon, marking the application.
I find this highly confusing for my part :)
For me we always need 2 icons: > * one to represent the application (e.g. Pages app, Blog app, etc) > * one to represent the event (e.g. for the Paged app: Create, Modify, > Delete, Comment. For the Blog app: Publish a blog post) > > So if we display the avatar this means 3 icons: one for the avatar, one > for the app and one for the event. Maybe that’s a bit too much. > > Right now, on the proposals I see, I find it very confusing and I can > never figure out which is the app and which is the event. > > I think I would prefer the following: > * On the left, avatar in big + app in smaller on top of it > * On the right, icon for the event. Actually the icon could be in addition > to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted > by”, etc) or we could drop the icon for the event and only keep the text. >
I wouldn't drop the event icon since that's the most important piece of information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
The grouping is done by page and by event. You want to know if someone deleted a new entry or just edited in a rapid way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
> In your variations I don’t see one where the app icon is on the
left.
>
I have put all the icons on the left in order to be easier to scan for them in collapsed and expanded form. Having the icons on the right made the layout very centered-heavy + you didn't had the extremities in order to scan for them.
So Guillaume and Clement like the event-focused view.
I don't particularly like the big event icons. I find them more cold and less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
I like: http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_ reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
There’s another problem too actually. Not all events are related to people. For example the “A new version of XWiki is available” event would not have an avatar. However we could decide to use an “X” icon, representing the xwiki.org entity/avatar.
What I wouldn’t like is some generic image such as a bland group image. I find that this breaks the concept of showing avatars.
Thanks -Vincent
Now I haven't created versions for all the combinations, but we
should
decide if: - we want user focused vs. event focused layout - expanded version should have users or events on the left; - the summary should contain avatars or not for the users (important when there is a single user that did the event); - if / when we combine the users (when we have more than 2/3 users; always;
I am lacking some information in order to get some statistical decisions. For example, in practice: - we have more individual events or more events done by multiple people? - how common is to group also events? the example with blog published that also has the create. Do we really need to display them? Also when creating an user profile we launch a multitude of edit events, should all those be displayed?
Regarding the user vs. event focused layout: it's just in the layout and what we display on the first position, since I've kept the current page/event grouping that is currently implemented. The decision depends on how everyone is using the wiki: are they more interested in activity being done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
I like to see who did what, but if the Notifications implementation will always group users and we will get the Group icon, than this might not be very nice.
Thanks, Caty
> Thanks > -Vincent > > >> On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) < valicac@gmail.com
> wrote: >> >> Hi, >> >> So these are some more iterations for the notifications layout >> http://design.xwiki.org/xwiki/bin/view/Proposal/ > NotificationsImprovements9xTypes >> >> I've played with User centered vs. Event centered and variants for >> displaying the avatars, user names and event names. >> >> Let me know what version you prefer. Also you can fork the prototypes if >> you want to make some small changes. >> >> Thanks, >> Caty >> >> On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol < vincent@massol.net
> wrote: >> >>> >>>> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < >>> guillaume.delhumeau@xwiki.com> wrote: >>>> >>>> Hello >>>> >>>> 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net>: >>>> >>>>> Hi Guillaume, >>>>> >>>>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < >>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>> >>>>>> Any news on this? I'd like to implement this quickly because 9.10 is >>>>> coming >>>>>> :) >>>>> >>>>> This the current status: >>>>> * Caty proposed some improved layout for displaying notifications >>>>> * I commented about the need to display event + type, and about the > need >>>>> to have a link to see the diff. I also mentioned that we need to work > on >>>>> the mail template display >>>>> * Caty replied and updated her proposal to take into account those >>>>> comments. >>>>> * I kind of like Caty’s proposal focused on the user. We want to favor >>>>> contributions and I think it helps. It also makes the UI more > appealing >>>>> visually. >>>>> * You mentioned that you’d prefer a proposal more focused on the event >>>>> rather than the user >>>>> * Thomas agrees with you >>>>> * Edy mentioned some extra points >>>>> >>>> >>>> I have also mentioned that the diff we propose is too technical for > many >>>> users. >>> >>> Yes and we have 4 solutions: >>> >>> * Solution 1: make it simpler to understand for everyone >>> * Solution 2: have a wiki admin UI level option to select whether to >>> include diff or not in the default template + user-level profile UI > option >>> (ie. per user) >>> * Solution 3: have a singe button in the mail, that, when clicked, >>> displays the diff (which is hidden by default) >>> * Solution 4: implement 2 mail templates (one for simple users and one > for >>> advanced users) and let the users choose in their profile which one they >>> want to receive + have a wiki admin UI level option to decide which is > the >>> default when not overridden by the user. >>> >>> Thanks >>> -Vincent >>> >>>> >>>>> So I guess we need to decide about whether we show the avatar as in >>> Caty’s >>>>> proposal or not, right? Is that what you’re asking about Guillaume? >>>>> >>>>> On my side, I don’t see the issue in displaying the user avatar large > vs >>>>> small. The events are still ordered by page events. >>>>> >>>>> Thanks >>>>> -Vincent >>>>> >>>> >>>> Thanks >>>> >>>> >>>>> >>>>>> >>>>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com>: >>>>>> >>>>>>> Note that you have a mail template for the notifications too. It's >>>>>>> https://github.com/xwiki/xwiki-platform/blob/ >>>>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>>>>>> core/xwiki-platform-notifications/xwiki-platform- >>>>>>> notifications-ui/src/main/resources/XWiki/Notifications/ >>>>>>> MailTemplate.xml#L23 but it's not documented yet. >>>>>>> >>>>>>> This mail template allows you to customize the header and the footer >>> of >>>>>>> the email, but not the actual content. >>>>>>> >>>>>>> To be precise, each *event type* can have its own template or > failback >>>>> to >>>>>>> the default one (https://github.com/xwiki/ xwiki-platform/blob/ >>>>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>>>>>> core/xwiki-platform-web/src/main/webapp/templates/ >>>>>>> notification/email/default.html.vm) >>>>>>> >>>>>>> So it's a template *per event type* and it's not linked to any user >>>>>>> choice. But we could add some options in the default template for >>>>> example. >>>>>>> >>>>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>>>> >>>>>>>> Hi Guillaume, >>>>>>>> >>>>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>> >>>>>>>>> Some ideas. >>>>>>>>> >>>>>>>>> I have feedback about the fact the diff is way too technical for >>>>> users. >>>>>>>>> >>>>>>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>>>>>> pics/670307example1.png >>>>>>>>> >>>>>>>>> So we could hide this in a "technical details" link. >>>>>>>> >>>>>>>> That’s one option but there’s another which is to provide the > ability >>>>> to >>>>>>>> choose which mail template to use in the Admin and provide several >>>>>>>> templates for different needs. >>>>>>>> >>>>>>>> For example for the xwiki.org watchlist we absolutely need to be >>> able >>>>> to >>>>>>>> see the diffs without clicking a “technical details” link for each >>>>>>>> notification. It could be ok if there’s a single “technical > details” >>>>> link >>>>>>>> for ALL notifications that shows all diffs at once. >>>>>>>> >>>>>>>> Thanks >>>>>>>> -Vincent >>>>>>>> >>>>>>>>> >>>>>>>>> The "details" link could be replaced by a "more" link, with a very >>>>>>>>> simplified diff (the complete diff would go the the technical >>> details >>>>>>>> view). >>>>>>>>> >>>>>>>>> In the body of the event, in addition with the title of the >>> document, >>>>> we >>>>>>>>> could add some extracts of the diff. >>>>>>>>> >>>>>>>>> Example taken on gmail: >>>>>>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>>>>>> >>>>>>>>> I hope it helps, >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>> >>>>>>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>>>>>> >>>>>>>>>> I'd like an option to show the details for all events as > otherwise >>>>> it's >>>>>>>>>> too painful to have to open all one by one (for the use case when >>> you >>>>>>>> want >>>>>>>>>> to check everything). >>>>>>>>>> >>>>>>>>>> Same as Guillaume: not all events are page-related events. So we >>> need >>>>>>>> to >>>>>>>>>> handle those too. >>>>>>>>>> >>>>>>>>>> Thanks! >>>>>>>>>> -Vincent >>>>>>>>>> >>>>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>> >>>>>>>>>>> First of all, it looks very nice. >>>>>>>>>>> >>>>>>>>>>> Now, you said the events are displayed like in the > notifications, >>>>> but >>>>>>>> in >>>>>>>>>>> the notifications they are ordered by dates, not by pages. Does >>> your >>>>>>>>>>> proposal imply to change the ordering? What about events that do >>> not >>>>>>>>>>> concern any page (like: "a new wiki has been created" or "a new >>>>> XWiki >>>>>>>>>>> version is available")? We don't have such events for now but we >>>>> plan >>>>>>>> to >>>>>>>>>>> have some soon. We could display them last for example. >>>>>>>>>>> >>>>>>>>>>> Nice CSS expand! >>>>>>>>>>> >>>>>>>>>>> Thanks you, >>>>>>>>>>> >>>>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>> valicac@gmail.com >>>>>>>>>>> : >>>>>>>>>>> >>>>>>>>>>>> This is a proposal for the Notifications mail: >>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>> NotificationsImprovements9xEmail >>>>>>>>>>>> >>>>>>>>>>>> I've continued with the 'user' avatar focused proposal, since >>> I've >>>>>>>>>>>> currently focused on the email template. If we drop the user >>> avatar >>>>>>>>>> (since >>>>>>>>>>>> we group multiple users) then we can have the event/app icon >>>>> instead >>>>>>>> of >>>>>>>>>> the >>>>>>>>>>>> avatar. >>>>>>>>>>>> >>>>>>>>>>>> What I want to have feedback on is the email layout, >>> functionality >>>>>>>> (tree >>>>>>>>>>>> navigation, details expanding) and styling. >>>>>>>>>>>> >>>>>>>>>>>> You can play with the Prototype >>>>>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>>>>>> >>>>>>>>>>>> If we were to translate to the mail template, there are still >>> some >>>>>>>>>> things >>>>>>>>>>>> to be tested (like translating the CSS selectors into inline, >>>>> decide >>>>>>>>>> what >>>>>>>>>>>> email clients we support, etc.) >>>>>>>>>>>> >>>>>>>>>>>> Let me know, >>>>>>>>>>>> Caty >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>>>> valicac@gmail.com >>>>>>>>>>>>> : >>>>>>>>>>>>> >>>>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>>>> >>>>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < > vincent@massol.net >>>> : >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < > vincent@massol.net >>>> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < >>> vincent@massol.net> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user >>>>> profile? >>>>>>>>>>>>>>>>>> * We need a way to link directly to the diff, at least > for >>>>> page >>>>>>>>>>>>>> events >>>>>>>>>>>>>>>> so that the user can see what was modified (as we have >>>>> currently >>>>>>>> in >>>>>>>>>>>>> the >>>>>>>>>>>>>>> AS) >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your >>> example I >>>>>>>>>>>> see >>>>>>>>>>>>> I >>>>>>>>>>>>>>>> created and modified the Roadmap page but they both say “2 >>>>> hours >>>>>>>>>>>>> ago”. >>>>>>>>>>>>>>>> Shouldn’t I be able to see how far away both events were >>> done? >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> My understanding is that events are grouped by app+type but >>> not >>>>>>>> by >>>>>>>>>>>>>> entity >>>>>>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>>>>>> displayed >>>>>>>>>>>>> for >>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> And you could also have different users grouped in the same >>>>>>>> composite >>>>>>>>>>>>>>> event. So when you display the details, it would be nice to >>> show >>>>>>>>>>>> which >>>>>>>>>>>>>> user >>>>>>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> The focus of this proposal is on user, compared to the old > one, >>>>>>>> when >>>>>>>>>> it >>>>>>>>>>>>> was >>>>>>>>>>>>>> on the app/doc. >>>>>>>>>>>>>> Close to what we have on Facebool. So it didn't made sense > that >>>>> we >>>>>>>> say >>>>>>>>>>>>> that >>>>>>>>>>>>>> a page has been edited by vmassol, and that the details >>> showcase >>>>>>>> that >>>>>>>>>>>>>> multiple user actually did the edit. >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> In Facebook, you have it actually: >>>>>>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>>>>>> >>>>>>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> Thanks, >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < >>> vincent@massol.net >>>>>> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top > to >>>>>>>>>>>> bottom >>>>>>>>>>>>>> and >>>>>>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> However I don’t think it scales since it means one > unique >>>>> icon >>>>>>>>>>>>> per >>>>>>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> What would scale better is two icons: one for the app > type >>>>> and >>>>>>>>>>>>> one >>>>>>>>>>>>>>> for >>>>>>>>>>>>>>>> the event type. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>>>>>> events: >>>>>>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent > the >>> 3 >>>>>>>>>>>>> events. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the >>>>> Blog >>>>>>>>>>>>> app. >>>>>>>>>>>>>> A >>>>>>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder > and >>>>>>>>>>>> harder >>>>>>>>>>>>>> to >>>>>>>>>>>>>>>> find unique icons as we had more events to apps, especially >>> if >>>>>>>>>>>>> there’s >>>>>>>>>>>>>>> only >>>>>>>>>>>>>>>> 1 icon that is supposed to combine both app type + event >>> type. >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>>>>>> vincent@massol.net> >>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>>>>>> Notifications >>>>>>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/ >>>>>>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the > app? >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would > be >>>>>>>>>>>>>> displayed >>>>>>>>>>>>>>>> and you >>>>>>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>>>>>> modification? >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> -- >>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>>> >>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>> Research & Development Engineer at XWiki SAS >>>>>> Committer on the XWiki.org project >>>>> >>>>> >>>> >>>> >>>> -- >>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>> Research & Development Engineer at XWiki SAS >>>> Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
So although I tried to keep the user avatars as primary elements in the UI, in the end I will change my vote to the event based layout. The first problem was the grouping we have. If we were to display individual entries for each user that layout might work, since we would not have the generic group avatar. But this was not the main problem. The main problem is scalability. Since we need to display the event and application, having also the avatar was putting the application icon as a tertiary element. Was very small and not readable at all. Today I was trying to represent how an application upgrade would look like. You can check http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9xT... So what I am proposing is a mix of the 2 layouts, see http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... For normal pages the event will be displayed as primary; while for application events the application is primary. I made this change taking into consideration Vincent's notes about confusion of knowing who sent the event. I think this way is easier to read and understand from where the event is coming from. So let me know what think about this latest layout. http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... Avatars are still present, but not primary. Applications are displayed. Prototype at https://jsfiddle.net/risherry/t1nv2uoz/ Thanks, Caty On Tue, Oct 31, 2017 at 11:11 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-30 18:59 GMT+01:00 Vincent Massol <vincent@massol.net>:
On 30 Oct 2017, at 18:46, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
I've iterated how it would look inside the mail, see http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9xEmail#HProposal2
Thanks Caty. In your proposal I don’t see where you put the TOC for non-page events.
Still haven't found a solution for the avatar's group image, but the thing is that when the user selects to receive the diffs in the mail, this
user
grouping is confusing.
Indeed, we cannot group diffs I think. The diff needs to be under each change, not under the whole grouped change.
This is not the case in the watchlist. In the watchlist, you see the diff for the whole changes on each listed page. I don't think you want to have each individual diff when you look on what's changed in the wiki.
For some events we display just the last change, not all the changes,
or
we
display the whole diff, so it's kind of hard to tell which user did what.
A solution would be to display the entries separate, each with its own diff. Not sure what is the best approach.
Yep
Thanks -Vincent
Thanks, Caty
On Mon, Oct 30, 2017 at 4:26 PM, Vincent Massol <vincent@massol.net>
wrote:
On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) <
valicac@gmail.com
wrote:
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net>
wrote:
> On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <
valicac@gmail.com
wrote: > > On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <
vincent@massol.net
wrote: > >> Hi Caty, >> >> Thanks! >> >> There’ s something I don’t understand. Sometimes you have 2 icons and >> sometimes only 1. >> > > There is only 1 icon if the action is done by the "Pages" app, coming from > XWiki. > I've considered that this is the main/default app, so we don't display it. > It's the default. > So if you have created, edited, delete, commented on a normal page, you get > just the event action. > If the page is special, coming from a particular application, then you have > an additional icon, marking the application.
I find this highly confusing for my part :)
> For me we always need 2 icons: >> * one to represent the application (e.g. Pages app, Blog app, etc) >> * one to represent the event (e.g. for the Paged app: Create, Modify, >> Delete, Comment. For the Blog app: Publish a blog post) >> >> So if we display the avatar this means 3 icons: one for the avatar, one >> for the app and one for the event. Maybe that’s a bit too much. >> >> Right now, on the proposals I see, I find it very confusing and I can >> never figure out which is the app and which is the event. >> >> I think I would prefer the following: >> * On the left, avatar in big + app in smaller on top of it >> * On the right, icon for the event. Actually the icon could be in addition >> to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted >> by”, etc) or we could drop the icon for the event and only keep the text. >> > > I wouldn't drop the event icon since that's the most important piece of > information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
> The grouping is done by page and by event. > You want to know if someone deleted a new entry or just edited in a rapid > way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
> >> In your variations I don’t see one where the app icon is on the
left.
>> > > I have put all the icons on the left in order to be easier to scan for them > in collapsed and expanded form. Having the icons on the right made the > layout very centered-heavy + you didn't had the extremities in order to > scan for them. > > So Guillaume and Clement like the event-focused view. > > I don't particularly like the big event icons. I find them more cold and > less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
> I like: > http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_ reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
There’s another problem too actually. Not all events are related to people. For example the “A new version of XWiki is available” event would not have an avatar. However we could decide to use an “X” icon, representing the xwiki.org entity/avatar.
What I wouldn’t like is some generic image such as a bland group image. I find that this breaks the concept of showing avatars.
Thanks -Vincent
> Now I haven't created versions for all the combinations, but we
should
> decide if: > - we want user focused vs. event focused layout > - expanded version should have users or events on the left; > - the summary should contain avatars or not for the users (important when > there is a single user that did the event); > - if / when we combine the users (when we have more than 2/3 users; always; > > I am lacking some information in order to get some statistical decisions. > For example, in practice: > - we have more individual events or more events done by multiple people? > - how common is to group also events? the example with blog published that > also has the create. Do we really need to display them? Also when creating > an user profile we launch a multitude of edit events, should all those be > displayed? > > Regarding the user vs. event focused layout: it's just in the layout and > what we display on the first position, since I've kept the current > page/event grouping that is currently implemented. The decision depends on > how everyone is using the wiki: are they more interested in activity being > done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
> I like to see who did what, but if the Notifications implementation will > always group users and we will get the Group icon, than this might not be > very nice. > > Thanks, > Caty > > > >> Thanks >> -Vincent >> >> >>> On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) < valicac@gmail.com > >> wrote: >>> >>> Hi, >>> >>> So these are some more iterations for the notifications layout >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9xTypes >>> >>> I've played with User centered vs. Event centered and variants for >>> displaying the avatars, user names and event names. >>> >>> Let me know what version you prefer. Also you can fork the prototypes if >>> you want to make some small changes. >>> >>> Thanks, >>> Caty >>> >>> On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol < vincent@massol.net
>> wrote: >>> >>>> >>>>> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>> Hello >>>>> >>>>> 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>> >>>>>> Hi Guillaume, >>>>>> >>>>>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>> Any news on this? I'd like to implement this quickly because 9.10 is >>>>>> coming >>>>>>> :) >>>>>> >>>>>> This the current status: >>>>>> * Caty proposed some improved layout for displaying notifications >>>>>> * I commented about the need to display event + type, and about the >> need >>>>>> to have a link to see the diff. I also mentioned that we need to work >> on >>>>>> the mail template display >>>>>> * Caty replied and updated her proposal to take into account those >>>>>> comments. >>>>>> * I kind of like Caty’s proposal focused on the user. We want to favor >>>>>> contributions and I think it helps. It also makes the UI more >> appealing >>>>>> visually. >>>>>> * You mentioned that you’d prefer a proposal more focused on the event >>>>>> rather than the user >>>>>> * Thomas agrees with you >>>>>> * Edy mentioned some extra points >>>>>> >>>>> >>>>> I have also mentioned that the diff we propose is too technical for >> many >>>>> users. >>>> >>>> Yes and we have 4 solutions: >>>> >>>> * Solution 1: make it simpler to understand for everyone >>>> * Solution 2: have a wiki admin UI level option to select whether to >>>> include diff or not in the default template + user-level profile UI >> option >>>> (ie. per user) >>>> * Solution 3: have a singe button in the mail, that, when clicked, >>>> displays the diff (which is hidden by default) >>>> * Solution 4: implement 2 mail templates (one for simple users and one >> for >>>> advanced users) and let the users choose in their profile which one they >>>> want to receive + have a wiki admin UI level option to decide which is >> the >>>> default when not overridden by the user. >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>>> So I guess we need to decide about whether we show the avatar as in >>>> Caty’s >>>>>> proposal or not, right? Is that what you’re asking about Guillaume? >>>>>> >>>>>> On my side, I don’t see the issue in displaying the user avatar large >> vs >>>>>> small. The events are still ordered by page events. >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>> >>>>> Thanks >>>>> >>>>> >>>>>> >>>>>>> >>>>>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com>: >>>>>>> >>>>>>>> Note that you have a mail template for the notifications too. It's >>>>>>>> https://github.com/xwiki/xwiki-platform/blob/ >>>>>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>>>>>>> core/xwiki-platform-notifications/xwiki-platform- >>>>>>>> notifications-ui/src/main/resources/XWiki/Notifications/ >>>>>>>> MailTemplate.xml#L23 but it's not documented yet. >>>>>>>> >>>>>>>> This mail template allows you to customize the header and the footer >>>> of >>>>>>>> the email, but not the actual content. >>>>>>>> >>>>>>>> To be precise, each *event type* can have its own template or >> failback >>>>>> to >>>>>>>> the default one (https://github.com/xwiki/ xwiki-platform/blob/ >>>>>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>>>>>>> core/xwiki-platform-web/src/main/webapp/templates/ >>>>>>>> notification/email/default.html.vm) >>>>>>>> >>>>>>>> So it's a template *per event type* and it's not linked to any user >>>>>>>> choice. But we could add some options in the default template for >>>>>> example. >>>>>>>> >>>>>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>> >>>>>>>>> Hi Guillaume, >>>>>>>>> >>>>>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>> >>>>>>>>>> Some ideas. >>>>>>>>>> >>>>>>>>>> I have feedback about the fact the diff is way too technical for >>>>>> users. >>>>>>>>>> >>>>>>>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>>>>>>> pics/670307example1.png >>>>>>>>>> >>>>>>>>>> So we could hide this in a "technical details" link. >>>>>>>>> >>>>>>>>> That’s one option but there’s another which is to provide the >> ability >>>>>> to >>>>>>>>> choose which mail template to use in the Admin and provide several >>>>>>>>> templates for different needs. >>>>>>>>> >>>>>>>>> For example for the xwiki.org watchlist we absolutely need to be >>>> able >>>>>> to >>>>>>>>> see the diffs without clicking a “technical details” link for each >>>>>>>>> notification. It could be ok if there’s a single “technical >> details” >>>>>> link >>>>>>>>> for ALL notifications that shows all diffs at once. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> >>>>>>>>>> The "details" link could be replaced by a "more" link, with a very >>>>>>>>>> simplified diff (the complete diff would go the the technical >>>> details >>>>>>>>> view). >>>>>>>>>> >>>>>>>>>> In the body of the event, in addition with the title of the >>>> document, >>>>>> we >>>>>>>>>> could add some extracts of the diff. >>>>>>>>>> >>>>>>>>>> Example taken on gmail: >>>>>>>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>>>>>>> >>>>>>>>>> I hope it helps, >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>>> >>>>>>>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>>>>>>> >>>>>>>>>>> I'd like an option to show the details for all events as >> otherwise >>>>>> it's >>>>>>>>>>> too painful to have to open all one by one (for the use case when >>>> you >>>>>>>>> want >>>>>>>>>>> to check everything). >>>>>>>>>>> >>>>>>>>>>> Same as Guillaume: not all events are page-related events. So we >>>> need >>>>>>>>> to >>>>>>>>>>> handle those too. >>>>>>>>>>> >>>>>>>>>>> Thanks! >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>> First of all, it looks very nice. >>>>>>>>>>>> >>>>>>>>>>>> Now, you said the events are displayed like in the >> notifications, >>>>>> but >>>>>>>>> in >>>>>>>>>>>> the notifications they are ordered by dates, not by pages. Does >>>> your >>>>>>>>>>>> proposal imply to change the ordering? What about events that do >>>> not >>>>>>>>>>>> concern any page (like: "a new wiki has been created" or "a new >>>>>> XWiki >>>>>>>>>>>> version is available")? We don't have such events for now but we >>>>>> plan >>>>>>>>> to >>>>>>>>>>>> have some soon. We could display them last for example. >>>>>>>>>>>> >>>>>>>>>>>> Nice CSS expand! >>>>>>>>>>>> >>>>>>>>>>>> Thanks you, >>>>>>>>>>>> >>>>>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com >>>>>>>>>>>> : >>>>>>>>>>>> >>>>>>>>>>>>> This is a proposal for the Notifications mail: >>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>> NotificationsImprovements9xEmail >>>>>>>>>>>>> >>>>>>>>>>>>> I've continued with the 'user' avatar focused proposal, since >>>> I've >>>>>>>>>>>>> currently focused on the email template. If we drop the user >>>> avatar >>>>>>>>>>> (since >>>>>>>>>>>>> we group multiple users) then we can have the event/app icon >>>>>> instead >>>>>>>>> of >>>>>>>>>>> the >>>>>>>>>>>>> avatar. >>>>>>>>>>>>> >>>>>>>>>>>>> What I want to have feedback on is the email layout, >>>> functionality >>>>>>>>> (tree >>>>>>>>>>>>> navigation, details expanding) and styling. >>>>>>>>>>>>> >>>>>>>>>>>>> You can play with the Prototype >>>>>>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>>>>>>> >>>>>>>>>>>>> If we were to translate to the mail template, there are still >>>> some >>>>>>>>>>> things >>>>>>>>>>>>> to be tested (like translating the CSS selectors into inline, >>>>>> decide >>>>>>>>>>> what >>>>>>>>>>>>> email clients we support, etc.) >>>>>>>>>>>>> >>>>>>>>>>>>> Let me know, >>>>>>>>>>>>> Caty >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>>>>> valicac@gmail.com >>>>>>>>>>>>>> : >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < >> vincent@massol.net >>>>> : >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < >> vincent@massol.net >>>>> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < >>>> vincent@massol.net> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user >>>>>> profile? >>>>>>>>>>>>>>>>>>> * We need a way to link directly to the diff, at least >> for >>>>>> page >>>>>>>>>>>>>>> events >>>>>>>>>>>>>>>>> so that the user can see what was modified (as we have >>>>>> currently >>>>>>>>> in >>>>>>>>>>>>>> the >>>>>>>>>>>>>>>> AS) >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your >>>> example I >>>>>>>>>>>>> see >>>>>>>>>>>>>> I >>>>>>>>>>>>>>>>> created and modified the Roadmap page but they both say “2 >>>>>> hours >>>>>>>>>>>>>> ago”. >>>>>>>>>>>>>>>>> Shouldn’t I be able to see how far away both events were >>>> done? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> My understanding is that events are grouped by app+type but >>>> not >>>>>>>>> by >>>>>>>>>>>>>>> entity >>>>>>>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>>>>>>> displayed >>>>>>>>>>>>>> for >>>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> And you could also have different users grouped in the same >>>>>>>>> composite >>>>>>>>>>>>>>>> event. So when you display the details, it would be nice to >>>> show >>>>>>>>>>>>> which >>>>>>>>>>>>>>> user >>>>>>>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> The focus of this proposal is on user, compared to the old >> one, >>>>>>>>> when >>>>>>>>>>> it >>>>>>>>>>>>>> was >>>>>>>>>>>>>>> on the app/doc. >>>>>>>>>>>>>>> Close to what we have on Facebool. So it didn't made sense >> that >>>>>> we >>>>>>>>> say >>>>>>>>>>>>>> that >>>>>>>>>>>>>>> a page has been edited by vmassol, and that the details >>>> showcase >>>>>>>>> that >>>>>>>>>>>>>>> multiple user actually did the edit. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> In Facebook, you have it actually: >>>>>>>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>>>>>>> >>>>>>>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < >>>> vincent@massol.net >>>>>>> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/ >>>>>>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top >> to >>>>>>>>>>>>> bottom >>>>>>>>>>>>>>> and >>>>>>>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> However I don’t think it scales since it means one >> unique >>>>>> icon >>>>>>>>>>>>>> per >>>>>>>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> What would scale better is two icons: one for the app >> type >>>>>> and >>>>>>>>>>>>>> one >>>>>>>>>>>>>>>> for >>>>>>>>>>>>>>>>> the event type. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>>>>>>> events: >>>>>>>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent >> the >>>> 3 >>>>>>>>>>>>>> events. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the >>>>>> Blog >>>>>>>>>>>>>> app. >>>>>>>>>>>>>>> A >>>>>>>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder >> and >>>>>>>>>>>>> harder >>>>>>>>>>>>>>> to >>>>>>>>>>>>>>>>> find unique icons as we had more events to apps, especially >>>> if >>>>>>>>>>>>>> there’s >>>>>>>>>>>>>>>> only >>>>>>>>>>>>>>>>> 1 icon that is supposed to combine both app type + event >>>> type. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>>>>>>> vincent@massol.net> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>>>>>>> Notifications >>>>>>>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/ >>>>>>>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the >> app? >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would >> be >>>>>>>>>>>>>>> displayed >>>>>>>>>>>>>>>>> and you >>>>>>>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>>>>>>> modification? >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>> Committer on the XWiki.org project >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
So although I tried to keep the user avatars as primary elements in the UI, in the end I will change my vote to the event based layout. The first problem was the grouping we have. If we were to display individual entries for each user that layout might work, since we would not have the generic group avatar. But this was not the main problem. The main problem is scalability. Since we need to display the event and application, having also the avatar was putting the application icon as a tertiary element. Was very small and not readable at all. Today I was trying to represent how an application upgrade would look like. You can check http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9xTypes#HApplicationsevents So what I am proposing is a mix of the 2 layouts, see http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/event_app_primary.png For normal pages the event will be displayed as primary; while for application events the application is primary. I made this change taking into consideration Vincent's notes about confusion of knowing who sent the event. I think this way is easier to read and understand from where the event is coming from. So let me know what think about this latest layout. http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/event_app_primary_extension.png Avatars are still present, but not primary. Applications are displayed. Prototype at https://jsfiddle.net/risherry/t1nv2uoz/ Thanks, Caty On Tue, Oct 31, 2017 at 11:11 AM, Guillaume Delhumeau < guillaume.delhumeau@xwiki.com> wrote:
2017-10-30 18:59 GMT+01:00 Vincent Massol <vincent@massol.net>:
On 30 Oct 2017, at 18:46, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
I've iterated how it would look inside the mail, see http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9xEmail#HProposal2
Thanks Caty. In your proposal I don’t see where you put the TOC for non-page events.
Still haven't found a solution for the avatar's group image, but the thing is that when the user selects to receive the diffs in the mail, this
user
grouping is confusing.
Indeed, we cannot group diffs I think. The diff needs to be under each change, not under the whole grouped change.
This is not the case in the watchlist. In the watchlist, you see the diff for the whole changes on each listed page. I don't think you want to have each individual diff when you look on what's changed in the wiki.
For some events we display just the last change, not all the changes,
or
we
display the whole diff, so it's kind of hard to tell which user did what.
A solution would be to display the entries separate, each with its own diff. Not sure what is the best approach.
Yep
Thanks -Vincent
Thanks, Caty
On Mon, Oct 30, 2017 at 4:26 PM, Vincent Massol <vincent@massol.net>
wrote:
On 30 Oct 2017, at 15:15, Ecaterina Moraru (Valica) <
valicac@gmail.com
wrote:
On Mon, Oct 30, 2017 at 3:50 PM, Vincent Massol <vincent@massol.net>
wrote:
> On 30 Oct 2017, at 12:27, Ecaterina Moraru (Valica) <
valicac@gmail.com
wrote: > > On Mon, Oct 30, 2017 at 12:32 PM, Vincent Massol <
vincent@massol.net
wrote: > >> Hi Caty, >> >> Thanks! >> >> There’ s something I don’t understand. Sometimes you have 2 icons and >> sometimes only 1. >> > > There is only 1 icon if the action is done by the "Pages" app, coming from > XWiki. > I've considered that this is the main/default app, so we don't display it. > It's the default. > So if you have created, edited, delete, commented on a normal page, you get > just the event action. > If the page is special, coming from a particular application, then you have > an additional icon, marking the application.
I find this highly confusing for my part :)
> For me we always need 2 icons: >> * one to represent the application (e.g. Pages app, Blog app, etc) >> * one to represent the event (e.g. for the Paged app: Create, Modify, >> Delete, Comment. For the Blog app: Publish a blog post) >> >> So if we display the avatar this means 3 icons: one for the avatar, one >> for the app and one for the event. Maybe that’s a bit too much. >> >> Right now, on the proposals I see, I find it very confusing and I can >> never figure out which is the app and which is the event. >> >> I think I would prefer the following: >> * On the left, avatar in big + app in smaller on top of it >> * On the right, icon for the event. Actually the icon could be in addition >> to the “text” (i.e. “edited by”, “published by”, “commented by”, “deleted >> by”, etc) or we could drop the icon for the event and only keep the text. >> > > I wouldn't drop the event icon since that's the most important piece of > information now.
I would not drop it but it’s already contained in the text on the right so that’s duplication.
I’d use the avatar + the app and leave the event icon on the right or simply drop it in favor of the text (either one).
> The grouping is done by page and by event. > You want to know if someone deleted a new entry or just edited in a rapid > way, without the need to read the text.
I’d prefer to see who did something and what they modified. That’s really how I use XWiki’s AS the most personally.
If the text is not visual enough the event icon is ok too but I wouldn’t put it on the left.
In any case, you need consistency and all entries need to look the same. We must not have special cases as it makes it very hard to understand.
For me it was confusing seeing "Pages", since in XWiki everything is a page and I don't have any application called Pages. I saw the addition of "Pages" as redundant.
> >> In your variations I don’t see one where the app icon is on the
left.
>> > > I have put all the icons on the left in order to be easier to scan for them > in collapsed and expanded form. Having the icons on the right made the > layout very centered-heavy + you didn't had the extremities in order to > scan for them. > > So Guillaume and Clement like the event-focused view. > > I don't particularly like the big event icons. I find them more cold and > less personal. So I prefer the users-centered version.
Same here for the same reason, but… (see below)
> I like: > http://design.xwiki.org/xwiki/bin/download/Proposal/ NotificationsImprovements9xTypes/userCentered_smallAvatars_ reverse.png
I don’t like the generic group image, it breaks the nice UI with avatars. We could maybe resize the avatars and display up to 4 and if beyond then display some continuations symbol.
Not really sure how to display 4 avatars + in a nice way, while still being the main focus.
There’s another problem too actually. Not all events are related to people. For example the “A new version of XWiki is available” event would not have an avatar. However we could decide to use an “X” icon, representing the xwiki.org entity/avatar.
What I wouldn’t like is some generic image such as a bland group image. I find that this breaks the concept of showing avatars.
Thanks -Vincent
> Now I haven't created versions for all the combinations, but we
should
> decide if: > - we want user focused vs. event focused layout > - expanded version should have users or events on the left; > - the summary should contain avatars or not for the users (important when > there is a single user that did the event); > - if / when we combine the users (when we have more than 2/3 users; always; > > I am lacking some information in order to get some statistical decisions. > For example, in practice: > - we have more individual events or more events done by multiple people? > - how common is to group also events? the example with blog published that > also has the create. Do we really need to display them? Also when creating > an user profile we launch a multitude of edit events, should all those be > displayed? > > Regarding the user vs. event focused layout: it's just in the layout and > what we display on the first position, since I've kept the current > page/event grouping that is currently implemented. The decision depends on > how everyone is using the wiki: are they more interested in activity being > done on the wiki or who actually did that activity?
Both are needed and it depends on the usage I guess. My feeling is that humans are good at relationships in a group and a picture speaks more than a generic icon for an app. You know who you work with, you know people you like, you know who you consider is a stranger, etc and you’ll want to check the diff and dive further based on that. The fact that the avatar is shown prominently will help that.
Thanks -Vincent
> I like to see who did what, but if the Notifications implementation will > always group users and we will get the Group icon, than this might not be > very nice. > > Thanks, > Caty > > > >> Thanks >> -Vincent >> >> >>> On 27 Oct 2017, at 17:31, Ecaterina Moraru (Valica) < valicac@gmail.com > >> wrote: >>> >>> Hi, >>> >>> So these are some more iterations for the notifications layout >>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >> NotificationsImprovements9xTypes >>> >>> I've played with User centered vs. Event centered and variants for >>> displaying the avatars, user names and event names. >>> >>> Let me know what version you prefer. Also you can fork the prototypes if >>> you want to make some small changes. >>> >>> Thanks, >>> Caty >>> >>> On Tue, Oct 24, 2017 at 12:47 PM, Vincent Massol < vincent@massol.net
>> wrote: >>> >>>> >>>>> On 24 Oct 2017, at 11:24, Guillaume Delhumeau < >>>> guillaume.delhumeau@xwiki.com> wrote: >>>>> >>>>> Hello >>>>> >>>>> 2017-10-24 11:12 GMT+02:00 Vincent Massol <vincent@massol.net : >>>>> >>>>>> Hi Guillaume, >>>>>> >>>>>>> On 24 Oct 2017, at 10:58, Guillaume Delhumeau < >>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>> >>>>>>> Any news on this? I'd like to implement this quickly because 9.10 is >>>>>> coming >>>>>>> :) >>>>>> >>>>>> This the current status: >>>>>> * Caty proposed some improved layout for displaying notifications >>>>>> * I commented about the need to display event + type, and about the >> need >>>>>> to have a link to see the diff. I also mentioned that we need to work >> on >>>>>> the mail template display >>>>>> * Caty replied and updated her proposal to take into account those >>>>>> comments. >>>>>> * I kind of like Caty’s proposal focused on the user. We want to favor >>>>>> contributions and I think it helps. It also makes the UI more >> appealing >>>>>> visually. >>>>>> * You mentioned that you’d prefer a proposal more focused on the event >>>>>> rather than the user >>>>>> * Thomas agrees with you >>>>>> * Edy mentioned some extra points >>>>>> >>>>> >>>>> I have also mentioned that the diff we propose is too technical for >> many >>>>> users. >>>> >>>> Yes and we have 4 solutions: >>>> >>>> * Solution 1: make it simpler to understand for everyone >>>> * Solution 2: have a wiki admin UI level option to select whether to >>>> include diff or not in the default template + user-level profile UI >> option >>>> (ie. per user) >>>> * Solution 3: have a singe button in the mail, that, when clicked, >>>> displays the diff (which is hidden by default) >>>> * Solution 4: implement 2 mail templates (one for simple users and one >> for >>>> advanced users) and let the users choose in their profile which one they >>>> want to receive + have a wiki admin UI level option to decide which is >> the >>>> default when not overridden by the user. >>>> >>>> Thanks >>>> -Vincent >>>> >>>>> >>>>>> So I guess we need to decide about whether we show the avatar as in >>>> Caty’s >>>>>> proposal or not, right? Is that what you’re asking about Guillaume? >>>>>> >>>>>> On my side, I don’t see the issue in displaying the user avatar large >> vs >>>>>> small. The events are still ordered by page events. >>>>>> >>>>>> Thanks >>>>>> -Vincent >>>>>> >>>>> >>>>> Thanks >>>>> >>>>> >>>>>> >>>>>>> >>>>>>> 2017-10-23 13:19 GMT+02:00 Guillaume Delhumeau < >>>>>>> guillaume.delhumeau@xwiki.com>: >>>>>>> >>>>>>>> Note that you have a mail template for the notifications too. It's >>>>>>>> https://github.com/xwiki/xwiki-platform/blob/ >>>>>>>> 83b76ed4c26954aa2755bbdce23b32c41725ac06/xwiki-platform- >>>>>>>> core/xwiki-platform-notifications/xwiki-platform- >>>>>>>> notifications-ui/src/main/resources/XWiki/Notifications/ >>>>>>>> MailTemplate.xml#L23 but it's not documented yet. >>>>>>>> >>>>>>>> This mail template allows you to customize the header and the footer >>>> of >>>>>>>> the email, but not the actual content. >>>>>>>> >>>>>>>> To be precise, each *event type* can have its own template or >> failback >>>>>> to >>>>>>>> the default one (https://github.com/xwiki/ xwiki-platform/blob/ >>>>>>>> acdf68f4c0d20a9b44ea48eec4df808e22c54548/xwiki-platform- >>>>>>>> core/xwiki-platform-web/src/main/webapp/templates/ >>>>>>>> notification/email/default.html.vm) >>>>>>>> >>>>>>>> So it's a template *per event type* and it's not linked to any user >>>>>>>> choice. But we could add some options in the default template for >>>>>> example. >>>>>>>> >>>>>>>> 2017-10-17 16:23 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>> >>>>>>>>> Hi Guillaume, >>>>>>>>> >>>>>>>>>> On 17 Oct 2017, at 07:16, Guillaume Delhumeau < >>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>> >>>>>>>>>> Some ideas. >>>>>>>>>> >>>>>>>>>> I have feedback about the fact the diff is way too technical for >>>>>> users. >>>>>>>>>> >>>>>>>>>> Example: "What does it means???" https://img15.hostingpics.net/ >>>>>>>>>> pics/670307example1.png >>>>>>>>>> >>>>>>>>>> So we could hide this in a "technical details" link. >>>>>>>>> >>>>>>>>> That’s one option but there’s another which is to provide the >> ability >>>>>> to >>>>>>>>> choose which mail template to use in the Admin and provide several >>>>>>>>> templates for different needs. >>>>>>>>> >>>>>>>>> For example for the xwiki.org watchlist we absolutely need to be >>>> able >>>>>> to >>>>>>>>> see the diffs without clicking a “technical details” link for each >>>>>>>>> notification. It could be ok if there’s a single “technical >> details” >>>>>> link >>>>>>>>> for ALL notifications that shows all diffs at once. >>>>>>>>> >>>>>>>>> Thanks >>>>>>>>> -Vincent >>>>>>>>> >>>>>>>>>> >>>>>>>>>> The "details" link could be replaced by a "more" link, with a very >>>>>>>>>> simplified diff (the complete diff would go the the technical >>>> details >>>>>>>>> view). >>>>>>>>>> >>>>>>>>>> In the body of the event, in addition with the title of the >>>> document, >>>>>> we >>>>>>>>>> could add some extracts of the diff. >>>>>>>>>> >>>>>>>>>> Example taken on gmail: >>>>>>>>>> https://img15.hostingpics.net/pics/763456example2.png >>>>>>>>>> >>>>>>>>>> I hope it helps, >>>>>>>>>> >>>>>>>>>> Thanks >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> 2017-10-12 15:38 GMT+02:00 Vincent Massol < vincent@massol.net : >>>>>>>>>> >>>>>>>>>>> Looks nice. Does it work in all mail clients that support HTML? >>>>>>>>>>> >>>>>>>>>>> I'd like an option to show the details for all events as >> otherwise >>>>>> it's >>>>>>>>>>> too painful to have to open all one by one (for the use case when >>>> you >>>>>>>>> want >>>>>>>>>>> to check everything). >>>>>>>>>>> >>>>>>>>>>> Same as Guillaume: not all events are page-related events. So we >>>> need >>>>>>>>> to >>>>>>>>>>> handle those too. >>>>>>>>>>> >>>>>>>>>>> Thanks! >>>>>>>>>>> -Vincent >>>>>>>>>>> >>>>>>>>>>>> On 12 Oct 2017, at 15:03, Guillaume Delhumeau < >>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>> >>>>>>>>>>>> First of all, it looks very nice. >>>>>>>>>>>> >>>>>>>>>>>> Now, you said the events are displayed like in the >> notifications, >>>>>> but >>>>>>>>> in >>>>>>>>>>>> the notifications they are ordered by dates, not by pages. Does >>>> your >>>>>>>>>>>> proposal imply to change the ordering? What about events that do >>>> not >>>>>>>>>>>> concern any page (like: "a new wiki has been created" or "a new >>>>>> XWiki >>>>>>>>>>>> version is available")? We don't have such events for now but we >>>>>> plan >>>>>>>>> to >>>>>>>>>>>> have some soon. We could display them last for example. >>>>>>>>>>>> >>>>>>>>>>>> Nice CSS expand! >>>>>>>>>>>> >>>>>>>>>>>> Thanks you, >>>>>>>>>>>> >>>>>>>>>>>> 2017-10-12 14:47 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>>> valicac@gmail.com >>>>>>>>>>>> : >>>>>>>>>>>> >>>>>>>>>>>>> This is a proposal for the Notifications mail: >>>>>>>>>>>>> http://design.xwiki.org/xwiki/bin/view/Proposal/ >>>>>>>>>>>>> NotificationsImprovements9xEmail >>>>>>>>>>>>> >>>>>>>>>>>>> I've continued with the 'user' avatar focused proposal, since >>>> I've >>>>>>>>>>>>> currently focused on the email template. If we drop the user >>>> avatar >>>>>>>>>>> (since >>>>>>>>>>>>> we group multiple users) then we can have the event/app icon >>>>>> instead >>>>>>>>> of >>>>>>>>>>> the >>>>>>>>>>>>> avatar. >>>>>>>>>>>>> >>>>>>>>>>>>> What I want to have feedback on is the email layout, >>>> functionality >>>>>>>>> (tree >>>>>>>>>>>>> navigation, details expanding) and styling. >>>>>>>>>>>>> >>>>>>>>>>>>> You can play with the Prototype >>>>>>>>>>>>> http://jsfiddle.net/risherry/cj25759w/embedded/#Result >>>>>>>>>>>>> >>>>>>>>>>>>> If we were to translate to the mail template, there are still >>>> some >>>>>>>>>>> things >>>>>>>>>>>>> to be tested (like translating the CSS selectors into inline, >>>>>> decide >>>>>>>>>>> what >>>>>>>>>>>>> email clients we support, etc.) >>>>>>>>>>>>> >>>>>>>>>>>>> Let me know, >>>>>>>>>>>>> Caty >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On Tue, Oct 10, 2017 at 5:51 PM, Guillaume Delhumeau < >>>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>>> >>>>>>>>>>>>>> 2017-10-03 17:32 GMT+02:00 Ecaterina Moraru (Valica) < >>>>>>>>>>> valicac@gmail.com >>>>>>>>>>>>>> : >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On Tue, Oct 3, 2017 at 10:50 AM, Guillaume Delhumeau < >>>>>>>>>>>>>>> guillaume.delhumeau@xwiki.com> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> 2017-10-02 18:09 GMT+02:00 Vincent Massol < >> vincent@massol.net >>>>> : >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:08, Vincent Massol < >> vincent@massol.net >>>>> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:05, Vincent Massol < >>>> vincent@massol.net> >>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Another feedback/questions: >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> * Is the avatar icon clickable and leading to the user >>>>>> profile? >>>>>>>>>>>>>>>>>>> * We need a way to link directly to the diff, at least >> for >>>>>> page >>>>>>>>>>>>>>> events >>>>>>>>>>>>>>>>> so that the user can see what was modified (as we have >>>>>> currently >>>>>>>>> in >>>>>>>>>>>>>> the >>>>>>>>>>>>>>>> AS) >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> * Maybe “2 hours ago” is not precise enough. In your >>>> example I >>>>>>>>>>>>> see >>>>>>>>>>>>>> I >>>>>>>>>>>>>>>>> created and modified the Roadmap page but they both say “2 >>>>>> hours >>>>>>>>>>>>>> ago”. >>>>>>>>>>>>>>>>> Shouldn’t I be able to see how far away both events were >>>> done? >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> My understanding is that events are grouped by app+type but >>>> not >>>>>>>>> by >>>>>>>>>>>>>>> entity >>>>>>>>>>>>>>>>> anymore (for page events) and thus you can have 3 events >>>>>>>>> displayed >>>>>>>>>>>>>> for >>>>>>>>>>>>>>>> the >>>>>>>>>>>>>>>>> same page, f.ex: Creation, Modification, Deletion. >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> And you could also have different users grouped in the same >>>>>>>>> composite >>>>>>>>>>>>>>>> event. So when you display the details, it would be nice to >>>> show >>>>>>>>>>>>> which >>>>>>>>>>>>>>> user >>>>>>>>>>>>>>>> made each event, and I see you have removed this info. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> The focus of this proposal is on user, compared to the old >> one, >>>>>>>>> when >>>>>>>>>>> it >>>>>>>>>>>>>> was >>>>>>>>>>>>>>> on the app/doc. >>>>>>>>>>>>>>> Close to what we have on Facebool. So it didn't made sense >> that >>>>>> we >>>>>>>>> say >>>>>>>>>>>>>> that >>>>>>>>>>>>>>> a page has been edited by vmassol, and that the details >>>> showcase >>>>>>>>> that >>>>>>>>>>>>>>> multiple user actually did the edit. >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> In Facebook, you have it actually: >>>>>>>>>>>>>> https://pasteboard.co/GOioRAT.png >>>>>>>>>>>>>> >>>>>>>>>>>>>> On XWiki, we have the following (already implemented): >>>>>>>>>>>>>> https://pasteboard.co/GOiqgYf.png >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 18:01, Vincent Massol < >>>> vincent@massol.net >>>>>>> >>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Event Type: BlogPostPublishedEvent >>>>>>>>>>>>>>>>>>>>> from >>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/ >>>>>>>>>>>>>>>>> NotificationsImprovements9x#HEventTypes >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> ok thanks, had missed this since I was reading from top >> to >>>>>>>>>>>>> bottom >>>>>>>>>>>>>>> and >>>>>>>>>>>>>>>>> stopped at the overview :) >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> However I don’t think it scales since it means one >> unique >>>>>> icon >>>>>>>>>>>>>> per >>>>>>>>>>>>>>>>> combination of app type + event type. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> What would scale better is two icons: one for the app >> type >>>>>> and >>>>>>>>>>>>>> one >>>>>>>>>>>>>>>> for >>>>>>>>>>>>>>>>> the event type. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> For example imagine that the Blog app had the following >>>>>>>>> events: >>>>>>>>>>>>>>>>>>>> * When a blog post is published >>>>>>>>>>>>>>>>>>>> * When a blog post is created >>>>>>>>>>>>>>>>>>>> * When a blog post is removed >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> You wouldn’t be able to use the RSS icon to represent >> the >>>> 3 >>>>>>>>>>>>>> events. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> BTW the RSS icon isn’t necessarily representative of the >>>>>> Blog >>>>>>>>>>>>>> app. >>>>>>>>>>>>>>> A >>>>>>>>>>>>>>>>> lot of apps can have a RSS feed. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> That’s the main remark I have: it’s going to be harder >> and >>>>>>>>>>>>> harder >>>>>>>>>>>>>>> to >>>>>>>>>>>>>>>>> find unique icons as we had more events to apps, especially >>>> if >>>>>>>>>>>>>> there’s >>>>>>>>>>>>>>>> only >>>>>>>>>>>>>>>>> 1 icon that is supposed to combine both app type + event >>>> type. >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> WDYT? >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>> On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol < >>>>>>>>>>>>>>> vincent@massol.net> >>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Hi Caty, >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < >>>>>>>>>>>>>>>>> valicac@gmail.com> >>>>>>>>>>>>>>>>>>>>>> wrote: >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Hi, >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> I've created some improvements suggestions for our >>>>>>>>>>>>>> Notifications >>>>>>>>>>>>>>>>> UI, see >>>>>>>>>>>>>>>>>>>>>>> http://design.xwiki.org/xwiki/ bin/view/Proposal/ >>>>>>>>>>>>>>>>>>>>>> NotificationsImprovements9x >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Let me know what you think. >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Re the overview, I don’t see where you mention the >> app? >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> For example, could you show how a new Blog post would >> be >>>>>>>>>>>>>>> displayed >>>>>>>>>>>>>>>>> and you >>>>>>>>>>>>>>>>>>>>>> differentiate that for example from a Page creation or >>>>>>>>>>>>>>>> modification? >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> Thanks >>>>>>>>>>>>>>>>>>>>>> -Vincent >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>>> Thanks, >>>>>>>>>>>>>>>>>>>>>>> Caty >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> -- >>>>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> -- >>>>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>>>> Committer on the XWiki.org project >>>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>>>> Committer on the XWiki.org project >>>>>>>>> >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>>> Research & Development Engineer at XWiki SAS >>>>>>>> Committer on the XWiki.org project >>>>>>>> >>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>>>> Research & Development Engineer at XWiki SAS >>>>>>> Committer on the XWiki.org project >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) >>>>> Research & Development Engineer at XWiki SAS >>>>> Committer on the XWiki.org project
-- Guillaume Delhumeau (guillaume.delhumeau@xwiki.com) Research & Development Engineer at XWiki SAS Committer on the XWiki.org project
So although I tried to keep the user avatars as primary elements in the UI, in the end I will change my vote to the event based layout. The first problem was the grouping we have. If we were to display individual entries for each user that layout might work, since we would not have the generic group avatar. But this was not the main problem. The main problem is scalability. Since we need to display the event and application, having also the avatar was putting the application icon as a tertiary element. Was very small and not readable at all. Today I was trying to represent how an application upgrade would look like. You can check http://design.xwiki.org/xwiki/bin/view/Proposal/Notification sImprovements9xTypes#HApplicationsevents So what I am proposing is a mix of the 2 layouts, see http://design.xwiki.org/xwiki/bin/download/Proposal/Notifica tionsImprovements9xTypes/event_app_primary.png For normal pages the event will be displayed as primary; while for application events the application is primary. I made this change taking into consideration Vincent's notes about confusion of knowing who sent the event. I think this way is easier to read and understand from where the event is coming from. So let me know what think about this latest layout. http://design.xwiki.org/xwiki/bin/download/Proposal/Notifica tionsImprovements9xTypes/event_app_primary_extension.png Avatars are still present, but not primary. Applications are displayed. Prototype at https://jsfiddle.net/risherry/t1nv2uoz/ Thanks, Caty
On Mon, Oct 2, 2017 at 7:08 PM, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
* Maybe “2 hours ago” is not precise enough. In your example I see I created and modified the Roadmap page but they both say “2 hours ago”. Shouldn’t I be able to see how far away both events were done?
This depends on the implementation. My point was that we should use jodatime and present some nicer times, just like we have in AS. The full time is present in the title.
Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com>
wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/
NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) < valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On 2 Oct 2017, at 18:05, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile? * We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
Actually it would be awesome to be able to see the diff without navigating away. Thanks -Vincent
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/NotificationsImprovements9x#...
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 7:05 PM, Vincent Massol <vincent@massol.net> wrote:
Another feedback/questions:
* Is the avatar icon clickable and leading to the user profile?
yes
* We need a way to link directly to the diff, at least for page events so that the user can see what was modified (as we have currently in the AS)
yes, we can extend the events with details if we want, just like we do for comments, diff, etc. in Activity Stream. They worked well in AS. But we need to decide on some limits, since the 5 entries loading is not very practical and we might want to provide a zone where user can see more than 5 notifications.
Thanks -Vincent
On 2 Oct 2017, at 18:01, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com
wrote:
Hi,
I've created some improvements suggestions for our Notifications UI,
see
http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 7:01 PM, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
I've used the RSS icon since that's the icon the Blog Application is using to represent itself in the AppBar.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
Regarding this comment, we can do what Silk icon where doing in the Activity Stream. I've iterated here: http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... on how it would look like. I prefer Var 2, but you can see here multiple variations http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement...
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
On 3 Oct 2017, at 17:27, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
On Mon, Oct 2, 2017 at 7:01 PM, Vincent Massol <vincent@massol.net> wrote:
On 2 Oct 2017, at 17:54, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Event Type: BlogPostPublishedEvent from http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x#HEventTypes
ok thanks, had missed this since I was reading from top to bottom and stopped at the overview :)
However I don’t think it scales since it means one unique icon per combination of app type + event type.
What would scale better is two icons: one for the app type and one for the event type.
For example imagine that the Blog app had the following events: * When a blog post is published * When a blog post is created * When a blog post is removed
You wouldn’t be able to use the RSS icon to represent the 3 events.
BTW the RSS icon isn’t necessarily representative of the Blog app. A lot of apps can have a RSS feed.
I've used the RSS icon since that's the icon the Blog Application is using to represent itself in the AppBar.
ok, makes sense.
That’s the main remark I have: it’s going to be harder and harder to find unique icons as we had more events to apps, especially if there’s only 1 icon that is supposed to combine both app type + event type.
Regarding this comment, we can do what Silk icon where doing in the Activity Stream. I've iterated here: http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement... on how it would look like. I prefer Var 2, but you can see here multiple variations http://design.xwiki.org/xwiki/bin/download/Proposal/NotificationsImprovement...
Cool, that’s what I meant. I hope it’s not going to be too confusing for users. I don’t know which one I prefer. Note that we also need an icon to represent the virtual “Pages” app (ie the “system”). Thanks! -Vincent
WDYT?
Thanks -Vincent
Thanks, Caty
On Mon, Oct 2, 2017 at 6:52 PM, Vincent Massol <vincent@massol.net> wrote:
Hi Caty,
On 2 Oct 2017, at 17:21, Ecaterina Moraru (Valica) <valicac@gmail.com> wrote:
Hi,
I've created some improvements suggestions for our Notifications UI, see http://design.xwiki.org/xwiki/bin/view/Proposal/ NotificationsImprovements9x
Let me know what you think.
Re the overview, I don’t see where you mention the app?
For example, could you show how a new Blog post would be displayed and you differentiate that for example from a Page creation or modification?
Thanks -Vincent
Thanks, Caty
participants (6)
-
Clément Aubin -
Ecaterina Moraru (Valica) -
Eduard Moraru -
Guillaume Delhumeau -
Thomas Mortagne -
Vincent Massol