[xwiki-devs] [VOTE] Move Events in XE 2.6RC2
Hi, We have created a mess we need to fix ASAP since event classes are public. Here's a proposal: * Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event). * Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package) * Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package) +1 from me Thanks -Vincent
Big +1, specific events have nothing to do in observation API they should be where they makes sense. On Wed, Nov 3, 2010 at 10:00, Vincent Massol <vincent@massol.net> wrote:
Hi,
We have created a mess we need to fix ASAP since event classes are public. Here's a proposal:
* Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event).
When moving it we should improve them and start using references (and maybe have some kind of AbstractEntityEvent to prepare events on any entity that would be a real nice to have) and most importantly rename DocumentSaveEvent.
* Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package) * Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package)
+1 from me
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
Hi all, Actually some of these things have been released, they were there before these new events were added in 2.6. How should we approach this? On 11/03/2010 10:00 AM, Vincent Massol wrote:
Hi,
We have created a mess we need to fix ASAP since event classes are public. Here's a proposal:
* Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event).
these are already part of the API
* Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package)
these too
* Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package)
these too, since 2.5.
* Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package)
these too Also, Comments should be moved to the core events, I would say, since ftm the comments API is in the core. I think what we could do for the moment is at least move the newly created ones, and in the future we'll figure out what's the best deprecation strategy for the existing ones. If there is a strategy that works fast (besides breaking API) I agree to do it before the 2.6RC or final. Thanks, Anca
+1 from me
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Here's a refined proposal after Anca's comments and after having talked to Thomas about it: For XE 2.6RC2: ============ * Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package) * Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Comments events to xwiki-core for now (in a com.xpn.xwiki.event package) For XE 2.7RC1: ============ * Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event). * Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package) More specifically, in order to preserve backward compat: * Modify all places sending events so that they send the new event classes * Create a Backward compatibility Listener that listens to the new events and which resends them as old events * We need to modify code that listens to all events (such as the remote observation module and maybe even the activity stream) to filter out events so that we don't get duplicates. Since we already voted I'm going to implement the tasks for XE 2.6RC2 right now. Please let me know if it's ok for XE 2.7RC1. Thanks -Vincent On Nov 3, 2010, at 10:00 AM, Vincent Massol wrote:
Hi,
We have created a mess we need to fix ASAP since event classes are public. Here's a proposal:
* Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event). * Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package) * Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package)
+1 from me
Thanks -Vincent
And another refinement below. On Nov 8, 2010, at 3:50 PM, Vincent Massol wrote:
Here's a refined proposal after Anca's comments and after having talked to Thomas about it:
For XE 2.6RC2: ============
* Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package) * Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Comments events to xwiki-core for now (in a com.xpn.xwiki.event package)
For Attachments/Comments move them to the com.xpn.xwiki.internal.event package so that they are internal (ie not expose them public for now so that we can change them without deprecation later on when we move them again to the target module - when it exists).
For XE 2.7RC1: ============
* Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event). * Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package)
Same as above, move Action events to the com.xpn.xwiki.internal.event paclage. Thanks -Vincent
* Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package)
More specifically, in order to preserve backward compat: * Modify all places sending events so that they send the new event classes * Create a Backward compatibility Listener that listens to the new events and which resends them as old events * We need to modify code that listens to all events (such as the remote observation module and maybe even the activity stream) to filter out events so that we don't get duplicates.
Since we already voted I'm going to implement the tasks for XE 2.6RC2 right now. Please let me know if it's ok for XE 2.7RC1.
Thanks -Vincent
On Nov 3, 2010, at 10:00 AM, Vincent Massol wrote:
Hi,
We have created a mess we need to fix ASAP since event classes are public. Here's a proposal:
* Move Documents events (and all model events in general: classes, objects, etc) to the Model module in an event package (org.xwiki.model.event). * Move Action events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Annotations events to the annotation-core module in org.xwiki.annotation.event package * Move script events to the xwiki-script module (in org.xwiki.script.event package) * Move Attachments events to xwiki-core for now (in a com.xpn.xwiki.event package) * Move Application started/stopped events to xwiki-container-api (in a org.xwiki.container.event package)
+1 from me
Thanks -Vincent
participants (3)
-
Anca Luca -
Thomas Mortagne -
Vincent Massol