[xwiki-devs] [VOTE] Put a new line at the beginning and the end of group content in xwiki/2.0 renderer
Hi devs, I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line: 1.A ((( * list1 * list 2 ))) instead of 1.B (((* list1 * list 2))) for example but it also mean: 2.A | ((( * list ))) | second cell instead of 2.B | (((* list with one item))) Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO Here is my +1 -- Thomas Mortagne
On Sep 30, 2009, at 5:48 PM, Thomas Mortagne wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1 Note that technically speaking this means changing the XWiki Syntax 2.0 specification... ;) Thus technically it should be in XWiki Syntax 2.1. However it's a small change and I agree to put it in the XWiki Syntax 2.0 version. Thanks -Vincent
On Wed, Sep 30, 2009 at 18:11, Vincent Massol <vincent@massol.net> wrote:
On Sep 30, 2009, at 5:48 PM, Thomas Mortagne wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1
Note that technically speaking this means changing the XWiki Syntax 2.0 specification... ;) Thus technically it should be in XWiki Syntax 2.1.
No it does not change it since the syntax specification is about parser and we don't remove or add anything to what is supported by the parser. You can already use the group syntax any way you want.
However it's a small change and I agree to put it in the XWiki Syntax 2.0 version.
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Sep 30, 2009, at 6:24 PM, Thomas Mortagne wrote:
On Wed, Sep 30, 2009 at 18:11, Vincent Massol <vincent@massol.net> wrote:
On Sep 30, 2009, at 5:48 PM, Thomas Mortagne wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1
Note that technically speaking this means changing the XWiki Syntax 2.0 specification... ;) Thus technically it should be in XWiki Syntax 2.1.
No it does not change it since the syntax specification is about parser and we don't remove or add anything to what is supported by the parser. You can already use the group syntax any way you want.
I understand but for me the Syntax also specifies what is the canonical way of entering elements (in other words the Syntax is what we describe in the XWikiSyntax document for me). Right now the canonical way of entering groups is: (((* list1 * list2))) Thanks -Vincent
However it's a small change and I agree to put it in the XWiki Syntax 2.0 version.
Thanks -Vincent
On 09/30/2009 07:24 PM, Thomas Mortagne wrote:
On Wed, Sep 30, 2009 at 18:11, Vincent Massol<vincent@massol.net> wrote:
On Sep 30, 2009, at 5:48 PM, Thomas Mortagne wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1
Note that technically speaking this means changing the XWiki Syntax 2.0 specification... ;) Thus technically it should be in XWiki Syntax 2.1.
No it does not change it since the syntax specification is about parser and we don't remove or add anything to what is supported by the parser. You can already use the group syntax any way you want.
Hi Thomas, if I understand correctly and one can already enter the group in any way (with or without new lines) and this is only about changing the default way in which it's serialized, then +1. Happy coding, Anca
However it's a small change and I agree to put it in the XWiki Syntax 2.0 version.
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
On Thu, Oct 1, 2009 at 12:15, Anca Paula Luca <ancapaula.luca@xwiki.com> wrote:
On 09/30/2009 07:24 PM, Thomas Mortagne wrote:
On Wed, Sep 30, 2009 at 18:11, Vincent Massol<vincent@massol.net> wrote:
On Sep 30, 2009, at 5:48 PM, Thomas Mortagne wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1
Note that technically speaking this means changing the XWiki Syntax 2.0 specification... ;) Thus technically it should be in XWiki Syntax 2.1.
No it does not change it since the syntax specification is about parser and we don't remove or add anything to what is supported by the parser. You can already use the group syntax any way you want.
Hi Thomas,
if I understand correctly and one can already enter the group in any way (with or without new lines) and this is only about changing the default way in which it's serialized, then
Yes.
+1.
Happy coding, Anca
However it's a small change and I agree to put it in the XWiki Syntax 2.0 version.
Thanks -Vincent
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
_______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 Jerome Thomas Mortagne wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1 JV. On Wed, Sep 30, 2009 at 5:48 PM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
Hi, On Wed, Sep 30, 2009 at 9:18 PM, Thomas Mortagne <thomas.mortagne@xwiki.com>wrote:
Hi devs,
I would like to modify the xwiki/2.0 renderer to print the group with a trailing and ending new line:
1.A ((( * list1 * list 2 )))
instead of
1.B (((* list1 * list 2)))
for example but it also mean:
2.A | ((( * list ))) | second cell
instead of
2.B | (((* list with one item)))
Here are my arguments: * i tough of that idea at first because it's not very easy/clean to support well the escaping of an ending ) before a ending group in an events based renderer, the problem is that you need to bufferize at least 4 events (if not more) to know when you print the ) character that it will be followed by end group syntax when printed. For example it can be the last character of paragraph in the last cell or last row of a table before the end of the group * i prefer to "break" 2.A done on purpose than 1.A done on purpose since it's not possible to support both currently * even with 2.A it's more readable to have it in its own line IMO
Here is my +1
+1 Thanks.
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
participants (6)
-
Anca Paula Luca -
Asiri Rathnayake -
Jean-Vincent Drean -
Jerome Velociter -
Thomas Mortagne -
Vincent Massol