[xwiki-devs] [VOTE] Create a xwiki-macro module in core for Syntax 2.0 macros
Hi devs, the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO. For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;) Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.). Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823 Here is my +1 -- Thomas Mortagne
Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823
Here is my +1
+1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
+1 On Wed, Nov 12, 2008 at 4:47 PM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823
Here is my +1
-- Thomas Mortagne _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Jean-Vincent Drean
On Nov 12, 2008, at 4:47 PM, Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
+1 but with the following conditions: 1) named xwiki-macros (note the 's' since this is how we've named other modules like plugins, applications, xwiki-containers, etc) 2) it's released together with core, i.e. same jira project Thanks -Vincent
Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823
Here is my +1
-- Thomas Mortagne
On Wed, Nov 12, 2008 at 5:39 PM, Vincent Massol <vincent@massol.net> wrote:
On Nov 12, 2008, at 4:47 PM, Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
+1 but with the following conditions:
1) named xwiki-macros (note the 's' since this is how we've named other modules like plugins, applications, xwiki-containers, etc)
xwiki-query and xwiki-cache does not contains "s" and xwiki-containers sub modules are named xwiki-container-* so I think there is a problem....
2) it's released together with core, i.e. same jira project
Yes, this was implicit since it's a core sub module.
Thanks -Vincent
Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823
Here is my +1
-- Thomas Mortagne
devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
On Wed, Nov 12, 2008 at 5:59 PM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Wed, Nov 12, 2008 at 5:39 PM, Vincent Massol <vincent@massol.net> wrote:
On Nov 12, 2008, at 4:47 PM, Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
+1 but with the following conditions:
1) named xwiki-macros (note the 's' since this is how we've named other modules like plugins, applications, xwiki-containers, etc)
xwiki-query and xwiki-cache does not contains "s" and xwiki-containers sub modules are named xwiki-container-* so I think there is a problem....
I would prefer follow the java package style.
2) it's released together with core, i.e. same jira project
Yes, this was implicit since it's a core sub module.
Thanks -Vincent
Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823
Here is my +1
-- Thomas Mortagne
devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
-- Thomas Mortagne
On Nov 12, 2008, at 6:00 PM, Thomas Mortagne wrote:
On Wed, Nov 12, 2008 at 5:59 PM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Wed, Nov 12, 2008 at 5:39 PM, Vincent Massol <vincent@massol.net> wrote:
On Nov 12, 2008, at 4:47 PM, Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core - rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
+1 but with the following conditions:
1) named xwiki-macros (note the 's' since this is how we've named other modules like plugins, applications, xwiki-containers, etc)
xwiki-query and xwiki-cache does not contains "s"
That's because they haven't been following the practice I started ;)
and xwiki-containers sub modules are named xwiki-container-* so I think there is a problem....
No that's perfectly normal and done voluntarily. The plural is only when there's more than one. The sub module do not have an 's' because they're not hosting several containers.
I would prefer follow the java package style.
That's a decision we need to take but IMO it doesn't have to follow the same rule. My preference goes with an 's' for directory names since it's more clear that it contains several sub modules. With no "s" you're in doubt and need to check inside. [snip] Thanks -Vincent
On Wed, Nov 12, 2008 at 6:26 PM, Vincent Massol <vincent@massol.net> wrote:
On Nov 12, 2008, at 6:00 PM, Thomas Mortagne wrote:
On Wed, Nov 12, 2008 at 5:59 PM, Thomas Mortagne <thomas.mortagne@xwiki.com> wrote:
On Wed, Nov 12, 2008 at 5:39 PM, Vincent Massol <vincent@massol.net> wrote:
On Nov 12, 2008, at 4:47 PM, Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core - rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
+1 but with the following conditions:
1) named xwiki-macros (note the 's' since this is how we've named other modules like plugins, applications, xwiki-containers, etc)
xwiki-query and xwiki-cache does not contains "s"
That's because they haven't been following the practice I started ;)
and xwiki-containers sub modules are named xwiki-container-* so I think there is a problem....
No that's perfectly normal and done voluntarily. The plural is only when there's more than one. The sub module do not have an 's' because they're not hosting several containers.
I would prefer follow the java package style.
That's a decision we need to take but IMO it doesn't have to follow the same rule.
My preference goes with an 's' for directory names since it's more clear that it contains several sub modules. With no "s" you're in doubt and need to check inside.
Good point. Anyway, this is already a rule you defined so I will not discuss it here in this context but It would be good to add it in dev.xwiki.org as it seems nobody knows about it (and did not looked at containers, right).
[snip]
Thanks -Vincent _______________________________________________ devs mailing list devs@xwiki.org http://lists.xwiki.org/mailman/listinfo/devs
-- Thomas Mortagne
+1 Thomas Mortagne wrote:
Hi devs,
the xwiki-core-rendering module is growing more and more and will contain too many things and dependencies IMO.
For example I will soon commit code macro and script/groovy macros which come with big dependencies (like jython, groovy, etc.) and it would be god to not add more things in already too big core -rendering pom.xml file ;)
Now the proposal: add a xwiki-macro submodule in /platform/core and have one macro/one sub module (xwiki-macro/xwiki-macro-code, xwiki-macro/xwiki-macro-script, etc.).
Jerome already created a task for it, see http://jira.xwiki.org/jira/browse/XWIKI-2823
Here is my +1
participants (5)
-
Jean-Vincent Drean -
Marius Dumitru Florea -
Sergiu Dumitriu -
Thomas Mortagne -
Vincent Massol