Re: [xwiki-devs] [xwiki-notifications] r22926 - in enterprise/trunk/wiki/src/main/resources: . ColorThemes
Author: sdumitriu Date: 2009-08-26 09:21:10 +0200 (Wed, 26 Aug 2009) New Revision: 22926
Added: enterprise/trunk/wiki/src/main/resources/ColorThemes/ enterprise/trunk/wiki/src/main/resources/ColorThemes/BlueSky.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Bordo.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeClass.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeTemplate.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/DefaultColorTheme.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/InnerDark.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nature.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nightfall.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Peach.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/WebHome.xml Log: XE-?: New ColorTheme application Done
Hi Sergiu, I find the ColorThemes application pretty confusing : we can edit existing themes, but not create new ones? I would have seen it the other way around : existing themes are freezed, and users create new custom ones. Also I find it hard to understand what the application really do, and how it relate to the Colibri skin. It looks a little like dropped in the middle of nowhere. Finally, I think this kind of application raises the question of how we want them to be accessed. Personally I find a bit odd to have 'ColorThemes' in the space index. I would be in favor of blacklisting the space, and linking the application from the presentation section of the administration. Jerome.
Jerome Velociter wrote:
Author: sdumitriu Date: 2009-08-26 09:21:10 +0200 (Wed, 26 Aug 2009) New Revision: 22926
Added: enterprise/trunk/wiki/src/main/resources/ColorThemes/ enterprise/trunk/wiki/src/main/resources/ColorThemes/BlueSky.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Bordo.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeClass.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeSheet.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/ColorThemeTemplate.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/DefaultColorTheme.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/InnerDark.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nature.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Nightfall.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/Peach.xml enterprise/trunk/wiki/src/main/resources/ColorThemes/WebHome.xml Log: XE-?: New ColorTheme application Done
Hi Sergiu,
I find the ColorThemes application pretty confusing : we can edit existing themes, but not create new ones? I would have seen it the other way around : existing themes are freezed, and users create new custom ones.
The Create page was not ready at the moment. Raluca is working on it on the incubator, it will be added soon (hopefully in time for RC1).
Also I find it hard to understand what the application really do, and how it relate to the Colibri skin. It looks a little like dropped in the middle of nowhere.
Theoretically, It is not tied to any skin, but they should be the basis of all our styling. I will move the velocity code that prepares the $theme object into a template, so that any CSS file can just do #template('theme.vm') and then make use of the $theme object. Since this is new, right now only the Colibri css is making use of themes.
Finally, I think this kind of application raises the question of how we want them to be accessed. Personally I find a bit odd to have 'ColorThemes' in the space index. I would be in favor of blacklisting the space, and linking the application from the presentation section of the administration.
+1 -- Sergiu Dumitriu http://purl.org/net/sergiu/
participants (2)
-
Jerome Velociter -
Sergiu Dumitriu